I am making a new Criterion trigger called SunAmountTrigger.

First I create SunAmountTrigger class like the default did : https://github.com/HungTeen/pvzmod/blob/dev/src/main/java/com/hungteen/pvz/advancement/SunAmountTrigger.java

And then I register it in AdvancementHandler : https://github.com/HungTeen/pvzmod/blob/dev/src/main/java/com/hungteen/pvz/advancement/AdvancementHandler.java

Here is the json file of the custom advancement : https://github.com/HungTeen/pvzmod/blob/dev/src/main/resources/data/pvz/advancements/sunny_days.json

But When I run mc, I didn't see the advancements and got log like this:

[m[1;31m[11:11:47] [Server thread/ERROR] [minecraft/AdvancementManager]: Parsing error loading custom advancement pvz:sunny_days: Invalid criterion trigger: minecraft:sun_amount

 

I don't know why it's Invalid, tysm if someone can help me figure out.

https://github.com/HungTeen/pvzmod/blob/dev/src/main/java/com/hungteen/pvz/advancement/SunAmountTrigger.java#L15

You did not add your modid to the rl so it thinks it belongs to vanilla (just my guess).

57 minutes ago, poopoodice said:

https://github.com/HungTeen/pvzmod/blob/dev/src/main/java/com/hungteen/pvz/advancement/SunAmountTrigger.java#L15

You did not add your modid to the rl so it thinks it belongs to vanilla (just my guess).

Thx for reply. I try it before, but still the same error. I even copy a trigger code from twilightforest, also failed. Idk if it is because i miss some important register.