[SOLVED] Registry Question

[imawindow]

public static final DeferredRegister<Item> ITEMS = DeferredRegister.create(ForgeRegistries.ITEMS, Main.MOD_ID);

public static final RegistryObject<Item> TEST_BLOCK_ITEM = itemRegistry("test_block_item", ModBlocks.TEST_BLOCK);

private static RegistryObject<Item> itemRegistry(String registryName, RegistryObject<Block> block){
    String user = System.getProperty("user.home");
    File modFile = new File(user + "\\AppData\\Roaming\\.minecraft\\mods\\Test.txt");
    boolean modExists = modFile.exists();
    if(modExists) {
        return ITEMS.register(registryName, () -> new BlockItem(block.get(), new Item.Properties().group(Main.TAB)));
    }
    return null;
}

 

will returning null here cause any problems? I'm sorry if this is a dumb question; I'm just afraid haha

 

edit: is this a good way of making your mod "compatible" with other mods? Is this a good way of removing this blocks/items once the mod is no longer there?

Edited January 31, 2021 by imawindow

[diesieben07]

Do not dynamically register things. Always register all your items, blocks, etc.

[imawindow]

12 minutes ago, diesieben07 said:

Do not dynamically register things. Always register all your items, blocks, etc.

ok. so what is a good way to approach this? or is this just not a good idea? lol. I want the block/item to appear if you have a mod installed. 

[diesieben07]

Define "appear".

[imawindow]

Just now, diesieben07 said:

Define "appear".

So i made a block type called "quarter stairs" and I would like to make it compatible with, let's say, Biomes O' Plenty blocks (ex:White Sandstone Quarter Stairs). I only want that to "appear" if Biomes O' Plenty is downloaded.

[diesieben07]

Yes, I understood that part. What do you mean by "appear"?

[imawindow]

Just now, diesieben07 said:

Yes, I understood that part. What do you mean by "appear"?

Like I want the items/blocks to be registered only when that mod is installed. else, remove the registry (almost like when you remove a mod, the content gets removed along side with it (obviously)). But like you said, I shouldn't do this. What is a good alternative?

[diesieben07]

Just now, imawindow said:

Like I want the items/blocks to be registered only when that mod is installed.

That is not possible. Either you register items and blocks always, or you don't.

 

Again: What do you mean by "appear"?

[imawindow]

Just now, diesieben07 said:

That is not possible. Either you register items and blocks always, or you don't.

 

Again: What do you mean by "appear"?

alright. I meant as being registered and you can see its presence... lol i don't know how else to explain. So I'm just gonna register it and hide it from the creative tab if the mod is not downloaded and vice versa if it is. 

[diesieben07]

Yes, that is a good approach.