Registering objects with @ObjectHolder

[octa]

Hello, I've recently decided to clean up my mod because it was a huge mess, so one thing I did was move all of the registration out of the one "registration" god class and divide the registration tasks into categories of block and item. Somewhere during this process, I must have gone wrong because my mod either fails to load or inevitably crashes when loading a world. I've played around with adding listeners and registering classes to the forge and mod busses, and gotten different errors. One thing I noticed is that they all lead to null pointers to items whose fields should have been injected from registries using the @ObjectHolder tag, so this is where I focused my research. I'm struggling to find anything about object holders, and beyond the idea that I didn't update the resource locations to match my new modid I'm stumped.

Latest Log and crash report (which correspond to the version on my repo) are attached.

Repo: https://github.com/eddie1101/PortalTest

Can someone tell me what I'm doing wrong?

latest.log crash-2021-02-01_20.37.37-client.txt

[Draco18s]

All of these methods are pointless, just call setRegistryName instead of calling a wrapper function that calls one line of code.

https://github.com/eddie1101/PortalTest/blob/c26623c062770115212536c540219f7abda1091f/src/main/java/erg/voidcraft/common/util/Util.java#L12

 

All of the declared types of these can just be Block

https://github.com/eddie1101/PortalTest/blob/c26623c062770115212536c540219f7abda1091f/src/main/java/erg/voidcraft/common/block/VoidcraftBlocks.java#L10-L14

Also, you haven't @ObjectHolder'd them, so you're not even using the thing you said you are in your thread title.

 

You aren't registering any blocks or items, because you haven't registered your classes with the event bus:

https://github.com/eddie1101/PortalTest/blob/c26623c062770115212536c540219f7abda1091f/src/main/java/erg/voidcraft/common/Voidcraft.java#L40

(You also aren't using the @EventBusSubscriber annotation)

 

Or the @SubscribeEvent annotation:

https://github.com/eddie1101/PortalTest/blob/master/src/main/java/erg/voidcraft/common/block/VoidcraftBlocks.java#L16

[octa]

1 hour ago, Draco18s said:

Also, you haven't @ObjectHolder'd them, so you're not even using the thing you said you are in your thread title.

 

1 hour ago, Draco18s said:

(You also aren't using the @EventBusSubscriber annotation)

 

Or the @SubscribeEvent annotation:

Oh, I forgot all of the annotations in my blocks class. ¯\_(ツ)_/¯
Thanks for the eye.

 

 

[Draco18s]

If you use @Object holder, the field needs to be final and null, so you can't assign a value to it like you are.