Jump to content

[1.16] How do you add recipes that depends on the ingredients?


Recommended Posts

Posted (edited)

The method I'm using to add recipes is creating json files as recommended. However this method doesn't seem ideal for working with "dynamic" recipes (meaning recipes that depends on the ingredients).

 

How would you register recipes in a way that lets you access the ingredients' information and edit the result appropriately? 

 

Edit: There is probably a guide somewhere for this, but can't find it for this version. If anyone can provide a link that would be more than enough.

 

Thanks!

Edited by crischu
Posted
24 minutes ago, diesieben07 said:

Make your own IRecipeSerializer and IRecipe implementation.

I can't seem to find any examples of this, I'm guessing the ingredient list now goes in the "match" function of IRecipe, but most of the methods I wouldn't know how to complete, namely IRecipe.getId, IRecipe.getSerializer, IRecipe.getType, and the methods of IRecipeSerializer.

 

I think I'd need to see a minimal working example of these classes implemented.

Posted (edited)
52 minutes ago, crischu said:

I can't seem to find any examples of this, I'm guessing the ingredient list now goes in the "match" function of IRecipe, but most of the methods I wouldn't know how to complete, namely IRecipe.getId, IRecipe.getSerializer, IRecipe.getType, and the methods of IRecipeSerializer.

 

I think I'd need to see a minimal working example of these classes implemented.

you have examples in the vanilla source code, check the Shapeless or Shaped crafting recipe classes for instance. (not the builder classes, the builders are for the data generation, and since you are writing the jsons by hand, you won't need them)

- you will need to register the serializer and use the registered instance in IRecipe#getSerializer. you can do this using deffered registers

- you'll also need to register a recipe type, and use the registered instance in IRecipe#getType. there isn't a deffered register for recipe types, so you'll need to subscribe to the RecipeSerializer registry event and use IRecipeType#register, to register the recipe type

- for IRecipe#getId you need to return the ResourceLocation that's passed to the class in the constructor.

after that you can change the type in the json to match your recipe type name (e.g.: "mymod:myrecipetype")

 

for the serializer class you'll need to handle writing and reading to packet buffers, and deserializing the json recipe's into an instance of the recipe. the vanilla classes have all examples you need to figure how these methods can be implemented.

 

Edited by kiou.23
  • Like 1
Posted
1 hour ago, kiou.23 said:

you have examples in the vanilla source code, check the Shapeless or Shaped crafting recipe classes for instance. (not the builder classes, the builders are for the data generation, and since you are writing the jsons by hand, you won't need them)

- you will need to register the serializer and use the registered instance in IRecipe#getSerializer. you can do this using deffered registers

- you'll also need to register a recipe type, and use the registered instance in IRecipe#getType. there isn't a deffered register for recipe types, so you'll need to subscribe to the RecipeSerializer registry event and use IRecipeType#register, to register the recipe type

- for IRecipe#getId you need to return the ResourceLocation that's passed to the class in the constructor.

after that you can change the type in the json to match your recipe type name (e.g.: "mymod:myrecipetype")

 

for the serializer class you'll need to handle writing and reading to packet buffers, and deserializing the json recipe's into an instance of the recipe. the vanilla classes have all examples you need to figure how these methods can be implemented.

 

Thank you. And once I defined my recipe class how do I register it in the game?

Posted
19 hours ago, diesieben07 said:

You only need to register the recipe serializer. And because it is an IForgeRegistryEntry you register it the same way you do any other registry entry:

https://mcforge.readthedocs.io/en/latest/concepts/registries/

I tried, but it is not recognizing my recipe type, I get "Invalid or unsupported recipe type" error message. How do I point to my recipe from the json if the recipe type I used is just IRecipeType.CRAFTING?

Posted
5 hours ago, diesieben07 said:

The recipe type is entirely irrelevant in the JSON. The JSON needs to specify the recipe serializer, which reads the JSON and then the result of that is what determines the recipe type.

So how should the JSON look like then? Mine looked like:

{
	"type": recipeid
}

where recipe id is the one specified in IRecipe.getId. And removing the type raises "com.google.gson.JsonSyntaxException: Missing type, expected to find a string"

Posted
17 minutes ago, diesieben07 said:

type needs to point to the registry name of your IRecipeSerializer.

That's the same id as my recipe so that's not working for me, it's an invalid recipe type.

Posted
26 minutes ago, diesieben07 said:

Then you need to post more of your code.

Your whole JSON file and all of your recipe and registration code. Ideally just your Mod as a Git repo.

This is the code https://github.com/crisdesivo/Elemental_Chaos, a lot of stuff is unused, I'm just trying stuff to see what works and what doesn't.

 

The recipe I'm interested in is in com.example.elementalchaos.elementalItems.recipes.RechargeRecipe.java, the registration code is in RegistryHandler, the JSON is com.example.elementalchaos.elementalItems.recipes.recharge.json, and the serializer is defined at com/example/elementalchaos/elementalItems/recipes/ModRecipes.java

Posted
9 minutes ago, diesieben07 said:

Do not put the DeferredRegister and its RegistryObjects in separate classes.

Great, that worked! But the result of the crafting is minecraft:air instead of the IRecipe.getCraftingResult return.

Posted
11 minutes ago, diesieben07 said:

Your recipe creates new Item instances. You cannot do this. Item instances must be created during registry events and registered there.

That worked, thank you

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • So me and a couple of friends are playing with a shitpost mod pack and one of the mods in the pack is corail tombstone and for some reason there is a problem with it, where on death to fire the player will get kicked out of the server and the tombstone will not spawn basically deleting an entire inventory, it doesn't matter what type of fire it is, whether it's from vanilla fire/lava, or from modded fire like ice&fire/lycanites and it's common enough to where everyone on the server has experienced at least once or twice and it doesn't give any crash log. a solution to this would be much appreciated thank you!
    • It is 1.12.2 - I have no idea if there is a 1.12 pack
    • Okay, but does the modpack works with 1.12 or just with 1.12.2, because I need the Forge client specifically for Minecraft 1.12, not 1.12.2
    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.