[1.16.5] Guis not loading

[plugsmustard]

Hello,

 

i am currently updating my mod to 1.16.5 and i need a little help.

my GUIs aren't loading. please see below for links to Tile Entity, Container, Screen, and Block classes.

TileEnt: MarijuanaCraft1.16.5/ColumnTileEntity.java at main · drmdgg/MarijuanaCraft1.16.5 (github.com)

Container: MarijuanaCraft1.16.5/ColumnContainer.java at main · drmdgg/MarijuanaCraft1.16.5 (github.com)

Screen: MarijuanaCraft1.16.5/ColumnScreen.java at main · drmdgg/MarijuanaCraft1.16.5 (github.com)

Block: MarijuanaCraft1.16.5/ColumnBlock.java at main · drmdgg/MarijuanaCraft1.16.5 (github.com)

 

any help is greatly appreciated. thanks

[plugsmustard]

  On 2/16/2021 at 10:58 PM, diesieben07 said:

• Use @Override when overriding methods.
• Your repository is missing the build.gradle and gradle wrapper. The MDK comes with a properly configured .gitignore file, use it. However that means you need to use a proper git client instead of the web upload, which you should be doing anyways.
• I can't see the issue from just the code, it looks fine from just looking at it. Please correct the point above so we can use the debugger on it.

Expand  

Hope this helps. 
drmdgg/MarijuanaCraft1.16.5 (github.com)

which overrides are you referring to?

[plugsmustard]

  On 2/17/2021 at 8:12 PM, diesieben07 said:

Your ColumnBlock class is entirely unused, you never register a block with that class. Your BlockInit class does register something called column, but it does not use ColumnBlock.

 

In ColumnBlock for example.

Expand  

thank you, that got the gui to come up, 
https://github.com/drmdgg/MarijuanaCraft1.16.5/blob/07db89d8b03f89c86d01893936d40a3ac2e412ee/src/main/java/drmdgg/marijuanacraft/init/BlockInit.java#L36

however, it still spawns another "column" when the gui it opened

[plugsmustard]

  On 2/17/2021 at 8:31 PM, diesieben07 said:

The code you posted does not compile.

Please stop using the Web UI to update your code... Use a Git client.

Expand  

i did, except in the case of changing the line of code  i just posted 
im using GitHub Desktop

[plugsmustard]

  On 2/17/2021 at 8:34 PM, diesieben07 said:

I am so confused. Just use the Git client instead of copy-pasting code into the web UI, which is then not consistent and thus does not compile.

Expand  

im saying i am using the Git Client "GitHub Desktop" 

[plugsmustard]

  On 2/17/2021 at 8:34 PM, diesieben07 said:

I am so confused. Just use the Git client instead of copy-pasting code into the web UI, which is then not consistent and thus does not compile.

Expand  

hopefully it will compile this time
drmdgg/MarijuanaCraft1.16.5 (github.com)

[plugsmustard]

  On 2/17/2021 at 9:02 PM, diesieben07 said:

Yes... But then you also said you didn't use it this time. Which will make things terrible for you, because you now need to merge things when you commit next time.

 

You completely recreated the repository... Why...

 

I do not understand what you mean by this. I did not notice any kind of "spawning" when opening the GUI.

Expand  

if it wasn't spawing an extra "column" then it must be my laptop being garbage. 

 

and i thank you. i knew it had to be something registered that was missing

 

are you able to help me with a button or should i make a new topic?

 

[plugsmustard]

  On 2/17/2021 at 9:14 PM, diesieben07 said:

Make a new button.

Expand  

...i have old code from 1.14.4 that does not work. 

 this.addButton(new Button(relX + 18, relY + 15, 5, 20, "PURGE", button -> PacketHandler.sendToServer(new C2SRequestStartOven(tileEntity.getPos()))));
      this.addButton(new Button(relX + 18, relY + 15, 5, 20, "PURGE", button -> PacketHandler.sendToServer(new C2SRequestStartOven(tileEntity.getPos()))));
 

gets "The constructor Button(int, int, int, int, String, Button.IPressable) is undefined"

[plugsmustard]

  On 2/17/2021 at 9:18 PM, diesieben07 said:

Use a constructor that does exist... You do understand Java?

Expand  

it's been a while unfortunately, since 1.14.4 so im a little rusty. but i have this so far:

 

MarijuanaCraft1.16.5/PurgeButton.java at main · drmdgg/MarijuanaCraft1.16.5 (github.com)

[plugsmustard]

  On 2/17/2021 at 9:24 PM, diesieben07 said:

Look at the constructors that are available. Then pick the one that fits your need.

Expand  

I'm not asking you to write the code or anything for me, but could you be a little more specific.
is there a list of available constructors i can look at pertaining to this?