Jump to content
  • Home
  • Files
  • Docs
Topics
  • All Content

  • This Topic
  • This Forum

  • Advanced Search
  • Existing user? Sign In  

    Sign In



    • Not recommended on shared computers


    • Forgot your password?

  • Sign Up
  • All Activity
  • Home
  • Mod Developer Central
  • Modder Support
  • [1.16.4] Change Biome RainType through Reflections Casting error
Currently Supported: 1.16.X (Latest) and 1.15.X (LTS)
Sign in to follow this  
Followers 1
than00ber1

[1.16.4] Change Biome RainType through Reflections Casting error

By than00ber1, Tuesday at 03:26 PM in Modder Support

  • Reply to this topic
  • Start new topic

Recommended Posts

than00ber1    0

than00ber1

than00ber1    0

  • Tree Puncher
  • than00ber1
  • Members
  • 0
  • 3 posts
Posted Tuesday at 03:26 PM

I am trying to change all biome's RainType from RAIN to SNOW.

 

Following this (old but most recent) post, I figured I should use reflections but I am having some trouble cast from Biome.Builder to Biome with this casting error:

 

java.lang.ClassCastException: net.minecraft.world.biome.Biome cannot be cast to net.minecraft.world.biome.Biome$Builder

 

Here is my code:

 

        @SubscribeEvent
        public static void onBiomeRegistry(final RegistryEvent.Register<Biome> event) {
            Set<Map.Entry<RegistryKey<Biome>, Biome>> biomes = event.getRegistry().getEntries();

            for (Map.Entry<RegistryKey<Biome>, Biome> biome : biomes) {
                String name = biome.getValue().getRegistryName().getPath();
                String method = String.format("make%sBiome", CaseFormat.LOWER_UNDERSCORE.to(CaseFormat.UPPER_CAMEL, name));
                System.out.println(method);
                Method builder = null;
                Biome.Builder biome$builder = null;

                try {
                    builder = ObfuscationReflectionHelper.findMethod(BiomeMaker.class, method);
                    biome$builder = (Biome.Builder) builder.invoke(BiomeMaker.class);
                }
                catch (Exception e) {
                    LOGGER.error("Could not get biome builder: %s", e);
                }

                if (builder != null && biome$builder != null) {
                    Biome newBiome = biome$builder.precipitation(Biome.RainType.SNOW).build();
                    event.getRegistry().register(newBiome);
                    LOGGER.info("NEW BIOME " + newBiome.getPrecipitation());
                }
            }
        }

 

  • Quote

Share this post


Link to post
Share on other sites

lupicus    1

lupicus

lupicus    1

  • Tree Puncher
  • lupicus
  • Members
  • 1
  • 7 posts
Posted Tuesday at 03:58 PM (edited)

A Biome object and Biome.Builder object can't be cast to the other type.

The easier way to do this is by using the BiomeLoadingEvent, then you can do:

event.getClimate().precipitation = RainType.SNOW;

 

Edited Tuesday at 11:07 PM by lupicus
  • Quote

Share this post


Link to post
Share on other sites

than00ber1    0

than00ber1

than00ber1    0

  • Tree Puncher
  • than00ber1
  • Members
  • 0
  • 3 posts
Posted 7 hours ago

Alright, I've made some changes to my code and noticed that the precipitation field in the Biome class is final and had to change its modifiers from public final to just public.

 

        private static Field precipitation;

        @SubscribeEvent
        public static void onBiomeLoad(BiomeLoadingEvent event) {
            try {
                precipitation.set(event.getClimate().precipitation, Biome.RainType.SNOW);
            }
            catch (Exception e) {
                LOGGER.error(e);
            }
        }

        static {
            try {
                precipitation = Biome.Climate.class.getDeclaredField("precipitation");
                Field mf = Field.class.getDeclaredField("modifiers");
                mf.setAccessible(true);
                mf.setInt(precipitation, precipitation.getModifiers() & ~Modifier.FINAL);

                System.out.println(precipitation.getModifiers()); // prints 1 -> public

            }
            catch (Exception e) {
                LOGGER.error(e);
            }
        }

 

 However, an IllegalArgumentException is thrown with message:

 

Can not set net.minecraft.world.biome.Biome$RainType field net.minecraft.world.biome.Biome$Climate.precipitation to net.minecraft.world.biome.Biome$RainType

 

I honestly don't understand why this happens. My code seems to make sense (atleast to me)...

 

Any ideas why that is or how to fix this?

  • Quote

Share this post


Link to post
Share on other sites

lupicus    1

lupicus

lupicus    1

  • Tree Puncher
  • lupicus
  • Members
  • 1
  • 7 posts
Posted 6 hours ago (edited)

You don't need to use reflection for this.

Sorry my code wasn't good.

Try this:

        Climate climate = event.getClimate();
        event.setClimate(new Climate(RainType.SNOW, climate.temperature, climate.temperatureModifier, climate.downfall));

 

FYI: you will not see snow in higher temperature biomes

Edited 6 hours ago by lupicus
  • Quote

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

    • Insert image from URL
×
  • Desktop
  • Tablet
  • Phone
Sign in to follow this  
Followers 1
Go To Topic Listing



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • Centmap
      Forge Mods Folder

      By Centmap · Posted 51 minutes ago

      so i created a "1.16.5" folder in the folder "mod" as usual but it doesn't use the mods. Can anyone help me ?
    • Skyriis
      [SOLVED][1.16.5] Adding a Button to KeyBindings

      By Skyriis · Posted 1 hour ago

      That worked.   Here is my solution @SubscribeEvent public static void onOpenGui(final GuiScreenEvent.InitGuiEvent.Post event) { if (!(event.getGui() instanceof ControlsScreen)) return; final ControlsScreen controlsScreen = (ControlsScreen) event.getGui(); final KeyBindingList replacement = new KeyBindingListReplacement(controlsScreen, event.getGui().getMinecraft()); final KeyBindingList old = ObfuscationReflectionHelper.getPrivateValue(ControlsScreen.class, controlsScreen, "field_146494_r"); controlsScreen.getEventListeners().remove(old); ObfuscationReflectionHelper.setPrivateValue(ControlsScreen.class, controlsScreen, replacement, "field_146494_r"); try { Method addChildMethod = ObfuscationReflectionHelper.findMethod(Screen.class, "func_230481_d_", IGuiEventListener.class); addChildMethod.setAccessible(true); addChildMethod.invoke(controlsScreen, replacement); addChildMethod.setAccessible(false); } catch (IllegalAccessException | InvocationTargetException e) { e.printStackTrace(); } }  
    • DrCowiber
      Failed To Start Minecraft Server

      By DrCowiber · Posted 1 hour ago

      im using this run.sh file, which contains: java -Xmx6G -Xms6G -jar minecraft_server.1.16.5.jar --nogui Edit: When I first posted about this I was using the serverRun.jar, which the first log file I posted is what the output was
    • Tez
      [1.15.2] Couln't not resolve dependency: net.minecraftforge:forge:1.15.2-31.2.0:userdev

      By Tez · Posted 2 hours ago

      I'm new to mod coding so i've watch tutorial in youtube in setup workspace step i got this error , i've try many solutions to fix but it still not working try update gradle to 6.8.3 but still not working try update java and still not working too here's my stacktrace: Stacktrace
    • diesieben07
      Failed To Start Minecraft Server

      By diesieben07 · Posted 2 hours ago

      Please show how exactly you are starting the server.
  • Topics

    • Centmap
      0
      Forge Mods Folder

      By Centmap
      Started 51 minutes ago

    • Skyriis
      8
      [SOLVED][1.16.5] Adding a Button to KeyBindings

      By Skyriis
      Started 23 hours ago

    • DrCowiber
      8
      Failed To Start Minecraft Server

      By DrCowiber
      Started 21 hours ago

    • Tez
      0
      [1.15.2] Couln't not resolve dependency: net.minecraftforge:forge:1.15.2-31.2.0:userdev

      By Tez
      Started 2 hours ago

    • Mysterious minecrafter
      1
      game keeps crashing while initializings

      By Mysterious minecrafter
      Started 4 hours ago

  • Who's Online (See full list)

    • Zeher_Monkey
    • Uncreative
    • NullDev
    • PyRoTheLifeLess
    • Centmap
    • redlynx
    • GermanBucket
    • smitokyo
  • All Activity
  • Home
  • Mod Developer Central
  • Modder Support
  • [1.16.4] Change Biome RainType through Reflections Casting error
  • Theme

Copyright © 2019 ForgeDevelopment LLC · Ads by Longitude Ads LLC Powered by Invision Community