[1.16.5] Help with custom Backpack (slot background and mouse wheel move)

[Luis_ST]

I created a custom backpack.

which should get a few additional features (adding the armor slots, offhand slot, tool swicht slot).

the armor slots and the offhand slot of the player work.

i need some help for the siwtch slot tool:

1. the slot should have a custom background (like the player armor slots).

I've already tried this on the way as vanilla does it (it doesn't work).

this is the slot code:

 

	public static class ToolSlot extends SlotItemHandler {
		
		public static final ResourceLocation LOCATION_BLOCKS_TEXTURE = new ResourceLocation("textures/atlas/blocks.png");
		public static final ResourceLocation EMPTY_TOOL_SLOT = new ResourceLocation("cave:textures/items/empty_tool_slot.png");

		public ToolSlot(IItemHandler itemHandler, int index, int xPosition, int yPosition) {
			
			super(itemHandler, index, xPosition, yPosition);
			
		}
		
		@Override
		public int getSlotStackLimit() {
			
			return 1;
			
		}
		
		@Override
		public boolean isItemValid(ItemStack stack) {
			
			return stack.getItem() instanceof TieredItem;
			
		}
		
		@Override
		public Pair<ResourceLocation, ResourceLocation> getBackground() {
			
			return Pair.of(LOCATION_BLOCKS_TEXTURE, EMPTY_TOOL_SLOT);
			
		}
		
	}

 

2. I want that when the player sneaks and moves the mouse wheel,

the item in the hand is swapped with the item in the backpack slot.

Now how do I check whether the mouse wheel is moving (even if the gui is not open),

and how do I prevent the scrolling in the hotbar?

 

[Luis_ST]

1 hour ago, diesieben07 said:

Just add the background to your GUI texture...? Slot#getBackground does not seem to be used at all in rendering the slot, it only seems to be relevant during dragging, and nothing ever sets the background as far as I can tell.

I've already tried that and it's not how it's supposed to work.

For example, if I put an item in the offand slot, the background texture is set to default.

that's how it should work

 

1 hour ago, diesieben07 said:

InputEvent.MouseScrollEvent is fired outside of GUIs and can be cancelled.

While the GUI is open, you can override mouseScrolled in your screen

I'll try the event

 

Another question which event should I use to open my BackpackContainer.

I know that there is the KeyInputEvent when I use this I don't get a ServerPlayerEntity which I need to open the GUI with NetworkHooks#openGui.

I currently use TickEvent#PlayerTickEvent which is not the best solution.

Is there another / better way to do this?

[Luis_ST]

31 minutes ago, diesieben07 said:

I do not understand. How is the offhand slot relevant regarding the background color of your slot?

it is an example of how the slot background should work

 

33 minutes ago, diesieben07 said:

If it is, send a packet to the server, which then calls NetworkHooks#openGui

using a SimpleChannel?

 

34 minutes ago, diesieben07 said:

You can preemptively also open it on the client to hide the latency of the two network roundtrips.

and then send the change in the container to the server?

[Luis_ST]

17 minutes ago, diesieben07 said:

Apparently I was too stupid to operate my IDE. getBackground should work fine. You just need to ensure that that textures are actually stitched onto the texture sheet, using TextureStitchEvent.Pre

like this (dosent work):

	@SubscribeEvent
	public static void TextureStitch(TextureStitchEvent.Pre event) {
		
		event.addSprite(new ResourceLocation("cave:items/empty_tool_slot.png"));
		
	}

 

25 minutes ago, diesieben07 said:

Yes, that is how you make custom packets.

Because of the Simple Channel,

I've read the associated Forge doc several times and just didn't understand it.

I understand how I have to create the simple channel, but how do I create the required packet / message.

Can I do this like minecraft (creat class which implements IPackackt)?

 

31 minutes ago, diesieben07 said:

What?

was a question about the other possibility (only open on the client).

but I try that with the NetworkHooks#openGui

[Luis_ST]

13 hours ago, diesieben07 said:

More context is needed.

I don't know what code I would still be helpful, so here are the relevant classes in my git repo:

TextureStitchEvent:

https://github.com/Luis-st/Forge-1.16.5-36.0.1-mdk/blob/main/forge-1.16.5-36.0.1-mdk/src/main/java/net/luis/cave/events/other/OnTextureStitchEvent.java

BackpackContainer (with custom slot subclass):

https://github.com/Luis-st/Forge-1.16.5-36.0.1-mdk/blob/main/forge-1.16.5-36.0.1-mdk/src/main/java/net/luis/cave/common/inventory/container/BackpackContainer.java

 

13 hours ago, diesieben07 said:

The docs explain this. Have you tried anything?

I think I understood after trying something:

my message class requires 3 methods (encode, decode, handle)

which I then have to specify when registering the message (parameter 3 - 6).

Am I right?

[Luis_ST]

50 minutes ago, diesieben07 said:

First of all, this is completely broken.

21 hours ago, Luis_ST said:

I currently use TickEvent#PlayerTickEvent which is not the best solution.

Is there another / better way to do this?

I know this is not the best solution and I have already pointed out that I am currently using the TickEvent#PlayerTickEvent to open the container.

 

5 hours ago, Luis_ST said:

I think I understood after trying something:

my message class requires 3 methods (encode, decode, handle)

which I then have to specify when registering the message (parameter 3 - 6).

so i tried something with the simple channel and i think i understood how it works.

that's why I asked if I was right there so i am right?

 

59 minutes ago, diesieben07 said:

Please start with basic troubleshooting. Your textures that you tried to stitch don't work. So what is the first step? Put a breakpoint in the stitch event handler. Oh, it's not called at all. Why would that be? Let's look at where TextureStitchEvent.Pre is fired: here. Oh look, its fired on the mod event bus. I wonder why your event handler does not work. This is absolute basic debugging. Please try to do it yourself before simply always screaming "it doesn't work". This stuff is not hard.

that is a point that i can understand from you,

i did not test it for long time (use debugger etc.) and then immediately asked for help

 

But now I have tested something and I know (now) that I have to change the EventBus

and that I have to remove the .png from the texture because minecaft adds this automatically.

it still doesn't work, but it's not the TextureStitchEvent because it is running.

so I think it's because of how I use the texture in the slot:

 

	public static class ToolSlot extends SlotItemHandler {
		
		public static final ResourceLocation EMPTY_TOOL_SLOT = new ResourceLocation("cave:items/empty_tool_slot.png");

		// remove two needless methods and the constructor
		
		@Override
		public Pair<ResourceLocation, ResourceLocation> getBackground() {
			
			return Pair.of(PlayerContainer.LOCATION_BLOCKS_TEXTURE, EMPTY_TOOL_SLOT);
			
		}
		
	}

 

[Luis_ST]

54 minutes ago, diesieben07 said:

Update your Git repo please.

updated

 

54 minutes ago, diesieben07 said:

It is not a solution at all. It is broken.

I give up...

 

8 hours ago, Luis_ST said:

I think I understood after trying something:

my message class requires 3 methods (encode, decode, handle)

which I then have to specify when registering the message (parameter 3 - 6).

Am I right?

can you please just give me an answer to this question that would really helpful

[Luis_ST]

9 minutes ago, diesieben07 said:

The ResourceLocation returned from getBackground should not have the .png extension.

that's working

 

11 minutes ago, diesieben07 said:

You do not need to use methods here. You just need to give an encoder, decoder and handler when registering your message. You could even implement them as standalone classes, if you wanted to. You could use lambdas. Or anonymous inner classes. Or method references. It doesn't matter. All that matters is that you conform to the required interface.

Okay, I'll try, but in which method I have to call NetworkHooks#openGui

[Luis_ST]

17 minutes ago, diesieben07 said:

What do you mean?

the message I send has to call NetworkHooks # openGui in which of the methods of the message class I have to call this (encode, decode, handle).

i'm not sure but i think handle because i can't get a player from the other methods

and do I need the remaining methods for something?

[Luis_ST]

14 minutes ago, diesieben07 said:

Server and client can only communicate via the network, which means they can only exchange bytes. Packets are an abstraction of this. Encode tells the game how to turn your packet into bytes, decode tells the game how to turn those bytes back into the packet. Handle is then called (on the receiving side) to perform whatever action you need to perform when the packet is received.

that makes the whole thing not clearer.

 

okay soI should send a message/packet in the ClientTickEvent with the help of the SimpleChannel.

should i add a player to the constructor of the message,

convert it into bytes using the encode method and then back into a player using the decode method

 

Or do I just think too much about the whole thing and I am right to use the handle method because it is carried out on the receiving side.

So I can just check whether the receiving side is server and then open the container?

 

[Luis_ST]

56 minutes ago, diesieben07 said:

When registering your messages to the SimpleChannel you can specify a NetworkDirection. You should do this, as this message makes no sense being sent from server to client. In that case you do not need to check the receiving side, because it will always be server

I tried to create a massage and ClientTickEvent from your explanation:

My message:

https://github.com/Luis-st/Forge-1.16.5-36.0.1-mdk/blob/main/forge-1.16.5-36.0.1-mdk/src/main/java/net/luis/cave/core/BackpackMessage.java

my PacketHandler:

https://github.com/Luis-st/Forge-1.16.5-36.0.1-mdk/blob/main/forge-1.16.5-36.0.1-mdk/src/main/java/net/luis/cave/core/ModPacketHandler.java

and the ClientTickEvent :

https://github.com/Luis-st/Forge-1.16.5-36.0.1-mdk/blob/main/forge-1.16.5-36.0.1-mdk/src/main/java/net/luis/cave/events/other/OnClientTickEvent.java

 

is that correct or do I have to change something?

[Luis_ST]

15 minutes ago, diesieben07 said:

The IMessage interface is not needed. But yes, that works.

okay i already thought so, but why is the interface unnecessary?

 

to the tools switch slots. I probably also need a message for this, right?

 

 

[Luis_ST]

1 minute ago, diesieben07 said:

What?

If, as explained above,

I want to swap the item in the player's hand for the item from a slot in the backpack (when the player presses a key or sneak and uses the mouse wheel)

I also need a message again, am I correct?

[Luis_ST]

51 minutes ago, diesieben07 said:

Yes, you do, because inventory manipulation has to be done server side.

okay I have now created 3 more messages (NextTool, ToolDown, ToolTop) these are currently only sent by pressing keys, and later also by scrolling with the mouse

unfortunately only the first message works, which always gives the player the next tool. at the others,

the player's hand moves but he doesn't get a new item

this is my ClientTickEvent

 

why do only the first message?

and how do I prevent the permanent switch of tools when pressing (adding a cooldown)?

Edited March 6, 2021 by Luis_ST

[Luis_ST]

45 minutes ago, diesieben07 said:

Okay, some things about your packet system which I noticed:

okay i have applied your notice on my packet system

now the other 2 messages also work

 

49 minutes ago, diesieben07 said:

Your messages don't work correctly, because you send all of them twice. All tick events fire twice every tick, you must check TickEvent#phase

is there another possibility to add a delay/cooldown, because despite the TickEvent#phase check you can still change the tools too quickly