Jump to content

[Solved] 1.5.2 Custom Furnace Doesn't Work


mardiff

Recommended Posts

Hello Everyone,

I've been working on making a custom furnace and so far I have tried to copy the vanilla furnace code. Everything has worked fine except for when I to right click on the block. The error I get says that TileEntityFurnace cannot be cast to TileEntityGrinder (which is my tile entity) in onBlockActivated in BlockGrinder. Here's the code for that:

/*
 * A replacement for the displayGUIFurnace in EntityPlayer.
 */
    public void displayGUIGrinder(TileEntityGrinder par1TileEntityGrinder) {}

public boolean onBlockActivated(World par1World, int par2, int par3, int par4, EntityPlayer par5EntityPlayer, int par6, float par7, float par8, float par9)
    {
        if (par1World.isRemote)
        {
            return true;
        }
        else
        {
            TileEntityGrinder tileentitygrinder = (TileEntityGrinder)par1World.getBlockTileEntity(par2, par3, par4);

            if (tileentitygrinder != null)
            {
                this.displayGUIGrinder(tileentitygrinder);
            }

            return true;
        }
    }

Any suggestions? All help will be appreciated.

Thanks,

mardiff

If you really want help, give that modder a thank you.

 

Modders LOVE thank yous.

Link to comment
Share on other sites

Hey there, your problem seems to be at the line,

TileEntityGrinder tileentitygrinder = (TileEntityGrinder)par1World.getBlockTileEntity(par2, par3, par4);

 

And the problem isn't with the line itself. Your errors sounds like the tile entity linked with the block for your grinder is the TileEntityFurnace. Check your createNewTileEntity(World world) method and make sure it returns your custom tile entity.

Link to comment
Share on other sites

Okay, thank you everyone, my furnace doesn't freeze anymore, but when I right click on it now, nothing happens.... Just a question, do I need packet handlers? And if I do, do I need both server and client side?

If you really want help, give that modder a thank you.

 

Modders LOVE thank yous.

Link to comment
Share on other sites

Now it says my mod has to be a network mod. I have the @NetworkMod annotain my my main class and I have a packet handler, but it still gives me the error. Any ideas?

If you really want help, give that modder a thank you.

 

Modders LOVE thank yous.

Link to comment
Share on other sites

Now it says my mod has to be a network mod. I have the @NetworkMod annotain my my main class and I have a packet handler, but it still gives me the error. Any ideas?

Does your annotation look like this?  It doesnt matter if you have either one set differently

@NetworkMod(clientSideRequired = true, serverSideRequired = false)

 

Post your main mod file please

Link to comment
Share on other sites

Main Class:

package redstone;


import net.minecraft.block.Block;
import net.minecraft.block.BlockFurnace;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.item.EnumArmorMaterial;
import net.minecraft.item.EnumToolMaterial;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.src.ModLoader;
import net.minecraftforge.common.EnumHelper;
import net.minecraftforge.common.MinecraftForge;
import cpw.mods.fml.common.Mod;
import cpw.mods.fml.common.Mod.Init;
import cpw.mods.fml.common.Mod.Instance;
import cpw.mods.fml.common.event.FMLInitializationEvent;
import cpw.mods.fml.common.network.NetworkMod;
import cpw.mods.fml.common.network.NetworkRegistry;
import cpw.mods.fml.common.registry.GameRegistry;
import cpw.mods.fml.common.registry.LanguageRegistry;

@Mod(modid="redstoneModv1.0.0", name="Redstone Tools & Armor", version="1.0.0")

@NetworkMod(clientSideRequired = true, serverSideRequired = false)

public class RedstoneBase {
//Blocks
public static final Block grinderIdle = (new BlockGrinder(2624, false)).setHardness(3.5F).setStepSound(Block.soundStoneFootstep).setUnlocalizedName("grinder").setCreativeTab(CreativeTabs.tabDecorations);
    public static final Block grinderBurning = (new BlockGrinder(2625, true)).setHardness(3.5F).setStepSound(Block.soundStoneFootstep).setLightValue(0.875F).setUnlocalizedName("grinder");
    
    @Init
public void load(FMLInitializationEvent event)
{
	LanguageRegistry.addName(grinderIdle, "Grinder");
	GameRegistry.registerBlock(grinderIdle);
	GameRegistry.addRecipe(new ItemStack(grinderIdle), "xxx", "xyx", "xxx", 'x', Block.stone, 'y', Item.wheat);
	GameRegistry.registerTileEntity(TileEntityGrinder.class, "TileEntityGrinder");
	NetworkRegistry.instance().registerGuiHandler(this, new GuiHandler());
}

}

 

GuiHandler:

package redstone;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.world.World;
import cpw.mods.fml.common.network.IGuiHandler;

public class GuiHandler implements IGuiHandler {

@Override
public Object getServerGuiElement(int ID, EntityPlayer player, World world, int x, int y, int z) {

	TileEntity tile_entity = world.getBlockTileEntity(x, y, z);

	if(tile_entity instanceof TileEntityGrinder){

		return new ContainerGrinder(player.inventory, (TileEntityGrinder) tile_entity);
	}

	return null;
}

@Override
public Object getClientGuiElement(int ID, EntityPlayer player, World world, int x, int y, int z) {

	TileEntity tile_entity = world.getBlockTileEntity(x, y, z);

	if(tile_entity instanceof TileEntityGrinder){

		return new GuiGrinder(player.inventory, (TileEntityGrinder) tile_entity);
	}
	return null;
}
}

If you really want help, give that modder a thank you.

 

Modders LOVE thank yous.

Link to comment
Share on other sites

I've been having problems with my custom furnace I've created. I don't get any errors, but when i right click on my furnace in game nothing happens. I've tried adding system out lines at every step, everything right up to the point the gui should be drawn. the only part (so far) that i think i have wrong is here:

      this.mc.renderEngine.bindTexture("alpoh:kilnGui.png");

 

I think I'm not calling my texture the right way. I've various combinations of "mod/alpoh/textures/gui/kilnGui.png" and such.

Even when i left it at its defualt ("/gui/furnace.png") nothing would happen.

 

my onBlockActivated.

    public boolean onBlockActivated(World world, int x, int y, int z, EntityPlayer player, int par6, float par7, float par8, float par9)
    {
    	System.out.println("Kiln was left clicked");
    	if (world.isRemote){
    		System.out.println("world is remote");
    		return true;
    	}
    	else
    	{
    	TileEntityKilnALPOH te = (TileEntityKilnALPOH)world.getBlockTileEntity(x, y , z);
    	
    	if (te != null){
	    	System.out.println("player gui should open");
    		player.openGui(ALPOH.instance, 0, world, x, y, z);
    	}
    	
    	return true;
    	}
    }

 

I have all the proper registers in the main class and have the guiHandler set up just like the one post in this thread.

 

I can set the block, it's just the right click function that doesn't seem to work.

 

edit:

yes this is also for 1.5.2

Link to comment
Share on other sites

I think i'm not registering my renders?

 

package mods.alpoh.common;

import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.item.EnumToolMaterial;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraftforge.common.Configuration;
import net.minecraftforge.common.EnumHelper;
import net.minecraftforge.common.MinecraftForge;
import net.minecraftforge.event.Event.Result;
import net.minecraftforge.event.ForgeSubscribe;
import net.minecraftforge.event.terraingen.OreGenEvent.GenerateMinable;
import net.minecraftforge.oredict.OreDictionary;
import cpw.mods.fml.common.Mod;
import cpw.mods.fml.common.Mod.Init;
import cpw.mods.fml.common.Mod.Instance;
import cpw.mods.fml.common.Mod.PostInit;
import cpw.mods.fml.common.Mod.PreInit;
import cpw.mods.fml.common.event.FMLInitializationEvent;
import cpw.mods.fml.common.event.FMLPostInitializationEvent;
import cpw.mods.fml.common.event.FMLPreInitializationEvent;
import cpw.mods.fml.common.network.NetworkMod;
import cpw.mods.fml.common.network.NetworkRegistry;
import cpw.mods.fml.common.registry.GameRegistry;
import cpw.mods.fml.common.registry.LanguageRegistry;


@Mod(modid = "t1junox_ALPOH", name = "Alexander's Little Ponys of Horror", version = "0.1")
@NetworkMod(clientSideRequired = true, serverSideRequired = false, channels = "ALPOHChannel", packetHandler = PacketHandlerALPOH.class)

public class ALPOH 
{
@Instance
public static ALPOH instance = new ALPOH();

private GuiHandlerALPOH guihandler = new GuiHandlerALPOH();

//===CreativeTab===
public static CreativeTabs tabALPOH = new CreativeTabALPOH(CreativeTabs.getNextID(), "tabALPOH");

//===Event Manager===
public static EventManagerALPOH eventManager = new EventManagerALPOH();

//===============
//PreLoad Method
//===============
@PreInit
public void preInit(FMLPreInitializationEvent event)
{

	//Blocks
	ALPOHBlocks.loadBlocks();
	//Items
	ALPOHItems.loadItems();

	Configuration config = new Configuration(event.getSuggestedConfigurationFile());

	config.load();
	//Blocks
	ALPOHBlocks.oreCopperID = config.get(config.CATEGORY_BLOCK, "Copper Ore", 2750).getInt();
	ALPOHBlocks.oreTinID = config.get(config.CATEGORY_BLOCK, "Tin Ore", 2751).getInt();
	ALPOHBlocks.oreSilverID = config.get(config.CATEGORY_BLOCK, "Silver Ore", 2752).getInt();
	ALPOHBlocks.lifeStoneID = config.get(config.CATEGORY_BLOCK, "Life Stone", 2755).getInt();
	//Items
	ALPOHItems.ingotCopperID = config.get(config.CATEGORY_ITEM, "Copper Ingot", 5500).getInt();
	ALPOHItems.ingotTinID = config.get(config.CATEGORY_ITEM, "Tin Ingot", 5501).getInt();
	ALPOHItems.ingotBronzeID = config.get(config.CATEGORY_ITEM, "Bronze Ingot", 5502).getInt();
	ALPOHItems.ingotSilverID = config.get(config.CATEGORY_ITEM, "Silver Ingot", 5503).getInt();
	ALPOHItems.ingotSteelID = config.get(config.CATEGORY_ITEM, "Steel Ingot", 5504).getInt();
	ALPOHItems.lifeStoneDustID = config.get(config.CATEGORY_ITEM, "Life Stone Dust", 5509).getInt();
	ALPOHItems.rodIronID = config.get(config.CATEGORY_ITEM, "Iron Rod", 5510).getInt();
		//===Foods (5511-5525)===
	ALPOHItems.milkBottleID = config.get(config.CATEGORY_ITEM, "Milk Bottle", 5511).getInt();
	ALPOHItems.flourID = config.get(config.CATEGORY_ITEM, "Flour", 5512).getInt();
	ALPOHItems.doughBreadID = config.get(config.CATEGORY_ITEM, "Bread Dough", 5513).getInt();
	ALPOHItems.mixCakeID = config.get(config.CATEGORY_ITEM, "Cake Mix", 5514).getInt();
	ALPOHItems.doughCookieID = config.get(config.CATEGORY_ITEM, "Cookie Dough", 5515).getInt();
		//===Tools (5526-)===
	//Copper
	ALPOHItems.axeCopperID = config.get(config.CATEGORY_ITEM, "Copper Axe", 5526).getInt();
	ALPOHItems.hoeCopperID = config.get(config.CATEGORY_ITEM, "Copper Hoe", 5527).getInt();
	ALPOHItems.pickaxeCopperID = config.get(config.CATEGORY_ITEM, "Copper Pickaxe", 5528).getInt();
	ALPOHItems.spadeCopperID = config.get(config.CATEGORY_ITEM, "Copper Shovel", 5529).getInt();
	ALPOHItems.swordCopperID = config.get(config.CATEGORY_ITEM, "Copper Sword", 5530).getInt();
	//Bronze
	ALPOHItems.axeBronzeID = config.get(config.CATEGORY_ITEM, "Bronze Axe", 5531).getInt();
	ALPOHItems.hoeBronzeID = config.get(config.CATEGORY_ITEM, "Bronze Hoe", 5532).getInt();
	ALPOHItems.pickaxeBronzeID = config.get(config.CATEGORY_ITEM, "Bronze Pickaxe", 5533).getInt();
	ALPOHItems.spadeBronzeID = config.get(config.CATEGORY_ITEM, "Bronze Shovel", 5534).getInt();
	ALPOHItems.swordBronzeID = config.get(config.CATEGORY_ITEM, "Bronze Sword", 5535).getInt();
	//Silver5536-5540

	//Steel
	ALPOHItems.axeSteelID = config.get(config.CATEGORY_ITEM, "Steel Axe", 5541).getInt();
	ALPOHItems.hoeSteelID = config.get(config.CATEGORY_ITEM, "Steel Hoe", 5542).getInt();
	ALPOHItems.pickaxeSteelID = config.get(config.CATEGORY_ITEM, "Steel Pickaxe", 5543).getInt();
	ALPOHItems.spadeSteelID = config.get(config.CATEGORY_ITEM, "Steel Shovel", 5544).getInt();
	ALPOHItems.swordSteelID = config.get(config.CATEGORY_ITEM, "Steel Sword", 5545).getInt();

	config.save();
}

//============
//Load Method
//============
@Init
public void load(FMLInitializationEvent event)
{
	MinecraftForge.ORE_GEN_BUS.register(this);

	//===Register World===
	GameRegistry.registerWorldGenerator(eventManager);

	//Registry for Kiln
	GameRegistry.registerTileEntity(TileEntityKilnALPOH.class, "tileEntityKilnALPOH");
	NetworkRegistry.instance().registerGuiHandler(this, guihandler);
}

//==========
//Post Init
//==========
@PostInit
public void postInit(FMLPostInitializationEvent event){

}

//Remove Vanilla Iron World Generation
@ForgeSubscribe
    public void generateMineable(GenerateMinable event) {
            switch(event.type) {
                    case IRON:
                            event.setResult(Result.DENY);
                            break;
                    default:
            }
    }


}

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I'm developing a dimension, but it's kinda resource intensive so some times during player teleporting it lags behind making the player phase down into the void, so im trying to implement some kind of pregeneration to force the game loading a small set of chunks in the are the player will teleport to. Some of the things i've tried like using ServerLevel and ServerChunkCache methods like getChunk() dont actually trigger chunk generation if the chunk isn't already on persistent storage (already generated) or placing tickets, but that doesn't work either. Ideally i should be able to check when the task has ended too. I've peeked around some pregen engines, but they're too complex for my current understanding of the system of which I have just a basic understanding (how ServerLevel ,ServerChunkCache  and ChunkMap work) of. Any tips or other classes I should be looking into to understand how to do this correctly?
    • https://mclo.gs/4UC49Ao
    • Way back in the Forge 1.17 days, work started for adding JPMS (Java Platform Module Support) to ModLauncher and ForgeModLoader. This has been used internally by Forge and some libraries for a while now, but mods (those with mods.toml specifically) have not been able to take advantage of it. As of Forge 1.21.1 and 1.21.3, this is now possible!   What is JPMS and what does it mean for modders? JPMS is the Java Platform Module System, introduced in Java 9. It allows you to define modules, which are collections of packages and resources that can be exported or hidden from other modules. This allows for much more fine-tuned control over visibility, cleaner syntax for service declarations and support for sealed types across packages. For example, you might have a mod with a module called `com.example.mod` that exports `com.example.mod.api` and `com.example.mod.impl` to other mods, but hides `com.example.mod.internal` from them. This would allow you to have a clean API for other mods to use, while keeping your internal implementation details hidden from IDE hints, helping prevent accidental usage of internals that might break without prior notice. This is particularly useful if you'd like to use public records with module-private constructors or partially module-private record components, as you can create a sealed interface that only your record implements, having the interface be exported and the record hidden. It's also nice for declaring and using services, as you'll get compile-time errors from the Java compiler for typos and the like, rather than deferring to runtime errors. In more advanced cases, you can also have public methods that are only accessible to specific other modules -- handy if you want internal interactions between multiple of your own mods.   How do I bypass it? We understand there may be drama in implementing a system that prevents mods from accessing each other's internals when necessary (like when a mod is abandoned or you need to fix a compat issue) -- after all, we are already modding a game that doesn't have explicit support for Java mods yet. We have already thought of this and are offering APIs from day one to selectively bypass module restrictions. Let me be clear: Forge mods are not required to use JPMS. If you don't want to use it, you don't have to. The default behaviour is to have fully open, fully exported automatic modules. In Java, you can use the `Add-Opens` and `Add-Exports` manifest attributes to selectively bypass module restrictions of other mods at launch time, and we've added explicit support for these when loading your Forge mods. At compile-time, you can use existing solutions such as the extra-java-module-info Gradle plugin to deal with non-modular dependencies and add extra opens and exports to other modules. Here's an example on how to make the internal package `com.example.examplemod.internal` open to your mod in your build.gradle: tasks.named('jar', Jar) { manifest { attributes([ 'Add-Opens' : 'com.example.examplemod/com.example.examplemod.internal' 'Specification-Title' : mod_id, 'Specification-Vendor' : mod_authors // (...) ]) } } With the above in your mod's jar manifest, you can now reflectively access the classes inside that internal package. Multiple entries are separated with a space, as per Java's official spec. You can also use Add-Exports to directly call without reflection, however you'd need to use the Gradle plugin mentioned earlier to be able to compile. The syntax for Add-Exports is the same as Add-Opens, and instructions for the compile-time step with the Gradle plugin are detailed later in this post. Remember to prefer the opens and exports keywords inside module-info.java for sources you control. The Add-Opens/Add-Exports attributes are only intended for forcing open other mods.   What else is new with module support? Previously, the runtime module name was always forced to the first mod ID in your `mods.toml` file and all packages were forced fully open and exported. Module names are now distinguished from mod IDs, meaning the module name in your module-info.java can be different from the mod ID in your `mods.toml`. This allows you to have a more descriptive module name that doesn't have to be the same as your mod ID, however we strongly recommend including your mod ID as part of your module name to aid troubleshooting. The `Automatic-Module-Name` manifest attribute is now also honoured, allowing you to specify a module name for your mod without needing to create a `module-info.java` file. This is particularly useful for mods that don't care about JPMS features but want to have a more descriptive module name and easier integration with other mods that do use JPMS.   How do I use it? The first step is to create a `module-info.java` file in your mod's source directory. This file should be in the same package as your main mod class, and should look something like this: open module com.example.examplemod { requires net.minecraftforge.eventbus; requires net.minecraftforge.fmlcore; requires net.minecraftforge.forge; requires net.minecraftforge.javafmlmod; requires net.minecraftforge.mergetool.api; requires org.slf4j; requires logging; } For now, we're leaving the whole module open to reflection, which is a good starting point. When we know we want to close something off, we can remove the open modifier from the module and open or export individual packages instead. Remember that you need to be open to Forge (module name net.minecraftforge.forge), otherwise it can't call your mod's constructor. Next is fixing modules in Gradle. While Forge and Java support modules properly, Gradle does not put automatic modules on the module path by default, meaning that the logging module (from com.mojang:logging) is not found. To fix this, add the Gradle plugin and add a compile-time module definition for that Mojang library: plugins { // (...) id 'org.gradlex.extra-java-module-info' version "1.9" } // (...) extraJavaModuleInfo { failOnMissingModuleInfo = false automaticModule("com.mojang:logging", "logging") } The automatic module override specified in your build.gradle should match the runtime one to avoid errors. You can do the same for any library or mod dependency that is missing either a module-info or explicit Automatic-Module-Name, however be aware that you may need to update your mod once said library adds one. That's all you need to get started with module support in your mods. You can learn more about modules and how to use them at dev.java.
    • Faire la mise à jour grâce à ce lien m'a aider personnellement, merci à @Paint_Ninja. https://www.amd.com/en/support 
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.