Jump to content

[1.6.2] [Solved] Fluid system


Pow3rCut

Recommended Posts

Hi,

 

I am trying to update my mod to 1.6.2, all is going well apart from the liquid system, previously I had used ILiquid and extended BlockFlowing/BlockStill. This system is now gone, and I was wondering if anyone has an example (or can just point me in the right direction, at the moment I am running around like a headless chicken) for how to implement the new system using BlockFluidBase/Finite

 

From what I can see you need:

A fluid

Two blocks as usual - Source and Flowing

To Register the fluid in the FluidRegistery

 

What else do you need to add?

 

Thanks in advance,

- Pow3rCut

 

If I helped you click the Thank You button

Link to comment
Share on other sites

Going through the same process, and I think I just about have it working.

 

What you need:

 

  • Class extending Fluid for the registry
  • Class extending BlockFluidClassic (flowing and still are rolled into one) for the in-world block
  • Class extending ItemBucket if you want a custom container
  • @ForgeSubscribe'd FillBucketEvent handler function (can have its own class if you use MinecraftForge.EVENT_BUS.register())

 

The Fluid class is very simple. All you need is a constructor to set a couple of values. You can even register it within its constructor:

 

public FluidExample( int id )
{
	super( "example" );

	setDensity( 8 ); // used by the block to work out how much it slows entities
	setViscosity( 4000 ); // used by the block to work out how fast it flows

	FluidRegistry.registerFluid( this );
}

 

The BlockFluidClassic class is more similar to the old LiquidFlowing and Liquid Still classes. The main difference is that you give it a reference to the fluid, and it draws some information from that. Also, the textures are slightly different. Define private still and flowing icons in the class, and register them in your override of

registerIcons( IconRegister )

. Also, pass them to

getFluid().setIcons( Icon, Icon )

, since it's impossible to get a reference to the IconRegister elsewhere. Then, in your getIcon override, put this:

 

@Override
@SideOnly(Side.CLIENT)
public Icon getIcon( int side, int meta )
{
	if ( side <= 1 )
		return iconStill;
	else
		return iconFlowing;
}

 

This is getting quite long, so I'll put the bucket code in another comment.

Link to comment
Share on other sites

Before I get onto the bucket code, I almost forgot - register your BlockFluidClassic instance in your proxy like you would for any other block.

 

For the ItemBucket class, the only difference from a normal Item is that you pass the

super

constructor a second value: the id of your BlockFluidClassic class, which will be automatically placed when you right click.

 

Then, somewhere in initialisation, use the FluidContainerRegistry to register this item as a container holding one bucket's worth of that fluid:

 

FluidContainerRegistry.registerFluidContainer(
	new FluidContainerData(
		FluidRegistry.getFluidStack( ModExample.fluidExample.getName(), FluidContainerRegistry.BUCKET_VOLUME ),
		new ItemStack( ModExample.bucketExample ),
		new ItemStack( Item.bucketEmpty )
	)
);

 

Finally, we need to tell minecraft to fill a bucket with this fluid whenever it is right clicked on with a bucket in hand. Fortunately, Forge provides an event listener that fires when you right click with a bucket.

 

@ForgeSubscribe
public void onBucketFill( FillBucketEvent event )
{
	ItemStack result = attemptFill( event.world, event.target );

	if ( result != null )
	{
		event.result = result;
		event.setResult( Result.ALLOW );
	}
}

 

where attemptFill( World, MovingObjectPosition ) is a function that checks what the picked block is, and returns an ItemStack of the relevant filled container if applicable:

 

private ItemStack attemptFill( World world, MovingObjectPosition p )
{
	int id = world.getBlockId( p.blockX, p.blockY, p.blockZ );

	if ( id == ModExample.blockFluidExample.blockID )
	{
		if ( world.getBlockMetadata( p.blockX, p.blockY, p.blockZ ) == 0 ) // Check that it is a source block
		{
			world.setBlock( p.blockX, p.blockY, p.blockZ, 0 ); // Remove the fluid block

			return new ItemStack( ModExample.bucketExample );
		}
	}

	return null;
}

 

Phew. I think that's all, though. If it doesn't work, I'll check to see if I've missed anything.

Link to comment
Share on other sites

I'm not sure what I did wrong, but the texture on the liquid in game doesn't work. All I know is that the error is unhappy with the this.getFluid().setIcons(this.theIcon[0], this.theIcon[1]); Here's the whole class:

package mardiff.ethanol.fluids;

import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;
import net.minecraft.block.Block;
import net.minecraft.block.BlockStationary;
import net.minecraft.block.material.Material;
import net.minecraft.client.renderer.texture.IconRegister;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.Entity;
import net.minecraft.util.DamageSource;
import net.minecraft.util.Icon;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;
import net.minecraftforge.fluids.BlockFluidClassic;

public class BlockEthanolLiquid extends BlockFluidClassic
{
protected Icon[] theIcon;

public BlockEthanolLiquid(int i)
{
	super(i, ModFluids.ethanol, Material.water);
	this.setCreativeTab(CreativeTabs.tabMisc);
	ModFluids.ethanol.setBlockID(this);
	this.getFluid().setIcons(this.theIcon[0], this.theIcon[1]);
}

@Override
@SideOnly(Side.CLIENT)
public void registerIcons(IconRegister iconRegister) {
	this.theIcon = new Icon[]{iconRegister.registerIcon("ethanol:ethanol_still"), iconRegister.registerIcon("ethanol:ethanol_flow")};
}

@Override
@SideOnly(Side.CLIENT)
public Icon getIcon(int side, int meta)
{
	if ( side <= 1 ) {
		return this.theIcon[0];
	} else {
		return this.theIcon[1];
	}
}
}

 

Edit: *facepalm* It wasn't the code, it was that I was using my 1.5 textures.... Everything works fine!

If you really want help, give that modder a thank you.

 

Modders LOVE thank yous.

Link to comment
Share on other sites

  • 4 weeks later...

I finally got the bucket to place the liquid but I can't get the the bucket to pick up the liquid, it keeps giving water bucket instead of darkness bucket.

this is my bucket code please help.

 

 

 

package kakarotvg.omega.items;

 

import kakarotvg.omega.ItemHandler;

import kakarotvg.omega.LiquidHandler;

import kakarotvg.omega.Reference;

import net.minecraft.client.renderer.texture.IconRegister;

import net.minecraft.item.ItemBucket;

import net.minecraft.item.ItemStack;

import net.minecraft.util.MovingObjectPosition;

import net.minecraft.world.World;

import net.minecraftforge.event.Event.Result;

import net.minecraftforge.event.EventPriority;

import net.minecraftforge.event.ForgeSubscribe;

import net.minecraftforge.event.entity.player.FillBucketEvent;

import cpw.mods.fml.relauncher.Side;

import cpw.mods.fml.relauncher.SideOnly;

 

public class VgBucket extends ItemBucket {

 

    private String itemName;

 

    @SideOnly(Side.CLIENT)

    @Override

    public void registerIcons(IconRegister register) {

        this.itemIcon = register.registerIcon(Reference.MOD_ID + ":" + (this.getUnlocalizedName().substring(5)));

    }

 

    public VgBucket(int id, int par1, String name) {

        super(id, par1);

        this.itemName = name;

        this.setUnlocalizedName(name);

 

    }

 

    @ForgeSubscribe

    public void onBucketFill(FillBucketEvent event) {

        ItemStack result = attemptFill(event.world, event.target);

 

        if (result != null) {

            event.result = result;

            event.setResult(Result.ALLOW);

        }

    }

 

    private ItemStack attemptFill(World world, MovingObjectPosition p) {

        int id = world.getBlockId(p.blockX, p.blockY, p.blockZ);

 

        if (id == LiquidHandler.Darknessliquid.blockID) {

            if (world.getBlockMetadata(p.blockX, p.blockY, p.blockZ) == 0) // Check that it is a source block

            {

                world.setBlock(p.blockX, p.blockY, p.blockZ, 0); // Remove the fluid block

 

                return new ItemStack(ItemHandler.darknessbucket); // Return the filled bucked item here.

            }

        }

 

        return null;

    }

 

}

 

 

 

if (You.likescoding == false){
      You.goaway;
}

Link to comment
Share on other sites

  • 2 months later...

@Kakarotvg you need to add this line:

MinecraftForge.EVENT_BUS.register(this);

to the constructor of the VgBucket:

public VgBucket(int id, int par1, String name) {
        super(id, par1);
        this.itemName = name;
        this.setUnlocalizedName(name);
        MinecraftForge.EVENT_BUS.register(this);
    }

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I'm developing a dimension, but it's kinda resource intensive so some times during player teleporting it lags behind making the player phase down into the void, so im trying to implement some kind of pregeneration to force the game loading a small set of chunks in the are the player will teleport to. Some of the things i've tried like using ServerLevel and ServerChunkCache methods like getChunk() dont actually trigger chunk generation if the chunk isn't already on persistent storage (already generated) or placing tickets, but that doesn't work either. Ideally i should be able to check when the task has ended too. I've peeked around some pregen engines, but they're too complex for my current understanding of the system of which I have just a basic understanding (how ServerLevel ,ServerChunkCache  and ChunkMap work) of. Any tips or other classes I should be looking into to understand how to do this correctly?
    • https://mclo.gs/4UC49Ao
    • Way back in the Forge 1.17 days, work started for adding JPMS (Java Platform Module Support) to ModLauncher and ForgeModLoader. This has been used internally by Forge and some libraries for a while now, but mods (those with mods.toml specifically) have not been able to take advantage of it. As of Forge 1.21.1 and 1.21.3, this is now possible!   What is JPMS and what does it mean for modders? JPMS is the Java Platform Module System, introduced in Java 9. It allows you to define modules, which are collections of packages and resources that can be exported or hidden from other modules. This allows for much more fine-tuned control over visibility, cleaner syntax for service declarations and support for sealed types across packages. For example, you might have a mod with a module called `com.example.mod` that exports `com.example.mod.api` and `com.example.mod.impl` to other mods, but hides `com.example.mod.internal` from them. This would allow you to have a clean API for other mods to use, while keeping your internal implementation details hidden from IDE hints, helping prevent accidental usage of internals that might break without prior notice. This is particularly useful if you'd like to use public records with module-private constructors or partially module-private record components, as you can create a sealed interface that only your record implements, having the interface be exported and the record hidden. It's also nice for declaring and using services, as you'll get compile-time errors from the Java compiler for typos and the like, rather than deferring to runtime errors. In more advanced cases, you can also have public methods that are only accessible to specific other modules -- handy if you want internal interactions between multiple of your own mods.   How do I bypass it? We understand there may be drama in implementing a system that prevents mods from accessing each other's internals when necessary (like when a mod is abandoned or you need to fix a compat issue) -- after all, we are already modding a game that doesn't have explicit support for Java mods yet. We have already thought of this and are offering APIs from day one to selectively bypass module restrictions. Let me be clear: Forge mods are not required to use JPMS. If you don't want to use it, you don't have to. The default behaviour is to have fully open, fully exported automatic modules. In Java, you can use the `Add-Opens` and `Add-Exports` manifest attributes to selectively bypass module restrictions of other mods at launch time, and we've added explicit support for these when loading your Forge mods. At compile-time, you can use existing solutions such as the extra-java-module-info Gradle plugin to deal with non-modular dependencies and add extra opens and exports to other modules. Here's an example on how to make the internal package `com.example.examplemod.internal` open to your mod in your build.gradle: tasks.named('jar', Jar) { manifest { attributes([ 'Add-Opens' : 'com.example.examplemod/com.example.examplemod.internal' 'Specification-Title' : mod_id, 'Specification-Vendor' : mod_authors // (...) ]) } } With the above in your mod's jar manifest, you can now reflectively access the classes inside that internal package. Multiple entries are separated with a space, as per Java's official spec. You can also use Add-Exports to directly call without reflection, however you'd need to use the Gradle plugin mentioned earlier to be able to compile. The syntax for Add-Exports is the same as Add-Opens, and instructions for the compile-time step with the Gradle plugin are detailed later in this post. Remember to prefer the opens and exports keywords inside module-info.java for sources you control. The Add-Opens/Add-Exports attributes are only intended for forcing open other mods.   What else is new with module support? Previously, the runtime module name was always forced to the first mod ID in your `mods.toml` file and all packages were forced fully open and exported. Module names are now distinguished from mod IDs, meaning the module name in your module-info.java can be different from the mod ID in your `mods.toml`. This allows you to have a more descriptive module name that doesn't have to be the same as your mod ID, however we strongly recommend including your mod ID as part of your module name to aid troubleshooting. The `Automatic-Module-Name` manifest attribute is now also honoured, allowing you to specify a module name for your mod without needing to create a `module-info.java` file. This is particularly useful for mods that don't care about JPMS features but want to have a more descriptive module name and easier integration with other mods that do use JPMS.   How do I use it? The first step is to create a `module-info.java` file in your mod's source directory. This file should be in the same package as your main mod class, and should look something like this: open module com.example.examplemod { requires net.minecraftforge.eventbus; requires net.minecraftforge.fmlcore; requires net.minecraftforge.forge; requires net.minecraftforge.javafmlmod; requires net.minecraftforge.mergetool.api; requires org.slf4j; requires logging; } For now, we're leaving the whole module open to reflection, which is a good starting point. When we know we want to close something off, we can remove the open modifier from the module and open or export individual packages instead. Remember that you need to be open to Forge (module name net.minecraftforge.forge), otherwise it can't call your mod's constructor. Next is fixing modules in Gradle. While Forge and Java support modules properly, Gradle does not put automatic modules on the module path by default, meaning that the logging module (from com.mojang:logging) is not found. To fix this, add the Gradle plugin and add a compile-time module definition for that Mojang library: plugins { // (...) id 'org.gradlex.extra-java-module-info' version "1.9" } // (...) extraJavaModuleInfo { failOnMissingModuleInfo = false automaticModule("com.mojang:logging", "logging") } The automatic module override specified in your build.gradle should match the runtime one to avoid errors. You can do the same for any library or mod dependency that is missing either a module-info or explicit Automatic-Module-Name, however be aware that you may need to update your mod once said library adds one. That's all you need to get started with module support in your mods. You can learn more about modules and how to use them at dev.java.
    • Faire la mise à jour grâce à ce lien m'a aider personnellement, merci à @Paint_Ninja. https://www.amd.com/en/support 
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.