Custom Block GUI - Why do my items fall out when picked up?

Draco18s · May 5, 2013

Ok, I have a working custom GUI with inventory slots and all that jazz.

But here's the thing:

I want to have some locked slots (effectively output slots), several storage slots (like a chest), and an input slot.

But it seems that every time I move items from one slot to another in the code (e.g. taking the input stack and moving to an output slot or to a storage slot) when I go to pick that stack up, I pick up a stack of size one and drop it into the world.

What gives?

Update entity function:

public void updateEntity() {
    	if (chestContents[30] != null) {
    	    	//if the input slot has something in it
    		for(int i = 18; i < 24; i++) {
    	    	    	//find an output slot that has the same item, or an empty one
    			if(chestContents[i] != null && chestContents[i].getItem() == chestContents[30].getItem()) {
    	    	    	    	//if output matches, stick the rest in storage and quit
    				placeItemInChest(30);
    				return;
    			}
    			else if (chestContents[i] == null) {
    	    	    	    	//if an empty output slot, put one in the output and the rest in storage, then quit
    				chestContents[i] = chestContents[30].splitStack(1);
    				placeItemInChest(30);
    				return;
    			}
    		}
    	}
    }
    
    private void placeItemInChest(int slotID) {
    	if(chestContents[slotID] == null || chestContents[slotID].stackSize == 0) {
    		return;
    	}
	for(int i = 0; i < 18; i++) {
    		    if(chestContents[i] == null) {
		    //copy to new slot, null old slot
   			    chestContents[i] = chestContents[slotID].copy();
    			    chestContents[slotID] = null;
    			    return;
    			}
    		}
    }

Mazetar · May 5, 2013

Exactly the same problem as I have inn my fucked up GUI thread.

I've got the feeling that this is a subtle but quite stupid bug we have somehow managed to implement

Draco18s · May 5, 2013

Exactly the same problem as I have inn my fucked up GUI thread.

I've got the feeling that this is a subtle but quite stupid bug we have somehow managed to implement

I discovered late last night that placing the Slots at negative values is what does it:

for (int i = 0; i < 6; i++) {//down
			for (int j = 0; j < 3; j++) {//across
				addSlotToContainer(new Slot(shopEntity, j + i * 3, mod -35 + j * 18, 0 + i * 18));
			}
		}

See that mod in there? It's equal to 35, so that when j is 0, the x position of the slot doesn't go negative. Which means the farthest left you can put a slot is where the left most hotbar item is.

The problem is, I can't find a way to shift the leftmost edge of the Gui to the left, that is, make the actual GUI bigger.

Draco18s · May 5, 2013

To set the GUI size set xSize and ySize to the appropriate values in your initGui method in the GuiContainer.

Ok, so, here's the thing:

In order to make a gui that is wider than it is tall, the texture doesn't render properly.

I set xSize to 291 (256+35) and increase my texture's width by the same amount (transparent pixels on the right edge):

width=800 height=449 http://s21.postimg.org/if7xg385z/2013_05_05_17_08_45.png[/img]

Ok, so maybe the texture needs to be square, add 35 pixels to the height (centering it), and increase the GUI size to 291 tall as well.

width=800 height=449 http://s18.postimg.org/h1f77j5mh/2013_05_05_17_10_58.png[/img]

Yeah, I have no idea what's going on.

Sign In

Custom Block GUI - Why do my items fall out when picked up?

Recommended Posts

Draco18s

Mazetar

Draco18s

Draco18s

Join the conversation

Announcements

Recently Browsing

Posts

Topics

Who's Online (See full list)

Browse

Activity

Important Information