Turtledove

Solved my own problem, I ended up using a parser rather than the ScriptEngine, which I should've done from the beginning.

I am currently creating dozens (potentially 100+) different animations for the player's hand in first person view, and to make it easier on myself I have a system that lets me parse .json files for expressions, in a form like this: { "transform":[ {"translation":["__i * 0.56 - __swing_ratio * 1.75 + 0.9","-0.38", "-0.52"]}, {"rotation":["0.0","90.0","0.0"]}, {"rotation":["0.0","0.0","-90.0"]}, {"rotation":["-25.0 + 25.0 * Math.cos(__swing_ratio * __swing_ratio * Math.PI)","0.0","0.0"]} ] } these get read into a list of an HandTransformation class where type is the type of transformation. public class HandTransformation { public String type; public String[] transformation = new String[3]; } At runtime, this method is called which evaluates the expression in the .json via a JS ScriptEngine, and does the appropriate transformations to the MatrixStacks object from the RenderHand event: matrixStack.clear(); matrixStack.push(); for (ItemTransformation itemTransformation:action.getTransformations()) { String type = itemTransformation.type; Vector3f transform = getVector(itemTransformation, side, swingRatio, equippedRatio); if (type.equals("translation")) { matrixStack.translate(transform.getX(), transform.getY(), transform.getZ()); } else if (type.equals("rotation")) { matrixStack.rotate(Vector3f.XP.rotationDegrees(transform.getX())); matrixStack.rotate(Vector3f.YP.rotationDegrees(transform.getY())); matrixStack.rotate(Vector3f.ZP.rotationDegrees(transform.getZ())); } } Minecraft.getInstance().getFirstPersonRenderer().renderItemSide(Minecraft.getInstance().player, itemStack, rightHanded ? ItemCameraTransforms.TransformType.FIRST_PERSON_RIGHT_HAND : ItemCameraTransforms.TransformType.FIRST_PERSON_LEFT_HAND, !rightHanded, matrixStack, buffer,light); matrixStack.pop(); private Vector3f getVector(ItemTransformation itemTransformation, float side, float swingRatio, float equippedRatio) { String[] transformation = itemTransformation.transformation; String sideString = Float.toString(side); String swingRatioString = Float.toString(swingRatio); String equppedRatioString = Float.toString(equippedRatio); Vector3f transforms = new Vector3f(); for (int i = 0; i < 3; i++) { String expression = transformation[i]; expression.replaceAll("__i", sideString); expression.replaceAll("__swing_ratio", swingRatioString); expression.replaceAll("__equip_ratio", equppedRatioString); float result = evaluateScript(expression); switch(i) { case 0: transforms.setX(result); break; case 1: transforms.setY(result); break; default: transforms.setZ(result); } } return transforms; } public float evaluateScript(String expression) { float result = 0.0f; ScriptEngineManager factory = new ScriptEngineManager(); ScriptEngine engine = factory.getEngineByName("JavaScript"); try { Object obj = engine.eval(expression); result = Float.parseFloat(obj.toString()); } catch(ScriptException e) { e.printStackTrace(); } return result; } This all works, but as expected it cripples the framerate whenever it runs due to ScriptEngine. So, the next best thing is to apply the transformations to my own MatrixStacks object at initialization, for when I need them during gameplay. Can I simply create my own MatrixStacks object at initialization (outside of the render event call) and not use the one provided by the event call? Or does it work more like the old GLStateManager and just wouldn't work? Or better yet, is there an equally robust alternative to the JS script engine for evaluating mathematical expressions at runtime?

I think I got it, in some ways it's cleaner than how it was done in 1.12.2 since we don't need to go through an interface. public final class PacketRegistry { /** * The ID for the next packet registration. */ private static final String PROTOCOL_VERSION = Integer.toString(1); private byte nextPacketID = 0; /** * The internal network wrapper. */ private static final SimpleChannel wrapper = NetworkRegistry.ChannelBuilder .named(new ResourceLocation(Withernauts.MODID, "main_channel")) .clientAcceptedVersions(PROTOCOL_VERSION::equals) .serverAcceptedVersions(PROTOCOL_VERSION::equals) .networkProtocolVersion(() -> PROTOCOL_VERSION) .simpleChannel(); public void registerPackets() { //register packets going to the client //register packets going to the server } @SuppressWarnings({"unchecked", "rawtypes"}) protected <MESSAGE> void registerServerToClient(Class<MESSAGE> type, BiConsumer<MESSAGE, PacketBuffer> encoder, Function<PacketBuffer, MESSAGE> decoder, BiConsumer<MESSAGE, Supplier<NetworkEvent.Context>> consumer) { this.wrapper.registerMessage(nextPacketID++, type, encoder, decoder, consumer, Optional.of(NetworkDirection.PLAY_TO_CLIENT)); } @SuppressWarnings({"unchecked", "rawtypes"}) protected <MESSAGE> void registerClientToServer(Class<MESSAGE> type, BiConsumer<MESSAGE, PacketBuffer> encoder, Function<PacketBuffer, MESSAGE> decoder, BiConsumer<MESSAGE, Supplier<NetworkEvent.Context>> consumer) { this.wrapper.registerMessage(nextPacketID++, type, encoder, decoder, consumer, Optional.of(NetworkDirection.PLAY_TO_SERVER)); } /** * Sends the given packet to every client. * * @param message the packet to send. */ public<MESSAGE> void sendToAll(MESSAGE message) { this.wrapper.send(PacketDistributor.ALL.noArg(), message); } /** * Sends the given packet to the given player. * * @param message the packet to send. * @param player the player to send the packet to. */ public<MESSAGE> void sendTo(MESSAGE message, ServerPlayerEntity player) { if (player.connection != null) this.wrapper.sendTo(message, player.connection.getNetworkManager(), NetworkDirection.PLAY_TO_CLIENT); } /** * Sends the given packet to all players around the given target point. * * @param message the packet to send. * @param point the target point. */ public<MESSAGE> void sendToAllAround(MESSAGE message, PacketDistributor.TargetPoint point) { this.wrapper.send(PacketDistributor.NEAR.with(()->point), message); } /** * Sends the given packet to the server. * * @param message the packet to send. */ public<MESSAGE> void sendToServer(MESSAGE message) { this.wrapper.sendToServer(message); } public<MESSAGE> void sendToAllTracking(MESSAGE message, Entity entity) { this.wrapper.send(PacketDistributor.TRACKING_ENTITY.with(() -> entity), message); } }

I'm attempting to update my packet system from 1.12.2 -> 1.16.3, and I've found that a ton appears to have changed, I've looked through the 1.13/1.14 primer and overall I'm still not sure what to do here. This was my packethandler class in 1.12 public final class PacketHandler { /** * The ID for the next packet registration. */ private byte nextPacketID = 0; /** * The internal network wrapper. */ private SimpleNetworkWrapper wrapper; /** * The channelid. */ private String channelid; /** * Instantiates a new packet handler with the given channelid and reserves * the channel. * * @param channelid the channelid. This is mostly the modid. */ public PacketHandler(String channelid) { this.wrapper = NetworkRegistry.INSTANCE.newSimpleChannel(channelid); this.channelid = channelid; } public void registerPackets() { registerPacket(PlayerSyncCapability.class, new PlayerSyncCapability.Handler(), Side.SERVER); } /** * Register an IMessage packet with it's corresponding message handler. * * @param packetClass the packet's class that should be registered. * @param messageHandler the message handler for this packet type. * @param target The side to which this packet can be sent. * @return <code>true</code>, if successful */ @SuppressWarnings({"unchecked", "rawtypes"}) public boolean registerPacket(Class<? extends IMessage> packetClass, MessageHandler messageHandler, Side target) { if (this.nextPacketID == -1) throw new IllegalStateException("Too many packets registered for channel " + this.channelid); this.wrapper.registerMessage(messageHandler, packetClass, this.nextPacketID, target); Log.debug("Registered packet class %s with handler class %s for the channel %s. Send direction: to %s. The discriminator is %s.", packetClass.getSimpleName(), messageHandler.getClass().getSimpleName(), this.channelid, target.name().toLowerCase(), this.nextPacketID); this.nextPacketID++; return true; } /** * Sends the given packet to every client. * * @param message the packet to send. */ public void sendToAll(IMessage message) { this.wrapper.sendToAll(message); } /** * Sends the given packet to the given player. * * @param message the packet to send. * @param player the player to send the packet to. */ public void sendTo(IMessage message, EntityPlayerMP player) { if (player.connection != null) this.wrapper.sendTo(message, player); } /** * Sends the given packet to all players around the given target point. * * @param message the packet to send. * @param point the target point. */ public void sendToAllAround(IMessage message, NetworkRegistry.TargetPoint point) { this.wrapper.sendToAllAround(message, point); } /** * Sends the given packet to all players within the radius around the given coordinates. * * @param message the packet to send. * @param dimension the dimension. * @param x the x coordinate. * @param y the y coordinate. * @param z the z coordinate. * @param range the radius. */ public void sendToAllAround(IMessage message, int dimension, double x, double y, double z, double range) { this.sendToAllAround(message, new NetworkRegistry.TargetPoint(dimension, x, y, z, range)); } /** * Sends the given packet to all players within the radius around the given entity. * * @param message the packet to send. * @param entity the entity. * @param range the radius. */ public void sendToAllAround(IMessage message, Entity entity, double range) { this.sendToAllAround(message, entity.dimension, entity.posX, entity.posY, entity.posZ, range); } /** * Sends the given packet to the server. * * @param message the packet to send. */ public void sendToServer(IMessage message) { this.wrapper.sendToServer(message); } public void sendToAllTracking(IMessage message, Entity entity) { this.wrapper.sendToAllTracking(message, entity); } } Couple things that threw me for a loop I'm hoping for some clarification on: 1) IMessage is no longer a thing. So can I no longer do something like my registerpacket implementation anymore? Or is it going to have to be in the form of INSTANCE.registerMessage(nextID(),SendBlockData.class,SendBlockData::encode,SendBlockData::new,SendBlockData::handle); 2) Logical sides aren't specified when registering the packets. Is there no longer any distinction between packets meant on the client vs server? 3) SimpleChannel doesn't have sendToAll alongside a few other convenient methods. Thanks!

I'm updating a gigantic mod of mine to the latest version, I have just a few questions to start: 1. To my understanding the preInit and and initialization events were removed. As an example, in 1.12 I registered my entities' renderer in the preinitialization event, where would this go in 1.16? 2. I use GLStateManager calls throughout the mod to make changes to UI, first person item rendering, and the like. But is there a new way of doing this? 3. Did entity AI/pathfinding change in any significant way?

For testing purposes, I've cloned my mods repo on github and successfully got it to run the game on a separate, fresh machine, but for some reason it's missing the minecraft library files that comes with Forge mdk installs. The build.gradle is obviously the same as the version I pushed to git, and the library fils are all there on that machine. What do I need to do?

Post your same class in 1.15, it'll be obvious if it's 1.12 or not based on the class names.

An idea I've just had: When a player first spawns into a world (checked via a value set in player capabilities), set a radius in the XZ direction, and find an appropriate y level to spawn the entity in. Would this work? If an entity is spawned where chunks haven't been loaded yet, what happens?

I've created some npc entities that I'd like to have spawn only once in the world. They can't die (unless you break bedrock and make them fall into the void) so they don't need to have any special respawn mechanics. How can I achieve this? Is there a way I can save whether an NPC has been spawned to the world?

It doesn't look like you know Java, go learn that before trying to make a mod.

So I was having a gander at the docs, and I see this: Is this inclusive or exclusive? I.e. Can I have something like this?

Bruh this isnt a forum for fabric, that's not forge related at all

I've been reading Jabelar's old guide on this topic (http://jabelarminecraft.blogspot.com/p/minecraft-modding-custom-dimension.html) and I was wondering, if I want to add a biome to the Overworld, do I still need to create a worldprovider and chunk generator? I just want to add a variant of the existing ocean biomes with different water color. Edit: Nope you do not. Just registering the biome is enough

So I've defined a custom entity behavior called EntityAIFaceOff, and it basically just has my entity find a path to the player and stop at a certain distance. These are the conditions for stopping the execution: It all works fine on solid ground, but when I lead the mob into water it'll stop chasing me because its path to me becomes null. It reverts to its wandering AI and floats around with the swimming AI and wandering AI. I took a look at the zombie's AIs and didn't see anything special it was doing there, I use all the same path finding methods. How exactly does Minecraft's pathfinding work when the mob is in water? Edit: I've sort of replicated the Vanilla one by manually setting the entity's motion to go towards the player if it's in water. Not sure if there's a better way I can do it tho.

Hmm, would it work to just check for the item's registry name? Or would this not work in an obfuscated environment? I.e. check if the item's registry name has the word "cooked" in it.