Jump to content
View in the app

A better way to browse. Learn more.

Forge Forums

A full-screen app on your home screen with push notifications, badges and more.

To install this app on iOS and iPadOS
  1. Tap the Share icon in Safari
  2. Scroll the menu and tap Add to Home Screen.
  3. Tap Add in the top-right corner.
To install this app on Android
  1. Tap the 3-dot menu (⋮) in the top-right corner of the browser.
  2. Tap Add to Home screen or Install app.
  3. Confirm by tapping Install.

Featured Replies

Posted

Hi!
I was making a custom ambulance, and when i press the key "b", it should play the siren sound effect, but it doesn't.
Can someone help?

This is Where i Call the Sound:

public class AmbulanceEntity extends VehicleEntity {

    private boolean sirenActivate;

    public AmbulanceEntity(EntityType<? extends AmbulanceEntity> type, World worldIn) {
        super(type, worldIn);
        this.setMaxSpeed(20F);
        this.sirenActivate = false;
    }

    public boolean isSirenOn() {
        return this.sirenActivate;
    }

    public void updateSiren() {
        this.sirenActivate = !this.sirenActivate;
        if (this.sirenActivate) {
            AmbulanceSirenSound sound = new AmbulanceSirenSound(this);
            System.out.println("Add Sound");
            Minecraft.getInstance().getSoundHandler().play(sound);
        }
        PacketHandler.instance.sendToServer(new MessageAmbulanceSirenChange(this.sirenActivate));
    }

    public void setSirenActivate(boolean sirenActivate) {
        this.sirenActivate = sirenActivate;
    }
}

The Ambulance Sound Class:

public class AmbulanceSirenSound extends TickableSound {

    private AmbulanceEntity refEntity;

    public AmbulanceSirenSound(AmbulanceEntity entity) {
        super(ModSounds.AMBULANCE_SIREN.get(), SoundCategory.MUSIC);
        this.refEntity = entity;
        this.repeat = true;
        this.repeatDelay = 0;
        this.volume = 0.8F;
        this.pitch = 0.85F;
    }

    @Override
    public void tick() {
        if (this.refEntity == null || Minecraft.getInstance().player == null) {
            this.func_239509_o_();
            return;
        }
        if (refEntity.isSirenOn() && this.refEntity.getPassengers().size() > 0) {
            PlayerEntity localPlayer = Minecraft.getInstance().player;
            this.x = (float) (this.refEntity.getPosX() + (localPlayer.getPosX() - this.refEntity.getPosX()) * 0.65);
            this.y = (float) (this.refEntity.getPosY() + (localPlayer.getPosY() - this.refEntity.getPosY()) * 0.65);
            this.z = (float) (this.refEntity.getPosZ() + (localPlayer.getPosZ() - this.refEntity.getPosZ()) * 0.65);
            System.out.println("Sound Tick");
        } else {
            //refEntity.sirenOff();
            this.func_239509_o_();
        }
    }
}


 

  • Author

dove dovrei riprodurre il suono? e come?

I call the update Siren here, in my Client Event Handler:

@SubscribeEvent
    public void onKeyInput(InputEvent.KeyInputEvent event) {
        if (Minecraft.getInstance().player == null)
            return;

        if (ClientProxy.KEY_CYCLE_SEATS.isPressed() && event.getAction() == GLFW.GLFW_PRESS) {
            if (Minecraft.getInstance().player.getRidingEntity() instanceof VehicleEntity) {
                PacketHandler.instance.sendToServer(new MessageCycleSeats());
            }
        }

        if (ClientProxy.KEY_AMBULANCE_SIREN.isPressed() && event.getAction() == GLFW.GLFW_PRESS) {
            Entity entity = Minecraft.getInstance().player.getRidingEntity();
            if (entity instanceof AmbulanceEntity) {
                ((AmbulanceEntity) entity).updateSiren();
            }
        }
    }

 

  • Author

There are no errors, the sound is loaded correctly.
Now i try to use ClientTickEvent and see if something changes

  • Author

Ok, thanks for the help but I found the error.

It's a stupid one..

I continually send messages to the server to update the sound, then it keeps turning on / off. I changed some lines of code and now I can reproduce the sound correctly.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

Important Information

By using this site, you agree to our Terms of Use.

Configure browser push notifications

Chrome (Android)
  1. Tap the lock icon next to the address bar.
  2. Tap Permissions → Notifications.
  3. Adjust your preference.
Chrome (Desktop)
  1. Click the padlock icon in the address bar.
  2. Select Site settings.
  3. Find Notifications and adjust your preference.