Jump to content

Recommended Posts

Posted

Hello forum people.

 

This is my first post, I still use minecraft release 1.5.2, just to be safe when modding, and I'm not that good at Java (I don't like to type that much) and I noticed that for registering textures for items or blocks to be able to be rendered in game, you need to override a method. That's not what minecraft itself does most of the time. Just a few blocks/items have their own classes but just because they have unique logic or they have to override other methods.

 

So there's really no way around this? deriving from a base class for each and every block/item I define in mod, even if it's just a dumb block with a different texture, is the only possible way to have a block/item rendered in game?

Posted

wow... that's a shame. Minecraft seems to locate their textures by block/item unlocalizedName property and then just add ".png" to the end. Sad this is a problem people encounter so early. By the time they've mastered enough skills to solve it more elegantly than by inheritance, I think they just got used to it (i mean the forge developers and the rest of the community).

 

And there's also the strange requirement java has that every class must be define in it's own file... create 50 blocks/items and you have 50 files just for that, plus all the rest of your mod. Really a shame.

 

Edit: after reading your editing on your second post: I really don't think that's it. Although I don't think it would be worthless learning what that particular member does, if you can.

Posted

Unless you declare your Item classes like this:

 

pacakge mypackage.item;

import net.minecraft.item.Item;

public class MyItemClasses {

    public static class ItemMyFirstItem extends Item {

        public ItemMyFirstItem(int par1) {
            super(par1);
        }
    };

    public static class ItemMySecondItem extends Item {

        public ItemMySecondItem(int par1) {
            super(par1);
        }
    };
    // etc., etc., etc..
}

 

Then it's your all your items in one file technically xD

I am Mew. The Legendary Psychic. I behave oddly and am always playing practical jokes.

 

I have also found that I really love making extremely long and extremely but sometimes not so descriptive variables. Sort of like what I just did there xD

Posted

You  can actually create items and blocks like that:

public static final Item itemOfYours = new Item(800);
public static final Block blockOfYours = new Block(503, Material.iron).setHardness(1.0F).setResistance(3F);

Check Block and Item classes to see details.

If i helped you, don't forget pressing "Thank You" button. Thanks for your time.

Posted

@Mew Yes I could... Still a lot of work compared to net.minecraft.item.Item class, have you seen it?

 

(and in a side note, I'm not sure java inner classes can be declared static, but I may be wrong)

 

edit: added @Mew at the begining of the post because it wasn't clear who I was talking to.

Posted

@Naitenne yes, that would be really great. That's exactly what I wanted to do. But if I do it like that, it seems I have no way to render my blocks/items textures, because forge needs me to override some method to be able to find my textures. And that's only possible by inheritance

 

edit: to make it clearer, I CAN define blocks and items like that. But they won't be properly shown in game. they will appear as a cube (for blocks) or a little square thingy like a white tablet. Both with the words "texture not found" (or something like that) written all over them. So unless there's a way around this, people have to derive from either block or item to be able to override that special method forge needs to find my textures.

 

Posted

Try messing with .setUnlozalizedName("yourMod:textureName") place it like .setResistance(3F). The texture should be located as MCP/src/mods/yourMod/textures/items/textureName.png for items and MCP/src/mods/yourMod/textures/blocks/textureName.png for blocks;

If i helped you, don't forget pressing "Thank You" button. Thanks for your time.

Posted

Try messing with .setUnlozalizedName("yourMod:textureName") place it like .setResistance(3F). The texture should be located as MCP/src/mods/yourMod/textures/items/textureName.png for items and MCP/src/mods/yourMod/textures/blocks/textureName.png for blocks;

Have you tested that and had it work?

 

Because to my knowledge that is the reference to the VANILLA textures folder.

I am Mew. The Legendary Psychic. I behave oddly and am always playing practical jokes.

 

I have also found that I really love making extremely long and extremely but sometimes not so descriptive variables. Sort of like what I just did there xD

Posted

I hope it works for you in 1.6.*. Because if it doesn't, your screwed. And I am glad it works. I know that they said that it points there, but I also did say TO MY KNOWLEDGE, basically according to what I knew it pointed to the vanilla textures, not ones in a mod file. Now I have been proven wrong it seems I can update my knowledge :P

I am Mew. The Legendary Psychic. I behave oddly and am always playing practical jokes.

 

I have also found that I really love making extremely long and extremely but sometimes not so descriptive variables. Sort of like what I just did there xD

Posted

Mew, how can mods/yourMod/ point at vanilla textures?

 

And once again people aren't reading what I have said correctly...

 

What I was referring to was .setUnlocalizedName(). Before proven otherwise I thought it to be pointing to the Vanilla texture path. That is what I was meaning.

 

 

And as a side note, VERY NICE mod. Good ole' trains. Awesome :D

 

well the forge build for 1.6 may not be the recommended one for a while... but I sure hope it works for 1.6 or I'll start to think Mojang is sabotaging us modders >.<

 

Don't bother waiting for a recommended build of 1.6.1, there will NEVER be one. There is a recommended build for minecraft 1.6.2 though xD

I am Mew. The Legendary Psychic. I behave oddly and am always playing practical jokes.

 

I have also found that I really love making extremely long and extremely but sometimes not so descriptive variables. Sort of like what I just did there xD

Posted

.setUnlocalizedName

is for setting the name of your block that goes through the localization files so it can be displayed in the users current language (if provided)

 

for Blocks the function you want is .func_111022_d("yourMod:textureName")

by using it you set field_111026_f

 

registerIcons gets the icon from func_111023_E which in turn reads it from field_111026_f (the one you set)

 

 

Items go through a similar path but you use .func_111206_d("yourMod:textureName")

Posted

.setUnlocalizedName

is for setting the name of your block that goes through the localization files so it can be displayed in the users current language (if provided)

 

for Blocks the function you want is .func_111022_d("yourMod:textureName")

by using it you set field_111026_f

 

registerIcons gets the icon from func_111023_E which in turn reads it from field_111026_f (the one you set)

 

 

Items go through a similar path but you use .func_111206_d("yourMod:textureName")

 

But is that 1.5.2? I don't think so. The OP was asking about this in relation to 1.5.2, but yes this is still relevant when it comes to moving to 1.6.*.

I am Mew. The Legendary Psychic. I behave oddly and am always playing practical jokes.

 

I have also found that I really love making extremely long and extremely but sometimes not so descriptive variables. Sort of like what I just did there xD

Posted

;D I missed the 1.5.2 part, noticed the suggestion of using setUnlocalizedName for textures and thought, oh no thats going to cause problems in the future.

 

There has already been several people who have ignored the new functions due to the names, just figured it was happening again :)

Posted

well, let's hope the deobfuscator get's a little better then, before I migrate to 1.6... I don't think func_111022_d is human readable. Not so hot for the par1, par2, ..., par999 either, but that seems to be inevitable. But actual methods and fields named as numbers is far beyond my will to mod minecraft.

Posted

Huh, I deleted my post because I felt as if I was making a fool of myself, now I really feel like a food, anyways. Well atleast I know how to use that function now, good luck to you.

Posted
That's not what minecraft itself does most of the time. Just a few blocks/items have their own classes but just because they have unique logic or they have to override other methods.

 

Actually all of Minecraft's blocks have their own class.  Some have overlaps (e.g. colored wool, stairs) some are split when they don't seem like they would need to be (redstone torches,* redstone lamps**).

 

But you're right, a lot of methods that vanilla doesn't override with their block classes ARE overriden by mod classes.

 

Icon registration is one of these, because mod textures are in a different location than vanilla textures.

 

*Two block IDs, same block class file

**Two actually different classes, if I recall correctly.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • It is 1.12.2 - I have no idea if there is a 1.12 pack
    • Okay, but does the modpack works with 1.12 or just with 1.12.2, because I need the Forge client specifically for Minecraft 1.12, not 1.12.2
    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.