Jump to content

Recommended Posts

Posted

Hi, I was trying to add a piranha entity in the game. Very similar to Cod, and when testing it out, I realised that I was getting a NullPointerException. I guess that I'm forgetting something important like a function thats required or such, so I'm reaching out to see if someone can point me in the right direction.

Piranha Entity class:

Spoiler

public class PiranhaEntity extends AbstractGroupFishEntity {
    public PiranhaEntity(EntityType<? extends PiranhaEntity> p_i49856_1_, World p_i49856_2_) {
        super(p_i49856_1_, p_i49856_2_);
    }

    @Override
    protected ItemStack getBucketItemStack() {
        return new ItemStack(ItemsInit.PIRANHA_BUCKET.get());
    }

    @Override
    protected SoundEvent getAmbientSound() {
        return SoundEvents.COD_AMBIENT;
    }

    @Override
    protected SoundEvent getDeathSound() {
        return SoundEvents.COD_DEATH;
    }

    @Override
    protected SoundEvent getHurtSound(DamageSource p_184601_1_) {
        return SoundEvents.COD_HURT;
    }

    @Override
    protected SoundEvent getFlopSound() {
        return SoundEvents.COD_FLOP;
    }

    @Override
    public int getMaxSchoolSize() {
        return 3;
    }

    @Override
    protected void registerGoals() {
        super.registerGoals();
    }

    @Override
    public void tick() {
        super.tick();
    }

 

Registering the Entity:

Spoiler

public static final DeferredRegister<EntityType<?>> ENTITIES = DeferredRegister.create(ForgeRegistries.ENTITIES, OceansCompound.MOD_ID);

    public static final RegistryObject<EntityType<PiranhaEntity>> PIRANHA = ENTITIES.register("piranha", () ->
            EntityType.Builder.of(PiranhaEntity::new, EntityClassification.MONSTER)
                    .sized(EntityType.COD.getWidth(), EntityType.COD.getHeight())
            .build(new ResourceLocation(OceansCompound.MOD_ID, "piranha").toString())
    );

    @Mod.EventBusSubscriber(modid = OceansCompound.MOD_ID, bus = Mod.EventBusSubscriber.Bus.MOD)
    public static class EntityHandler {
        @SubscribeEvent
        public void entityAddAttributes(final EntityAttributeCreationEvent event) {
            event.put(PIRANHA.get(), PiranhaEntity.createAttributes()
                    .add(Attributes.MAX_HEALTH, 5).build());
        }
    }

 

Piranha Rendering:

Spoiler

private static final ResourceLocation PIRANHA_LOCATION = new ResourceLocation(OceansCompound.MOD_ID, "textures/entity/fish/piranha.png");

    public PiranhaRenderer(EntityRendererManager p_i48864_1_) {
        super(p_i48864_1_, new PiranhaModel<>(), 0.3F);
    }

    @Override
    public ResourceLocation getTextureLocation(PiranhaEntity p_110775_1_) {
        return PIRANHA_LOCATION;
    }

    protected void setupRotations(PiranhaEntity p_225621_1_, MatrixStack p_225621_2_, float p_225621_3_, float p_225621_4_, float p_225621_5_) {
        super.setupRotations(p_225621_1_, p_225621_2_, p_225621_3_, p_225621_4_, p_225621_5_);
        float f = 4.3F * MathHelper.sin(0.6F * p_225621_3_);
        p_225621_2_.mulPose(Vector3f.YP.rotationDegrees(f));
        if (!p_225621_1_.isInWater()) {
            p_225621_2_.translate(0.1F, 0.1F, -0.1F);
            p_225621_2_.mulPose(Vector3f.ZP.rotationDegrees(90.0F));
        }

    }

 

Finally, Piranha Model:

Spoiler

private final ModelRenderer head;
    private final ModelRenderer body;

    public PiranhaModel() {
        texWidth = 64;
        texHeight = 64;

        head = new ModelRenderer(this);
        head.setPos(0.0F, 24.0F, 0.0F);
        head.setTexSize(0, 9).addBox(-3.0F, -2.0F, -7.0F, 7.0F, 2.0F, 7.0F, 0.0F, false);
        head.setTexSize(0, 18).addBox(-2.0F, -8.0F, -6.0F, 5.0F, 6.0F, 6.0F, 0.0F, false);
        head.setTexSize(0, 0).addBox(-3.0F, -4.0F, -7.0F, 7.0F, 2.0F, 7.0F, 0.0F, false);

        body = new ModelRenderer(this);
        body.setPos(0.0F, 24.0F, 0.0F);
        body.setTexSize(22, 18).addBox(-2.0F, -7.0F, 0.0F, 5.0F, 6.0F, 3.0F, 0.0F, false);
        body.setTexSize(24, 5).addBox(-1.0F, -6.1F, 2.0F, 3.0F, 5.0F, 4.0F, 0.0F, false);
        body.setTexSize(8, 30).addBox(0.0F, -5.0F, 5.0F, 1.0F, 4.0F, 3.0F, 0.0F, false);
        body.setTexSize(0, 26).addBox(0.6F, -7.0F, 8.0F, 0.0F, 7.0F, 4.0F, 0.0F, false);

        ModelRenderer backfin_r1 = new ModelRenderer(this);
        backfin_r1.setPos(0.6F, -9.5F, 4.5F);
        body.addChild(backfin_r1);
        setRotationAngle(backfin_r1, 1.5708F, 0.0F, 0.0F);
        backfin_r1.setTexSize(22, 23).addBox(0.0F, -4.5F, -4.5F, 0.0F, 7.0F, 4.0F, 0.0F, false);

        ModelRenderer fin_r1 = new ModelRenderer(this);
        fin_r1.setPos(3.6616F, -4.303F, 4.4246F);
        body.addChild(fin_r1);
        setRotationAngle(fin_r1, -0.6109F, 0.0F, 1.0472F);
        fin_r1.setTexSize(21, 0).addBox(-3.1F, -0.4F, -3.1F, 3.0F, 4.0F, 1.0F, 0.0F, false);

        ModelRenderer fin_r2 = new ModelRenderer(this);
        fin_r2.setPos(-3.6616F, -4.303F, 4.4246F);
        body.addChild(fin_r2);
        setRotationAngle(fin_r2, -0.6109F, 0.0F, -1.0472F);
        fin_r2.setTexSize(29, 0).addBox(0.5F, 0.3F, -2.7F, 3.0F, 4.0F, 1.0F, 0.0F, false);
    }

    @Override
    public void setupAnim(Entity entity, float limbSwing, float limbSwingAmount, float ageInTicks, float netHeadYaw, float headPitch){
        //previously the render function, render code was moved to a method below
    }

    @Override
    public void renderToBuffer(MatrixStack matrixStack, IVertexBuilder buffer, int packedLight, int packedOverlay, float red, float green, float blue, float alpha){
        head.render(matrixStack, buffer, packedLight, packedOverlay);
        body.render(matrixStack, buffer, packedLight, packedOverlay);
    }

    @Override
    public Iterable<ModelRenderer> parts() {
        return ImmutableList.of(this.head, this.body);
    }

    public void setRotationAngle(ModelRenderer modelRenderer, float x, float y, float z) {
        modelRenderer.xRot = x;
        modelRenderer.yRot = y;
        modelRenderer.zRot = z;
    }

 

Any help in the right direction is appreciated, thanks.

Have some lorem ispum.

Posted

You have to assign your entity attributes, there's a EntityAttributeCreationEvent or something named similar in the latest version. In older versions you can register them in GlobalEntityTypeAttributes through common setup event.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • logs too big for one pastebin https://pastebin.com/ZjUGHu3u  https://pastebin.com/RqCUZf3X  https://pastebin.com/6ZPS99nD
    • You probably used jd-gui to open it, didn't you? Nothing wrong with that, I also made that mistake, except that Notch was a smart guy and he obfuscated the code. That's why you only see files called "a", "b", "c" and then a file that combines them all. As I said, use RetroMCP to deobfuscate the code so that you will 100% understand it and be able to navigate it.
    • Decompiling minecraft indev, infdev, alpha, beta or whichever legacy version is really easy. I'm not a plug, I just also got interested in modding legacy versions (Infdev to be specific). Use https://github.com/MCPHackers/RetroMCP-Java Once you install their client and the Zulu Architecture that they say they recommend (or use your own Java). I encountered some problems, so I run it with: "java -jar RetroMCP-Java-CLI.jar". You should run it in a seperate folder (not in downloads), otherwise the files and folders will go all over the place. How to use RetroMCP: Type setup (every time you want change version), copy-paste the version number from their list (they support indev), write "decompile" and done! The code will now be deobfuscated and filenames will be normal, instead of "a", "b" and "c"! Hope I helped you, but I don't expect you to reply, as this discussion is 9 years old! What a piece of history!  
    • I know that this may be a basic question, but I am very new to modding. I am trying to have it so that I can create modified Vanilla loot tables that use a custom enchantment as a condition (i.e. enchantment present = item). However, I am having trouble trying to implement this; the LootItemRandomChanceWithEnchantedBonusCondition constructor needs a Holder<Enchantment> and I am unable to use the getOrThrow() method on the custom enchantment declared in my mod's enchantments class. Here is what I have so far in the GLM:   protected void start(HolderLookup.Provider registries) { HolderLookup.RegistryLookup<Enchantment> registrylookup = registries.lookupOrThrow(Registries.ENCHANTMENT); LootItemRandomChanceWithEnchantedBonusCondition lootItemRandomChanceWithEnchantedBonusCondition = new LootItemRandomChanceWithEnchantedBonusCondition(0.0f, LevelBasedValue.perLevel(0.07f), registrylookup.getOrThrow(*enchantment here*)); this.add("nebu_from_deepslate", new AddItemModifier(new LootItemCondition[]{ LootItemBlockStatePropertyCondition.hasBlockStateProperties(Blocks.DEEPSLATE).build(), LootItemRandomChanceCondition.randomChance(0.25f).build(), lootItemRandomChanceWithEnchantedBonusCondition }, OrichalcumItems.NEBU.get())); }   Inserting Enchantments.[vanilla enchantment here] actually works but trying to declare an enchantment from my custom enchantments class as [mod enchantment class].[custom enchantment] does not work even though they are both a ResourceKey and are registered in Registries.ENCHANTMENT. Basically, how would I go about making it so that a custom enchantment declared as a ResourceKey<Enchantment> of value ResourceKey.create(Registries.ENCHANTMENT, ResourceLocation.fromNamespaceAndPath([modid], [name])), declared in a seperate enchantments class, can be used in the LootItemRandomChanceWithEnchantedBonusCondition constructor as a Holder? I can't use getOrThrow() because there is no level or block entity/entity in the start() method and it is running as datagen. It's driving me nuts.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.