[1.16.5] Make Mod Data Editable with Datapack (adding new data type)?

[JayZX535]

Hey all,

I'm attempting to figure out how to make some functions of my mod editable via datapacks, in much the same way as recipes, advancements, etc. can be edited.  I'd love to see examples of how others have done this, since I'm struggling to figure out how it's even set up in the first place.  I know Origins makes use of custom datapacks to edit powers, but it runs on Fabric, not Forge, so not as helpful for figuring out how to do it on Forge specifically.

I also need to make sure that datapacks are able to append their data to each existing entry instead of just overwriting it.

If anyone has or knows of examples of this I'd love to see them, I'm having a hard time actually tracking anything down to look at since I end up just getting results for actual datapacks, oops.

Thank you for your time, and have a great day!

 

EDIT: Just to specify, I'm talking about adding new types of data, not just using existing ones.  I know how to add stuff like item tags, recipes, etc.  I want to add a new type of data that can be edited through a datapack in the same sort of way-- like what Origins does to allow for the adding of new powers and such.  I just don't know how to do that in Forge.  Sorry for the initial confusion.

Edited May 25, 2021 by JayZX535
Clarifying

[Draco18s]

Your mod is a data pack. Your data files go in src/main/resources/data/<modID>

https://github.com/Draco18s/ReasonableRealism/tree/1.14.4/src/main/resources/data

Any datapack can place overrides in the same modID directory and Forge will override as expected.

[JayZX535]

Yes, I've worked with the existing types of data such as tags, recipes, etc. before.  What I'm having difficulty with is trying to create a new type of data.  Like what Origins has done to allow the adding/modifying of alternative origins and powers, a feature that is added by the mod itself and not part of Vanilla minecraft like tags, recipes, advancements, etc.  That's where I'm having trouble.

[JayZX535]

Oh thank you!  That looks like what I was trying to figure out, and it looks like I've got it loading now!

[JayZX535]

Well, I got it almost figured out.  For some reason it seems to only be loading on the client?  Which is odd, because my research is indicating that the AddReloadListenerEvent is supposed to be serverside?  I'm registering it as the following.  Fairly stumped...

@EventBusSubscriber(modid = Mod.MODID, bus = EventBusSubscriber.Bus.FORGE)
public class ReloadListener {
    @SubscribeEvent
	public static void addReloadListenerEvent(AddReloadListenerEvent event) {
		event.addListener(Mod.getDataThing());
		Mod.getLogger().info("ReloadListener registered.");
	}
}

The only thread that log seems to get called on is the render one.  Running it on a server never outputs that log at all.  I can correctly output the data I'm getting from the json into the logs on the client side, but the server doesn't seem to have access to it.  Is extending JsonReloadListener supposed to be able to work with serverside resources?

[JayZX535]

Ohhhh hmmm, that may be what's causing the problem.  I'm trying to use this info in the BiomeLoadingEvent, but it looks like the first time it runs, the data hasn't been updated.  If I reload worlds the data applies properly, but the first time it runs the data hasn't been set yet, so it ignores it and carries on as usual.  I'm guessing that means I have to check and see if the data needs updating at the start of that event, and then make sure I have it update data if it does?  Unless this event just runs before the data is even accessible, in which case what I'm trying to do might just not be possible.  Either that, or I need to reload the biomes themselves once the data is updated, but I'm guessing the prior option may be the better one.

 

How could I go about reloading the resources if I detect they haven't been generated for the BiomeLoadingEvent?  Or is that not going to be a safe thing to do?

[JayZX535]

Here it is.

https://github.com/JayZX535/mcbiomespawner

(this is set up to clear all entity spawns in the savanna and replace them with wolves and cats.  whenever it detects a spawn has been modified, it will clear all existing spawns to ensure easy visibility.)

What it's doing that has me stumped is when you first create a world, the spawns aren't modified.  When you quit to menu and reload it, the spawns aren't modified.  But when you relaunch the game entirely and then load the world, then the new spawns take effect.

I'm still new to the way 1.16 works and I haven't worked too much with data until now, so maybe there's something I'm misunderstanding...

[JayZX535]

Argh.  Not used to github, hopefully this version works...

https://github.com/JayZX535/mcbiomespawner

 

Also, it definitely seems to me that the issue is that the datapack loads after the event runs.  I ran a dedicated server and looked at the logs, and I can see my debug statements from the BiomeLoadingEvent running before the ones that get the information from the datapack.  I'm just not certain how to solve that problem, unfortunately...

Edited May 27, 2021 by JayZX535
Adding info

[JayZX535]

Dang, still didn't upload right.  Sorry

Eesh, that's unfortunate.  I'll have to poke around with it some more, but it may just not be doable.  Is there a way to manually trigger the reload event?  The one idea in my head currently is to have a boolean to see if the files have been updated, and if not, manually trigger the reload the first time it tries to run the biome event.  But that sounds like it could be a bit dodgy so I'm not sure if that'd work...

Thank you for your help nonetheless.

Edited May 27, 2021 by JayZX535