[1.16.4] How do you register a custom minecart entity?

[than00ber1]

I am trying to register a simple minecart entity but it does not seem to appear in-game. No errors are thrown either.

 

Here is my Minecart entity class:

public class MinerCartEntity extends AbstractMinecartEntity {

    public MinerCartEntity(EntityType<?> type, World worldIn) {
        super(type, worldIn);
    }

    @Override
    public Type getMinecartType() {
        return Type.CHEST;
    }
}

 

Here is how I register it,

public class AllEntities {

    public static final DeferredRegister<EntityType<?>> ENTITIES = DeferredRegister.create(ForgeRegistries.ENTITIES, MODID);

    private static <T extends EntityType<?>> RegistryObject<EntityType<?>> register(String name, Supplier<T> entity) {
        System.out.println("REGISTERING MOD ENTITY: " + name);
        return ENTITIES.register(name, entity);
    }

    public static final RegistryObject<EntityType<?>> MINER_MINECART = register("miner_minecart",
            () -> EntityType.Builder.<AbstractMinecartEntity>create(MinerCartEntity::new, EntityClassification.MISC)
            .size(0.98F, 0.7F).trackingRange(8)
            .build(new ResourceLocation(MODID, "miner_minecart").toString()));
}

and in the main file simply:

        IEventBus fmlContext = FMLJavaModLoadingContext.get().getModEventBus();
        AllBlocks.BLOCKS.register(fmlContext);
        AllTileEntities.TILE_ENTITIES.register(fmlContext);
        AllItems.ITEMS.register(fmlContext);
        AllEntities.ENTITIES.register(fmlContext);	// <------ over here

 

My first guess was to follow the same way to register entities as blocks or items while using the entity builder shown in Minecraft's source code.

Any guess as to why it does not load in-game or not throwing errors? Is this even the right way?

[vemerion]

  On 5/30/2021 at 8:40 PM, than00ber1 said:

I am trying to register a simple minecart entity but it does not seem to appear in-game. No errors are thrown either.

Expand  

You need to override createSpawnPacket() (called getAddEntityPacket() in the official mappings) and return this:

NetworkHooks.getEntitySpawningPacket(this)

 

[than00ber1]

Where would I call this? 

NetworkHooks.getEntitySpawningPacket(this)

In the constructor of the minecart class?

[Luis_ST]

  On 5/31/2021 at 9:15 AM, than00ber1 said:

here would I call this? 

In the constructor of the minecart class?

Expand  

@vemerion has already told you what you have to do

  On 5/31/2021 at 6:08 AM, vemerion said:

You need to override createSpawnPacket() (called getAddEntityPacket() in the official mappings) and return this:

Expand  

 

 

Edited May 31, 2021 by Luis_ST

[than00ber1]

Ah I managed to do this. The problem was really dumb, I didn't register the actual item itself.

 

For any in the future that want to know how to it, this how I did it:

Create the item:

public class MinerCartItem extends MinecartItem {

    public MinerCartItem() {
        super(AbstractMinecartEntity.Type.RIDEABLE, (new Item.Properties()).maxStackSize(1).group(ItemGroup.FOOD));
    }
}

and then register it the same way you would do for other registries:

    public static final RegistryObject<Item> MINER_ITEM = ITEMS.register("miner_item", MinerCartItem::new);