[1.16.5] [SOLVED] Block NBT being modified every other tick

[NoEffort]

Long time no see,

I've got this block that I want to update on a button press in it's respective screen. The block data does technically update, but it seems to switch back to it's default values every other tick (or at least, that's what it seems like visibly). Have a look:

Related Code: https://gist.github.com/NoEffort/5cd66d7d5c8165338b9ae89c6036f3c3
The Bug:

Spoiler

 

Edited June 3, 2021 by NoEffort
Problem Resolved

[Draco18s]

There's nothing wrong with your block class.

The reason you're seeing the difference is because there's two threads: the server thread and the client thread. Notice at the left how it says "Server thread" and the next line "Render thread"? You have a synchronization problem.

[NoEffort]

5 minutes ago, Draco18s said:

There's nothing wrong with your block class.

The reason you're seeing the difference is because there's two threads: the server thread and the client thread. Notice at the left how it says "Server thread" and the next line "Render thread"? You have a synchronization problem.

So what you're saying is my Client is correct, but the server is not? The docs lead me to believe I've done everything I should be doing, but it seems like that isn't the case. How can I go about syncing the data correctly?

[Draco18s]

Seeing as that logging isn't coming from the block, I can't say. You only shared your block code and the problem isn't in your block code.

[NoEffort]

@Draco18s You got it boss: https://github.com/NoEffort/NuggetMod/tree/main

[NoEffort]

6 hours ago, diesieben07 said:

https://mcforge.readthedocs.io/en/latest/tileentities/tileentity/#synchronizing-the-data-to-the-client

I do a combination of these to achieve the same result (on paper, I suppose).

WeatherPedestalTileEntity.java (Snippet):

Spoiler

    @Nonnull
    @Override
    public CompoundNBT save(@Nonnull CompoundNBT nbt) {
        nbt = super.save(nbt);
        nbt.putBoolean("WeatherRain", this.raining);
        nbt.putBoolean("WeatherThunder", this.thundering);
        nbt.putBoolean("WeatherClear", this.clear);
        return nbt;
    }

    @Override
    public void load(@Nonnull BlockState state, @Nonnull CompoundNBT nbt) {
        super.load(state, nbt);
        this.raining = nbt.getBoolean("WeatherRain");
        this.thundering = nbt.getBoolean("WeatherThunder");
        this.clear = nbt.getBoolean("WeatherClear");
    }

    @Nullable
    @Override
    public SUpdateTileEntityPacket getUpdatePacket() {
        return new SUpdateTileEntityPacket(this.getBlockPos(), 1, this.getUpdateTag());
    }

    @Nonnull
    @Override
    public CompoundNBT getUpdateTag() {
        return this.save(new CompoundNBT());
    }

    @Override
    public void handleUpdateTag(BlockState state, CompoundNBT tag) {
        this.load(state, tag);
    }

    @Override
    public void onDataPacket(NetworkManager net, SUpdateTileEntityPacket pkt) {
        this.handleUpdateTag(this.getBlockState(), pkt.getTag());
    }

 

 

[Draco18s]

Ah yes. I wondered if this was the case.

You're trying to change the weather using a GUI screen.

https://github.com/NoEffort/NuggetMod/blob/main/src/main/java/me/noeffort/nuggetmod/client/screen/WeatherPedestalScreen.java#L82

That code cannot and will not ever work because only the client knows about it.

Edited June 3, 2021 by Draco18s

[NoEffort]

12 minutes ago, Draco18s said:

That code cannot and will not ever work because only the client knows about it.

How can I resolve this? Network messages? Maybe my design is wrong and I should be using another method?
EDIT: Method, as in plan of attack not functional Java method

Edited June 3, 2021 by NoEffort
Clarification

[NoEffort]

Thanks for all the help guys, praise be the internet!

If you're curious, I created a new message & registered it. Here's the handler for said message:

    public static void handle(WeatherPedestalUpdateMessage message, Supplier<NetworkEvent.Context> context) {
        NetworkEvent.Context ctx = context.get();
        ctx.enqueueWork(() -> {
            ServerPlayerEntity player = ctx.getSender();
            TileEntity tile = player.level.getBlockEntity(message.pos);
            if(tile == null || !player.level.isLoaded(message.pos) || !(tile instanceof WeatherPedestalTileEntity))
                return;
            WeatherPedestalTileEntity pedestal = (WeatherPedestalTileEntity) tile;
            pedestal.setRaining(message.rain);
            pedestal.setThundering(message.thunder);
            pedestal.setClear(message.clear);
            player.level.sendBlockUpdated(message.pos, pedestal.getBlockState(), pedestal.getBlockState(), Constants.BlockFlags.BLOCK_UPDATE);
        });
        ctx.setPacketHandled(true);
    }

I also removed half of my update() method in WeatherPedestalScreen, and replaced it with this single line:

NuggetMod.CHANNEL.sendToServer(new WeatherPedestalUpdateMessage(this.pos, rain, thunder, clear));

 

[NoEffort]

22 minutes ago, diesieben07 said:

Do not send the position. The server knows this position by the container the playing is looking at. By sending the position again and blindly trusting it, you allow the client to modify any TE.

Noted and resolved.