Jump to content

[1.16.5] Entity loot modifier triggering for blocks


Daedalus4096

Recommended Posts

I'm trying out using global loot modifiers to modify the loot tables of some vanilla entities for my mod.  At first I thought I had it working fine: my custom item dropped for entities in the specified tag and didn't drop for entities outside of it.  Great.  The next day, though, while doing some testing in survival mode, I broke an oak log... and my custom item dropped for that too.  And then again for stone, granite, and coal ore.  Not great.

Can anyone tell me what I'm doing wrong?  Why my loot modifier, with conditions that seem to imply that it should only drop for certain entity types, is also triggering for every block under the sun?  I haven't found anything that derives from ILootCondition with a name that suggests it differentiates between blocks and entities, so I'm feeling stuck.

Here's the code for the loot modifier object:

package com.verdantartifice.primalmagic.common.loot.modifiers;

import java.util.ArrayList;
import java.util.List;

import com.google.gson.JsonObject;
import com.verdantartifice.primalmagic.common.items.ItemsPM;
import com.verdantartifice.primalmagic.common.util.ItemUtils;

import net.minecraft.item.ItemStack;
import net.minecraft.loot.ConstantRange;
import net.minecraft.loot.ItemLootEntry;
import net.minecraft.loot.LootContext;
import net.minecraft.loot.LootPool;
import net.minecraft.loot.LootTable;
import net.minecraft.loot.RandomValueRange;
import net.minecraft.loot.conditions.ILootCondition;
import net.minecraft.loot.functions.LootingEnchantBonus;
import net.minecraft.loot.functions.SetCount;
import net.minecraft.util.ResourceLocation;
import net.minecraftforge.common.loot.GlobalLootModifierSerializer;
import net.minecraftforge.common.loot.LootModifier;

/**
 * Global loot modifier that allows mobs in the conditioned tag to drop Bloody Flesh when killed.
 * 
 * @author Daedalus4096
 */
public class BloodyFleshModifier extends LootModifier {
    public BloodyFleshModifier(ILootCondition[] conditionsIn) {
        super(conditionsIn);
    }

    @SuppressWarnings("deprecation")
    @Override
    protected List<ItemStack> doApply(List<ItemStack> generatedLoot, LootContext context) {
        LootTable table = LootTable.builder().addLootPool(LootPool.builder().rolls(ConstantRange.of(1)).addEntry(ItemLootEntry.builder(ItemsPM.BLOODY_FLESH.get()).acceptFunction(SetCount.builder(RandomValueRange.of(0.0F, 1.0F))).acceptFunction(LootingEnchantBonus.builder(RandomValueRange.of(0.0F, 1.0F))))).build();
        List<ItemStack> lootList = new ArrayList<>();
        table.generate(context, lootList::add); // Use deprecated version to avoid calling modifyLoot and prevent infinite recursion
        return ItemUtils.mergeItemStackLists(generatedLoot, lootList);
    }

    public static class Serializer extends GlobalLootModifierSerializer<BloodyFleshModifier> {
        @Override
        public BloodyFleshModifier read(ResourceLocation location, JsonObject object, ILootCondition[] ailootcondition) {
            return new BloodyFleshModifier(ailootcondition);
        }

        @Override
        public JsonObject write(BloodyFleshModifier instance) {
            return this.makeConditions(instance.conditions);
        }
    }
}

And here's the JSON file for the modifier:

{
  "conditions": [
    {
      "condition": "minecraft:entity_properties",
      "predicate": {
        "type": "#primalmagic:drops_bloody_flesh"
      },
      "entity": "this"
    }
  ],
  "type": "primalmagic:bloody_flesh"
}

The GitHub repository can be found here if you need to look at anything else.  Thank you for your time.

Link to comment
Share on other sites

3 hours ago, Daedalus4096 said:

Can anyone tell me what I'm doing wrong?

When you are breaking a block, the "this" entity in the condition is the player, and since the primalmagic:drops_bloody_flesh tag contains the player, the condition is met. You would have to add another condition that checks that an entity was actually killed.

  • Thanks 1
Link to comment
Share on other sites

Also why are you building a new loot table every time?

Either:

a) build the loot table once and store it in a field
b) don't use a loot table at all and just go "derp, I can ask for a random integer from 0 to 1 and if 1 add a new item stack to the generated loot list." Because the loot table you're building is overkill for what you need.
c) put that loot table stuff in the loot table json file and deserialize the details so datapacks can override it

Edited by Draco18s
  • Thanks 1

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Description of issue: Tried to run MC client, crashing with java.lang.NoSuchFieldError. I Went into SRG fields, found that f_271198 does exist, but Forge thinks this field does not exist.   Crash Report: ---- Minecraft Crash Report ---- // I let you down. Sorry Time: 2024-02-22 09:21:29 Description: Mod loading error has occurred java.lang.Exception: Mod Loading has failed     at net.minecraftforge.logging.CrashReportExtender.dumpModLoadingCrashReport(CrashReportExtender.java:48) ~[forge-1.20.4-49.0.30_mapped_official_1.20.4.jar:?] {re:classloading}     at net.minecraftforge.client.loading.ClientModLoader.completeModLoading(ClientModLoader.java:119) ~[forge-1.20.4-49.0.30_mapped_official_1.20.4.jar:?] {re:classloading,pl:runtimedistcleaner:A}     at net.minecraft.client.Minecraft.lambda$new$6(Minecraft.java:611) ~[forge-1.20.4-49.0.30_mapped_official_1.20.4.jar:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}     at net.minecraft.Util.ifElse(Util.java:432) ~[forge-1.20.4-49.0.30_mapped_official_1.20.4.jar:?] {re:classloading}     at net.minecraft.client.Minecraft.lambda$new$7(Minecraft.java:602) ~[forge-1.20.4-49.0.30_mapped_official_1.20.4.jar:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}     at net.minecraftforge.client.loading.ForgeLoadingOverlay.render(ForgeLoadingOverlay.java:146) ~[forge-1.20.4-49.0.30_mapped_official_1.20.4.jar:?] {re:classloading}     at net.minecraft.client.renderer.GameRenderer.render(GameRenderer.java:931) ~[forge-1.20.4-49.0.30_mapped_official_1.20.4.jar:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}     at net.minecraft.client.Minecraft.runTick(Minecraft.java:1250) ~[forge-1.20.4-49.0.30_mapped_official_1.20.4.jar:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}     at net.minecraft.client.Minecraft.run(Minecraft.java:801) ~[forge-1.20.4-49.0.30_mapped_official_1.20.4.jar:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}     at net.minecraft.client.main.Main.main(Main.java:234) ~[forge-1.20.4-49.0.30_mapped_official_1.20.4.jar:?] {re:classloading,pl:runtimedistcleaner:A}     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?] {}     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?] {}     at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?] {}     at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?] {}     at net.minecraftforge.fml.loading.targets.CommonLaunchHandler.runTarget(CommonLaunchHandler.java:91) ~[fmlloader-1.20.4-49.0.30.jar:?] {}     at net.minecraftforge.fml.loading.targets.CommonLaunchHandler.lambda$makeService$0(CommonLaunchHandler.java:75) ~[fmlloader-1.20.4-49.0.30.jar:?] {}     at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54) ~[modlauncher-10.1.2.jar:?] {}     at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:74) ~[modlauncher-10.1.2.jar:?] {}     at cpw.mods.modlauncher.Launcher.run(Launcher.java:114) ~[modlauncher-10.1.2.jar:?] {}     at cpw.mods.modlauncher.Launcher.main(Launcher.java:73) ~[modlauncher-10.1.2.jar:?] {}     at cpw.mods.modlauncher.BootstrapEntry.main(BootstrapEntry.java:17) ~[modlauncher-10.1.2.jar:?] {}     at net.minecraftforge.bootstrap.Bootstrap.moduleMain(Bootstrap.java:97) ~[bootstrap-2.0.0.jar!/:?] {}     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?] {}     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?] {}     at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?] {}     at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?] {}     at net.minecraftforge.bootstrap.Bootstrap.start(Bootstrap.java:48) ~[bootstrap-2.0.0.jar!/:?] {}     at net.minecraftforge.bootstrap.ForgeBootstrap.main(ForgeBootstrap.java:18) ~[bootstrap-2.0.0.jar!/:?] {} A detailed walkthrough of the error, its code path and all known details is as follows: --------------------------------------------------------------------------------------- -- Head -- Thread: Render thread Suspected Mod:      Better Biomes (betterbiomes), Version: 0.1.4.3         at TRANSFORMER/betterbiomes@0.1.4.3/net.crypticverse.betterbiomes.util.BetterBiomeWoodTypes.<clinit>(BetterBiomeWoodTypes.java:8) Stacktrace:     at net.crypticverse.betterbiomes.util.BetterBiomeWoodTypes.<clinit>(BetterBiomeWoodTypes.java:8) ~[betterbiomes-forge-2.1.4.6-1.20.4.jar!/:2.1.4.6-1.20.4] {re:classloading} -- MOD betterbiomes -- Details:     Mod File: /C:/Users/myUser/BetterBiomes-Forge/run/mods/betterbiomes-forge-2.1.4.6-1.20.4.jar     Failure message: Better Biomes (betterbiomes) has failed to load correctly         java.lang.NoSuchFieldError: f_271198_     Mod Version: 0.1.4.3     Mod Issue URL: NOT PROVIDED     Exception message: java.lang.NoSuchFieldError: f_271198_ Stacktrace:     at net.crypticverse.betterbiomes.util.BetterBiomeWoodTypes.<clinit>(BetterBiomeWoodTypes.java:8) ~[main/:?] {re:classloading}     at net.crypticverse.betterbiomes.BetterBiomes.<init>(BetterBiomes.java:55) ~[main/:?] {re:classloading}     at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[?:?] {}     at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77) ~[?:?] {}     at jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ~[?:?] {}     at java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499) ~[?:?] {}     at java.lang.reflect.Constructor.newInstance(Constructor.java:480) ~[?:?] {}     at net.minecraftforge.fml.javafmlmod.FMLModContainer.constructMod(FMLModContainer.java:66) ~[javafmllanguage-1.20.4-49.0.30.jar!/:49.0.30] {}     at net.minecraftforge.fml.ModContainer.lambda$buildTransitionHandler$5(ModContainer.java:125) ~[fmlcore-1.20.4-49.0.30.jar!/:1.0] {}     at java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1804) ~[?:?] {}     at java.util.concurrent.CompletableFuture$AsyncRun.exec(CompletableFuture.java:1796) ~[?:?] {}     at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373) ~[?:?] {}     at java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182) ~[?:?] {}     at java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655) ~[?:?] {}     at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622) ~[?:?] {}     at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165) ~[?:?] {} -- System Details -- Details:     Minecraft Version: 1.20.4     Minecraft Version ID: 1.20.4     Operating System: Windows 10 (amd64) version 10.0     Java Version: 17.0.9, Eclipse Adoptium     Java VM Version: OpenJDK 64-Bit Server VM (mixed mode, sharing), Eclipse Adoptium     Memory: 578548144 bytes (551 MiB) / 1128267776 bytes (1076 MiB) up to 8522825728 bytes (8128 MiB)     CPUs: 20     Processor Vendor: GenuineIntel     Processor Name: 12th Gen Intel(R) Core(TM) i7-12700K     Identifier: Intel64 Family 6 Model 151 Stepping 2     Microarchitecture: Alder Lake     Frequency (GHz): 3.61     Number of physical packages: 1     Number of physical CPUs: 12     Number of logical CPUs: 20     Graphics card #0 name: NVIDIA GeForce RTX 3070 Ti     Graphics card #0 vendor: NVIDIA (0x10de)     Graphics card #0 VRAM (MB): 4095.00     Graphics card #0 deviceId: 0x2482     Graphics card #0 versionInfo: DriverVersion=31.0.15.3699     Memory slot #0 capacity (MB): 16384.00     Memory slot #0 clockSpeed (GHz): 4.80     Memory slot #0 type: Unknown     Memory slot #1 capacity (MB): 16384.00     Memory slot #1 clockSpeed (GHz): 4.80     Memory slot #1 type: Unknown     Virtual memory max (MB): 37373.42     Virtual memory used (MB): 22391.79     Swap memory total (MB): 4864.00     Swap memory used (MB): 95.69     JVM Flags: 1 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump     ModLauncher: 10.1.2     ModLauncher launch target: forge_userdev_client     ModLauncher naming: mcp     ModLauncher services:          / slf4jfixer PLUGINSERVICE          / runtimedistcleaner PLUGINSERVICE          / runtime_enum_extender PLUGINSERVICE          / object_holder_definalize PLUGINSERVICE          / capability_token_subclass PLUGINSERVICE          / accesstransformer PLUGINSERVICE          / eventbus PLUGINSERVICE          / mixin PLUGINSERVICE          / fml TRANSFORMATIONSERVICE          / mixin TRANSFORMATIONSERVICE      FML Language Providers:          lowcodefml@49         minecraft@1.0         javafml@49.0.30     Mod List:                                                            |Minecraft                     |minecraft                     |1.20.4              |COMMON_SET|Manifest: NOSIGNATURE         TerraBlender-forge-1.20.4-3.3.0.12_mapped_official|TerraBlender                  |terrablender                  |3.3.0.12            |COMMON_SET|Manifest: NOSIGNATURE                                                           |Forge                         |forge                         |49.0.30             |COMMON_SET|Manifest: NOSIGNATURE         betterbiomes-forge-2.1.4.6-1.20.4.jar             |Better Biomes                 |betterbiomes                  |0.1.4.3             |ERROR     |Manifest: NOSIGNATURE         Notebook-api-forge-1.20.4-1.1.0.4_mapped_official_|Notebook                      |notebook                      |1.1.0.4             |COMMON_SET|Manifest: NOSIGNATURE     Crash Report UUID: ad19c004-038a-4777-adbc-0504acf15d93     FML: 0.0     Forge: net.minecraftforge:49.0.30
    • Some kind of issue/conflict with eureka - also try other builds of it
    • doesn't work But after trying to make a boat with Valkyrien Skies, I got this : https://pastebin.com/bxnDcHr3 maybe the problem comes from valkyrien skies itself ?
    • yeah, I was about to try other builds for Valkyrien Skies but i'm scared of breaking everything again
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.