ClientTickEvent doesnt work

[Craftit7]

@SubscribeEvent
	public void clientTickEvent(ClientTickEvent event) {
		if (openGuiMenuKey.isPressed()) {
			System.out.println("Helllllllooooooooooooooooooooooooooooooooooooooooooooooooooooo");
		}
	}

Just crashes with:-
`AL lib: (EE) alc_cleanup: 1 device not closed`

 

// Daisy, daisy...

Time: 06/07/21 12:15
Description: Unexpected error

java.lang.NullPointerException: Unexpected error
    at com.craftit7.fpsbooster.FpsBooster.clientTickEvent(FpsBooster.java:47) ~[main/:?] {re:classloading}

[Saksham4106]

event method should be static

[Craftit7]

1 minute ago, diesieben07 said:

I assume that is the line with the if statement in it? How do you initialize openGuiMenuKey? Also note that ClientTickEvent fires twice every tick, check TickEvent#phase.

public void init(FMLClientSetupEvent event) {
        this.openGuiMenuKey = new KeyBinding("key.openfpsboostermenu", 72, "key.categories.menu");

[Craftit7]

1 minute ago, Saksham4106 said:

event method should be static

Error: openGuiKeyMenu is not static, and i cant make it static because i need it not to be static

[Craftit7]

// Here it is
package com.craftit7.fpsbooster;

import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;

import net.minecraft.client.settings.KeyBinding;
import net.minecraftforge.common.MinecraftForge;
import net.minecraftforge.event.TickEvent;
import net.minecraftforge.event.TickEvent.ClientTickEvent;
import net.minecraftforge.eventbus.api.SubscribeEvent;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.event.lifecycle.FMLClientSetupEvent;

@Mod("fpsbooster")
public class FpsBooster {

	public static final Logger LOGGER = LogManager.getLogger();
	public static final String MOD_ID = "fpsbooster";
	
	public KeyBinding openGuiMenuKey;
	
	private boolean isMenuOpen = false;
	
	private final ClientTickEvent tickEvent = new ClientTickEvent(TickEvent.Phase.START);
	
	public void init(FMLClientSetupEvent event) {
		this.openGuiMenuKey = new KeyBinding("key.openfpsboostermenu", 72, "key.categories.menu");
		
		/** TODO
		 * Run "H" key listener.
		 */
		
		//looper
		/*if (openGuiMenuKey.isPressed()) {
			if (isMenuOpen) {
				saveSettings();
				closeMenu(); within it: isMenuOpen = false;
			} else {
				loadSettings();
				openMenu(); within it: isMenuOpen = true;
			}
		}*/
	}
	
	@SubscribeEvent
	public void clientTickEvent(ClientTickEvent event) {
		if (openGuiMenuKey.isPressed()) {
			System.out.println("Test, works ig");
		}
	}

	public FpsBooster() {
		//IEventBus Bus = FMLJavaModLoadingContext.get().getModEventBus();
		MinecraftForge.EVENT_BUS.register(this);
	}
}

 

1 minute ago, diesieben07 said:

Show more of your code.

 

[Craftit7]

The mod is client-sid only and im registering the event bus at the very bottom....
public FpsBooster() { //IEventBus Bus = FMLJavaModLoadingContext.get().getModEventBus(); MinecraftForge.EVENT_BUS.register(this); }

[Saksham4106]

'init' method still needs a @SubscribeEvent

Edited July 8, 2021 by Saksham4106

[Craftit7]

Init works, i tested it.

[Craftit7]

Oh wait a minute, My code didnt save @SubscribeEvent....  Added it lemme test it now

[Saksham4106]

ClientRegistry.registerKeyBinding(myKey);

also you need to register your key bindings like this in FMLClientSetupEvent i believe

Edited July 8, 2021 by Saksham4106

[Craftit7]

Works, init was the problem, moved it to the public KyeBinding openGuiMenuKey 

[Craftit7]

Uh sure

package com.craftit7.fpsbooster;

import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;

import net.minecraft.client.settings.KeyBinding;
import net.minecraftforge.common.MinecraftForge;
import net.minecraftforge.event.TickEvent;
import net.minecraftforge.event.TickEvent.ClientTickEvent;
import net.minecraftforge.eventbus.api.SubscribeEvent;
import net.minecraftforge.fml.client.registry.ClientRegistry;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.event.lifecycle.FMLClientSetupEvent;

@Mod("fpsbooster")
public class FpsBooster {

	public static final Logger LOGGER = LogManager.getLogger();
	public static final String MOD_ID = "fpsbooster";
	
	public KeyBinding openGuiMenuKey = new KeyBinding("key.openfpsboostermenu", 72, "key.categories.menu");;
	
	private boolean isMenuOpen = false;
	
	@SubscribeEvent
	public void clientTickEvent(ClientTickEvent event) {
		if (openGuiMenuKey.isPressed()) {
			/** TODO
			 * Run "H" key listener.
			 */
			
			//looper
			/*if (openGuiMenuKey.isPressed()) {
				if (isMenuOpen) {
					saveSettings();
					closeMenu(); within it: isMenuOpen = false;
				} else {
					loadSettings();
					openMenu(); within it: isMenuOpen = true;
				}
			}*/
			System.out.println("Ayo man asdjhsakjf hdsahh fsadhf hhkdshk jksdrhfhsdajkhg jkhdfkjghsdfhgjk");
		}
	}

	public FpsBooster() {
		//IEventBus Bus = FMLJavaModLoadingContext.get().getModEventBus();
		MinecraftForge.EVENT_BUS.register(this);
	}
}

 

[Craftit7]

Um i dont understand, it works fine on singleplayer, im gonna try it in mp rn

[Craftit7]

Uhhhh its works perfect on multiplayer

[Craftit7]

One more thing, if i keep holding the H key, it prints multiple times, i want to use it to open a gui so no matter how much u hold it for, the second u release it, the gui opens

[Craftit7]

How can i check if it is?

16 minutes ago, diesieben07 said:

Did you install it on the server?

Then check if it was released.

 

[Craftit7]

Also as i said before ITS CLIENT SIDE ONLYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYY ONLY CLIENT WILL RUN IT

[Craftit7]

Uhm, Its a private mod

[Craftit7]

How can i make a dist-only event sub on a sep class??

[Luis_ST]

1 minute ago, Craftit7 said:

How can i make a dist-only event sub on a sep class??

you need to set the "value" in the EventBusSubscriber annotation
take a look at the forge doc -> there is a practical example
https://mcforge.readthedocs.io/en/latest/events/intro/