Jump to content

[1.16.5] Get effect amplifier in Loot Modifier


MLGDuckboi

Recommended Posts

I am trying to make a loot modifier which has varying effects based off the level of a certain status effect a player has. My modifier JSON currently checks if the player has the status effect.

{
  "conditions": [
    {
      "condition": "minecraft:entity_properties",
      "entity": "this",
      "predicate": {
        "effects": {
          "calebsmod:golden_touch": {}
        }
      }
    }
  ],
  "chance_per_level": 20,
  "drop": {
    "min": 1,
    "max": 3,
    "item": "minecraft:gold"
  }
}

Basically, "chance_per_level" dictates the chance of a block dropping somewhere between one and three gold (as defined in "drop") per level of my effect, calebsmod:golden_touch. For example, level 1 is 20% chance for gold, level 2 is 40% chance, and so on. What I'm stuck on is in my LootModifier class in the doApply method, how to get the level of the effect on the given entity. The only solution I can think of is making a loot modifier JSON for each level of the effect, but I was hoping there might be a better way. Thanks in advance!

Link to comment
Share on other sites

Update: Sorry, I cant seem to figure out where LootParameters comes into my class.

public class LootModification extends LootModifier {
    private final int minDrop;
    private final int maxDrop;
    private final Item replacementItem;
    private final int chancePerLvl;
    public LootModification(ILootCondition[] conditionsIn, int minDrop, int maxDrop, Item itemDrop, int chancePerLvl) {
        super(conditionsIn);
        this.minDrop = minDrop;
        this.maxDrop = maxDrop;
        this.replacementItem = itemDrop;
        this.chancePerLvl = chancePerLvl;
    }

    @Nonnull
    @Override
    public List<ItemStack> doApply(List<ItemStack> generatedLoot, LootContext context) {
        return generatedLoot;
    }

    public static class Serializer extends GlobalLootModifierSerializer<LootModification> {

        @Override
        public LootModification read(ResourceLocation name, JsonObject object, ILootCondition[] conditionsIn) {
            int chance = JSONUtils.getAsInt(object, "chance_per_level");
            int max = JSONUtils.getAsInt(object, "drop.max");
            int min = JSONUtils.getAsInt(object, "drop.min");
            Item drop = ForgeRegistries.ITEMS.getValue(new ResourceLocation((JSONUtils.getAsString(object, "drop.item"))));
            return new LootModification(conditionsIn, min, max, drop, chance);
        }

        @Override
        public JsonObject write(LootModification instance) {
            JsonObject json = makeConditions(instance.conditions);
            json.addProperty("chance_per_level", instance.chancePerLvl);
            json.addProperty("drop.min", instance.minDrop);
            json.addProperty("drop.max", instance.maxDrop);
            json.addProperty("drop.item", ForgeRegistries.ITEMS.getKey(instance.replacementItem).toString());
            return json;
        }
    }
}

Could you point me in the right direction?

Link to comment
Share on other sites

Another issue:
My loot modifier won't load, the log just says it can't parse it, as well as a NullPointerException error. Do I have to specify that my class should be used to parse it somewhere?

All related files below:

data/forge/loot_modifiers/global_loot_modifiers.json

{
  "replace": false,
  "entries": [
    "calebsmod:golden_touch"
  ]
}

data/calebsmod/loot_modifiers/golden_touch.json

{
  "conditions": [
    {
      "condition": "minecraft:entity_properties",
      "entity": "this",
      "predicate": {
        "effects": {
          "calebsmod:golden_touch": {}
        }
      }
    }
  ],
  "chance_per_level": 0.2,
  "drop": {
    "min": 1,
    "max": 3,
    "item": "minecraft:gold"
  }
}

LootModification

public class LootModification extends LootModifier {
    private final int minDrop;
    private final int maxDrop;
    private final Item replacementItem;
    private final float chancePerLvl;
    public LootModification(ILootCondition[] conditionsIn, int minDrop, int maxDrop, Item itemDrop, float chancePerLvl) {
        super(conditionsIn);
        this.minDrop = minDrop;
        this.maxDrop = maxDrop;
        this.replacementItem = itemDrop;
        this.chancePerLvl = chancePerLvl;
    }

    @Nonnull
    @Override
    public List<ItemStack> doApply(List<ItemStack> generatedLoot, LootContext context) {
        LivingEntity entity = (LivingEntity)context.getParamOrNull(LootParameters.THIS_ENTITY);
        Random random = new Random();
        if (entity.getEffect(ModEffects.GOLDEN_TOUCH.get()).getAmplifier() * chancePerLvl > random.nextFloat()) {
            generatedLoot.removeAll(generatedLoot);
            generatedLoot.add(new ItemStack(replacementItem, minDrop + random.nextInt(maxDrop - minDrop)));
        }
        return generatedLoot;
    }

    public static class Serializer extends GlobalLootModifierSerializer<LootModification> {

        @Override
        public LootModification read(ResourceLocation name, JsonObject object, ILootCondition[] conditionsIn) {
            float chance = JSONUtils.getAsFloat(object, "chance_per_level");
            int max = JSONUtils.getAsInt(object, "drop.max");
            int min = JSONUtils.getAsInt(object, "drop.min");
            Item drop = ForgeRegistries.ITEMS.getValue(new ResourceLocation((JSONUtils.getAsString(object, "drop.item"))));
            return new LootModification(conditionsIn, min, max, drop, chance);
        }

        @Override
        public JsonObject write(LootModification instance) {
            JsonObject json = makeConditions(instance.conditions);
            json.addProperty("chance_per_level", instance.chancePerLvl);
            json.addProperty("drop.min", instance.minDrop);
            json.addProperty("drop.max", instance.maxDrop);
            json.addProperty("drop.item", ForgeRegistries.ITEMS.getKey(instance.replacementItem).toString());
            return json;
        }
    }
}

 

Edited by MLGDuckboi
Link to comment
Share on other sites

Closer to how custom recipe types are registered, but yes: Things need to be registered.

the forge/loot_modifiers/global_loot_modifiers.json file is there for specifying processing order (obviously if you don't include it or don't reference a registered serializer, it won't be run at all, even if it's registered). It doesn't do the registration. It's purpose is to allow data pack folks to resolve conflicts.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

5 hours ago, diesieben07 said:

Unless you mean recipe serializers, in which case it's still the same way as blocks or items. So really, this is just wrong.

No I meant custom recipe types.

Custom recipe types register their serializers.
Blocks register themselves.

So while you're not wrong, it's missing the point. The way that that most people think about it is "recipes" because "recipes are data assets" and that "custom recipe types" need to have a serializer registered rather than registering the recipe itself whereas items and blocks are just registered "normally."

There's a degree of indirection that is the same between "Recipes" and "Loot Modifiers" that isn't present for "Blocks" and "Items."

 

(Unless there's a BlockSerializer implements ForgeRegistryEntry around that I'm unaware of...)

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

1 hour ago, diesieben07 said:

You register LootModifierSerializer the same way you do a block.

Yes.

But you don't register LootModifiers.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • KLIK DISINI UNTUK DAFTAR     Situs Slot Thailand Terpercaya adalah situs yang menyediakan permainan slot online dengan tema dan layanan yang sesuai dengan kebutuhan dan preferensi pemain asal Thailand. Situs-situs ini biasanya menawarkan permainan slot dengan server khusus yang berasal dari Thailand, yang diklaim memiliki tingkat kemenangan yang tinggi dan mudah mendapatkan jackpot. Beberapa situs juga menyediakan permainan slot dengan server dari negara lain, seperti Rusia dan Singapura, yang juga populer di kalangan pemain Thailand.  
    • I was trying to use viaforge (latest version) on forge 1.20.2 and then it crashed showing exit code 1 heres the log : 04Dec2023 11:40:52.058] [main/INFO] [cpw.mods.modlauncher.Launcher/MODLAUNCHER]: ModLauncher running: args [--username, Goldenretriver, --version, 1.16.5-forge-36.2.34, --gameDir, C:\Users\rashr\AppData\Roaming\.minecraft, --assetsDir, C:\Users\rashr\AppData\Roaming\.minecraft\assets, --assetIndex, 1.16, --uuid, a688ba406e4f4635a428d7555a467474, --accessToken, ????????, --userType, msa, --versionType, release, --launchTarget, fmlclient, --fml.forgeVersion, 36.2.34, --fml.mcVersion, 1.16.5, --fml.forgeGroup, net.minecraftforge, --fml.mcpVersion, 20210115.111550] [04Dec2023 11:40:52.061] [main/INFO] [cpw.mods.modlauncher.Launcher/MODLAUNCHER]: ModLauncher 8.1.3+8.1.3+main-8.1.x.c94d18ec starting: java version 1.8.0_51 by Oracle Corporation [04Dec2023 11:40:52.071] [main/DEBUG] [cpw.mods.modlauncher.LaunchServiceHandler/MODLAUNCHER]: Found launch services [minecraft,testharness,fmlclient,fmlserver] [04Dec2023 11:40:52.075] [main/WARN] [cpw.mods.modlauncher.SecureJarHandler/]: LEGACY JDK DETECTED, SECURED JAR HANDLING DISABLED [04Dec2023 11:40:52.082] [main/DEBUG] [cpw.mods.modlauncher.NameMappingServiceHandler/MODLAUNCHER]: Found naming services : [] [04Dec2023 11:40:52.118] [main/DEBUG] [cpw.mods.modlauncher.LaunchPluginHandler/MODLAUNCHER]: Found launch plugins: [mixin,eventbus,object_holder_definalize,runtime_enum_extender,accesstransformer,capability_inject_definalize,runtimedistcleaner] [04Dec2023 11:40:52.125] [main/DEBUG] [cpw.mods.modlauncher.TransformationServicesHandler/MODLAUNCHER]: Discovering transformation services [04Dec2023 11:40:52.132] [main/DEBUG] [cpw.mods.modlauncher.TransformationServicesHandler/MODLAUNCHER]: Found additional transformation services from discovery services: [C:\Users\rashr\AppData\Roaming\.minecraft\mods\viaforge-1.12.2-3.4.3.jar]
    • 网络花图战略▷BCGAME55·COM⊙网络花图网站帕劳网络花图游乐场America花图方法[本社文之Tele @JBOX7]网络花图Holdom Pub Ginibiso网络花图广播匈牙利花图旅行津巴布韦花图比赛[总经销文的Kakao Talk JBOX7]网络游戏FOXWood Casino ITALPERAUTALL Telecom Pub[本社文之音] 制作社区] 网游] [澳大利亚网购] [赌场总公司] 网络花图巡回 莱索托 网络花图赌场 哈萨克斯坦花图游乐场 科特迪瓦花图企业 [体育总公司] 网络花图网站南非 网络花图 巴卡拉酒吧 加拿大花图视频 Kyrivasi 网络花图赌场酒吧 [TOTO总公司咨询] ITWO赌博场所 ESWATINI IT COUPONE厄瓜多尔卡什游戏 Aria Casino Hoto Tourtourtourtune [TOTO总购买] ITHIGOTUGO游戏场] 联盟[bacara总经销] 网络花图 bacara pub 塞内加尔网络花图视频 南美洲花图战略塞内加尔花图转播[赛马总经销] 网络花图 bacara pub 罗马尼亚网络花图游戏 日本花图 bacara pub montecaro 花图 coopoon[BCGAME bc游戏总经销咨询] 设置通知推荐 订阅 点赞
    • 東京都キスバン話†BCGAME33・COM↖東京都キスバン、ツイッターボッチャ東京都キスバンサイト槍投げキスバンサイトのオンラインゲームキスバンインスタグラム[本社の問い合わせテレ@JBOX7]東京都キスバン同好会、鉄棒、東京都キスバン、ユーチューブオンラインゲームキスバン動画の水上スポーツのキスバン推薦[の一手販売業者の問い合わせ、カカオトークやJBOX7]東京都キスバン放送、マッサージ、東京都キスバン指導スキーキスバンツアーラグビーキスバン会情報[各種オーピーコミュニティ制作】東京都キスバンリゾート水泳東京都キスバン旅行重量挙げキスバン映像シルムキスバンするところ[マーケティング問い合わせ]東京都キスバン旅行棒高跳びの東京都キスバン、ツイッタースキーキスバンの一手販売ラケットボールキスバン求人広告[カジノ本社] 東京都キスバン住所、重量挙げ、東京都キスバン旅行水泳キスバンラインハンドボールキスバンシステム[スポーツ本社】東京都キスバンラインアルペン東京都キスバンツアーハンドボールキスバン接続ワールドカップキスバン位置[トト(株)本社のお問い合わせ]東京都キスバン、ツイッター、マッサージ、東京都キスバン求人広告バドミントンキスバンリンクギョクキキスバンインスタグラム[トトの一手販売購買】東京都キスバン話、鉄棒、東京都キスバンリゾートアーチェリーキスバンリンク棒高跳びキスバン、新住所[カジノの一手販売業者】東京都キスバンの一手販売業者フェンシング東京都キスバン、新住所、ティーボールキスバン推薦誘導キスバン動画[大和の本社】東京都キスバンコミュニティ相撲東京都キスバン指導ギョクキキスバンリンクダイビングキスバン指導[バカラの一手販売]
    • 东南亚Go-Stop游戏厅♨BCGAME55·COM @ 东南亚Go-Stop网站Book Makedonia东南亚Go-Stop转播Win Casino Go-Stop网站Ryberia Go-Stop方法[本社的Tele @JBOX7] 东南亚Go-Stop Bar西亚东南亚Go-Poon 格伦纳丁GO-Stop扑克大赛刚果民主Goostop Coopon[总经销的Kakao Talk JBOX7] 东南亚 Gomino Saition网站] 制作方法[东南亚 G 赌场 [赌场总公司] 东南亚Go Stop 转播 帕劳 东南亚Go Stop总经销 苏里南Go Stop 视频 罗马尼亚Go Stop战略 尼泊尔东南亚Go Stop方法西非Go Stop赌场尼日利亚Go Stop Tour[TOTO总公司咨询]东南亚Go Stop连接冈比亚东南亚 GOSTOP SITE Estonia GOSTOP MALLET MALLATION GOSTOP招募[TOTOTOTO总经销购买]东南亚 GOSTOP比赛 NIGOSTOP TANGE GOSTOP TALLIGOTION GOSTOP总经销 Holdumba厄瓜多尔Go Stop赌场酒吧新西兰Go Stop总经销[Bakara总经销]东南亚Go Stop转播巴登巴登东南亚Go Stop游戏场台湾Go Stop社区塞内加尔Go Stop招募[赛马总经销]东南亚Go Stop视频葡萄牙东南亚Go Stop方法 Falls View赌场Kosogos游戏场Cipross Gosing地址[BCGME BC Game总经销咨询]设置通知推荐订阅点赞
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.