Jump to content

[1.16.5] [Solved] Get loot_tables from datapacks


Erfurt

Recommended Posts

Hey guys

So I have this class, where I get the chance value from a loot_table, it works perfectly, however I would like to add datapack functionality to this. And I'm pretty lost here, I know I have to add datapacks in my getManager(@Nullable World world) method, and I have no idea how to do that atm, so I could use some help achieving this

It is possible that there is a vanilla/forge method where they are already stored, but it's something I haven't been able to find myself

 

The class in question

Spoiler

public class LootTableUtil
{
    public static List<LootPool> getPools(LootTable table)
    {
        // public net.minecraft.loot.LootTable field_186466_c # pools
        return ObfuscationReflectionHelper.getPrivateValue(LootTable.class, table, "field_186466_c");
    }
 
    public static List<ILootCondition> getLootConditions(LootPool pool)
    {
        // public net.minecraft.loot.LootPool field_186454_b # conditions
        return ObfuscationReflectionHelper.getPrivateValue(LootPool.class, pool, "field_186454_b");
    }
 
    public static float getRandomChanceValue(RandomChance condition)
    {
        // public net.minecraft.loot.conditions.RandomChance field_186630_a # chance
        return ObfuscationReflectionHelper.getPrivateValue(RandomChance.class, condition, "field_186630_a");
    }
 
    public static float getRandomChanceWithLootingValue(RandomChanceWithLooting condition)
    {
        // public net.minecraft.loot.conditions.RandomChanceWithLooting field_186627_a # chance
        return ObfuscationReflectionHelper.getPrivateValue(RandomChanceWithLooting.class, condition, "field_186627_a");
    }
 
    public static float getLootingMultiplierValue(RandomChanceWithLooting condition)
    {
        // public net.minecraft.loot.conditions.RandomChanceWithLooting field_186628_b # lootingMultiplier
        return ObfuscationReflectionHelper.getPrivateValue(RandomChanceWithLooting.class, condition, "field_186628_b");
    }
 
    public static float getChance(ResourceLocation resource)
    {
        final Float[] chance = {null};
        final LootTableManager manager = getManager();
 
        LootTable table = manager.getLootTableFromLocation(resource);
 
        getPools(table).forEach(
                pool -> {
                    final List<ILootCondition> poolConditions = getLootConditions(pool);
                    poolConditions.forEach(condition -> {
                            if(condition instanceof RandomChance)
                            {
                                chance[0] = getRandomChanceValue((RandomChance) condition);
                            }
                            else if(condition instanceof RandomChanceWithLooting)
                            {
                                chance[0] = getRandomChanceWithLootingValue((RandomChanceWithLooting) condition);
                            }
                        }
                    );
                }
        );
 
        return chance[0];
    }
 
    public static float getLootingMultiplier(ResourceLocation resource)
    {
        final Float[] lootingMultiplier = {null};
        final LootTableManager manager = getManager();
 
        LootTable table = manager.getLootTableFromLocation(resource);
 
        getPools(table).forEach(
                pool -> {
                    final List<ILootCondition> poolConditions = getLootConditions(pool);
                    poolConditions.forEach(condition -> {
                            if(condition instanceof RandomChanceWithLooting)
                            {
                                lootingMultiplier[0] = getLootingMultiplierValue((RandomChanceWithLooting) condition);
                            }
                        }
                    );
                }
        );
 
        return lootingMultiplier[0];
    }
 
    private static LootTableManager manager;
 
    public static LootTableManager getManager(@Nullable World world)
    {
        if(world == null || world.getServer() == null)
        {
            if(manager == null)
            {
                manager = new LootTableManager(new LootPredicateManager());
 
                SimpleReloadableResourceManager serverResourceManger = new SimpleReloadableResourceManager(ResourcePackType.SERVER_DATA);
                List<IResourcePack> packs = new LinkedList<>();
                packs.add(new VanillaPack("minecraft"));
                for(ModFileInfo mod : ModList.get().getModFiles())
                {
                    if(mod.getFile().getFileName().contains(MagicalJewelry.MOD_ID) || mod.getFile().getFileName().equals("main"))
                    {
                        packs.add(new ModFileResourcePack(mod.getFile()));
                    }
                }
                packs.forEach(serverResourceManger::addResourcePack);
                serverResourceManger.addReloadListener(manager);
                CompletableFuture<Unit> completableFuture = serverResourceManger.reloadResourcesAndThen(Util.getServerExecutor(), Minecraft.getInstance(), packs, CompletableFuture.completedFuture(Unit.INSTANCE));
                Minecraft.getInstance().driveUntil(completableFuture::isDone);
            }
            return manager;
        }
        return world.getServer().getLootTableManager();
    }
 
    public static LootTableManager getManager()
    {
        World world = Minecraft.getInstance().world;
        return getManager(world);
    }
}

 

 

Link to comment
Share on other sites

12 hours ago, diesieben07 said:
  • You should use ObfuscationReflectionHelper.getField and store that in a static final field. getPrivateValue is slow and therefore should be used only for one-off lookups.
  • Your code in getManager(World) makes zero sense. Do not try to make your own LootTableManager... Why are you doing that? MinecraftServer#getLootTables gives it to you.
  • Your code in getManager() makes no sense either. This will hard-crash on servers (the server has no Minecraft class) and in generate data pack things are server side, so using Minecraft#world for it doesn't work.

I don't see those two methods, getField and getLootTables, I assume it's findField and getLootTableManager?

 

It's my first time doing anything with reflection, so will that method still get the value?

Link to comment
Share on other sites

8 minutes ago, Erfurt said:

I don't see those two methods, getField and getLootTables, I assume it's findField and getLootTableManager?

yes

9 minutes ago, Erfurt said:

It's my first time doing anything with reflection, so will that method still get the value?

if you store the value in a static final field?
yes this is basic java

Link to comment
Share on other sites

  • Erfurt changed the title to [1.16.5] [Solved] Get loot_tables from datapacks

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Keep this post up just in case but I'm using the curseforge launcher and it's working  IM SOO HAPPY
    • Post logs as per https://forums.minecraftforge.net/topic/125488-rules-and-frequently-asked-questions-faq/ They may have information that will answer these questions.
    • I was left reeling when a glitch on a cryptocurrency exchange caused me to lose $166,000 worth of my hard-earned savings. It felt like my entire world had crumbled in the blink of an eye, leaving me with a sense of hopelessness. Determined not to give up, I delved into research on recovery options, unsure of what to expect. That's when I stumbled upon I was left reeling when a glitch on a cryptocurrency exchange caused me to lose $166,000 worth of my hard-earned savings. It felt like my entire world had crumbled in the blink of an eye, leaving me with a sense of hopelessness. Determined not to give up, I delved into research on recovery options, unsure of what to expect. That's when I stumbled upon DIGITAL HACK RECOVERY, a beacon of hope in my darkest hour. Despite my initial doubts, I decided to take a leap of faith and give them a shot as a final lifeline. The experts at DIGITAL HACK RECOVERY proved to be masters of their craft, guiding me through their exclusive process with precision and expertise. Utilizing cutting-edge blockchain analysis methods, they were able to track down the elusive trail of my missing funds and identify the exact point of failure. Their forensic talents were unparalleled as they tirelessly combed through the intricate web of blockchain data to locate my cryptocurrency. With each step they took, they kept me informed of their progress, never wavering in their belief that my funds could be rescued. After several painstaking weeks, DIGITAL HACK RECOVERY finally located and restored my $166,000 worth of cryptocurrency. I was awestruck that they were able to salvage what I had thought was lost forever. The whole experience restored my faith in the crypto space and proved that even in the worst situations, recovery is possible with the right experts on your side. I will be forever grateful to DIGITAL HACK RECOVERY for giving me back my life savings when I needed it most. Their tireless efforts and technical mastery turned what could have been a devastating loss into an uplifting success story. Book a time with DIGITAL HACK RECOVERY through: digital hack recovery @ techie . com &  +12018871705
    • public class ParticleReboundRecipe implements Recipe<CraftingContainer> { private List<ParticleReboundIngredient> inputs; private ParticleReboundFuel fuel; private ItemStack output; public ParticleReboundRecipe(List<ParticleReboundIngredient> inputs, ParticleReboundFuel fuel, ItemStack output) { this.inputs = inputs; this.fuel = fuel; this.output = output; } // TODO: Implement interface ... // TODO: Move to separate file if desired public record ParticleReboundIngredient(Ingredient ingredient, int count) { public static final Codec<ParticleReboundIngredient> CODEC = RecordCodecBuilder.create( builder -> builder.group( Ingredient.CODEC.fieldOf("ingredient").forGetter((i) -> i.ingredient), Codec.INT.fieldOf("count").forGetter(i -> i.count) ).apply(builder, ParticleReboundIngredient::new) ); } // TODO: Move to separate file if desired public record ParticleReboundFuel(String tag) { public static final Codec<ParticleReboundFuel> CODEC = RecordCodecBuilder.create( builder -> builder.group(Codec.STRING.fieldOf("tag").forGetter(f -> f.tag)).apply(builder, ParticleReboundFuel::new) ); public boolean isFuel(ItemStack stack) { // TODO: Check if fuel item matches the tag } } public class Serializer implements RecipeSerializer<ParticleReboundRecipe> { public static final Codec<ParticleReboundRecipe> CODEC = RecordCodecBuilder.create( builder -> builder.group( ParticleReboundIngredient.CODEC.listOf().fieldOf("inputs").forGetter(r -> r.inputs), ParticleReboundFuel.CODEC.fieldOf("fuel").forGetter(r -> r.fuel), ItemStack.CODEC.fieldOf("output").forGetter(r -> r.output) ).apply(builder, ParticleReboundRecipe::new) ); @Override public @NotNull Codec<ParticleReboundRecipe> codec() { return CODEC; } // TODO: The rest ... } }   ?
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.