Jump to content

using threads for world gen


endershadow

Recommended Posts

One of my structures causes the game to lag while it's being generated, and I was wondering if anyone knows how I can put it in a seperate thread to reduce the lag caused during structure generation. I just need to know how I would get the structure to generate in the new thread. I already have a class sort of set up. Here's what I have so far.

https://github.com/code-lyoko-modding/CodeLyokoMod/blob/master/matt/lyoko/lib/TowerGenThread.java

Link to comment
Share on other sites

I suck at threading so I'm probably not much help, but to create a new thread do you not just call

(new Thread(Runnable runnable)).start()

at the point in the game loop where you want the thread to start?

 

this causes the run method to be called in your Runnable class, so form there call your methods to generate the structure

Link to comment
Share on other sites

given you pass it an object instance of the runnable class, can you not pass the required variables through the constructor for that then use them in the generation methods? I will repeat that I suck with threading and you will probably have to be careful with de-synchronizing the world variable (so two different ones exist as one was changed in the thread and the other remained the same) but I can't think how to fix this (lots of synchronization at points possibly???) I'll look into how to fix that in a bit

 

I'm probably being as useless as a... well.... as s sleep deprived me...

 

you did all i was just typing, looks like my knowledge isn't as bad as I thought it was :D

 

I'll look through your classes, but I probably won't be to much use in this state... why is England so hot all of a sudden???

Link to comment
Share on other sites

hey there, i do have some thread knowledge and i think i might be able to help you. since youre asking the qestion youre obviously not a noob soooo i wont go into deep details.

but basicly youre gonna want your world generator to create more then 1 thread, because if you only create 1 youre not solving the problem at all (feel free to ask why you need more then 1)

basicly each thread will have to do 1/number of thread  of your structure

aka, if your structure is 50 block long (doesnt matter how much width and height) and you have 5 thread, thread 1 will do from 0-9, T2 from 10-19 etc

 

so make some class extends Runnable or even thread, make the constructor of this thread have a reference to the world, the starting location of the structure, the structure youre trying to do and which part of it the thread is suppose to construct.

also include a reference to the thread that started the threads (aka the world generator )

 

once thats all setup, in the world generator starts/run all thread and wait for them to complete. 

 

it is important to note that minecraft is single threaded and it is a huge problem. so i suggest that even before starting to work on this. make a program an try to understand how thread works and specificly what are the functions Object.wait and Object.notify are doing (btw you know that every class that doesnt extends something specificly by default extends Object right ? so every object has the methods wait and notify)

 

sry if my explanation is shitty but ive written all this on a phone

fell free to pm me

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

round 2 (this "keyboard is painfull)

 

ok so in the case that you are using only 1 thread, basicly this would happen.

the minecraft thread creates a new thread, calls this thread and wait til its done... basicly while the main thread is waiting you got only 1 thread running, you didnt solve anything because overall, theres 1 thread doing nothing, 1 working. its the same as just having 1 thread doing all the work

 

in the case of creating 2 thread, you have the main thread waiting but 2 thread creating the structure

this is when you start gaining power

if you've actually read about wait and notify and dont understand them heres another solution

 

have the main thread create and start all thread and then have the main thread do something like this

for(all my thread){

while(!thread.isDoneGenerating()){}

}

 

make sure the custom thread set a boolean value to true tgat will be returned by isDoneGenerating when they are done generating their part

 

basicly if it takes 5 sec (its just an overkill example) to generate the structure, they should all finish at the same time. so the mc server thread will do the first "while" a lot but then the next while might not even make it in once

 

if thats still not clear tell me

and sorry for the shitty typing/typos/explanation, coding on a phone is horrible

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

let me see if I can understand this. you want me to make a bunch of threads with the default boolean value to false. then you want me to iterate through them all and while they're not finished, you want me to do something? I'm still kind of confused. if you have a skype it might be easier to talk through there.

Link to comment
Share on other sites

nope all good i got a computer ill be albe to make complete answers

 

ok so basicly your code to generate the world will look like this

 

public void idontknowthename(arguments){
//code
StructureGeneratorThread[] threads = new StructureGeneratorThread[5];
for(int i = 0; i < threads.length; i++){
threads[i] = new StructureGeneratorThread(/*argument to give to have all information */ world, structureToGenerate, startIndex, endIndex);
}

for(StructureGeneratorThread thread : threads){//do you know about this way of writing for loops ? if not its just going to iterate through the list
thread.start();
}

for(StructureGeneratorThread thread : threads){
while(!thread.isDone()){}
}
//more code
}

 

public class StructureGeneratorThread extends Thread{
boolean isDone = false;
public StructureGeneratorThread(/*the args showed earlier*/){
blah blah save all the args
}

public void run(){//this method will be automaticly called when start() is called
//here you generate the structure from startIndex to endIndex, aka thread 1 from 0-9, 2 from 10-19 etc if its 5 thread for a 50 block wide structure

isDone = true;
}

public boolean isDone(){ return isDone;}
}

 

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

so heres how to read this code

 

 

when youll start generating the structure, the server thread creates X "sub threads" each of those will be responsible to generate 1/X of the structure. (pick any axis and keep it as the "seperatable axis" exemple if you have a 10x20x30 structure, and you chose the x axis, the threads will generate from 1x20x30 to 5x20x30 and 6x20x30 to 10x20x30 (this is for 2 threads,  x threads= x subdivision) now the first loop creates all the threads and tell them which part they are responsible for

 

the 2nd loops starts all the thread, after the 2nd loop is done executing all the threads will be generating the structure

 

since they're all running in parallel the event log from this could look like this:

situation 2 thread generating a 2x2x2

 

thread1: generated 1, 1, 1

thread2: generated 2, 1, 1

thread1: generated 1, 1, 2

thread2: generated 2, 1, 2

thread1: generated 1, 2, 1

thread2: generated 2, 2, 1

thread1: generated 1, 2, 2

thread2: generated 2, 2, 2

 

optionnal note: since they are running in parallel this could be happening in ANY order (for some reason is it possible that the 2nd thread will generate more slowly but GENERALLY i should be pretty "symmetrical" )

 

so after the 2nd loop they're all generating and thats great, but how do we know its done? this is what the third loop is for

 

you see, at the end of the "run" method theres a isDone = true

meaning when the thread is done generating its own part of the structure itll set the boolean to true and the function isDone will now return true

 

the 3r loop basicly goes through each thread and wait til they are done generating

since this is happening in parrallel this SHOULD happen all at the same time

so the 3rd loop might wait 50 iteration of the while for the 1st loop to be done, but when itll be done all the other threads should ALSO be done, meaning it might not even enter then once !

 

was that better ?

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

the minecraft thread creates a new thread, calls this thread and wait til its done... basicly while the main thread is waiting you got only 1 thread running, you didnt solve anything because overall, theres 1 thread doing nothing, 1 working. its the same as just having 1 thread doing all the work

 

sorry for hijacking this thread (no pun intended), but @hydroflame, wouldn't there be two threads running if you create a new thread (the main mc thread and the new one you created)? correct me if i'm wrong, but wouldn't the main mc thread continue running whether or not the new one's finished (it's a new separate thread after all)?

Link to comment
Share on other sites

hijacking this thread

i loled

 

wouldn't there be two threads running if you create a new thread (the main mc thread and the new one you created)?

you are absolutelly right there will be 2 thread running BUT the thin is the server thread cannot continue its work until the generation is finished. saying that it can continue it works (like continue to generate the caves n everything) would mean that from anywhere in the code you can receive the "is finished" message from the generating threads.

 

technicly... it could be possible that the generating threads (GT) would NOT in ANY way communicate with the main thread other then by the method that creates then

 

this "technique" would imply that the threads have "queue" of structure to generate and whenever the world gen wants to generate a structure he simply queues it to the least filled queue

 

the code would ressemble this

 

public class TowerGen implements IWorldGen{

private TowerGenThread[] threads;

public TowerGen(){

threads = new TowerGenThread[5];

}

 

public void generateTower(){

 

//code to decide where/if to put a tower

//find tower with least ammount of queued tower

//add tower to that thread

 

//more code if you want

 

}

 

 

}

 

public class TowerGenThread extends Thread{

private Queue towerToGen = new IDontKnowTheExactClassName();

 

public int getQueueSize(){

return towerToGen.size();

}

 

 

public void addToQueue(/*args that describe the location*/){

towerToGen.add(the args, either an object or wtv);

}

 

public void run(){

while(true){

if(towerToGen.hasNext()){//or wtv the name to check if theres an object in the queue

//code to generate the tower

}

}

}

 

bascily this would also work, BUT you might find yourself in situation where a particular chunk isnt loaded because it took so much time that the player leaved the general area where the tower was supposed to be generated

 

 

 

both design have advantage and disadvantage

 

the first one keep the main idea of "single thread" because the server doesnt continue until its done but will be useless if the structures are very small

 

if the structure are numerous but small in size the 2nd design MAY be a better solution.

 

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

ExecutorService exe = Executors.newCachedThreadPool();
exe.execute(new MyWorldGenThread(params));

That will run alongside the main thread. I just tested it with one of my mods by executing the Runnable using the service. By printing a line at the start of the run() method, and then another during a loop, and then placing a line after the exe.execute() invocation, you will see something like this:

 

The thread has started

Test 1

Test 2

This should show after the thread has started

Test 3

Test 4

Test 5

 

This should help you run a world gen thread alongside the main thread.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • The future of Bitcoin recovery is a topic of great interest and excitement, particularly with the emergence of innovative companies like Dexdert Net Pro Recovery leading the charge. As the cryptocurrency market continues to evolve and face new challenges, the need for effective solutions to help users recover lost or stolen Bitcoin has become increasingly critical. Dexdert Net Pro, a specialized firm dedicated to this very purpose, has positioned itself at the forefront of this emerging field. Through their proprietary techniques and deep expertise in blockchain technology, Dexdert Net Pro has developed a comprehensive approach to tracking down and retrieving misplaced or compromised Bitcoin, providing a lifeline to individuals and businesses who have fallen victim to the inherent risks of the digital currency landscape. Their team of seasoned investigators and cryptography experts employ a meticulous, multi-pronged strategy, leveraging advanced data analysis, forensic techniques, and collaborative partnerships with law enforcement to painstakingly trace the movement of lost or stolen coins, often recovering funds that would otherwise be considered irrecoverable. This pioneering work not only restores financial assets but also helps to bolster confidence and trust in the long-term viability of Bitcoin, cementing Dexdert Net Pro role as a crucial player in shaping the future of cryptocurrency recovery and security. As the digital finance ecosystem continues to evolve, the importance of innovative solutions like those offered by Dexdert Net Pro will only grow, ensuring that users can navigate the complexities of Bitcoin with greater peace of mind and protection. Call Dexdert Net Pro now     
    • I'm developing a dimension, but it's kinda resource intensive so some times during player teleporting it lags behind making the player phase down into the void, so im trying to implement some kind of pregeneration to force the game loading a small set of chunks in the are the player will teleport to. Some of the things i've tried like using ServerLevel and ServerChunkCache methods like getChunk() dont actually trigger chunk generation if the chunk isn't already on persistent storage (already generated) or placing tickets, but that doesn't work either. Ideally i should be able to check when the task has ended too. I've peeked around some pregen engines, but they're too complex for my current understanding of the system of which I have just a basic understanding (how ServerLevel ,ServerChunkCache  and ChunkMap work) of. Any tips or other classes I should be looking into to understand how to do this correctly?
    • https://mclo.gs/4UC49Ao
    • Way back in the Forge 1.17 days, work started for adding JPMS (Java Platform Module Support) to ModLauncher and ForgeModLoader. This has been used internally by Forge and some libraries for a while now, but mods (those with mods.toml specifically) have not been able to take advantage of it. As of Forge 1.21.1 and 1.21.3, this is now possible!   What is JPMS and what does it mean for modders? JPMS is the Java Platform Module System, introduced in Java 9. It allows you to define modules, which are collections of packages and resources that can be exported or hidden from other modules. This allows for much more fine-tuned control over visibility, cleaner syntax for service declarations and support for sealed types across packages. For example, you might have a mod with a module called `com.example.mod` that exports `com.example.mod.api` and `com.example.mod.impl` to other mods, but hides `com.example.mod.internal` from them. This would allow you to have a clean API for other mods to use, while keeping your internal implementation details hidden from IDE hints, helping prevent accidental usage of internals that might break without prior notice. This is particularly useful if you'd like to use public records with module-private constructors or partially module-private record components, as you can create a sealed interface that only your record implements, having the interface be exported and the record hidden. It's also nice for declaring and using services, as you'll get compile-time errors from the Java compiler for typos and the like, rather than deferring to runtime errors. In more advanced cases, you can also have public methods that are only accessible to specific other modules -- handy if you want internal interactions between multiple of your own mods.   How do I bypass it? We understand there may be drama in implementing a system that prevents mods from accessing each other's internals when necessary (like when a mod is abandoned or you need to fix a compat issue) -- after all, we are already modding a game that doesn't have explicit support for Java mods yet. We have already thought of this and are offering APIs from day one to selectively bypass module restrictions. Let me be clear: Forge mods are not required to use JPMS. If you don't want to use it, you don't have to. The default behaviour is to have fully open, fully exported automatic modules. In Java, you can use the `Add-Opens` and `Add-Exports` manifest attributes to selectively bypass module restrictions of other mods at launch time, and we've added explicit support for these when loading your Forge mods. At compile-time, you can use existing solutions such as the extra-java-module-info Gradle plugin to deal with non-modular dependencies and add extra opens and exports to other modules. Here's an example on how to make the internal package `com.example.examplemod.internal` open to your mod in your build.gradle: tasks.named('jar', Jar) { manifest { attributes([ 'Add-Opens' : 'com.example.examplemod/com.example.examplemod.internal' 'Specification-Title' : mod_id, 'Specification-Vendor' : mod_authors // (...) ]) } } With the above in your mod's jar manifest, you can now reflectively access the classes inside that internal package. Multiple entries are separated with a space, as per Java's official spec. You can also use Add-Exports to directly call without reflection, however you'd need to use the Gradle plugin mentioned earlier to be able to compile. The syntax for Add-Exports is the same as Add-Opens, and instructions for the compile-time step with the Gradle plugin are detailed later in this post. Remember to prefer the opens and exports keywords inside module-info.java for sources you control. The Add-Opens/Add-Exports attributes are only intended for forcing open other mods.   What else is new with module support? Previously, the runtime module name was always forced to the first mod ID in your `mods.toml` file and all packages were forced fully open and exported. Module names are now distinguished from mod IDs, meaning the module name in your module-info.java can be different from the mod ID in your `mods.toml`. This allows you to have a more descriptive module name that doesn't have to be the same as your mod ID, however we strongly recommend including your mod ID as part of your module name to aid troubleshooting. The `Automatic-Module-Name` manifest attribute is now also honoured, allowing you to specify a module name for your mod without needing to create a `module-info.java` file. This is particularly useful for mods that don't care about JPMS features but want to have a more descriptive module name and easier integration with other mods that do use JPMS.   How do I use it? The first step is to create a `module-info.java` file in your mod's source directory. This file should be in the same package as your main mod class, and should look something like this: open module com.example.examplemod { requires net.minecraftforge.eventbus; requires net.minecraftforge.fmlcore; requires net.minecraftforge.forge; requires net.minecraftforge.javafmlmod; requires net.minecraftforge.mergetool.api; requires org.slf4j; requires logging; } For now, we're leaving the whole module open to reflection, which is a good starting point. When we know we want to close something off, we can remove the open modifier from the module and open or export individual packages instead. Remember that you need to be open to Forge (module name net.minecraftforge.forge), otherwise it can't call your mod's constructor. Next is fixing modules in Gradle. While Forge and Java support modules properly, Gradle does not put automatic modules on the module path by default, meaning that the logging module (from com.mojang:logging) is not found. To fix this, add the Gradle plugin and add a compile-time module definition for that Mojang library: plugins { // (...) id 'org.gradlex.extra-java-module-info' version "1.9" } // (...) extraJavaModuleInfo { failOnMissingModuleInfo = false automaticModule("com.mojang:logging", "logging") } The automatic module override specified in your build.gradle should match the runtime one to avoid errors. You can do the same for any library or mod dependency that is missing either a module-info or explicit Automatic-Module-Name, however be aware that you may need to update your mod once said library adds one. That's all you need to get started with module support in your mods. You can learn more about modules and how to use them at dev.java.
    • Faire la mise à jour grâce à ce lien m'a aider personnellement, merci à @Paint_Ninja. https://www.amd.com/en/support 
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.