Jump to content

Data Gen - Block Model from JSON template throws error


Recommended Posts

Posted (edited)

I am trying to generate my block models with Data Generators which I incounter this error.

 

It's easy to spot why this error occurs ("block/minecraft:sand", ':' triggers the error) but I don't understand where this error could come from by looking at my code.

 

Since I have a few variants of the same block, I've replicated Minecraft's way by defining a template JSON for my variant and simply have my block use it as a parent and add a texture.

Heres what I have:

    private void generateSiltBlockFenceGateFromTemplate(SiltFenceGateBlock gate) {
        String texture = Objects.requireNonNull(gate.getParentBlock().getRegistryName()).toString();

        getVariantBuilder(gate).forAllStatesExcept(state -> {
                String base = "silt_fence_gate" + (state.get(OPEN) ? "_open_" : "_close_") + state.get(AbstractSiltBarrierBlock.LAYER);
                if (state.get(IN_WALL)) base = base + "_in_wall"; 
                // <base> would look like "silt_fence_gate_close_1"

                ModelBuilder<?> model = models()
                        .withExistingParent(texture + "_" + base, modLoc("block/template_" + base))
                        .texture("texture", mcLoc("block/" + texture)) // <--- stacktrace points here
                        .element().end();

                int rotation = (int) state.get(HORIZONTAL_FACING).getHorizontalAngle();
                return ConfiguredModel.builder().modelFile(model).uvLock(true).rotationY(rotation).build();
            },
            WATERLOGGED
        );
    }

 

I've also tried to feed it a texture as a string directly but to no avail:

                        .texture("texture", "block/" + texture) // <--- stacktrace points here

 

What I expect is sand_silt_fence_gate_close_1.json:

{
  "parent": "siltsand:block/template_silt_fence_gate_close_1"
  "textures": {
  	"texture": "sand"
  }
}

 

Here's my template JSON: template_silt_fence_gate_close_1.json:

{
  "parent": "block/block",
  "textures": {
    "particle": "#texture"
  },
  "elements": [
    {
      "from": [ 14, 0, 7 ],
      "to": [ 16, 1, 9 ],
      "faces": {
        "north": { "uv": [ 0, 0, 2, 1 ], "texture": "#texture" },
        "east":  { "uv": [ 0, 0, 2, 1 ], "texture": "#texture" },
        "south": { "uv": [ 0, 0, 2, 1 ], "texture": "#texture" },
        "west":  { "uv": [ 0, 0, 2, 1 ], "texture": "#texture" },
        "up":    { "uv": [ 0, 0, 2, 2 ], "texture": "#texture" }
      }
    },
    {
      "from": [ 0, 0, 7 ],
      "to": [ 2, 1, 9 ],
      "faces": {
        "north": { "uv": [ 0, 0, 2, 1 ], "texture": "#texture" },
        "east":  { "uv": [ 0, 0, 2, 1 ], "texture": "#texture" },
        "south": { "uv": [ 0, 0, 2, 1 ], "texture": "#texture" },
        "west":  { "uv": [ 0, 0, 2, 1 ], "texture": "#texture" },
        "up":    { "uv": [ 0, 0, 2, 2 ], "texture": "#texture" }
      }
    },
    {
      "from": [ 2, -1, 7 ],
      "to": [ 14, 0, 9 ],
      "faces": {
        "up":    { "uv": [ 0, 0, 12, 2 ], "texture": "#texture" },
        "north": { "uv": [ 0, 0, 12, 1 ], "texture": "#texture" },
        "south": { "uv": [ 0, 0, 12, 1 ], "texture": "#texture" },
        "west":  { "uv": [ 0, 0, 2, 1 ], "texture": "#texture" },
        "east":  { "uv": [ 0, 0, 2, 1 ], "texture": "#texture" }
      }
    },
    {
      "from": [ 10, -7, 7 ],
      "to": [ 14, -6, 9 ],
      "faces": {
        "up":    { "uv": [ 0, 0, 4, 2 ], "texture": "#texture" },
        "north": { "uv": [ 0, 0, 4, 1 ], "texture": "#texture" },
        "south": { "uv": [ 0, 0, 4, 1 ], "texture": "#texture" },
        "west":  { "uv": [ 0, 0, 2, 1 ], "texture": "#texture" },
        "east":  { "uv": [ 0, 0, 2, 1 ], "texture": "#texture" }
      }
    },
    {
      "from": [ 2, -7, 7 ],
      "to": [ 6, -6, 9 ],
      "faces": {
        "up":    { "uv": [ 0, 0, 4, 2 ], "texture": "#texture" },
        "north": { "uv": [ 0, 0, 4, 1 ], "texture": "#texture" },
        "south": { "uv": [ 0, 0, 4, 1 ], "texture": "#texture" },
        "west":  { "uv": [ 0, 0, 2, 1 ], "texture": "#texture" },
        "east":  { "uv": [ 0, 0, 2, 1 ], "texture": "#texture" }
      }
    }
  ]
}

I have read that maybe this might be caused by invalid JSON but that has been checked too.

 

Any idea why this happens? 

 

PS: I am new to Data Gens so it is very likely that I using the builder wrong.

Edited by than00ber1
added further explanation
  • than00ber1 changed the title to Data Gen - Block Model from JSON template throws error

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

  Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

  Your link has been automatically embedded.   Display as a link instead

  Your previous content has been restored.   Clear editor

  You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hey there! I removed Bobby as Pyralis suggested and found that I still had that and a another closely related bug (or same bug, different presentation) wherein a torch only illuminates its own block and gets smoothed 1 block out, then gone.   After comparing your modlist to mine (I'm on fabric, also 1.20.1) I found we had 2 mods with the same versions. Mine || Yours Bobby-5.0.1.jar ||bobby-1.20.1_v5.0.1.jar ImmediatelyFast-Fabric-1.2.17+1.20.4.jar || ImmediatelyFast-Forge-1.2.17+1.20.4.jar Removing ImmediatelyFast.. immediately (馃槈) seems to have fixed the issue. Since it's client only- no new world needed either! To note, I also removed all mods related to or containing direct requirements for Sodium, Indium and Iris which may have played a role, I did not test with re-adding.
    • For anyone still looking for the equivalent for 1.19.2+, the render type should be set for the model. In datagen, this can be done by using ModelBuilder::renderType, otherwise just add the line directly to the json file. As for the validity of this question, the idiomatic solution is presented nowhere online; ModelBuilder::renderType is never addressed when discussing block render types meaning that the solution I have provided is the first mentioned usage. Furthermore, there are no external references to this function meaning that to discover its existence requires a deep search through Forge's code. Therefore it is not only understandable but expected that most beginner modders would struggle to find this function given the already poor documentation of Forge's API.
    • Same issue without voicechat?
    • Start by following the docs to get a workspace setup: https://docs.minecraftforge.net/en/latest/gettingstarted/ Then poke around some of the tutorials, https://www.mcjty.eu/docs/1.20/ used to be the goto, but not sure if there are any updates for regular forge or not, but if you've brushed up on Java, it will be enough to get you started. Poke around the Minecraft and Forge sources to see how things are done. Read the FAQ for information on how to post code/logs when you run into issues. Share as much info on issues you have as possible. Use github to host projects, chances of someone helping are higher when they can actually see all your code and/or build it themselves. And finally, keep it on the forums, don't direct message people with questions, most people do not provide personal support like that. Also keep in mind forums posts are not always immediately answered, if you're looking for a quicker response, you can always try the Minecraft Forge discord server.
    • Hello, I have a Forge Minecraft sever (I host it at g-portal.com) which has always worked fine and I had no problems, but today it doesn't wanna work anymore. Today I started the server and the status said online, but after a few seconds it said this: "Start failed". And then out of nowhere it restarted itself and the same thing happened again and again and now it's in an infinite loop where it just keeps failing and then restarts. Here's the download link for the server logs: https://www.mediafire.com/file/sq30dgoonjevib1/2025-07-06-1.log/file Does anyone know how to fix this? If yes I would really appreciate help. Best wishes, Gabs1107
  • Topics

  • Create New...

Important Information

By using this site, you agree to our Terms of Use.