Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

Data Gen - Block Model from JSON template throws error


than00ber1
 Share

Recommended Posts

I am trying to generate my block models with Data Generators which I incounter this error.

 

It's easy to spot why this error occurs ("block/minecraft:sand", ':' triggers the error) but I don't understand where this error could come from by looking at my code.

 

Since I have a few variants of the same block, I've replicated Minecraft's way by defining a template JSON for my variant and simply have my block use it as a parent and add a texture.

Heres what I have:

    private void generateSiltBlockFenceGateFromTemplate(SiltFenceGateBlock gate) {
        String texture = Objects.requireNonNull(gate.getParentBlock().getRegistryName()).toString();

        getVariantBuilder(gate).forAllStatesExcept(state -> {
                String base = "silt_fence_gate" + (state.get(OPEN) ? "_open_" : "_close_") + state.get(AbstractSiltBarrierBlock.LAYER);
                if (state.get(IN_WALL)) base = base + "_in_wall"; 
                // <base> would look like "silt_fence_gate_close_1"

                ModelBuilder<?> model = models()
                        .withExistingParent(texture + "_" + base, modLoc("block/template_" + base))
                        .texture("texture", mcLoc("block/" + texture)) // <--- stacktrace points here
                        .element().end();

                int rotation = (int) state.get(HORIZONTAL_FACING).getHorizontalAngle();
                return ConfiguredModel.builder().modelFile(model).uvLock(true).rotationY(rotation).build();
            },
            WATERLOGGED
        );
    }

 

I've also tried to feed it a texture as a string directly but to no avail:

                        .texture("texture", "block/" + texture) // <--- stacktrace points here

 

What I expect is sand_silt_fence_gate_close_1.json:

{
  "parent": "siltsand:block/template_silt_fence_gate_close_1"
  "textures": {
  	"texture": "sand"
  }
}

 

Here's my template JSON: template_silt_fence_gate_close_1.json:

{
  "parent": "block/block",
  "textures": {
    "particle": "#texture"
  },
  "elements": [
    {
      "from": [ 14, 0, 7 ],
      "to": [ 16, 1, 9 ],
      "faces": {
        "north": { "uv": [ 0, 0, 2, 1 ], "texture": "#texture" },
        "east":  { "uv": [ 0, 0, 2, 1 ], "texture": "#texture" },
        "south": { "uv": [ 0, 0, 2, 1 ], "texture": "#texture" },
        "west":  { "uv": [ 0, 0, 2, 1 ], "texture": "#texture" },
        "up":    { "uv": [ 0, 0, 2, 2 ], "texture": "#texture" }
      }
    },
    {
      "from": [ 0, 0, 7 ],
      "to": [ 2, 1, 9 ],
      "faces": {
        "north": { "uv": [ 0, 0, 2, 1 ], "texture": "#texture" },
        "east":  { "uv": [ 0, 0, 2, 1 ], "texture": "#texture" },
        "south": { "uv": [ 0, 0, 2, 1 ], "texture": "#texture" },
        "west":  { "uv": [ 0, 0, 2, 1 ], "texture": "#texture" },
        "up":    { "uv": [ 0, 0, 2, 2 ], "texture": "#texture" }
      }
    },
    {
      "from": [ 2, -1, 7 ],
      "to": [ 14, 0, 9 ],
      "faces": {
        "up":    { "uv": [ 0, 0, 12, 2 ], "texture": "#texture" },
        "north": { "uv": [ 0, 0, 12, 1 ], "texture": "#texture" },
        "south": { "uv": [ 0, 0, 12, 1 ], "texture": "#texture" },
        "west":  { "uv": [ 0, 0, 2, 1 ], "texture": "#texture" },
        "east":  { "uv": [ 0, 0, 2, 1 ], "texture": "#texture" }
      }
    },
    {
      "from": [ 10, -7, 7 ],
      "to": [ 14, -6, 9 ],
      "faces": {
        "up":    { "uv": [ 0, 0, 4, 2 ], "texture": "#texture" },
        "north": { "uv": [ 0, 0, 4, 1 ], "texture": "#texture" },
        "south": { "uv": [ 0, 0, 4, 1 ], "texture": "#texture" },
        "west":  { "uv": [ 0, 0, 2, 1 ], "texture": "#texture" },
        "east":  { "uv": [ 0, 0, 2, 1 ], "texture": "#texture" }
      }
    },
    {
      "from": [ 2, -7, 7 ],
      "to": [ 6, -6, 9 ],
      "faces": {
        "up":    { "uv": [ 0, 0, 4, 2 ], "texture": "#texture" },
        "north": { "uv": [ 0, 0, 4, 1 ], "texture": "#texture" },
        "south": { "uv": [ 0, 0, 4, 1 ], "texture": "#texture" },
        "west":  { "uv": [ 0, 0, 2, 1 ], "texture": "#texture" },
        "east":  { "uv": [ 0, 0, 2, 1 ], "texture": "#texture" }
      }
    }
  ]
}

I have read that maybe this might be caused by invalid JSON but that has been checked too.

 

Any idea why this happens? 

 

PS: I am new to Data Gens so it is very likely that I using the builder wrong.

Edited by than00ber1
added further explanation
Link to comment
Share on other sites

  • than00ber1 changed the title to Data Gen - Block Model from JSON template throws error

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • public static void onPlayerCloned(PlayerEvent.Clone event) { if (!event.getOriginal().world.isRemote() && !event.getPlayer().world.isRemote() && event.getOriginal() != null && event.getPlayer() != null) { LazyOptional<IMindCapability> oldMindCap = event.getOriginal().getCapability(LibCapabilities.MIND_CAPABILITY); LazyOptional<IMindCapability> newMindCap = event.getPlayer().getCapability(LibCapabilities.MIND_CAPABILITY); if (oldMindCap.isPresent() && newMindCap.isPresent()) { newMindCap.ifPresent(capability -> { oldMindCap.ifPresent(capabilityOld -> { event.getPlayer().sendMessage(new StringTextComponent("Before: " + capability.getMindStrength()), CommonProxy.IN_GAME_UUID); capability.deserializeNBT(capabilityOld.serializeNBT()); event.getPlayer().sendMessage(new StringTextComponent("After: " + capability.getMindStrength()), CommonProxy.IN_GAME_UUID); }); // This don't work, the value on the client side is still the initial value SCPacketHandler.INSTANCE.send(PacketDistributor.PLAYER.with(() -> (ServerPlayerEntity) event.getPlayer()), new MSGMindCapabilitySync(capability.getMindStrength())); // It works,the value on the client side is correct, but I don't know why, I think it's just a coincidence. // SCPacketHandler.INSTANCE.sendToServer(new MSGMindCapabilitySync(capability.getMindStrength())); }); } } }   This is my message code. public class MSGMindCapabilitySync { private final int mindStrength; public MSGMindCapabilitySync(int mindStrength) { this.mindStrength = mindStrength; } public static void encodingMSG(MSGMindCapabilitySync msg, PacketBuffer buffer) { buffer.writeInt(msg.mindStrength); } public static MSGMindCapabilitySync decodingMSG(PacketBuffer buffer) { return new MSGMindCapabilitySync(buffer.readInt()); } public static void handle(MSGMindCapabilitySync msg, Supplier<NetworkEvent.Context> ctx) { ctx.get().enqueueWork(() -> { // Form client to server ServerPlayerEntity serverPlayer = ctx.get().getSender(); if (serverPlayer != null) { serverPlayer.getCapability(LibCapabilities.MIND_CAPABILITY).ifPresent((capability -> { capability.setMindStrength(msg.mindStrength); })); SaintChapter.LOGGER.info("Form client to server. Done"); } // From server to client DistExecutor.unsafeRunWhenOn(Dist.CLIENT, () -> () -> { if (Minecraft.getInstance().player == null) return; Minecraft.getInstance().player.getCapability(LibCapabilities.MIND_CAPABILITY).ifPresent((capability -> { capability.setMindStrength(msg.mindStrength); })); SaintChapter.LOGGER.info("From server to client. Done"); }); }); ctx.get().setPacketHandled(true); } }
    • I don't know what you used to post the log here, but next time please upload the log to a paste site, this is horrible to look at with all the formatting removed One of your server configs is failing to load properly, if you have not modified it delete ironfurnaces-server.toml
    • Did you download the server-specific files for the pack or did you copy the mods from the client and hope?
    • 1.12 is no longer supported on this forum. Please update to a modern version of Minecraft to receive support.
    • [18:32:34] [Server thread/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Configuration file .\saves\New World (2)\serverconfig\forge-server.toml is not correct. Correcting [18:32:34] [Server thread/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key server was corrected from null to its default, SimpleCommentedConfig:{   Using that code and before I get that. And my mob still don't work.
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.