Jump to content

[SOLVED]Changing NBTTagName on Keypress


Taji34
 Share

Recommended Posts

Okay, so I am trying to get the name of a NBTTag to change when I press a key, however when I press the key the name is not changing. I have it print the name to the console on right click, but the name just stays at what it was initialized at. Here is my code:

 

Baton.java:

package taji34.troncraft;
import cpw.mods.fml.client.registry.KeyBindingRegistry.KeyHandler;
import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;
import net.minecraft.client.renderer.texture.IconRegister;
import net.minecraft.client.settings.KeyBinding;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTBase;
import net.minecraft.nbt.NBTTagByte;
import net.minecraft.nbt.NBTTagString;
import net.minecraft.world.World;
public class Baton extends Item {
public Baton(int par1) {
	super(par1);
	setMaxStackSize(1);
	setCreativeTab(CreativeTabs.tabMisc);
	setUnlocalizedName("Baton");
}
NBTTagByte data = new NBTTagByte("Test1");
    @Override
    @SideOnly(Side.CLIENT)
    public void registerIcons(IconRegister iconRegister) {
        this.itemIcon = iconRegister.registerIcon("Troncraft:Baton");
    }
public static KeyBinding mode = new KeyBinding("Baton Staff Mode", 36);   
public void keyboardEvent(KeyBinding keybinding)
    {
		if(keybinding == mode)
		{	
			if(!(data.getName().equals("Test2"))){
				data.setName("Test2");
			}
		}
    }
    
    public ItemStack onItemRightClick(ItemStack par1ItemStack, World par2World, EntityPlayer par3EntityPlayer)
    {
       System.out.println(data.getName());
    	return par1ItemStack;
    }
    
}

 

Troncraft.java:

package taji34.troncraft;
import net.minecraft.block.Block;
import net.minecraft.client.renderer.entity.RenderSnowball;
import net.minecraft.client.renderer.entity.RenderManager;
import net.minecraft.client.settings.KeyBinding;
import net.minecraft.entity.projectile.EntitySnowball;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.src.ModLoader;
import cpw.mods.fml.client.registry.KeyBindingRegistry;
import cpw.mods.fml.client.registry.KeyBindingRegistry.KeyHandler;
import cpw.mods.fml.client.registry.RenderingRegistry;
import cpw.mods.fml.common.Mod;
import cpw.mods.fml.common.Mod.EventHandler;
import cpw.mods.fml.common.Mod.Init;
import cpw.mods.fml.common.Mod.Instance;
import cpw.mods.fml.common.Mod.PostInit;
import cpw.mods.fml.common.Mod.PreInit;
import cpw.mods.fml.common.SidedProxy;
import cpw.mods.fml.common.event.FMLInitializationEvent;
import cpw.mods.fml.common.event.FMLPostInitializationEvent;
import cpw.mods.fml.common.event.FMLPreInitializationEvent;
import cpw.mods.fml.common.network.NetworkMod;
import cpw.mods.fml.common.registry.EntityRegistry;
import cpw.mods.fml.common.registry.GameRegistry;
import cpw.mods.fml.common.registry.LanguageRegistry;
@Mod(modid="Troncraft", name="Troncraft", version="0.0.1")
@NetworkMod(clientSideRequired=true, serverSideRequired=false)
public class Troncraft {
        // The instance of your mod that Forge uses.
        @Instance("Troncraft")
        public static Troncraft instance;
        public final static Item identityDisk = new IdentityDisk(5001);
        int diskItemID = identityDisk.itemID;
    	private final static Item baton = new Baton(5002);
    	int batonItemID = baton.itemID;
    	KeyBinding[] bindings = { Baton.mode };
    	TajiKeyHandler keyHandler;
        // Says where the client and server 'proxy' code is loaded.
        @SidedProxy(clientSide="taji34.troncraft.client.ClientProxy", serverSide="taji34.troncraft.CommonProxy")
        public static CommonProxy proxy;
        @EventHandler
        public void preInit(FMLPreInitializationEvent event) {
                // Stub Method
        }
        @EventHandler
        public void load(FMLInitializationEvent event) {
            LanguageRegistry.addName(identityDisk, "Identity Disk");
            LanguageRegistry.addName(baton, "Baton");
            EntityRegistry.registerModEntity(EntityIdentityDisk.class, "IdentityDisk", 5001, this, 40, 3, true);
            RenderingRegistry.registerEntityRenderingHandler(EntityIdentityDisk.class, new RenderSnowball(identityDisk));
        	keyHandler = new TajiKeyHandler(bindings);
        	KeyBindingRegistry.registerKeyBinding(keyHandler);
        }
        @EventHandler
        public void postInit(FMLPostInitializationEvent event) {
                // Stub Method
        }
}

 

Any ideas? Am I doing something wrong?

Link to comment
Share on other sites

First of all: Don't store that value in your Item class. Only one instance exists of the Item class, so if you store something there it will be always the same for all Items of that type.

You need to store your stuff in the ItemStack, each ItemStack has a NBTTagCompound attached to it.

Also you can't directly change the values from your KeyHandler because a KeyHandler is client-sided. The client should never change something about the world or inventories or anything, because the server (who is always "the boss") will never get to know about it and eventually your changes will be reverted.

The way around this is to send a custom Packet when your key is pressed and then alter the ItemStack on the server side.

Link to comment
Share on other sites

So do I have the NBT data in the right place now?

package taji34.troncraft;
import java.io.ByteArrayOutputStream;
import java.io.DataOutputStream;

import cpw.mods.fml.client.registry.KeyBindingRegistry.KeyHandler;
import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;
import net.minecraft.client.renderer.texture.IconRegister;
import net.minecraft.client.settings.KeyBinding;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTBase;
import net.minecraft.nbt.NBTTagByte;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagString;
import net.minecraft.network.packet.Packet250CustomPayload;
import net.minecraft.world.World;
public class Baton extends Item {
public Baton(int par1) {
	super(par1);
	setMaxStackSize(1);
	setCreativeTab(CreativeTabs.tabMisc);
	setUnlocalizedName("Baton");
}
    @Override
    @SideOnly(Side.CLIENT)
    public void registerIcons(IconRegister iconRegister) {
        this.itemIcon = iconRegister.registerIcon("Troncraft:Baton");
    }
public static KeyBinding mode = new KeyBinding("Baton Staff Mode", 36);   
public void keyboardEvent(KeyBinding keybinding)
    {
		if(keybinding == mode)
		{	

		}
    }
    
    public ItemStack onItemRightClick(ItemStack par1ItemStack, World par2World, EntityPlayer par3EntityPlayer)
    {
    	NBTTagCompound tag = par1ItemStack.getTagCompound();
    	if (tag == null) {
    		tag = new NBTTagCompound();
    		par1ItemStack.setTagCompound(tag);
    	}
    	if (tag.getName().equals("tag")) {
    		tag.setName("Test1");
    	}
    	System.out.println(tag.getName());
    	return par1ItemStack;
    }
    
}

Link to comment
Share on other sites

to send a packet check the wiki for packet handling

 

to send lines of code... i HIGHLY doubt you want to do that. so since you're asking the question im assuming the knowledge for this is WAY out of your reach and even if you knew how to do it you probably never want to do this as theres is SURELY another way

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

to send a packet check the wiki for packet handling

 

to send lines of code... i HIGHLY doubt you want to do that. so since you're asking the question im assuming the knowledge for this is WAY out of your reach and even if you knew how to do it you probably never want to do this as theres is SURELY another way

 

I'm new to coding, so that was the first thing I thought of. I'm trying to change the name of a tag in an itemstack, but I can't seem to think of a way to tell the server to do that.

Link to comment
Share on other sites

[shadow=red,left][shadow=red,left]to send a packet check the wiki for packet handling[/shadow][/shadow]

I meant what to send in the packet, I understand I need to send a packet to the server. I guess i'll just have to put a bit more thought into it.

Link to comment
Share on other sites

Never let the client tell the server what to do. Only tell the server what the use has done, then let the server decide what to do with that.

Example:

Don't send a packet to change NBT, but send a packet to tell the server that a key was pressed.

 

Then the server decides if the player was allowed to press the key, if he is holding the right item, etc. etc. (validation is all, Clients always lie to you, never trust them!).

After that it changes the NBT (or does whatever).

 

I highly suggest my tutorial as a followup to the Packet Handling tutorial on the wiki: www.minecraftforge.net/wiki/Advanced_Packet_Handling

 

Link to comment
Share on other sites

Never let the client tell the server what to do. Only tell the server what the use has done, then let the server decide what to do with that.

Example:

Don't send a packet to change NBT, but send a packet to tell the server that a key was pressed.

 

Then the server decides if the player was allowed to press the key, if he is holding the right item, etc. etc. (validation is all, Clients always lie to you, never trust them!).

After that it changes the NBT (or does whatever).

 

I highly suggest my tutorial as a followup to the Packet Handling tutorial on the wiki: www.minecraftforge.net/wiki/Advanced_Packet_Handling

 

Thank You! I was just about to post because I couldn't figure out how to send a packet from a keypress, but what you suggested makes more sense!

Link to comment
Share on other sites

Okay, so I have hit a snag. My key binding is registered in the game options, but when I press it, it does nothing. I currently have it print "Hi" to the console for troubleshooting purposes, but it is not working. Here is my code:

 

Troncraft.java:

package taji34.troncraft;
import net.minecraft.block.Block;
import net.minecraft.client.renderer.entity.RenderSnowball;
import net.minecraft.client.renderer.entity.RenderManager;
import net.minecraft.client.settings.KeyBinding;
import net.minecraft.entity.projectile.EntitySnowball;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.src.ModLoader;
import cpw.mods.fml.client.registry.KeyBindingRegistry;
import cpw.mods.fml.client.registry.KeyBindingRegistry.KeyHandler;
import cpw.mods.fml.client.registry.RenderingRegistry;
import cpw.mods.fml.common.Mod;
import cpw.mods.fml.common.Mod.EventHandler;
import cpw.mods.fml.common.Mod.Init;
import cpw.mods.fml.common.Mod.Instance;
import cpw.mods.fml.common.Mod.PostInit;
import cpw.mods.fml.common.Mod.PreInit;
import cpw.mods.fml.common.SidedProxy;
import cpw.mods.fml.common.event.FMLInitializationEvent;
import cpw.mods.fml.common.event.FMLPostInitializationEvent;
import cpw.mods.fml.common.event.FMLPreInitializationEvent;
import cpw.mods.fml.common.network.NetworkMod;
import cpw.mods.fml.common.registry.EntityRegistry;
import cpw.mods.fml.common.registry.GameRegistry;
import cpw.mods.fml.common.registry.LanguageRegistry;
@Mod(modid="Troncraft", name="Troncraft", version="0.0.1")
@NetworkMod(clientSideRequired=true, serverSideRequired=false, channels={"Baton"}, packetHandler = TajiPacketHandler.class)
public class Troncraft {
        // The instance of your mod that Forge uses.
        @Instance("Troncraft")
        public static Troncraft instance;
        public final static Item identityDisk = new IdentityDisk(5001);
        int diskItemID = identityDisk.itemID;
    	private final static Item baton = new Baton(5002);
    	int batonItemID = baton.itemID;
    	KeyBinding[] bindings = { Baton.mode };
    	TajiKeyHandler keyHandler;
        // Says where the client and server 'proxy' code is loaded.
        @SidedProxy(clientSide="taji34.troncraft.client.ClientProxy", serverSide="taji34.troncraft.CommonProxy")
        public static CommonProxy proxy;
        @EventHandler
        public void preInit(FMLPreInitializationEvent event) {
                // Stub Method
        }
        @EventHandler
        public void load(FMLInitializationEvent event) {
            LanguageRegistry.addName(identityDisk, "Identity Disk");
            LanguageRegistry.addName(baton, "Baton");
            EntityRegistry.registerModEntity(EntityIdentityDisk.class, "IdentityDisk", 5001, this, 40, 3, true);
            RenderingRegistry.registerEntityRenderingHandler(EntityIdentityDisk.class, new RenderSnowball(identityDisk));
        	keyHandler = new TajiKeyHandler(bindings);
        	KeyBindingRegistry.registerKeyBinding(keyHandler);
        }
        @EventHandler
        public void postInit(FMLPostInitializationEvent event) {
                // Stub Method
        }
}

 

Baton.java:

package taji34.troncraft;
import java.io.ByteArrayOutputStream;
import java.io.DataOutputStream;

import cpw.mods.fml.client.registry.KeyBindingRegistry.KeyHandler;
import cpw.mods.fml.common.network.PacketDispatcher;
import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;
import net.minecraft.client.entity.EntityClientPlayerMP;
import net.minecraft.client.renderer.texture.IconRegister;
import net.minecraft.client.settings.KeyBinding;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.player.EntityPlayerMP;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTBase;
import net.minecraft.nbt.NBTTagByte;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagString;
import net.minecraft.network.packet.Packet250CustomPayload;
import net.minecraft.world.World;
public class Baton extends Item {
public Baton(int par1) {
	super(par1);
	setMaxStackSize(1);
	setCreativeTab(CreativeTabs.tabMisc);
	setUnlocalizedName("Baton");
}
    @Override
    @SideOnly(Side.CLIENT)
    public void registerIcons(IconRegister iconRegister) {
        this.itemIcon = iconRegister.registerIcon("Troncraft:Baton");
    }
public static KeyBinding mode = new KeyBinding("Baton Staff Mode", 36);   
public void keyboardEvent(KeyBinding keybinding)
    {
		if(keybinding == mode)
		{	
			System.out.println("Hi");
			//PacketDispatcher.sendPacketToServer(new BatonModePacket("Hello World!").makePacket());
		}
    }
    
    public ItemStack onItemRightClick(ItemStack par1ItemStack, World par2World, EntityPlayer par3EntityPlayer)
    {
    	NBTTagCompound tag = par1ItemStack.getTagCompound();
    	if (tag == null) {
    		tag = new NBTTagCompound();
    		par1ItemStack.setTagCompound(tag);
    	}
    	if (tag.getName().equals("tag")) {
    		tag.setName("Test1");
    	}
    	System.out.println(tag.getName());
    	return par1ItemStack;
    }
    
}

 

TajiKeyHandler.java:

package taji34.troncraft;

import java.util.EnumSet;

import net.minecraft.client.settings.KeyBinding;
import cpw.mods.fml.client.registry.KeyBindingRegistry.KeyHandler;
import cpw.mods.fml.common.TickType;

public class TajiKeyHandler extends KeyHandler {

public TajiKeyHandler(KeyBinding[] keyBindings, boolean[] isRepeat) {
	super(keyBindings, isRepeat);
}
public TajiKeyHandler(KeyBinding[] keyBindings) {
	super(keyBindings);
}
@Override
public String getLabel() {
	return "Taji's Keys";
}

@Override
public void keyDown(EnumSet<TickType> types, KeyBinding kb,
		boolean tickEnd, boolean isRepeat) {
	// TODO Auto-generated method stub

}

@Override
public void keyUp(EnumSet<TickType> types, KeyBinding kb, boolean tickEnd) {
	// TODO Auto-generated method stub

}

@Override
public EnumSet<TickType> ticks() {
	// TODO Auto-generated method stub
	return null;
}
}

 

I've tried to follow stuff on how to make a keybinding, but none of the stuff I found was very detailed, so I think I might have missed something.

Link to comment
Share on other sites

Well, your key handler contains nothing but empty methods, how is it supposed to do something? :P

You probably forgot to call Baton#keyboardEvent from the KeyHandler.

 

I though it might be the empty methods, but nothing I found really specified what to put in those methods farther than "Put what you want it to do when a button is pressed here" which didn't really help me.

Link to comment
Share on other sites

welll ... what do you want to happen when a button is pressed ... print penis on the console ?

System.out.println("penis");

 

open a gui ?

player.openGui(args);

 

send a packet to the server ?

 

MyMod.sendPacektForKeyPress(args);

 

etc

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

welll ... what do you want to happen when a button is pressed ... print penis on the console ?

System.out.println("penis");

 

open a gui ?

player.openGui(args);

 

send a packet to the server ?

 

MyMod.sendPacektForKeyPress(args);

 

etc

 

Okay, but how does it know what to do for different key presses? Do I specify that myself?

Link to comment
Share on other sites

Okay, so apparently I don't have it all figured out. Cause it still isn't working :/ Here are the changes to my code I've made:

In TajiKeyHandler.java:

	@Override
public void keyDown(EnumSet<TickType> types, KeyBinding kb,
		boolean tickEnd, boolean isRepeat) {
	if(kb == Baton.mode)
	{	
		System.out.println("Hi");
		//PacketDispatcher.sendPacketToServer(new BatonModePacket("Hello World!").makePacket());
	}

}

@Override
public void keyUp(EnumSet<TickType> types, KeyBinding kb, boolean tickEnd) {
	if(kb == Baton.mode)
	{	
		System.out.println("Hi");
		//PacketDispatcher.sendPacketToServer(new BatonModePacket("Hello World!").makePacket());
	}

}

@Override
public EnumSet<TickType> ticks() {
	// TODO Auto-generated method stub
	return null;
}
}

I think I must be doing something wrong still here, do I need to put something in ENumSet<TickType> ticks()?

 

In Baton.java:

public static KeyBinding mode = new KeyBinding("Baton Staff Mode", 36);  

This is the only thing concerning key binding in this class now.

 

My main method hasn't changed but I'll post it anyway:

Troncraft.java:

package taji34.troncraft;
import net.minecraft.block.Block;
import net.minecraft.client.renderer.entity.RenderSnowball;
import net.minecraft.client.renderer.entity.RenderManager;
import net.minecraft.client.settings.KeyBinding;
import net.minecraft.entity.projectile.EntitySnowball;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.src.ModLoader;
import cpw.mods.fml.client.registry.KeyBindingRegistry;
import cpw.mods.fml.client.registry.KeyBindingRegistry.KeyHandler;
import cpw.mods.fml.client.registry.RenderingRegistry;
import cpw.mods.fml.common.Mod;
import cpw.mods.fml.common.Mod.EventHandler;
import cpw.mods.fml.common.Mod.Init;
import cpw.mods.fml.common.Mod.Instance;
import cpw.mods.fml.common.Mod.PostInit;
import cpw.mods.fml.common.Mod.PreInit;
import cpw.mods.fml.common.SidedProxy;
import cpw.mods.fml.common.event.FMLInitializationEvent;
import cpw.mods.fml.common.event.FMLPostInitializationEvent;
import cpw.mods.fml.common.event.FMLPreInitializationEvent;
import cpw.mods.fml.common.network.NetworkMod;
import cpw.mods.fml.common.registry.EntityRegistry;
import cpw.mods.fml.common.registry.GameRegistry;
import cpw.mods.fml.common.registry.LanguageRegistry;
@Mod(modid="Troncraft", name="Troncraft", version="0.0.1")
@NetworkMod(clientSideRequired=true, serverSideRequired=false, channels={"Baton"}, packetHandler = TajiPacketHandler.class)
public class Troncraft {
        // The instance of your mod that Forge uses.
        @Instance("Troncraft")
        public static Troncraft instance;
        public final static Item identityDisk = new IdentityDisk(5001);
        int diskItemID = identityDisk.itemID;
    	private final static Item baton = new Baton(5002);
    	int batonItemID = baton.itemID;
    	KeyBinding[] bindings = { Baton.mode };
    	TajiKeyHandler keyHandler;
        // Says where the client and server 'proxy' code is loaded.
        @SidedProxy(clientSide="taji34.troncraft.client.ClientProxy", serverSide="taji34.troncraft.CommonProxy")
        public static CommonProxy proxy;
        @EventHandler
        public void preInit(FMLPreInitializationEvent event) {
                // Stub Method
        }
        @EventHandler
        public void load(FMLInitializationEvent event) {
            LanguageRegistry.addName(identityDisk, "Identity Disk");
            LanguageRegistry.addName(baton, "Baton");
            EntityRegistry.registerModEntity(EntityIdentityDisk.class, "IdentityDisk", 5001, this, 40, 3, true);
            RenderingRegistry.registerEntityRenderingHandler(EntityIdentityDisk.class, new RenderSnowball(identityDisk));
        	keyHandler = new TajiKeyHandler(bindings);
        	KeyBindingRegistry.registerKeyBinding(keyHandler);
        }
        @EventHandler
        public void postInit(FMLPostInitializationEvent event) {
                // Stub Method
        }
}

Maybe I'm missing something here? I don't think so, because the key binding shows up in game, but since I'm new to this I'm not going to assume anything.

Link to comment
Share on other sites

well for 1, dont put the same thing in both keyDown and keyUp because itll happen twice (unless that what you want)

 

and 2

 

try this

@Override
public void keyDown(EnumSet<TickType> types, KeyBinding kb,
		boolean tickEnd, boolean isRepeat) {
                System.out.println("i happened");
	if(kb == Baton.mode)
	{	
		System.out.println("Hi");
		//PacketDispatcher.sendPacketToServer(new BatonModePacket("Hello World!").makePacket());
	}

}

 

if "i happened" prints, you have pressed the correct key and registered the keyhandler correctly,

if "hi" doesnt print then kb != Baton.mode

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

well for 1, dont put the same thing in both keyDown and keyUp because itll happen twice (unless that what you want)

 

and 2

 

try this

@Override
public void keyDown(EnumSet<TickType> types, KeyBinding kb,
		boolean tickEnd, boolean isRepeat) {
                System.out.println("i happened");
	if(kb == Baton.mode)
	{	
		System.out.println("Hi");
		//PacketDispatcher.sendPacketToServer(new BatonModePacket("Hello World!").makePacket());
	}

}

 

if "i happened" prints, you have pressed the correct key and registered the keyhandler correctly,

if "hi" doesnt print then kb != Baton.mode

I seem to be forgetting my troubleshooting basics! I did what you said, and nothing prints at all when I press J (the key I bound). So something must be going wrong elsewhere right?

Link to comment
Share on other sites

yes, now you know either that your key binder isnt registered correctly OR you're not pressing the right key

 

I fixed it! I shifted somethings around, and I found something on the wiki that helped. Hopefully it'll send the packet correctly now!

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.