Jump to content

[1.16.5] How to get drops from a block that player mined?


Recommended Posts

Posted

As the title says I need a way to get drops from a block that the player has just mined. How to do that? I have seen that getDrops exists but I don't know how to use it or if it is the right solution for this problem. Ideally, it should apply enchants that player has that affect drops (eg. Silk Touch or Fortune) automatically. Any help would be appreciated.

Posted
3 hours ago, Mislo_ said:

Ideally, it should apply enchants that player has that affect drops (eg. Silk Touch or Fortune) automatically.

GlobalLootModifiers are most likely the solution you're looking for. You are not required to actually modify the drops if you're only interested in knowing what dropped.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted
3 hours ago, diesieben07 said:

What is your goal? What effect do you want to achieve?

I am making an enchant (for tools) that will put drops from a block directly into a player's inventory. If the inventory is full I just drop items on player's coordinates.

56 minutes ago, Draco18s said:

GlobalLootModifiers are most likely the solution you're looking for.

I have stumbled upon that once but it looks complicated. If it is the best solution I will study it thoroughly and make use of it.

Posted
11 hours ago, diesieben07 said:

There is no simple way to do this. If you look at PlayerInteractionManager#destroyBlock you'll see that there isn't really any hook to influence the spawning of drops. Block#playerDestroy will eventually be called and simply spawn the drops into the world. You can in theory detect EntityJoinWorldEvent of the ItemEntities, but you don't really have a way to detect whether these are drops of a block mined with a tool that has your enchantment.

So using GlobalLootModifiers would be the best solution. Thanks for making that clear. I would probably spend a few more hours trying to find a different solution. Thanks for help.

Posted
6 hours ago, diesieben07 said:

They only allow you to modify what is dropped, not capture what will be dropped or change what is done with the drops.

While I haven't checked, I do believe that the player is part of the LootParameters, so the entire generated drops could be inserted into the player's inventory, and then cleared so nothing actually drops.

Not what the modifiers were intended for, but it might work.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

*puts up a sign: here there be dragons, woe unto thee who venture here*

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • hello i am wanting to know if anyone can help me with this crash happened when i tried to go to bed on server https://pastebin.com/CezfAbAh
    • I accidentally posted this in the ForgeGradle subforum, super sorry. I meant to post it in the regular modders forum. Hopefully it can still reach the right people!
    • I've been trying to make an addon mod for create, but setting up dependencies and trying to add the mod into my mod environment has proven a little difficult for me. Ive been searching this forum and I've seen problems that were close to mine but not exactly mine, searching the error output just yields  people having trouble with their own modid, not an addons. The error while loading Minecraft,  "mods.toml missing metadata of modid create" and  "The Mod File C:Users\user1\data\<mod>\build\resources\main has mods that were not found" My build.gradle file plugins { id 'eclipse' id 'idea' id 'maven-publish' id 'net.minecraftforge.gradle' version '[6.0,6.2)' id 'org.parchmentmc.librarian.forgegradle' version '1.+' } version = mod_version group = mod_group_id base { archivesName = mod_id } // Mojang ships Java 17 to end users in 1.18+, so your mod should target Java 17. java.toolchain.languageVersion = JavaLanguageVersion.of(17) println "Java: ${System.getProperty 'java.version'}, JVM: ${System.getProperty 'java.vm.version'} (${System.getProperty 'java.vendor'}), Arch: ${System.getProperty 'os.arch'}" minecraft { mappings channel: 'parchment', version: '2023.09.03-1.20.1' copyIdeResources = true runs { configureEach { workingDirectory project.file('run') property 'forge.logging.markers', 'REGISTRIES' property 'forge.logging.console.level', 'debug' property 'mixin.env.remapRefMap', 'true' property 'mixin.env.refMapRemappingFile', "${projectDir}/build/createSrgToMcp/output.srg" mods { "${mod_id}" { source sourceSets.main } } } client { // ... mods { other_mod { // ... } // Configures the 'example' mod create { // Add a source set to a mod's sources source sourceSets.main // Merges this configuration and specifies whether to overwrite existing properties merge mods.other_mod, true } } } server { property 'forge.enabledGameTestNamespaces', mod_id args '--nogui' } // This run config launches GameTestServer and runs all registered gametests, then exits. // By default, the server will crash when no gametests are provided. // The gametest system is also enabled by default for other run configs under the /test command. gameTestServer { property 'forge.enabledGameTestNamespaces', mod_id } data { // example of overriding the workingDirectory set in configureEach above workingDirectory project.file('run-data') // Specify the modid for data generation, where to output the resulting resource, and where to look for existing resources. args '--mod', mod_id, '--all', '--output', file('src/generated/resources/'), '--existing', file('src/main/resources/') } } } // Include resources generated by data generators. sourceSets.main.resources { srcDir 'src/generated/resources' } repositories { maven { url = 'https://maven.tterrag.com/' } } dependencies { // Specify the version of Minecraft to use. // Any artifact can be supplied so long as it has a "userdev" classifier artifact and is a compatible patcher artifact. // The "userdev" classifier will be requested and setup by ForgeGradle. // If the group id is "net.minecraft" and the artifact id is one of ["client", "server", "joined"], // then special handling is done to allow a setup of a vanilla dependency without the use of an external repository. minecraft "net.minecraftforge:forge:1.20.1-47.3.22" implementation fg.deobf("com.simibubi.create:create-${create_minecraft_version}:${create_version}:slim") { transitive = false } implementation fg.deobf("com.jozufozu.flywheel:flywheel-forge-${flywheel_minecraft_version}:${flywheel_version}") implementation fg.deobf("com.tterrag.registrate:Registrate:${registrate_version}") // Example mod dependency with JEI - using fg.deobf() ensures the dependency is remapped to your development mappings // The JEI API is declared for compile time use, while the full JEI artifact is used at runtime // compileOnly fg.deobf("mezz.jei:jei-${mc_version}-common-api:${jei_version}") // compileOnly fg.deobf("mezz.jei:jei-${mc_version}-forge-api:${jei_version}") // runtimeOnly fg.deobf("mezz.jei:jei-${mc_version}-forge:${jei_version}") // Example mod dependency using a mod jar from ./libs with a flat dir repository // This maps to ./libs/coolmod-${mc_version}-${coolmod_version}.jar // The group id is ignored when searching -- in this case, it is "blank" // implementation fg.deobf("blank:coolmod-${mc_version}:${coolmod_version}") // For more info: // http://www.gradle.org/docs/current/userguide/artifact_dependencies_tutorial.html // http://www.gradle.org/docs/current/userguide/dependency_management.html } // This block of code expands all declared replace properties in the specified resource targets. // A missing property will result in an error. Properties are expanded using ${} Groovy notation. // When "copyIdeResources" is enabled, this will also run before the game launches in IDE environments. // See https://docs.gradle.org/current/dsl/org.gradle.language.jvm.tasks.ProcessResources.html tasks.named('processResources', ProcessResources).configure { var replaceProperties = [ minecraft_version: minecraft_version, minecraft_version_range: minecraft_version_range, forge_version: forge_version, forge_version_range: forge_version_range, loader_version_range: loader_version_range, mod_id: mod_id, mod_name: mod_name, mod_license: mod_license, mod_version: mod_version, mod_authors: mod_authors, mod_description: mod_description, ] inputs.properties replaceProperties filesMatching(['META-INF/mods.toml', 'pack.mcmeta']) { expand replaceProperties + [project: project] } } // Example for how to get properties into the manifest for reading at runtime. tasks.named('jar', Jar).configure { manifest { attributes([ 'Specification-Title' : mod_id, 'Specification-Vendor' : mod_authors, 'Specification-Version' : '1', // We are version 1 of ourselves 'Implementation-Title' : project.name, 'Implementation-Version' : project.jar.archiveVersion, 'Implementation-Vendor' : mod_authors, 'Implementation-Timestamp': new Date().format("yyyy-MM-dd'T'HH:mm:ssZ") ]) } // This is the preferred method to reobfuscate your jar file finalizedBy 'reobfJar' } // However if you are in a multi-project build, dev time needs unobfed jar files, so you can delay the obfuscation until publishing by doing: // tasks.named('publish').configure { // dependsOn 'reobfJar' // } // Example configuration to allow publishing using the maven-publish plugin publishing { publications { register('mavenJava', MavenPublication) { artifact jar } } } tasks.withType(JavaCompile).configureEach { options.encoding = 'UTF-8' // Use the UTF-8 charset for Java compilation } -And my mods.toml file  modLoader="javafml" #mandatory loaderVersion="[47,)" license="MIT" [[mods]] modId="mechmod" version="0.0.1" displayName="Create: Mechs" authors="Affe" [[dependencies.mechmod]] modId="create" mandatory=true versionRange="[0,)" ordering="NONE" side="BOTH" [[dependencies.mechmod]] modId="forge" mandatory=true versionRange="[47.1.3,)" ordering="NONE" side="BOTH" [[dependencies.mechmod]] modId="minecraft" mandatory=true versionRange="[1.20,1.21)" ordering="NONE" side="BOTH" [[dependencies.mechmod]] modId="flywheel" mandatory=true versionRange="[0.6.11,0.6.12)" ordering="AFTER" side="CLIENT" I thought I had implemented the code from the "depending on create" section from their github correctly. But I assume I haven't implemented something that is needed. But I don't know what or where. I can also provide any file you think will help with your diagnosis. Any help would be appreciated, cheers!   
    • Yo i might be a lil bit late but on 1.20.6 you can call BuiltInRegistries.ITEMS.getTagOrEmpty(*required tag*) to get an iterable of item holders, this might be possible on 1.18.2 as well. Then you get the items using for(Holder<Item> holder: iterable) or the .forEach(Consumer<Holder<Item>>) method, or convert the iterable to array/list/collection. When you get the holders, use the .get() method to get the items
    • I'm troubleshooting some mods that I want for a single player world in 1.21.4 and I was having trouble with a resource library config crashing my game so I tried another mod and the library config for that was causing crashes as well. I've updated java and forge recently. Both of these dependency mods have caused Exit Code: -1 but I'm using the crash report for the mod that I was originally wanting to use. https://pastebin.com/82FZPwS2
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.