Jump to content

[1.17.1] Villager Point of interest


AurenX

Recommended Posts

I had this working in 1.16 but the same method doesn't seem to have the same effect.

I have a new block that replaces the fletching table but this breaks the villager point of interest so no more fletchers.
In 1.16 i had this


public static void fixVillagerPOI(FMLCommonSetupEvent event) {
     Map<BlockState, PointOfInterestType> types = ReflectionHelper.getPrivateValue(PointOfInterestType.class, null, ASMAPI.mapField("field_221073_u"));
     Blocks.FLETCHING_TABLE.getStateContainer().getValidStates().forEach(s -> types.put(s, PointOfInterestType.FLETCHER));
}

field_221073_u no longer exists and, unless I don't understand, is now f_27323_ . while this does not give an error it also does not effect the villagers

Is there a new method to get villagers to become an existing type with a new block?

Link to comment
Share on other sites

  • 4 weeks later...

Sorry for the delayed response i got busy with work.

I was able to get this working, with the gap between and my other bad habit of getting frustrated and deleting code that doesnt work i do not remember exactly what i did that did not work.
What i found was i had to create both a profession and a poitype and was not able to just override the poitype individually, this is probably what i was missing to be honest as the method i was using only needed the poi.

Thank you for the help you guys did provide.


note: The registry name for the profession uses minecraft so no new textures are needed
note: Was able to just pull trade data over but had to re-register that as well
note: Event subscription handled in other location but nothing special there

was able to get it working with Deferred registry

 

    public static final DeferredRegister<PoiType> POINT_OF_INTEREST_TYPES = DeferredRegister.create(ForgeRegistries.POI_TYPES, Reference.MOD_ID);
    public static final DeferredRegister<VillagerProfession> VILLAGER_PROFESSIONS = DeferredRegister.create(ForgeRegistries.PROFESSIONS, "minecraft");
    
    public static final RegistryObject<PoiType> FLETCHER_POI = POINT_OF_INTEREST_TYPES.register("fletcher", () -> new PoiType("fletcher", PoiType.getBlockStates(BlockHandler.FletchingTable), 1, 1));
    public static final RegistryObject<VillagerProfession> FLETCHER = VILLAGER_PROFESSIONS.register("fletcher", () -> new VillagerProfession("fletcher", FLETCHER_POI.get(), ImmutableSet.of(), ImmutableSet.of(Blocks.FLETCHING_TABLE), SoundEvents.VILLAGER_WORK_FLETCHER));
    
    public static void commonSetup(FMLCommonSetupEvent event) {
        event.enqueueWork(() -> {
            VillagerHandler.tradeData();
            VillagerHandler.registerFletherPOI();
        });
    }

    public static void registerFletherPOI() {
        try {
            ObfuscationReflectionHelper.findMethod(PoiType.class, "registerBlockStates", PoiType.class).invoke(null, FLETCHER_POI.get());
        } catch (InvocationTargetException | IllegalAccessException e) {
            e.printStackTrace();
        }
    }
    
    private static void tradeData() {
        VillagerTrades.TRADES.put(FLETCHER.get(), VillagerTrades.TRADES.get(VillagerProfession.FLETCHER));
    }



I was also able to get normal registry working with 

 


    public static final PoiType FLETCHER_POI = new PoiType("fletcher", PoiType.getBlockStates(BlockHandler.FletchingTable), 1, 1);
    public static final VillagerProfession FLETCHER = new VillagerProfession("fletcher", FLETCHER_POI, ImmutableSet.of(), ImmutableSet.of(Blocks.FLETCHING_TABLE), SoundEvents.VILLAGER_WORK_FLETCHER);
    
    public static void setupPOIType(Register<PoiType> event) {
        event.getRegistry().register(FLETCHER_POI.setRegistryName(Reference.MOD_ID, "fletcher"));
    }
    
    public static void setupProffessions(Register<VillagerProfession> event) {
        event.getRegistry().register(FLETCHER.setRegistryName("minecraft", "fletcher"));
    }
    
    private static void tradeData() {
        VillagerTrades.TRADES.put(FLETCHER, VillagerTrades.TRADES.get(VillagerProfession.FLETCHER));
    }
 
    public static void commonSetup(FMLCommonSetupEvent event) {
        VillagerHandler.tradeData();
    }
    }

Edited by AurenX
Link to comment
Share on other sites

You must have a licence to drive a car. "Must is a strong word, the car runs without it".

Just because it works doesn't mean that it won't cause you problems down the line. And if you do it correctly from the start, you won't have to spend the time finding and fixing bugs later on.

Link to comment
Share on other sites

1 hour ago, Alpvax said:

You must have a licence to drive a car. "Must is a strong word, the car runs without it".

Just because it works doesn't mean that it won't cause you problems down the line. And if you do it correctly from the start, you won't have to spend the time finding and fixing bugs later on.

Yes but when proving a proof of concept you don't drive on the open road so no a license technically isn't needed as they would use a test track or heck test parts individually before assembly. And a poor example as a working car and a street legal car are different; there are concept cars, race cars, plastic cars for kids, etc.

So when I am just starting to update mods to a newer version of forge and enough changed that a proof of concept test mod is advisable then no doing it perfect is not needed and instead just a waste.

Yes when updating the actual mod you should I stated that above. Again all I showed was that I got it working, not hey here is this perfect thing all learn from me as I am the smart perfect person.

Again I will say, it works fine how it is. And again I will say yes you should use object holders. But saying needed is wrong.

If you would like to provide people with a "here is the proper way to code this" instead of an example that "works" then go ahead and post it. I have no more need of advancing this as I have learned what I needed to from it.

22 hours ago, diesieben07 said:

This is why we can't have nice things.

I probably shouldn't show you how I work with blocks and items when I just need to bulk create things ;)

Edited by AurenX
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I tried to resolve the errors but I can't do it on my own, if anyone knows please help me Heres the log: https://paste.ee/p/JL1AA.  
    • Run jarfix https://johann.loefflmann.net/en/software/jarfix/index.html
    • Ich entschuldige mich schonmal im Voraus, falls es zu Kommunikationsproblemen  kommen sollte. Ich bin deutscher, etwas gestresst und habe gerade nicht wirklich die Nerven dafür, das alles ins englische zu übersetzen.   Ich habe mir in der Curseforge App 2 Mod-Profile für die Java Minecraft-Version 1.20.1 erstellt. eines für Forge-Mods und eines Für Fabric-Mods. Allerdings bekomme ich bei beiden eine Fehlermeldung, wenn ich Minecraft spielen will. Was kann ich tun? (Wenn es gebraucht wird, werde ich mir die Zeit nehmen und die Versionen und Ersteller der Mods und Recources raussuchen.)   Alle Mods, Resources und Modloader-packs sind auf der neusten Version Standpunkt 29.02.2024   - Forge: Meine Zusammenstellung besteht aus 121 Mods und 6 Resources. Was passiert: Wenn ich Spielen will, komm ich zwar in den Launcher und der Ladebildschirm taucht auf, bricht allerdings ab und bekomme eine Fehlermeldung. Fehlermeldung: The game crashed whilst initializing game Error: net.minecraftforge.fml.loading.EarlyLoadingException: Could not execute entrypoint stage 'main' due to errors, provided by 'eldritch_end'! Exitcode: -1 Wenn ich allerdings Eldrich End aus schalte, kommt ebenfalls eine. Fehlermeldung: The game crashed whilst initializing game Error: java.lang.NoClassDefFoundError: Could not initialize class net.minecraft.client.renderer.RenderType Exitcode: -1 Liste der Mods: A.V.A-Alliance of  Valiant Arms Guns Ad Astra Additional Lanterns Additional Structures Alex's Mobs Aquacolture 2 Aquamirae (Forge) Architectury API (Fabric/Forge/NeoForge) Armore Statues [Forge & Fabric] Armored Redstone AzurLib Balm (Forge Editon) Better Villages - Fabric BetterF3 Biomes O' Plenty Blue Skies Botarium CalamityMusicDisc Camera Mod Charm of Undying (Fabric/Forge/Quilt) Citadel Clasic musical discs Cloth Config API (Fabric/Forge/NeoForge) Config API [Fabric/Forge/NeoForge/Quilt] Connected Glass Connector Extras Cristel Lib Curios API (Forge/NeoForge) Curious Armor Stands Denki's Music Disc DivineRPG (Official) Dragon Mounts: Legacy Eldrich End Energized Power Eureka! Ships! for Valkyrien Skies (Forge/Fabric) Fish Tanks Forgified Fabric API Fussion (Connected Textures) Gamma Creatures GeckoLib Handcrafted HorkLord's Musik Discs Ice and Fire: Dragons Immersiv Melodies (Fabric/Forge) Immersiv Paintings (Fabric/Forge) Immersiv Structures Infinit Abyss Just Enough Items (JEI) Kotlin for Forge L_Enders Catalysm Library Ferret - Forge Macaw's Bridges Macaw's Doors Many More Music Discs [FORGE] MCEF (Minecraft Chromium Embedded  Framework) Mobs Head Modonomicon Monster Plus More Bows CJ (Fabric/Forge/Quilt) More Crossbows CJ (Fabric/Forge/Quilt) Morer Music Discs (Records) More Music Discs (Fabric/Forge/NeoForge) Moving Elevators MrCrayfish's Furniture Mod Multipart Machines: Mining Music Discs Galore Musical Instrument Minecraft Interface (MIMI) Musical Lib Mythic Mounts (Forge) Necronomicon API Nether Exorcism Netherrite Horse Armor CJ [Fabric/Forge/Quilt] Nullscape Nyctophobia (FABRIC) Obscure API (Fabric) Obscure Tooltips Occultism Ore Tree:Reeborn Patchouli Puzzles Lib [Forge & Fabric] Redstone engineering Redstone Lamp Plus Regions Unexplored (forge/fabric) Resourceful Config Resourceful Lib Scuffy Music Disc Pack Securety Craft Shadowlands Sinytra Connector SmartBrainLib (Forge/Fabric/Quilt) Spawn Structory Structory: Towers Structure Gel API  SuperMartijn642's Config Lib SuperMartijn642's Core Lib TerraBlender (Forge) The Ather The Graveyard (FORGE/NEOFORGE) The Twilight Forrest Towns and Towers Trash Cans Traveler' Backpack Valhelsia Core Valhelsia Structures Valkyrien Skies (Forge/Fabric) Waddles Waystones DebDisplays Wireles_Redstone Wither's Wepons YUNG'S API (Forge) YUNG'S Better Desert Temples (Forge) YUNG'S Better Dungeons (Forge) YUNG'S Better End Island (Forge) YUNG'S Better Jungle Temples (Forge) YUNG'S Better Mineshafts (Forge) YUNG'S Better Nether Fortresses (Forge) YUNG'S Better Ocean Monuments (Forge) YUNG'S Better Sreongholds (Forge) YUNG'S Better Witch Huts (Forge)   Liste der Resources: Better Cats Better Dogs Boss Refreshed Enhanced Boss Bars Visible Ores Zerotekz's Mythic Weapons     - Fabric: Meine Zusammenstellung besteht aus 61 Mods und 6 Resources. Was passiert: Wenn ich Spielen will, komm ich zwar in den Launcher, aber ich komme noch nicht einmal in den Ladebildschirm und drückt mir direkt eine Fehlermeldung rein. Fehlermeldung: The game crashed whilst initializing game Error: java.lang.NoSuchMethodError: 'java.lang.Object[] org.apache.commons.lang3.ArrayUtils.addFirst(java.lang.Object[], java.lang.Object)' Exitcode: -1 Liste der Mods: Ad Astra Additional Lanterns Aquamirae (Fabric) Architectury API (Fabric/Forge/NeoForge) AzurLib Better Villages - Fabric BetterF3 Bosses Of Mass Destruction Botarium Cardinal Components API Cloth Config API (Fabric/Forge/NeoForge) Clutter Config API [Fabric/Forge/NeoForge/Quilt] Cristel Lib Eldrich End Energized Power Eureka! Ships! for Valkyrien Skies (Forge/Fabric) Fabric API Fabric Language Kotlin GeckoLib Handcrafted Immersiv Armors (Fabric/Forge) Immersiv Melodies (Fabric/Forge) Immersiv Paintings (Fabric/Forge) Immersiv Structures Library Ferret - Fabric Macaw's Bridges Macaw's Doors More Bows CJ (Fabric/Forge/Quilt) More Crossbows CJ (Fabric/Forge/Quilt) More Music Discs (Fabric/Forge/NeoForge) Moving Elevators Mythic Mounts Necronomicon API Nullscape Nyctophobia (FABRIC) Obscure API (Fabric) Patchouli (Fabric) Regions Unexplored (forge/fabric) Resourceful Config Resourceful Lib Spawn Structory Structory: Towers SuperMartijn642's Config Lib SuperMartijn642's Core Lib TerraBlender (Fabric) The Graveyard (FABRIC) Towns and Towers Trash Cans Valkyrien Skies (Forge/Fabric) YUNG'S API (Fabric) YUNG'S Better Desert Temples (Fabric) YUNG'S Better Dungeons (Fabric) YUNG'S Better End Island (Fabric) YUNG'S Better Jungle Temples (Fabric) YUNG'S Better Mineshafts (Fabric) YUNG'S Better Nether Fortresses (Fabric) YUNG'S Better Ocean Monuments (Fabric) YUNG'S Better Sreongholds (Fabric) YUNG'S Better Witch Huts (Fabric)   Liste der Resources: Better Cats Better Dogs Boss Refreshed Enhanced Boss Bars Visible Ores Zerotekz's Mythic Weapons
    • When i click a jar file there's a black window popping out for a second then closing i don't know what to do, it's been happening for 2 days already
    • Hello, I don't have much experience with forge but I have some java knowledge, I want to add a button that says "Explore New Packs" to the Pause Screen that opens when we enter a world in the game and press the "esc" button, but I couldn't understand it (or I don't know how to use it), although I did research from artificial intelligence or different places. I was told that I can do it using mixins but I have no idea how to do it, can you explain step by step
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.