Jump to content

[1.17.1] Villager Point of interest


AurenX
 Share

Recommended Posts

I had this working in 1.16 but the same method doesn't seem to have the same effect.

I have a new block that replaces the fletching table but this breaks the villager point of interest so no more fletchers.
In 1.16 i had this


public static void fixVillagerPOI(FMLCommonSetupEvent event) {
     Map<BlockState, PointOfInterestType> types = ReflectionHelper.getPrivateValue(PointOfInterestType.class, null, ASMAPI.mapField("field_221073_u"));
     Blocks.FLETCHING_TABLE.getStateContainer().getValidStates().forEach(s -> types.put(s, PointOfInterestType.FLETCHER));
}

field_221073_u no longer exists and, unless I don't understand, is now f_27323_ . while this does not give an error it also does not effect the villagers

Is there a new method to get villagers to become an existing type with a new block?

Link to comment
Share on other sites

  • 4 weeks later...

Sorry for the delayed response i got busy with work.

I was able to get this working, with the gap between and my other bad habit of getting frustrated and deleting code that doesnt work i do not remember exactly what i did that did not work.
What i found was i had to create both a profession and a poitype and was not able to just override the poitype individually, this is probably what i was missing to be honest as the method i was using only needed the poi.

Thank you for the help you guys did provide.


note: The registry name for the profession uses minecraft so no new textures are needed
note: Was able to just pull trade data over but had to re-register that as well
note: Event subscription handled in other location but nothing special there

was able to get it working with Deferred registry

 

    public static final DeferredRegister<PoiType> POINT_OF_INTEREST_TYPES = DeferredRegister.create(ForgeRegistries.POI_TYPES, Reference.MOD_ID);
    public static final DeferredRegister<VillagerProfession> VILLAGER_PROFESSIONS = DeferredRegister.create(ForgeRegistries.PROFESSIONS, "minecraft");
    
    public static final RegistryObject<PoiType> FLETCHER_POI = POINT_OF_INTEREST_TYPES.register("fletcher", () -> new PoiType("fletcher", PoiType.getBlockStates(BlockHandler.FletchingTable), 1, 1));
    public static final RegistryObject<VillagerProfession> FLETCHER = VILLAGER_PROFESSIONS.register("fletcher", () -> new VillagerProfession("fletcher", FLETCHER_POI.get(), ImmutableSet.of(), ImmutableSet.of(Blocks.FLETCHING_TABLE), SoundEvents.VILLAGER_WORK_FLETCHER));
    
    public static void commonSetup(FMLCommonSetupEvent event) {
        event.enqueueWork(() -> {
            VillagerHandler.tradeData();
            VillagerHandler.registerFletherPOI();
        });
    }

    public static void registerFletherPOI() {
        try {
            ObfuscationReflectionHelper.findMethod(PoiType.class, "registerBlockStates", PoiType.class).invoke(null, FLETCHER_POI.get());
        } catch (InvocationTargetException | IllegalAccessException e) {
            e.printStackTrace();
        }
    }
    
    private static void tradeData() {
        VillagerTrades.TRADES.put(FLETCHER.get(), VillagerTrades.TRADES.get(VillagerProfession.FLETCHER));
    }



I was also able to get normal registry working with 

 


    public static final PoiType FLETCHER_POI = new PoiType("fletcher", PoiType.getBlockStates(BlockHandler.FletchingTable), 1, 1);
    public static final VillagerProfession FLETCHER = new VillagerProfession("fletcher", FLETCHER_POI, ImmutableSet.of(), ImmutableSet.of(Blocks.FLETCHING_TABLE), SoundEvents.VILLAGER_WORK_FLETCHER);
    
    public static void setupPOIType(Register<PoiType> event) {
        event.getRegistry().register(FLETCHER_POI.setRegistryName(Reference.MOD_ID, "fletcher"));
    }
    
    public static void setupProffessions(Register<VillagerProfession> event) {
        event.getRegistry().register(FLETCHER.setRegistryName("minecraft", "fletcher"));
    }
    
    private static void tradeData() {
        VillagerTrades.TRADES.put(FLETCHER, VillagerTrades.TRADES.get(VillagerProfession.FLETCHER));
    }
 
    public static void commonSetup(FMLCommonSetupEvent event) {
        VillagerHandler.tradeData();
    }
    }

Edited by AurenX
Link to comment
Share on other sites

You must have a licence to drive a car. "Must is a strong word, the car runs without it".

Just because it works doesn't mean that it won't cause you problems down the line. And if you do it correctly from the start, you won't have to spend the time finding and fixing bugs later on.

Link to comment
Share on other sites

1 hour ago, Alpvax said:

You must have a licence to drive a car. "Must is a strong word, the car runs without it".

Just because it works doesn't mean that it won't cause you problems down the line. And if you do it correctly from the start, you won't have to spend the time finding and fixing bugs later on.

Yes but when proving a proof of concept you don't drive on the open road so no a license technically isn't needed as they would use a test track or heck test parts individually before assembly. And a poor example as a working car and a street legal car are different; there are concept cars, race cars, plastic cars for kids, etc.

So when I am just starting to update mods to a newer version of forge and enough changed that a proof of concept test mod is advisable then no doing it perfect is not needed and instead just a waste.

Yes when updating the actual mod you should I stated that above. Again all I showed was that I got it working, not hey here is this perfect thing all learn from me as I am the smart perfect person.

Again I will say, it works fine how it is. And again I will say yes you should use object holders. But saying needed is wrong.

If you would like to provide people with a "here is the proper way to code this" instead of an example that "works" then go ahead and post it. I have no more need of advancing this as I have learned what I needed to from it.

22 hours ago, diesieben07 said:

This is why we can't have nice things.

I probably shouldn't show you how I work with blocks and items when I just need to bulk create things ;)

Edited by AurenX
Link to comment
Share on other sites

13 minutes ago, AurenX said:

Again I will say, it works fine how it is.

It does not.

13 minutes ago, AurenX said:

But saying needed is wrong.

It is not.

13 minutes ago, AurenX said:

If you would like to provide people with a "here is the proper way to code this" instead of an example that "works" then go ahead and post it. I have no more need of advancing this as I have learned what I needed to from it.

Proper registry usage is explained in the documentation: https://mcforge.readthedocs.io/en/latest/concepts/registries/.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I did everything i could to fix it, but nothing works. Error code: ---- Minecraft Crash Report ---- // Why did you do that? Time: 12/5/22 6:51 PM Description: Initializing game java.lang.NullPointerException: Initializing game     at net.minecraft.client.renderer.color.BlockColors.func_186722_a(BlockColors.java:97) ~[?:?] {re:classloading,pl:runtimedistcleaner:A}     at voronoiaoc.byg.client.textures.BlockColorManager.onBlockColorsInit(BlockColorManager.java:29) ~[?:1.0.11] {re:classloading}     at net.minecraftforge.eventbus.ASMEventHandler_181_BlockColorManager_onBlockColorsInit_Block.invoke(.dynamic) ~[?:?] {}     at net.minecraftforge.eventbus.ASMEventHandler.invoke(ASMEventHandler.java:80) ~[eventbus-2.2.1-service.jar:?] {}     at net.minecraftforge.eventbus.EventBus.post(EventBus.java:258) ~[eventbus-2.2.1-service.jar:?] {}     at net.minecraftforge.fml.javafmlmod.FMLModContainer.acceptEvent(FMLModContainer.java:168) ~[?:31.2] {re:classloading}     at net.minecraftforge.fml.ModLoader.lambda$postEvent$31(ModLoader.java:260) ~[?:?] {re:classloading}     at net.minecraftforge.fml.ModLoader$$Lambda$4851/35539019.accept(Unknown Source) ~[?:?] {}     at java.util.HashMap.forEach(HashMap.java:1280) ~[?:1.8.0_51] {}     at net.minecraftforge.fml.ModList.forEachModContainer(ModList.java:218) ~[?:?] {re:classloading}     at net.minecraftforge.fml.ModLoader.postEvent(ModLoader.java:260) ~[?:?] {re:classloading}     at net.minecraftforge.client.ForgeHooksClient.onBlockColorsInit(ForgeHooksClient.java:207) ~[?:?] {re:classloading}     at net.minecraft.client.renderer.color.BlockColors.func_186723_a(BlockColors.java:76) ~[?:?] {re:classloading,pl:runtimedistcleaner:A}     at net.minecraft.client.Minecraft.<init>(Minecraft.java:419) [?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:assets/immersive_portals/immersive_portals.mixins_client.json:block_manipulation.MixinMinecraftClient_B,pl:mixin:APP:assets/immersive_portals/immersive_portals.mixins_client.json:MixinMinecraftClient,pl:mixin:A,pl:runtimedistcleaner:A}     at net.minecraft.client.main.Main.main(SourceFile:166) [?:?] {re:classloading}     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_51] {}     at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_51] {}     at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_51] {}     at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_51] {}     at net.minecraftforge.fml.loading.FMLClientLaunchProvider.lambda$launchService$0(FMLClientLaunchProvider.java:51) [forge-1.15.2-31.2.57.jar:31.2] {}     at net.minecraftforge.fml.loading.FMLClientLaunchProvider$$Lambda$488/524566446.call(Unknown Source) [forge-1.15.2-31.2.57.jar:31.2] {}     at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-5.1.2.jar:?] {}     at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54) [modlauncher-5.1.2.jar:?] {}     at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:72) [modlauncher-5.1.2.jar:?] {}     at cpw.mods.modlauncher.Launcher.run(Launcher.java:81) [modlauncher-5.1.2.jar:?] {}     at cpw.mods.modlauncher.Launcher.main(Launcher.java:65) [modlauncher-5.1.2.jar:?] {} A detailed walkthrough of the error, its code path and all known details is as follows: --------------------------------------------------------------------------------------- -- Head -- Thread: Render thread Stacktrace:     at net.minecraft.client.renderer.color.BlockColors.func_186722_a(BlockColors.java:97)     at voronoiaoc.byg.client.textures.BlockColorManager.onBlockColorsInit(BlockColorManager.java:29)     at net.minecraftforge.eventbus.ASMEventHandler_181_BlockColorManager_onBlockColorsInit_Block.invoke(.dynamic)     at net.minecraftforge.eventbus.ASMEventHandler.invoke(ASMEventHandler.java:80)     at net.minecraftforge.eventbus.EventBus.post(EventBus.java:258)     at net.minecraftforge.fml.javafmlmod.FMLModContainer.acceptEvent(FMLModContainer.java:168)     at net.minecraftforge.fml.ModLoader.lambda$postEvent$31(ModLoader.java:260)     at net.minecraftforge.fml.ModLoader$$Lambda$4851/35539019.accept(Unknown Source)     at java.util.HashMap.forEach(HashMap.java:1280)     at net.minecraftforge.fml.ModList.forEachModContainer(ModList.java:218)     at net.minecraftforge.fml.ModLoader.postEvent(ModLoader.java:260)     at net.minecraftforge.client.ForgeHooksClient.onBlockColorsInit(ForgeHooksClient.java:207)     at net.minecraft.client.renderer.color.BlockColors.func_186723_a(BlockColors.java:76)     at net.minecraft.client.Minecraft.<init>(Minecraft.java:419) -- Initialization -- Details: Stacktrace:     at net.minecraft.client.main.Main.main(SourceFile:166)     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)     at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)     at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)     at java.lang.reflect.Method.invoke(Method.java:497)     at net.minecraftforge.fml.loading.FMLClientLaunchProvider.lambda$launchService$0(FMLClientLaunchProvider.java:51)     at net.minecraftforge.fml.loading.FMLClientLaunchProvider$$Lambda$488/524566446.call(Unknown Source)     at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37)     at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54)     at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:72)     at cpw.mods.modlauncher.Launcher.run(Launcher.java:81)     at cpw.mods.modlauncher.Launcher.main(Launcher.java:65) -- System Details -- Details:     Minecraft Version: 1.15.2     Minecraft Version ID: 1.15.2     Operating System: Windows 10 (amd64) version 10.0     Java Version: 1.8.0_51, Oracle Corporation     Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode), Oracle Corporation     Memory: 1181118944 bytes (1126 MB) / 2147483648 bytes (2048 MB) up to 2147483648 bytes (2048 MB)     CPUs: 8     JVM Flags: 9 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xss1M -Xmx2G -XX:+UnlockExperimentalVMOptions -XX:+UseG1GC -XX:G1NewSizePercent=20 -XX:G1ReservePercent=20 -XX:MaxGCPauseMillis=50 -XX:G1HeapRegionSize=32M     ModLauncher: 5.1.2+70+master.2845bb9     ModLauncher launch target: fmlclient     ModLauncher naming: srg     ModLauncher services:          /mixin-0.8.2.jar mixin PLUGINSERVICE          /eventbus-2.2.1-service.jar eventbus PLUGINSERVICE          /forge-1.15.2-31.2.57.jar object_holder_definalize PLUGINSERVICE          /forge-1.15.2-31.2.57.jar runtime_enum_extender PLUGINSERVICE          /accesstransformers-2.1.3-shadowed.jar accesstransformer PLUGINSERVICE          /forge-1.15.2-31.2.57.jar capability_inject_definalize PLUGINSERVICE          /forge-1.15.2-31.2.57.jar runtimedistcleaner PLUGINSERVICE          /mixin-0.8.2.jar mixin TRANSFORMATIONSERVICE          /forge-1.15.2-31.2.57.jar fml TRANSFORMATIONSERVICE      FML: 31.2     Forge: net.minecraftforge:31.2.57     FML Language Providers:          javafml@31.2         minecraft@1     Mod List:          forge-1.15.2-31.2.57-client.jar Minecraft {minecraft@1.15.2 CREATE_REGISTRIES}         pandoras_creatures-1.15.2-1.0.1.jar Pandoras Creatures {pandoras_creatures@1.15.2-1.0.1 CREATE_REGISTRIES}         ender-chested-1.15.2-1.0.2.jar Ender Chested {ender_chest_horses@1.0.2 CREATE_REGISTRIES}         mine-mine-no-mi-1.15.2-0.8.2.jar Mine Mine no Mi {mineminenomi@0.8.2 CREATE_REGISTRIES}         endportalrecipe_1.15.2-2.3.jar End Portal Recipe {endportalrecipe@2.3 CREATE_REGISTRIES}         areas_1.15.2-2.2.jar Areas {areas@2.2 CREATE_REGISTRIES}         the-conjurer-1.15.2-1.0.13.jar The Conjurer {conjurer_illager@1.0.13 CREATE_REGISTRIES}         Abnormals-Core-1.15.2-1.0.6.jar Abnormals Core {abnormals_core@1.0.6 CREATE_REGISTRIES}         simplelogin-0.0.0-alpha-mc1.15-build2.jar Simple Login {simplelogin@0.0.0-alpha-mc1.15-build2 CREATE_REGISTRIES}         modnametooltip_1.15.2-1.13.0.jar Mod Name Tooltip {modnametooltip@1.13.0 CREATE_REGISTRIES}         Neat+1.6-22.jar Neat {neat@1.6-22 CREATE_REGISTRIES}         collective-1.15.2-2.26.jar Collective {collective@2.26 CREATE_REGISTRIES}         EndReborn+[0.6.2].jar End: Reborn {endreborn@0.6.2 CREATE_REGISTRIES}         lanterncolors-1.15.2-1.0.1.jar Lantern Colors {lanterncolors@1.15.2-1.0.1 CREATE_REGISTRIES}         elevatorid-1.15.2-1.7.1.jar Elevator Mod {elevatorid@1.15.2-1.7.1 CREATE_REGISTRIES}         InventoryHud_1.15.2.forge-3.4.1.jar Inventory HUD+(Forge edition) {inventoryhud@3.4.1 CREATE_REGISTRIES}         DungeonCrawl-1.15.2-2.3.0-a.jar Dungeon Crawl {dungeoncrawl@2.3.0-a CREATE_REGISTRIES}         Desolation+1.0.2b+1.15.2.jar Desolation (Forge) {desolation@1.0.2b CREATE_REGISTRIES}         The-Endergetic-Expansion-1.15.2-v1.3.2.jar The Endergetic Expansion {endergetic@1.3.2 CREATE_REGISTRIES}         RealisticTorches-1.15.2-3.0.0.jar Realistic Torches {realistictorches@1.15.2-3.0.0 CREATE_REGISTRIES}         buildinggadgets-3.4.1.jar Building Gadgets {buildinggadgets@3.4.1 CREATE_REGISTRIES}         cobbler-1.5.1.jar Cobbler {cobbler@1.5.1 CREATE_REGISTRIES}         outvoted-1.15.2-1.2.1-rc1.jar Outvoted {outvoted@1.2.1-rc1 CREATE_REGISTRIES}         sworddisplay-1.15.2-1.5.1.jar Sword Displays {sworddisplay@1.15.2-1.5.1 CREATE_REGISTRIES}         BackTools-1.15.2-8.0.0.jar Back Tools {backtools@8.0.0 CREATE_REGISTRIES}         iChunUtil-1.15.2-8.0.3.jar iChunUtil {ichunutil@8.0.3 CREATE_REGISTRIES}         traverse-1.15.2-3.2.0.jar Traverse {traverse@1.15.2-3.2.0 ERROR}         carryon-1.15.2-1.13.0.5.jar Carry On {carryon@1.13.0.5 CREATE_REGISTRIES}         byg-1.0.11.jar Oh The Biomes You'll Go {byg@1.0.11 CREATE_REGISTRIES}         immersive-portals-0.24forMc1.15withForge.jar Immersive Portals {immersive_portals@0.24 CREATE_REGISTRIES}         forge-1.15.2-31.2.57-universal.jar Forge {forge@31.2.57 CREATE_REGISTRIES}         cofh_core-1.15.2-1.0.2.jar CoFH Core {cofh_core@1.0.2 CREATE_REGISTRIES}         archers_paradox-1.15.2-1.0.0.jar Archer's Paradox {archers_paradox@1.0.0 CREATE_REGISTRIES}         DragonMountsLegacy-1.0.5.jar Dragon Mounts Legacy {dragonmounts@1.0.5 CREATE_REGISTRIES}         colorbricks-forge-1.15.2-1.1.1.jar ColorBricks Mod {colorbricks@1.15.2-1.1.1 CREATE_REGISTRIES}         rainbegoneritual_1.15.2-1.4.jar Rain Be Gone Ritual {rainbegoneritual@1.4 CREATE_REGISTRIES}         castle_dungeons-1.3-1.15.2.jar Castle Dungeons {castle_dungeons@1.3 CREATE_REGISTRIES}         BetterMineshaftsForge-1.15.2-1.3.2.jar YUNG's Better Mineshafts {bettermineshafts@1.15.2-1.3.2 CREATE_REGISTRIES}         geckolib-forge-1.15.2-3.0.32.jar GeckoLib Example Mod {geckolib3@3.0.32 CREATE_REGISTRIES}         structure-gel-api-1.15.2-1.1.0.jar Structure Gel API {structure_gel@1.1.0 CREATE_REGISTRIES}         ironchest-1.15.2-10.0.3.jar Iron Chests {ironchest@1.15.2-10.0.1 CREATE_REGISTRIES}         dungeonsarise1.15.2-1.2.72b.jar Dungeons Arise {dungeons_arise@1.2.72b CREATE_REGISTRIES}         hakibar-1.15.2-1.5.jar Haki Bar {hakibar@1.5 CREATE_REGISTRIES}     Launched Version: 1.15.2-forge-31.2.57     Backend library: LWJGL version 3.2.2 build 10     Backend API: NVIDIA GeForce GTX 1050/PCIe/SSE2 GL version 4.6.0 NVIDIA 517.48, NVIDIA Corporation     GL Caps: Using framebuffer using OpenGL 3.0     Using VBOs: Yes     Is Modded: Definitely; Client brand changed to 'forge'     Type: Client (map_client.txt)     CPU: 8x Intel(R) Core(TM) i5-9300HF CPU @ 2.40GHz
    • fixes can apply: minecraft creeper,zombie,skeleton , tick extra minecraft chest(block entity) , tick extra minecraft mobs(stay still with no tick) minecraft head turn (removal or fix)
    • I appreciate the response. I am not new to modded Minecraft. Just in 1.19.2. Normally i am pretty handy with crashes/logs but i hadn't seen this one before and the log really didn't give me anything to go on.
    • More information is needed. How did you try to run it? What happened when you did?
    • Did you check the debug.log in the logs folder?
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.