Jump to content

[1.16.5] NullPointerException on player respawn


mclich

Recommended Posts

I have an item (basically totem), that will teleport player to its spawnpoint after fell in void. I use PlayerList#respawn method to teleport player back, but it throws NullPointerException. The code is below:

private void activateTotem(World world, ServerPlayerEntity player, ItemStack itemStack)
{
	player.fallDistance=0F;
	ItemStack totem=itemStack.copy();
	Minecraft minecraft=Minecraft.getInstance();
	if(world.dimension()==World.END) player.moveTo(100.5F, 49F, 0.5F);
	else player=world.getServer().getPlayerList().respawn(player, false);
	if(minecraft.gameMode.getPlayerMode().isSurvival()) itemStack.shrink(1);
	DistExecutor.unsafeRunWhenOn(Dist.CLIENT, ()->()->minecraft.gameRenderer.displayItemActivation(totem));
	minecraft.particleEngine.createTrackingEmitter(player, ParticleTypes.PORTAL, 40);
	world.playSound((PlayerEntity)null, player.blockPosition(), SoundEvents.TOTEM_USE, SoundCategory.PLAYERS, 2F, 1F);
	player.playSound(SoundEvents.TOTEM_USE, 2F, 1F);
}

Is there any errors or am i just do something wrong?

Link to comment
Share on other sites

 

2 minutes ago, diesieben07 said:

This code will hard-crash on servers, the Minecraft class does not exist there.

Show the stacktrace of the exception.

 

[17:29:37] [Server thread/ERROR] [minecraft/MinecraftServer]: Encountered an unexpected exception
net.minecraft.crash.ReportedException: Ticking player
	at net.minecraft.network.NetworkSystem.tick(NetworkSystem.java:137) ~[forge:?] {re:classloading}
	at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:865) ~[forge:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:787) ~[forge:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.server.integrated.IntegratedServer.tickServer(IntegratedServer.java:78) ~[forge:?] {re:classloading,pl:runtimedistcleaner:A}
	at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:642) ~[forge:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:232) ~[forge:?] {re:classloading,pl:accesstransformer:B}
	at java.lang.Thread.run(Thread.java:748) [?:1.8.0_291] {}
Caused by: java.lang.NullPointerException
	at net.minecraft.world.server.TicketManager.removePlayer(TicketManager.java:227) ~[forge:?] {re:classloading}
	at net.minecraft.world.server.ChunkManager.updatePlayerStatus(ChunkManager.java:843) ~[forge:?] {re:classloading}
	at net.minecraft.world.server.ChunkManager.removeEntity(ChunkManager.java:982) ~[forge:?] {re:classloading}
	at net.minecraft.world.server.ServerChunkProvider.removeEntity(ServerChunkProvider.java:454) ~[forge:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.world.server.ServerWorld.removeEntityComplete(ServerWorld.java:905) ~[forge:?] {re:classloading}
	at net.minecraft.world.server.ServerWorld.removeEntity(ServerWorld.java:951) ~[forge:?] {re:classloading}
	at net.minecraft.world.server.ServerWorld.removePlayer(ServerWorld.java:968) ~[forge:?] {re:classloading}
	at net.minecraft.server.management.PlayerList.respawn(PlayerList.java:411) ~[forge:?] {re:classloading}
	at com.mclich.engmod.item.TotemOfAbyssItem.activateTotem(TotemOfAbyssItem.java:72) ~[?:?] {re:classloading}
	at com.mclich.engmod.item.TotemOfAbyssItem.inventoryTick(TotemOfAbyssItem.java:58) ~[?:?] {re:classloading}
	at net.minecraft.item.ItemStack.inventoryTick(ItemStack.java:434) ~[forge:?] {re:classloading,xf:fml:forge:filled_map.4,xf:fml:forge:itemstack}
	at net.minecraft.entity.player.PlayerInventory.tick(PlayerInventory.java:238) ~[forge:?] {re:classloading}
	at net.minecraft.entity.player.PlayerEntity.aiStep(PlayerEntity.java:487) ~[forge:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.entity.LivingEntity.tick(LivingEntity.java:2158) ~[forge:?] {re:classloading}
	at net.minecraft.entity.player.PlayerEntity.tick(PlayerEntity.java:223) ~[forge:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.entity.player.ServerPlayerEntity.doTick(ServerPlayerEntity.java:404) ~[forge:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.network.play.ServerPlayNetHandler.tick(ServerPlayNetHandler.java:207) ~[forge:?] {re:classloading}
	at net.minecraft.network.NetworkManager.tick(NetworkManager.java:226) ~[forge:?] {re:classloading}
	at net.minecraft.network.NetworkSystem.tick(NetworkSystem.java:134) ~[forge:?] {re:classloading}
	... 6 more
Edited by mclich
Link to comment
Share on other sites

5 minutes ago, diesieben07 said:

Honestly I have no idea.

So as i understand the exception occurs when game tries to delete player from the chunk, but can not find it there:

public void removePlayer(SectionPos p_219367_1_, ServerPlayerEntity p_219367_2_) {
      long i = p_219367_1_.chunk().toLong();
      ObjectSet<ServerPlayerEntity> objectset = this.playersPerChunk.get(i);
      objectset.remove(p_219367_2_);
      if (objectset.isEmpty()) {
         this.playersPerChunk.remove(i);
         this.naturalSpawnChunkCounter.update(i, Integer.MAX_VALUE, false);
         this.playerTicketManager.update(i, Integer.MAX_VALUE, false);
      }

   }

 objectset.remove(p_219367_2_) that line actually throws NullPointerException, am i right?

Edited by mclich
Link to comment
Share on other sites

On 10/17/2021 at 6:15 PM, diesieben07 said:

Yes.

Can you post a Git repo of your mod so I can debug this locally?

Sorry for not responding for a while. Here is my repo: https://github.com/mclich/ElderNorseGods.git
A little update: the strange thing is that even an exception occurs, player will be teleported to spawn point anyway, but after that player just cannot move, break blocks or do any other action. Main camera still moves, but it looks like it "stuck" inside players head

Edited by mclich
Link to comment
Share on other sites

20 minutes ago, diesieben07 said:

I am not sure how to best do this.

do the same thing as vanilla in DeathScreen...?
i'm not sure if this would work, but the normal respawn logic is fired when you click the Respawn-Button in the DeathScreen
which is LocalPlayer#respawn, it will send a ServerboundClientCommandPacket with the respawn Action to the Server,
the handle methode on Server use the same code your are running (PlayerList#respawn), but with the missing data (position and look)

Link to comment
Share on other sites

35 minutes ago, Luis_ST said:

do the same thing as vanilla in DeathScreen...?
i'm not sure if this would work, but the normal respawn logic is fired when you click the Respawn-Button in the DeathScreen
which is LocalPlayer#respawn, it will send a ServerboundClientCommandPacket with the respawn Action to the Server,
the handle methode on Server use the same code your are running (PlayerList#respawn), but with the missing data (position and look)

I also tried it. Instead of 

world.getServer().getPlayerList().respawn(player, false)

i tried 

DistExecutor.unsafeRunWhenOn(Dist.CLIENT, ()->()->Minecraft.getInstance().player.respawn())

but it actually did nothing

Link to comment
Share on other sites

3 minutes ago, diesieben07 said:

This is not what runWhenOn does! You are still on the server thread here, you must check that you are on the logical client side using World#isClientSide. Then you can use DistExecutor.

Oh, i thought DistExecutor.runWhenOn can be called not depending on logical side. Thanks for information, i'll try fix it

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I tried to resolve the errors but I can't do it on my own, if anyone knows please help me Heres the log: https://paste.ee/p/JL1AA.  
    • Run jarfix https://johann.loefflmann.net/en/software/jarfix/index.html
    • Ich entschuldige mich schonmal im Voraus, falls es zu Kommunikationsproblemen  kommen sollte. Ich bin deutscher, etwas gestresst und habe gerade nicht wirklich die Nerven dafür, das alles ins englische zu übersetzen.   Ich habe mir in der Curseforge App 2 Mod-Profile für die Java Minecraft-Version 1.20.1 erstellt. eines für Forge-Mods und eines Für Fabric-Mods. Allerdings bekomme ich bei beiden eine Fehlermeldung, wenn ich Minecraft spielen will. Was kann ich tun? (Wenn es gebraucht wird, werde ich mir die Zeit nehmen und die Versionen und Ersteller der Mods und Recources raussuchen.)   Alle Mods, Resources und Modloader-packs sind auf der neusten Version Standpunkt 29.02.2024   - Forge: Meine Zusammenstellung besteht aus 121 Mods und 6 Resources. Was passiert: Wenn ich Spielen will, komm ich zwar in den Launcher und der Ladebildschirm taucht auf, bricht allerdings ab und bekomme eine Fehlermeldung. Fehlermeldung: The game crashed whilst initializing game Error: net.minecraftforge.fml.loading.EarlyLoadingException: Could not execute entrypoint stage 'main' due to errors, provided by 'eldritch_end'! Exitcode: -1 Wenn ich allerdings Eldrich End aus schalte, kommt ebenfalls eine. Fehlermeldung: The game crashed whilst initializing game Error: java.lang.NoClassDefFoundError: Could not initialize class net.minecraft.client.renderer.RenderType Exitcode: -1 Liste der Mods: A.V.A-Alliance of  Valiant Arms Guns Ad Astra Additional Lanterns Additional Structures Alex's Mobs Aquacolture 2 Aquamirae (Forge) Architectury API (Fabric/Forge/NeoForge) Armore Statues [Forge & Fabric] Armored Redstone AzurLib Balm (Forge Editon) Better Villages - Fabric BetterF3 Biomes O' Plenty Blue Skies Botarium CalamityMusicDisc Camera Mod Charm of Undying (Fabric/Forge/Quilt) Citadel Clasic musical discs Cloth Config API (Fabric/Forge/NeoForge) Config API [Fabric/Forge/NeoForge/Quilt] Connected Glass Connector Extras Cristel Lib Curios API (Forge/NeoForge) Curious Armor Stands Denki's Music Disc DivineRPG (Official) Dragon Mounts: Legacy Eldrich End Energized Power Eureka! Ships! for Valkyrien Skies (Forge/Fabric) Fish Tanks Forgified Fabric API Fussion (Connected Textures) Gamma Creatures GeckoLib Handcrafted HorkLord's Musik Discs Ice and Fire: Dragons Immersiv Melodies (Fabric/Forge) Immersiv Paintings (Fabric/Forge) Immersiv Structures Infinit Abyss Just Enough Items (JEI) Kotlin for Forge L_Enders Catalysm Library Ferret - Forge Macaw's Bridges Macaw's Doors Many More Music Discs [FORGE] MCEF (Minecraft Chromium Embedded  Framework) Mobs Head Modonomicon Monster Plus More Bows CJ (Fabric/Forge/Quilt) More Crossbows CJ (Fabric/Forge/Quilt) Morer Music Discs (Records) More Music Discs (Fabric/Forge/NeoForge) Moving Elevators MrCrayfish's Furniture Mod Multipart Machines: Mining Music Discs Galore Musical Instrument Minecraft Interface (MIMI) Musical Lib Mythic Mounts (Forge) Necronomicon API Nether Exorcism Netherrite Horse Armor CJ [Fabric/Forge/Quilt] Nullscape Nyctophobia (FABRIC) Obscure API (Fabric) Obscure Tooltips Occultism Ore Tree:Reeborn Patchouli Puzzles Lib [Forge & Fabric] Redstone engineering Redstone Lamp Plus Regions Unexplored (forge/fabric) Resourceful Config Resourceful Lib Scuffy Music Disc Pack Securety Craft Shadowlands Sinytra Connector SmartBrainLib (Forge/Fabric/Quilt) Spawn Structory Structory: Towers Structure Gel API  SuperMartijn642's Config Lib SuperMartijn642's Core Lib TerraBlender (Forge) The Ather The Graveyard (FORGE/NEOFORGE) The Twilight Forrest Towns and Towers Trash Cans Traveler' Backpack Valhelsia Core Valhelsia Structures Valkyrien Skies (Forge/Fabric) Waddles Waystones DebDisplays Wireles_Redstone Wither's Wepons YUNG'S API (Forge) YUNG'S Better Desert Temples (Forge) YUNG'S Better Dungeons (Forge) YUNG'S Better End Island (Forge) YUNG'S Better Jungle Temples (Forge) YUNG'S Better Mineshafts (Forge) YUNG'S Better Nether Fortresses (Forge) YUNG'S Better Ocean Monuments (Forge) YUNG'S Better Sreongholds (Forge) YUNG'S Better Witch Huts (Forge)   Liste der Resources: Better Cats Better Dogs Boss Refreshed Enhanced Boss Bars Visible Ores Zerotekz's Mythic Weapons     - Fabric: Meine Zusammenstellung besteht aus 61 Mods und 6 Resources. Was passiert: Wenn ich Spielen will, komm ich zwar in den Launcher, aber ich komme noch nicht einmal in den Ladebildschirm und drückt mir direkt eine Fehlermeldung rein. Fehlermeldung: The game crashed whilst initializing game Error: java.lang.NoSuchMethodError: 'java.lang.Object[] org.apache.commons.lang3.ArrayUtils.addFirst(java.lang.Object[], java.lang.Object)' Exitcode: -1 Liste der Mods: Ad Astra Additional Lanterns Aquamirae (Fabric) Architectury API (Fabric/Forge/NeoForge) AzurLib Better Villages - Fabric BetterF3 Bosses Of Mass Destruction Botarium Cardinal Components API Cloth Config API (Fabric/Forge/NeoForge) Clutter Config API [Fabric/Forge/NeoForge/Quilt] Cristel Lib Eldrich End Energized Power Eureka! Ships! for Valkyrien Skies (Forge/Fabric) Fabric API Fabric Language Kotlin GeckoLib Handcrafted Immersiv Armors (Fabric/Forge) Immersiv Melodies (Fabric/Forge) Immersiv Paintings (Fabric/Forge) Immersiv Structures Library Ferret - Fabric Macaw's Bridges Macaw's Doors More Bows CJ (Fabric/Forge/Quilt) More Crossbows CJ (Fabric/Forge/Quilt) More Music Discs (Fabric/Forge/NeoForge) Moving Elevators Mythic Mounts Necronomicon API Nullscape Nyctophobia (FABRIC) Obscure API (Fabric) Patchouli (Fabric) Regions Unexplored (forge/fabric) Resourceful Config Resourceful Lib Spawn Structory Structory: Towers SuperMartijn642's Config Lib SuperMartijn642's Core Lib TerraBlender (Fabric) The Graveyard (FABRIC) Towns and Towers Trash Cans Valkyrien Skies (Forge/Fabric) YUNG'S API (Fabric) YUNG'S Better Desert Temples (Fabric) YUNG'S Better Dungeons (Fabric) YUNG'S Better End Island (Fabric) YUNG'S Better Jungle Temples (Fabric) YUNG'S Better Mineshafts (Fabric) YUNG'S Better Nether Fortresses (Fabric) YUNG'S Better Ocean Monuments (Fabric) YUNG'S Better Sreongholds (Fabric) YUNG'S Better Witch Huts (Fabric)   Liste der Resources: Better Cats Better Dogs Boss Refreshed Enhanced Boss Bars Visible Ores Zerotekz's Mythic Weapons
    • When i click a jar file there's a black window popping out for a second then closing i don't know what to do, it's been happening for 2 days already
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.