Jump to content

Crafting recipes enable/disable with config file [1.16]


Razor

Recommended Posts

Hey guys, i try to make recipes based of config options, but i can`t find the problem here, all recipes linked to an config options are always disabled and theres no error in the console, maybe a problem in the factories?

 

ConditionsFactory

public class ConditionFactory implements IConditionBuilder {

        //@Override
        public BooleanSupplier parse(JsonSerializationContext context, JsonObject json) {
            boolean value = JSONUtils.getBoolean(json , "value", true);
            String key = JSONUtils.getString(json, "type");

            if (key.equals(Uncrafted.MODID + ":spawneggs_enabled")) {
                return () -> Config.ACTIVATE_SPAWNEGG_RECIPES.get().booleanValue() == value;
            }
            else if (key.equals(Uncrafted.MODID + ":spawner_enabled")) {
                return () -> Config.ACTIVATE_SPAWNER_RECIPES.get().booleanValue() == value;
            }
            else if (key.equals(Uncrafted.MODID + ":skulls_enabled")) {
                return () -> Config.ACTIVATE_SKULL_RECIPES.get().booleanValue() == value;
            }
            return null;
        }
}

 

_factories.json

{
    "conditions": {
      "spawneggs_enabled": "xxrexraptorxx.util.ConditionFactory",
      "spawner_enabled": "xxrexraptorxx.util.ConditionFactory",
      "skulls_enabled": "xxrexraptorxx.util.ConditionFactory"
    }
}

 

example recipe: spawner.json

{
  "conditions" : [
    {
      "type" : "uncrafted:spawner_enabled",
      "value" : true
    } ],
  "type": "minecraft:crafting_shaped",
  "pattern": [
  
    "XXX",
    "X#X",
    "XXX"
  ],
  
  "key": {
    "X": {
      "item": "minecraft:iron_bars"
    },
    "#": {
      "item": "minecraft:nether_star"
    }  
  },
  
  
  "result": {
    "item": "minecraft:spawner"
  }
}

 

i hope anyone can help me :D

 

 

Link to comment
Share on other sites

scrap all that (factory and _factories.json), it's for an older version.

do have a condition in a recipe json file. the one you have up there will do fine.

 

make a class that implements ICondition.
getID() should return "uncrafted:spawner_enabled".  test() should check options and enable/disable the recipe.

 

inside the condition class make a serializer class (yes inside, inner class, static) that implements IConditionSerializer<YourCondition>.
getID should return same as above;  read should return an instance of your condition class. use json.getAsJsonPrimitive("value_or_flag_name_or_whatever") to get the setting name (if you use a single condition for several recipes); write should do the opposite of read - json.addProperty.

 

finally, register your condition in FMLCommonSetupEvent. call CraftingHelper.register and pass the serializer instance.

enjoy!

  • Like 1
Link to comment
Share on other sites

one class inside another, just like you have fields and methods inside of a class. ok, i admit it's not very intuitive now that type definitions are no longer a thing...

it doesn't have to be inner class, it can be a separate class. it's just more maintainable if you don't have two separate non-inner classes whose life cycles are connected.

just make both classes. serializer will make condition class instances when the game needs them.

Link to comment
Share on other sites

  • 1 month later...
On 10/21/2021 at 9:41 PM, MFMods said:

one class inside another, just like you have fields and methods inside of a class. ok, i admit it's not very intuitive now that type definitions are no longer a thing...

it doesn't have to be inner class, it can be a separate class. it's just more maintainable if you don't have two separate non-inner classes whose life cycles are connected.

just make both classes. serializer will make condition class instances when the game needs them.

Could You Please Provide a simple example, I do understand java but this has me all in a twist

Link to comment
Share on other sites

{
    "conditions":[
        {
            "type":"mbs:mod_check",
            "modid":"mbs"
        }
    ],
    "type": "minecraft:crafting_shaped",
    "pattern": [
        "###",
        "# #"
    ],
    "key": {
        "#": {
            "item": "mbs:blue_diamond"
        }
    },
    "result": {
        "item": "mbs:armor/blue_diamond_helmet",
        "count": 1
    }
}
package com.SkyWarsFun2019.moreblock.util.Integration;

import com.google.gson.JsonObject;

import net.minecraft.resources.ResourceLocation;
import net.minecraft.util.GsonHelper;
import net.minecraftforge.common.crafting.conditions.ICondition;
import net.minecraftforge.common.crafting.conditions.IConditionSerializer;
import net.minecraftforge.fml.ModList;

public class ModIntegrationRecipeCondition implements ICondition
{
	private static final ResourceLocation NAME = new ResourceLocation("mbs", "mod_check");
	private final String Modid;

	public ModIntegrationRecipeCondition(String Mod) 
	{
		Modid = Mod;
	}
	
	@Override
	public ResourceLocation getID()
	{
		return NAME;
	}

	@Override
	public boolean test() 
	{
		System.out.println("Testing");
		return ModList.get().isLoaded(Modid);
	}
	 @Override
	public String toString()
	{
	    return "mod_loaded(\"" + Modid + "\")";
	}
	 
	 public static class Serializer implements IConditionSerializer<ModIntegrationRecipeCondition>
	    {
	        public static final Serializer INSTANCE = new Serializer();

	        @Override
	        public void write(JsonObject json, ModIntegrationRecipeCondition value)
	        {
	            json.addProperty("modid", value.Modid);
	        }

	        @Override
	        public ModIntegrationRecipeCondition read(JsonObject json)
	        {
	            return new ModIntegrationRecipeCondition(GsonHelper.getAsString(json, "modid"));
	        }

	        @Override
	        public ResourceLocation getID()
	        {
	            return ModIntegrationRecipeCondition.NAME;
	        }
	    }
}

 

this is my json and class, any reason why it doesnt work.

Edited by DX12
Updated Information, Provided More Details
Link to comment
Share on other sites

Just now, diesieben07 said:
  • "mbs" is a bad ModID. Do not use abbreviations.
  • You do not own SkyWarsFun2019.com.
  • Forge already provides the "forge:mod_loaded" condition, there is no need to implement it yourself.
  • You have not shown where you register your condition.

for the first and second part I Am co-owner, the original owner set that.

private void Setup(FMLCommonSetupEvent event)
	{
		event.enqueueWork(OreGen::RegisterOre);
		List<String> Mods = Searcher.GetModIDs(event);
		Searcher.PrintMods(Mods);
		System.out.println("Condition Register Starting");
		CraftingHelper.register(new ModIntegrationRecipeCondition.Serializer());
		System.out.println("Condition Register Complete");
	}

this is where and how it is registered. as with the third point i plan to change this to run a check on the mod config file

Link to comment
Share on other sites

Quote

[14:39:47] [Render thread/INFO]: Reloading ResourceManager: Default, , main
Serializer Read
mod_check("mbs")
Condition Test
true
[14:40:11] [Render thread/INFO]: Loaded 7 recipes

Here is the specific info you requested. I only included these lines

Edited by DX12
Updated Information, Provided More Details
Link to comment
Share on other sites

Quote

Here is the specific info you requested.

that output was for you, not us.


i wanted you to assert two things:
1) serializer creates a condition with value true when config file says true
2) serializer creates a condition with value false when config file says false (after you exit the game, change config, start the game)

can you confirm that you have that?

Link to comment
Share on other sites

  • 3 weeks later...
On 12/22/2021 at 10:57 PM, MFMods said:

that output was for you, not us.


i wanted you to assert two things:
1) serializer creates a condition with value true when config file says true
2) serializer creates a condition with value false when config file says false (after you exit the game, change config, start the game)

can you confirm that you have that?

Apologies for the late response, My computer had malfunctioned. To answer your question yes I do get the false and true when test is ran. however the issue im having is regardless of the value the recipe doesnt register. Also I have created A new topic to discuss this further.

Here is the topic Topic

Edited by DX12
Added Topic Link
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I am unable to resolve my current issue, I have successfully downloaded the forge extension. I downloaded the correct Java link with Javafix included. I log into the game and it shows the "forge" launcher active menu. I double checked to make sure it was the right release number of minecraft and it matched the forge download as well, this also including the most recent forge client. The issue is when I go into a new minecraft server it doesn't allow me to do //wand. No matter what I try the same issue is following me, it almost seems as if the client is fully active but something isn't allowing it to run on my computer. I would appreciate some assistance regarding my problem.   Thank you
    • Came here for the same reason. But for me it's the client. After following your instructions with the jar, I ended up with the following error. I assume to have chosen the right jar   -jar "${lminecraft_library_path}/net/minecraftforge/forge/1.20.4-49.0.3/forge-1.20.4-49.0.3-shim.jar"   Minecraft 1.20.4 Forge: 1.20.4 - 49.0.3   ;--- cut here --- [7.633s][info][class,load] cpw.mods.jarhandling.SecureJar$ModuleDataProvider source: file:/home/habibiboy/.minecraft/libraries/net/minecraftforge/securemodules/2.2.7/securemodules-2.2.7.jar [7.636s][info][class,load] java.security.CodeSigner source: jrt:/java.base [7.636s][info][class,load] java.nio.file.spi.FileSystemProvider$1 source: jrt:/java.base [7.637s][info][class,load] java.util.ServiceLoader source: shared objects file [7.639s][info][class,load] java.util.ServiceLoader$ModuleServicesLookupIterator source: shared objects file [7.639s][info][class,load] java.util.Spliterators$ArraySpliterator source: shared objects file [7.640s][info][class,load] java.util.Spliterators$1Adapter source: shared objects file [7.643s][info][class,load] java.util.Arrays$ArrayList source: shared objects file [7.648s][info][class,load] java.util.concurrent.CopyOnWriteArrayList$COWIterator source: shared objects file [7.649s][info][class,load] java.util.ServiceLoader$LazyClassPathLookupIterator source: shared objects file [7.649s][info][class,load] java.util.ServiceLoader$2 source: shared objects file [7.649s][info][class,load] java.util.ServiceLoader$3 source: shared objects file [7.652s][info][class,load] jdk.internal.module.ModulePatcher$PatchedModuleReader source: jrt:/java.base [7.654s][info][class,load] sun.net.www.protocol.jrt.Handler source: jrt:/java.base [7.663s][info][class,load] jdk.nio.zipfs.ZipFileSystemProvider source: jrt:/jdk.zipfs [7.667s][info][class,load] java.nio.file.FileSystemNotFoundException source: jrt:/java.base [7.672s][info][class,load] jdk.nio.zipfs.ZipFileSystem source: jrt:/jdk.zipfs [7.675s][info][class,load] java.lang.UnsupportedOperationException source: jrt:/java.base [7.676s][info][class,load] java.util.zip.ZipException source: jrt:/java.base [7.677s][info][class,load] java.nio.file.ProviderMismatchException source: jrt:/java.base [7.680s][info][class,load] java.nio.file.AccessMode source: jrt:/java.base [7.681s][info][class,load] java.nio.file.DirectoryStream$Filter source: jrt:/java.base [7.683s][info][class,load] java.nio.file.DirectoryStream source: jrt:/java.base [7.684s][info][class,load] java.nio.file.FileStore source: jrt:/java.base [7.688s][info][class,load] java.util.concurrent.Executor source: shared objects file [7.688s][info][class,load] java.util.concurrent.ExecutorService source: shared objects file [7.690s][info][class,load] java.nio.channels.AsynchronousChannel source: jrt:/java.base [7.690s][info][class,load] java.nio.channels.AsynchronousFileChannel source: jrt:/java.base [7.691s][info][class,load] java.util.ServiceLoader$1 source: shared objects file [7.692s][info][class,load] java.util.ServiceLoader$Provider source: shared objects file [7.692s][info][class,load] java.util.ServiceLoader$ProviderImpl source: shared objects file [7.693s][info][class,load] jdk.internal.reflect.DirectConstructorHandleAccessor source: shared objects file [7.695s][info][class,load] jdk.internal.jrtfs.JrtFileSystemProvider source: jrt:/java.base [7.699s][info][class,load] java.util.Collections$EmptyEnumeration source: shared objects file [7.699s][info][class,load] jdk.internal.loader.BuiltinClassLoader$1 source: shared objects file [7.700s][info][class,load] java.lang.CompoundEnumeration source: shared objects file [7.701s][info][class,load] jdk.internal.loader.URLClassPath$1 source: shared objects file [7.702s][info][class,load] sun.net.www.protocol.jrt.JavaRuntimeURLConnection source: jrt:/java.base [7.710s][info][class,load] sun.net.www.protocol.jrt.JavaRuntimeURLConnection$$Lambda/0x00007f5d70055728 source: sun.net.www.protocol.jrt.JavaRuntimeURLConnection [7.719s][info][class,load] sun.net.www.protocol.jrt.JavaRuntimeURLConnection$1 source: jrt:/java.base [7.720s][info][class,load] jdk.internal.jimage.ImageBufferCache source: jrt:/java.base [7.722s][info][class,load] jdk.internal.jimage.ImageBufferCache$1 source: jrt:/java.base [7.723s][info][class,load] jdk.internal.jimage.ImageBufferCache$2 source: jrt:/java.base [7.724s][info][class,load] java.util.AbstractMap$SimpleEntry source: jrt:/java.base [7.727s][info][class,load] java.util.LinkedHashMap$LinkedKeySet source: jrt:/java.base [7.731s][info][class,load] java.util.LinkedHashMap$LinkedHashIterator source: shared objects file [7.731s][info][class,load] java.util.LinkedHashMap$LinkedKeyIterator source: jrt:/java.base [7.732s][info][class,load] java.util.Collections$UnmodifiableList source: shared objects file [7.732s][info][class,load] java.util.Collections$UnmodifiableRandomAccessList source: shared objects file [7.736s][info][class,load] java.lang.invoke.LambdaForm$DMH/0x00007f5d7000c400 source: __JVM_LookupDefineClass__ [7.741s][info][class,load] cpw.mods.jarhandling.impl.Jar$$Lambda/0x00007f5d7000adb0 source: cpw.mods.jarhandling.impl.Jar [7.746s][info][class,load] cpw.mods.jarhandling.impl.Jar$$Lambda/0x00007f5d7000aff8 source: cpw.mods.jarhandling.impl.Jar [7.748s][info][class,load] java.lang.ExceptionInInitializerError source: jrt:/java.base [7.749s][info][class,load] java.lang.StackTraceElement$HashedModules source: jrt:/java.base [7.751s][info][class,load] java.lang.invoke.WrongMethodTypeException source: jrt:/java.base [7.751s][info][class,load] java.lang.reflect.InvocationTargetException source: jrt:/java.base Exception in thread "main" [7.758s][info][class,load] java.lang.Throwable$PrintStreamOrWriter source: jrt:/java.base [7.759s][info][class,load] java.lang.Throwable$WrappedPrintStream source: jrt:/java.base java.lang.reflect.InvocationTargetException     at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:118)     at java.base/java.lang.reflect.Method.invoke(Method.java:580)     at net.minecraftforge.bootstrap.shim.Main.main(Main.java:94) Caused by: java.lang.ExceptionInInitializerError     at cpw.mods.jarhandling.SecureJar.from(SecureJar.java:64)     at cpw.mods.jarhandling.SecureJar.from(SecureJar.java:60)     at net.minecraftforge.bootstrap.ClassPathHelper.getCleanedClassPathImpl(ClassPathHelper.java:178)     at net.minecraftforge.bootstrap.ClassPathHelper.getCleanedClassPath(ClassPathHelper.java:46)     at net.minecraftforge.bootstrap.Bootstrap.start(Bootstrap.java:28)     at net.minecraftforge.bootstrap.ForgeBootstrap.main(ForgeBootstrap.java:18)     at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)     ... 2 more Caused by: java.lang.IllegalStateException: Couldn't find UnionFileSystemProvider     at cpw.mods.jarhandling.impl.Jar.lambda$static$1(Jar.java:48)     at java.base/java.util.Optional.orElseThrow(Optional.java:403)     at cpw.mods.jarhandling.impl.Jar.<clinit>(Jar.java:48)     ... 9 more [7.783s][info][class,load] java.util.IdentityHashMap$IdentityHashMapIterator source: shared objects file [7.784s][info][class,load] java.util.IdentityHashMap$KeyIterator source: shared objects file [7.787s][info][class,load] java.lang.Shutdown source: shared objects file [7.789s][info][class,load] java.lang.Shutdown$Lock source: shared objects file ;--- cut here ---   I tried various things here. Java 17, then Java 21, Searched for missing objects, used strace -ff java ... and so on. The securejar class is there, accessible, permissions all fine. Still running into this issue.
    • sorry for the late answer, I tried it but i hadthe same result crash reportlog
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.