Jump to content

[SOLVED] GUI opens but won't allow item pickup


nerdboy64

Recommended Posts

I'm working on a mod that opens a GUI with a keypress and allows you to edit item names, enchantments, lore, etc. At the moment, I have created the basic GUI and added the player's inventory to it as well as the slot for the item you want to edit. It will open and display just fine, but when I try to pick up an item, it reverts back to its original slot after a fraction of a second. I've hunted around, but all the tutorials I find are outdated. I've found one other help thread on the topic, but the OP never released the code that fixed it so it wasn't any help.

 

Anyone know how to fix this problem? Relevant code is below. I found the problem. See the edit below.

 

My container:

package mapassist;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.player.InventoryPlayer;
import net.minecraft.inventory.Container;
import net.minecraft.inventory.IInventory;
import net.minecraft.inventory.InventoryBasic;
import net.minecraft.inventory.Slot;
import net.minecraft.world.World;

public class ContainerItemEdit extends Container {

public InventoryPlayer inventory;
public IInventory item = new InventoryBasic("Item", false, 1);
World world;
int x, y, z;

public ContainerItemEdit(InventoryPlayer inventory, World world, int x, int y, int z){
	this.inventory = inventory;
	this.world = world;
	this.x = x;
	this.y = y;
	this.z = z;
	addSlotToContainer(new Slot(inventory, 36, 8, 20));
	bindPlayerInventory(inventory);
}

@Override
public boolean canInteractWith(EntityPlayer entityplayer) {
	return true;
}

protected void bindPlayerInventory(InventoryPlayer inventoryPlayer) {
     for (int i = 0; i < 3; i++) {
       for (int j = 0; j < 9; j++) {
         addSlotToContainer(new Slot(inventoryPlayer, j + (i * 9) + 9, 
           8 + j * 18, 84 + i * 18));
       }
     }

     for (int i = 0; i < 9; i++)
       addSlotToContainer(new Slot(inventoryPlayer, i, 8 + i * 18, 142));
   }

}

 

Key handler class (opens the container):

package mapassist;

import java.io.ByteArrayOutputStream;
import java.io.DataOutputStream;
import java.io.IOException;
import java.util.EnumSet;

import net.minecraft.client.Minecraft;
import net.minecraft.client.settings.KeyBinding;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.network.packet.Packet250CustomPayload;
import cpw.mods.fml.client.registry.KeyBindingRegistry;
import cpw.mods.fml.common.FMLCommonHandler;
import cpw.mods.fml.common.TickType;
import cpw.mods.fml.common.network.PacketDispatcher;
import cpw.mods.fml.relauncher.Side;

public class KeyHandler extends KeyBindingRegistry.KeyHandler{

private static KeyBinding[] keys = {
	new KeyBinding("Open Mapmaker's Assistant", 19)
};

public KeyHandler() {
	super(keys, new boolean[keys.length]);
}

@Override
public String getLabel() {
	return "Key bindings for Mapmaker's Assistant";
}

@Override
public void keyDown(EnumSet<TickType> types, KeyBinding kb, boolean tickEnd, boolean isRepeat) {
	EntityPlayer player = Minecraft.getMinecraft().thePlayer;
	if(tickEnd && kb.keyCode == keys[0].keyCode && Minecraft.getMinecraft().currentScreen == null && player.capabilities.isCreativeMode){
		//player.addChatMessage("Congratulations! You pressed the R key!");
		player.openGui(MapAssist.instance, 0, player.worldObj, (int)player.posX, (int)player.posY, (int)player.posZ);
	}
}

@Override
public void keyUp(EnumSet<TickType> types, KeyBinding kb, boolean tickEnd) {

}

@Override
public EnumSet<TickType> ticks() {
	EnumSet<TickType> ticks = EnumSet.of(TickType.CLIENT);
	return ticks;
}

}

 

Base mod class:

package mapassist;

import cpw.mods.fml.common.Mod;
import cpw.mods.fml.common.Mod.EventHandler;
import cpw.mods.fml.common.Mod.Instance;
import cpw.mods.fml.common.SidedProxy;
import cpw.mods.fml.common.event.FMLInitializationEvent;
import cpw.mods.fml.common.network.NetworkMod;
import cpw.mods.fml.common.network.NetworkRegistry;

@Mod(modid="mapassist", name="Mapmaker's Assistant", version="0.1.0")
@NetworkMod(clientSideRequired=true, serverSideRequired=true, channels={"mapassist"}, packetHandler=PacketHandler.class)
public class MapAssist {

@SidedProxy(clientSide="mapassist.ProxyClient", serverSide="mapassist.ProxyCommon")
public static ProxyCommon proxy;
@Mod.Instance(value="mapassist")
public static MapAssist instance;

public static final short ITEMEDIT = 1;

@EventHandler
public void load(FMLInitializationEvent event){
	NetworkRegistry.instance().registerGuiHandler(this, new GuiHandler());
}

}

 

EDIT: Shortly after posting this, I figured out what the problem was. Keypresses are only registered client-side, so I just had to set up a packet handler to open the container on the server. For anyone else who wants to do the same thing, the new code is below:

 

New key handler:

package mapassist;

import java.io.ByteArrayOutputStream;
import java.io.DataOutputStream;
import java.io.IOException;
import java.util.EnumSet;

import net.minecraft.client.Minecraft;
import net.minecraft.client.settings.KeyBinding;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.network.packet.Packet250CustomPayload;
import cpw.mods.fml.client.registry.KeyBindingRegistry;
import cpw.mods.fml.common.FMLCommonHandler;
import cpw.mods.fml.common.TickType;
import cpw.mods.fml.common.network.PacketDispatcher;
import cpw.mods.fml.relauncher.Side;

public class KeyHandler extends KeyBindingRegistry.KeyHandler{

private static KeyBinding[] keys = {
	new KeyBinding("Open Mapmaker's Assistant", 19)
};

public KeyHandler() {
	super(keys, new boolean[keys.length]);
}

@Override
public String getLabel() {
	return "Key bindings for Mapmaker's Assistant";
}

@Override
public void keyDown(EnumSet<TickType> types, KeyBinding kb, boolean tickEnd, boolean isRepeat) {
	EntityPlayer player = Minecraft.getMinecraft().thePlayer;
	if(tickEnd && kb.keyCode == keys[0].keyCode && Minecraft.getMinecraft().currentScreen == null && player.capabilities.isCreativeMode){
		//player.addChatMessage("Congratulations! You pressed the R key!");
		player.openGui(MapAssist.instance, 0, player.worldObj, (int)player.posX, (int)player.posY, (int)player.posZ);

		Packet250CustomPayload pkt = new Packet250CustomPayload();
	    ByteArrayOutputStream bytes = new ByteArrayOutputStream();
	    DataOutputStream data = new DataOutputStream(bytes);
	    try {
	    	data.writeByte(1);
	    } catch (IOException e) {
	    	e.printStackTrace();
	    }
	    pkt.channel = "mapassist";
	    pkt.data = bytes.toByteArray();
	    pkt.length = pkt.data.length;
	    PacketDispatcher.sendPacketToServer(pkt);
	}
}

@Override
public void keyUp(EnumSet<TickType> types, KeyBinding kb, boolean tickEnd) {

}

@Override
public EnumSet<TickType> ticks() {
	EnumSet<TickType> ticks = EnumSet.of(TickType.CLIENT);
	return ticks;
}

}

 

Packet handler:

package mapassist;

import java.io.ByteArrayInputStream;
import java.io.DataInputStream;
import java.io.IOException;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.network.INetworkManager;
import net.minecraft.network.packet.Packet250CustomPayload;
import cpw.mods.fml.common.network.IPacketHandler;
import cpw.mods.fml.common.network.Player;

public class PacketHandler implements IPacketHandler {

@Override
public void onPacketData(INetworkManager manager, Packet250CustomPayload packet, Player player) {
	ByteArrayInputStream bytes = new ByteArrayInputStream(packet.data);
    DataInputStream data = new DataInputStream(bytes);

    try{
    	if(data.readByte() == 1){
    		EntityPlayer entityplayer = ((EntityPlayer)player);
    		entityplayer.openGui(MapAssist.instance, 0, entityplayer.worldObj, (int)entityplayer.posX, (int)entityplayer.posY, (int)entityplayer.posZ);
    	}
    } catch(IOException e){
		e.printStackTrace();
	}
}

}

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hey folks. I am working on a custom "Mecha" entity (extended from LivingEntity) that the player builds up from blocks that should get modular stats depending on the used blocks. e.g. depending on what will be used for the legs, the entity will have a different jump strength. However, something unexpected is happening when trying to override a few of LivingEntity's functions and using my new own "Mecha" specific fields: instead of their actual instance-specific value, the default value is used (0f for a float, null for an object...) This is especially strange as when executing with the same entity from a point in the code specific to the mecha entity, the correct value is used. Here are some code snippets to better illustrate what I mean: /* The main Mecha class, cut down for brevity */ public class Mecha extends LivingEntity { protected float jumpMultiplier; //somewhere later during the code when spawning the entity, jumpMultiplier is set to something like 1.5f //changing the access to public didn't help @Override //Overridden from LivingEntity, this function is only used in the jumpFromGround() function, used in the aiStep() function, used in the LivingEntity tick() function protected float getJumpPower() { //something is wrong with this function //for some reason I can't correctly access the fields and methods from the instanciated entity when I am in one of those overridden protected functions. this is very annoying LogUtils.getLogger().info(String.valueOf(this.jumpMultiplier))) //will print 0f return this.jumpMultiplier * super.getJumpPower(); } //The code above does not operate properly. Written as is, the entity will not jump, and adding debug logs shows that when executing the code, the value of this.jumpMultiplier is 0f //in contrast, it will be the correct value when done here: @Override public void tick() { super.tick(); //inherited LivingEntity logic //Custom logic LogUtils.getLogger().info(String.valueOf(this.jumpMultiplier))) //will print 1.5f } } My actual code is slightly different, as the jumpMuliplier is stored in another object (so I am calling "this.legModule.getJumpPower()" instead of the float), but even using a simple float exactly like in the code above didn't help. When running my usual code, the object I try to use is found to be null instead, leading to a crash from a nullPointerException. Here is the stacktrace of said crash: The full code can be viewed here. I have found a workaround in the case of jump strength, but have already found the same problem for another parameter I want to do, and I do not understand why the code is behaving as such, and I would very much like to be able to override those methods as intended - they seemed to work just fine like that for vanilla mobs... Any clues as to what may be happening here?
    • Please delete post. Had not noticed the newest edition for 1.20.6 which resolves the issue.
    • https://paste.ee/p/GTgAV Here's my debug log, I'm on 1.18.2 with forge 40.2.4 and I just want to get it to work!! I cant find any mod names in the error part and I would like some help from the pros!! I have 203 mods at the moment.
    • In 1.20.6 any potion brewed in the brewing stand disappears upon completion.
    • My game crashes whenever I click on Singleplayer then it crashes after the "Saving world". I'm playing on fabric 1.20.1 on forge for the easy instance loading. My game is using 12GB of RAM, I tried deleting the options.txt, and also renaming the saves file but neither worked. Here's the crash report link: https://mclo.gs/qByOqVK
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.