Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

Issue with capability


matthew123
 Share

Recommended Posts

This is my capability provider.

public class MyCapabilityProvider implements ICapabilitySerializable<INBT> {
    @CapabilityInject(IMyCapability.class)
    public static Capability<IMyCapability> My_CAPABILITY = null;

    private final LazyOptional<IMyCapability> lazyOptional = LazyOptional.of(MyCapability::new);

    @Nonnull
    @Override
    public <T> LazyOptional<T> getCapability(@Nonnull Capability<T> capability, @Nullable Direction side) {
        if (capability == My_CAPABILITY) {
            return lazyOptional.cast();
        }
        return LazyOptional.empty();
    }

    @Override
    public INBT serializeNBT() {
        return My_CAPABILITY.getStorage().writeNBT(My_CAPABILITY, lazyOptional.orElseThrow(() -> new IllegalArgumentException("LazyOptional must not be empty!")), null);
    }

    @Override
    public void deserializeNBT(INBT nbt) {
        My_CAPABILITY.getStorage().readNBT(My_CAPABILITY, lazyOptional.orElseThrow(() -> new IllegalArgumentException("LazyOptional must not be empty!")), null, nbt);
    }
}

 

The issue is that the values written to the disk are the default values for my capability data. I added some logging to the storage class, and this confirms it.

Why is that happening? 

Link to comment
Share on other sites

3 minutes ago, diesieben07 said:

Show where you are changing the values.

I am actually changing it in many places. My interface accesses the capability on the player to draw it.

This is where it gets updated on the server:

public static void handlePacket(ClientSyncOverlayMessage message, Supplier<NetworkEvent.Context> ctx) {
    LogManager.getLogger().info("Got sync overlay message! Selected: " + message.getSelectedTechnique().getId() + " nature: " + message.getSelectedTechnique().getNature());

    ServerPlayerEntity playerEntity = ctx.get().getSender();
    playerEntity.getCapability(TechniqueCapabilityProvider.Technique_CAPABILITY).ifPresent(TechniqueCapability -> {
       
        TechniqueCapability.setSelectedTechniqueFor(message.getSelectedTechnique().getNature(), message.getSelectedTechnique());
        LOGGER.info("Updated selected Technique to " + message.getSelectedTechnique().getId() + ", power level: " + message.getSelectedTechnique().getPower());
        LOGGER.info("PW after update: " + TechniqueCapability.getSelectedTechniqueFor(TechniqueCapability.getSelectedNatureOrDefault()).getPower());
    });
}

P.S i renamed the capability to TechniqueCapability in this example.

Edited by matthew123
Link to comment
Share on other sites

12 hours ago, diesieben07 said:

Examples are not useful, as the issue is with your code, not with some example.

Is this code executed? Does it do the correct thing?

The code above is used to synchronize the capability on the server. The correct values are printed out by the logger, but when I check the values with NBTExplorer, they are the default ones. Thus, when re-joining the singleplayer world, the capability has the default values.

Link to comment
Share on other sites

 

17 hours ago, diesieben07 said:

Show where you are changing the values.

private static int executeCommand(CommandContext<CommandSource> commandContext) throws CommandSyntaxException {
    Entity entity = commandContext.getSource().getEntity();
    TranslationTextComponent finalText = new TranslationTextComponent("chat.type.announcement",
            commandContext.getSource().getDisplayName(), new StringTextComponent("ok"));
    commandContext.getSource().getServer().getPlayerList().broadcastMessage(finalText, ChatType.CHAT, entity.getUUID());
        ServerPlayerEntity playerEntity =  commandContext.getSource().getPlayerOrException();
        playerEntity.getCapability(AbilityCapabilityProvider.Ability_CAPABILITY).ifPresent(AbilityData -> {
            AbilityData.addAbility(NatureTypes.A, new AbilityData(NatureTypes.A, "mymod:a", 0, 0, 1));
            AbilityData.addAbility(NatureTypes.A, new AbilityData(NatureTypes.A, "mymod:b", 0, 0, 1));
            AbilityData.addAbility(NatureTypes.B, new AbilityData(NatureTypes.B, "mymod:c", 0, 0, 1));
            AbilityData.addAbility(NatureTypes.B, new AbilityData(NatureTypes.B, "mymod:d", 0, 0, 1));
            AbilityData.addAbility(NatureTypes.D, new AbilityData(NatureTypes.D, "mymod:e", 0, 0, 1));
            AbilityData.addAbility(NatureTypes.E, new AbilityData(NatureTypes.E, "mymod:f", 0, 0, 1));
            ModNetwork.sendTo(new ServerSyncAbilityMessage(AbilityData), playerEntity);
            ModNetwork.sendTo(new ServerSyncPowerMessage(42, 42), playerEntity);
        });
    return 1;
}

 

Link to comment
Share on other sites

From what I can tell it functions correctly.

Your NBT format is absolutely bizarre though:

  • Why on earth is "Selected Nature" in the same compound tag as all the Jutsu data?
  • Why are you using spaces in the keys?
  • Why on earth did you decide that putting "[SELECTED] " in front of the key was a good way to mark an entry as selected instead of just... you know... a boolean?
  • Why on earth does JutsuData.serialize / deserialize use a random ad-hoc string format instead of, you know, serializing its values to a NBT compound tag?
Link to comment
Share on other sites

12 hours ago, diesieben07 said:

From what I can tell it functions correctly.

Your NBT format is absolutely bizarre though:

  • Why on earth is "Selected Nature" in the same compound tag as all the Jutsu data?
  • Why are you using spaces in the keys?
  • Why on earth did you decide that putting "[SELECTED] " in front of the key was a good way to mark an entry as selected instead of just... you know... a boolean?
  • Why on earth does JutsuData.serialize / deserialize use a random ad-hoc string format instead of, you know, serializing its values to a NBT compound tag?

I am not sure how to serialize all of it to NBT. When my data was only using integers, I used an integer array, but that is not possible now. Could you show me how? Also, do you have recommendations on the capability? I believe that my current approach is very messy.

Link to comment
Share on other sites

An issue still persists. It appears as if the power level is the only thing that is not serializing. The selected nature AND selected jutsu seems to be synchronizing fine, but the power level does not, even though it is clearly updated:

NZRzgqo.png

4HZ03gL.png

 

nuwdyJ1.png

 

Jorum9U.png

The selected jutsu seems to work fine, as indicated by that bool and in-game testing. Thus, I added logging in the exact place the jutsu serializes it's power level:

vwA2AEK.png

And then after updating values:

xtQxUTg.png

 

What the hell is going on?! I am at a loss. Why is everything else working but that integer?

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • Register your own IRecipeSerializer. It is registered like any other registry entry. However note that you should have as much as possible in the JSON. Don't just have a placeholder JSON file and then hardcode all the logic in code. That defeats the point of datapacks. You'll have to have your own repair recipe then (see above for how to make your own serializer) and override getRemainingItems. If the knife is your item, override hasContainerItem and getContainerItem in your Item class. If the knife is not your item, refer to the section about repairing. Use a GlobalLootModifier.
    • So, im kinda new to modding. Trying to make relatively complicated mod(as I see now, it breaks the api a little bit...), and faced into some problems, especially with crafting. I think I should tell a little bit about my mod, you actually can skip this part, but if you don't get something, i strongly suggest to read this part. The goal i'm chasing is to implement similar food mechanics to TFC classic(1.7.10) mechanics. In a nutshell, it's food with durrability, and when you eat, you consume as much as you need(like if you have a steak and 1 hunger, if you eat it, stake's potential wastes, in case of my mod, it shouldn't). That's it, that's already done(with little bugs thou, but done). Now I have to do crafting somehow, using that items and modify durability while crafting. And it doesn't seems to be easy.     And.. question 1 will be: is it possible to hardcode crafts in 1.16.5? I know.. it's kinda not beautifull, but I really hate the json system. I've made as much crafts as possible by using it, but now, when I need to implement some logic, it's such a headache.   2. This question is about repearing. I mean, placing two damaged items in recipe grid. If you add 2 8/10 items, you'll get just one 10/10 item, and nothing more. I'd like 6/10 item to apear in grid after crafting. 3. Also there should be a recipe for extracting seeds with knife(i don't like to loose knife and whole peace of crop after craft). 4. And the last one. Well, I should change drop of crops if it's broken by special tool. I know, it's possible to do it by adding harvest tools, but I can't modify vanilla crops(maybe only by reflection..). Seems like it's reasonable to use onBlockBroken event, or something like that, but I keep finding deprecated code examples in google, and it doesn't work for me. Maybe there is a better solution.   About crafts.. I tried to figure out how CraftSerializers works, and i think it might be a good solution for that crafting stuff. But don't understand how to bind the serializer to regular minecraft crafting. Tried to read ShapelessRecipe class, but don't understand what happens in mathes, so cant do any assumptions how should I modify it. 
    • IP: Play.EpicLandCraft.Com Version: Cualquiera
    • What Im trying to do is to implement a "dash" mechanic on a Shift button.   @SubscribeEvent public static void onEvent(InputEvent.KeyInputEvent event){ KeyBinding runBinding = Minecraft.getInstance().gameSettings.keyBindSprint; int key = event.getKey(); int runKey = runBinding.getKey().getKeyCode(); ClientPlayerEntity player = Minecraft.getInstance().player; if (key == runKey){ //some checks, and then: float yaw = player.rotationYaw; float x = -MathHelper.sin(yaw * 0.017453292F); float z = MathHelper.cos(yaw * 0.017453292F); double groundMotion = 5, airMotion = 2; if (player.isOnGround()) player.setMotion(new Vector3d(x * groundMotion, 0, z * groundMotion)); else player.setMotion(new Vector3d(x * airMotion, 0, z * airMotion)); } } And this code works. The problem is, it causes a lot of lag when the setMotion() is called - my fps drops from 60 to 50-40 and the dash movement looks discrete. I wonder why is it so and how it can be improved...
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.