Jump to content

(1.16.5 MCP) sittable blocks error


ElTotisPro50

Recommended Posts

so i watched this tutorial on youtube(https://www.youtube.com/watch?v=vZgYjHwKcHA&t=691s) for make sittable blocks and even if is a 1,12,2 tutorial video a kind of translated it to 1.16.5 code but is not working "correctly";

the SeatEntity spawns in MY position and not in the position of the chair, and it blocks me the mouse movement in Y, and i can't shift for exit the chair, i can break blocks but my hand is kind of freeze in time (https://imgur.com/a/6xoKrV5)

 

this is my code: 

@SubscribeEvent
    public static void test(PlayerInteractEvent.RightClickBlock event)
    {
        PlayerEntity player = event.getPlayer();
        if(player.getRidingEntity() != null)
        {
            return;
        }
        World world = event.getWorld();
        BlockPos pos = event.getPos();
        Vector3d vec = new Vector3d(pos.getX() + 0.5f,pos.getY(), pos.getZ() + 0.5f);
        double maxDistance = 4.5D;
        if((vec.x - player.getPosX()) * (vec.x - player.getPosX()) + (vec.y - player.getPosY()) * (vec.y - player.getPosY()) + (vec.z - player.getPosZ()) * (vec.z - player.getPosZ()) > maxDistance * maxDistance)
        {
            return;
        }
        BlockState state = world.getBlockState(pos);
        ItemStack mainStack = player.getHeldItemMainhand();
        ItemStack offStack = player.getHeldItemOffhand();
        if(!mainStack.isEmpty() || !offStack.isEmpty())
        {
            return;
        }
        if(state.getBlock() instanceof StairsBlock)
        {
            //List<SeatStair> seats = world.getEntitiesWithinAABB(SeatStair.class, new AxisAlignedBB(pos,pos.add(1,1,1)));
            SeatStair seat = new SeatStair(EntityType.ARMOR_STAND,world,pos);
            world.addEntity(seat);
            player.startRiding(seat);
        }
    }

    public static class SeatStair extends Entity
    {
        public SeatStair(EntityType<QUESTIONMARK extends Entity> type, World world, BlockPos pos)
        {
            super(type,world);
            setPosition(pos.getX() + 0.5D,pos.getY() + 0.2D,pos.getZ() + 0.5D);
        }

        @Override
        protected void registerData() {

        }

        @Override
        public void tick() {
            super.tick();
            BlockPos pos = getPosition();
            if(!(getEntityWorld().getBlockState(pos).getBlock() instanceof StairsBlock))
            {
                setDead();
                return;
            }
            List<Entity> passengers = getPassengers();
            if(passengers.isEmpty())
            {
                setDead();
            }
            for(Entity entity : passengers)
            {
                if(entity.isSneaking())
                {
                    setDead();
                }
            }
        }

        @Override
        protected void readAdditional(CompoundNBT compound) {

        }

        @Override
        protected void writeAdditional(CompoundNBT compound) {

        }

        @Override
        public IPacket<QUESTIONMARK> createSpawnPacket() {
            return null;
        }
    }

 

Link to comment
Share on other sites

4 hours ago, diesieben07 said:

Every time you post you post in the wrong subforum and I have to move your thread. Please take the hint.

This is broken. You must not return null from this method. Use NetworkHooks.getEntitySpawningPacket.

You must also only spawn your entity and start riding it on the server.

thank you it worked, but 2 things, tell me where i have tu pubish my posts, i publish them in modder support isnt that right?

 

and Diesieben how do you quickly find how to solve modding errors, i can do it but if i create my own program or something but im minecraft modding, what goes through your mind to solve those problems?

for example i still cant solve my problem with drawing correctly a glowing line even if i look the minecraft classes :(

 

Link to comment
Share on other sites

2 hours ago, ElTotisPro50 said:

i publish them in modder support isnt that right?

Yeah that's the correct Forum

2 hours ago, ElTotisPro50 said:

and Diesieben how do you quickly find how to solve modding errors, i can do it but if i create my own program or something but im minecraft modding, what goes through your mind to solve those problems?

Experience (a lot since he join 2012) and knowledge from other threads with similar problems

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I have setup a 1.12.2 forge server  occasionally it throws a '[Server thread/WARN] [minecraft/MinecraftServer]: Can't keep up! Did the system time change, or is the server overloaded? Running 2316ms behind, skipping 46 tick(s)' and a ram usage spike  I have 32gb of ram installed in my pc and on a vanilla server l would normally just make a run.bat file but it is not working   When I launch the run.bat C:\Users\Max\Desktop\1.12.2 server>java -Xmx4G -Xms4G -jar minecraft_server.1.12.2.jar nogui C:\Users\Max\Desktop\1.12.2 server>PAUSE Press any key to continue . . .   The run.bat file contains java -Xmx4G -Xms4G -jar minecraft_server.1.12.2.jar nogui PAUSE Any advice would be appreciated
    • I'm opening the forge 1.8.9 installer properly I click install with the client option selected, it says it installs properly but when I go into my files and also when I go into the minecraft launcher, it's just not there.  JVM info: Oracle Corporation - 1.8.0_431 - 25.431-b10 java.net.preferIPv4Stack=true Found java version 1.8.0_431 Considering minecraft client jar Considering library net.minecraftforge:forge:1.8.9-11.15.1.2318-1.8.9: Not Downloading {Wrong Side} Considering library net.minecraft:launchwrapper:1.12: Not Downloading {Wrong Side} Considering library org.ow2.asm:asm-all:5.0.3: Not Downloading {Wrong Side} Considering library jline:jline:2.13: Not Downloading {Wrong Side} Considering library com.typesafe.akka:akka-actor_2.11:2.3.3 Considering library com.typesafe:config:1.2.1 Considering library org.scala-lang:scala-actors-migration_2.11:1.1.0 Considering library org.scala-lang:scala-compiler:2.11.1 Considering library org.scala-lang.plugins:scala-continuations-library_2.11:1.0.2 Considering library org.scala-lang.plugins:scala-continuations-plugin_2.11.1:1.0.2 Considering library org.scala-lang:scala-library:2.11.1 Considering library org.scala-lang:scala-parser-combinators_2.11:1.0.1 Considering library org.scala-lang:scala-reflect:2.11.1 Considering library org.scala-lang:scala-swing_2.11:1.0.1 Considering library org.scala-lang:scala-xml_2.11:1.0.2 Considering library lzma:lzma:0.0.1: Not Downloading {Wrong Side} Considering library net.sf.jopt-simple:jopt-simple:4.6: Not Downloading {Wrong Side} Considering library java3d:vecmath:1.5.2 Considering library net.sf.trove4j:trove4j:3.0.3 Extracting: /forge-1.8.9-11.15.1.2318-1.8.9-universal.jar To: C:\Users\Ian\AppData\Roaming\.minecraft\libraries\net\minecraftforge\forge\1.8.9-11.15.1.2318-1.8.9\forge-1.8.9-11.15.1.2318-1.8.9.jar That's the installer log and I have no idea if anything is wrong.
    • https://mclo.gs/NQ786zI   I don’t understand what I need to do.
    • I am wanting to give the armour in my mod special properties, but I have no idea how to do so.   For the first armour set I want it to be the case that when the full set is worn it has the properties of a carved pumpkin, making it so you won't aggravate endermen when you look at them.    The second, and presumably harder property is that for the second set I would like it to be the case that when the full set is worn, you can walk over the void without falling. (I was considering using the levitation to accomplish this but I wanted to check beforehand).   Would both of these specialities be achievable for each armour set and how exactly would they both be done? Help would be much appreciated. 
    • I finally got my Forge server up and running thanks to the help of the people on this forum and played fine for a day. Now since I started playing today, the server runs for 20-30 minutes then freezes and kicks everyone out but stays up and running but won't let anyone connect. Here is the latest debug log and crashlog from the server. Thank you for reading & helping   https://gist.github.com/Dwolfwoood/d0410e581c86772694f1d8007431c409   https://gist.github.com/Dwolfwoood/b5d521fd071dbfcc816949924757fef9
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.