Jump to content

MultiBlock structure problem


decebaldecebal

Recommended Posts

Hello guys,

I recently started creating a MultiBlock 2x2x2 structure that is made up of one type of block.I have managed to do (I think) almost all of it, but the problem I have is that the GUI won't open and that the Master TileEntity coordinates have ALWAYS the X axes value higher with one then the coordinate that the last block in the structure is placed.

 

I have made my structure have a MasterBlock in the low left corner.That is also the block you need to click on before the structure forms.What I did is that I used metadata to check with direction the block has in the world so that it will always be in the low left corner.

 

So the structure functions as follows:

You put down the first block in the bottom left facing you, then you place the other blocks need.After that, your right click the first block placed and the structure should form and open the GUI.

 

I have tested it and it seems like the structure forms, but the GUI is not opening, only when some glitch happens after I remove a block.

 

Also I have made so that if you remove a block, it make the MasterBlock in all the other TileEntities null.

 

Here is my code, I have looked for 5 hours at it now, and I still can not find what is wrong with it:

 

Advanced Coal Refiner(the block)

package general.blocks.Machines;

import lib.GuiIDs;
import general.geoactivity;
import general.blocks.Machines.ACR.ACRTileE;
import net.minecraft.block.BlockContainer;
import net.minecraft.block.material.Material;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.tileentity.TileEntityFurnace;
import net.minecraft.util.MathHelper;
import net.minecraft.world.World;

public class AdvancedCoalRefiner extends BlockContainer
{
public AdvancedCoalRefiner(int id, Material material)
{
	super(id, material);
}

/**
     * Called when the block is placed in the world.
     */
    public void onBlockPlacedBy(World par1World, int par2, int par3, int par4, EntityLivingBase par5EntityLivingBase, ItemStack par6ItemStack)
    {
        int l = MathHelper.floor_double((double)(par5EntityLivingBase.rotationYaw * 4.0F / 360.0F) + 0.5D) & 3;

        if (l == 0)
        {
            par1World.setBlockMetadataWithNotify(par2, par3, par4, 2, 2);
        }

        if (l == 1)
        {
            par1World.setBlockMetadataWithNotify(par2, par3, par4, 5, 2);
        }

        if (l == 2)
        {
            par1World.setBlockMetadataWithNotify(par2, par3, par4, 3, 2);
        }

        if (l == 3)
        {
            par1World.setBlockMetadataWithNotify(par2, par3, par4, 4, 2);
        }

        if (par6ItemStack.hasDisplayName())
        {
            ((TileEntityFurnace)par1World.getBlockTileEntity(par2, par3, par4)).setGuiDisplayName(par6ItemStack.getDisplayName());
        }
        System.out.println(par1World.getBlockMetadata(par2, par3, par4));
    }

@Override
    public boolean onBlockActivated(World par1World, int par2, int par3, int par4, EntityPlayer par5EntityPlayer, int par6, float par7, float par8, float par9)
    {
	if (par1World.isRemote)
		return true;
	else
	{
		ACRTileE tile_entity = (ACRTileE) par1World.getBlockTileEntity(par2, par3, par4);
		if (tile_entity == null || par5EntityPlayer.isSneaking())
			return false;
		if(!tile_entity.isValid)
		{
			System.out.println("works1");
			if(tile_entity.checkMultiblock())
			{
				tile_entity.makeMultiBlock();
			}
		}
		if(tile_entity.isValid)
		{
			System.out.println("works3");
			ACRTileE core = (ACRTileE)tile_entity.getCore();
			if(core!=null)
			{
				System.out.println(core.xCoord + " " + core.yCoord + " " + core.zCoord);
				par5EntityPlayer.openGui(geoactivity.instance, GuiIDs.ACR, par1World, core.xCoord, core.yCoord, core.zCoord);
			}
		}
		return true;
	}
    }

@Override
    public void breakBlock(World par1World, int par2, int par3, int par4, int par5, int par6)
    {
	ACRTileE tile_entity = (ACRTileE) par1World.getBlockTileEntity(par2, par3, par4);
	ACRTileE core = tile_entity.getCore();
	if(core!=null)
	{
		System.out.println("destroy1");
		core.destroyMultiBlock();
	}

        super.breakBlock(par1World, par2, par3, par4, par5, par6);
        par1World.removeBlockTileEntity(par2, par3, par4);
    }

@Override
public TileEntity createNewTileEntity(World world)
{
	return new ACRTileE();
}
}

 

ACRTileE (the tile entity)

package general.blocks.Machines.ACR;

import general.geoactivity;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.inventory.ISidedInventory;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.tileentity.TileEntity;

public class ACRTileE extends TileEntity implements ISidedInventory
{	
ACRTileE coretile=null;
private int coreX, coreY, coreZ;
public boolean isValid=false;

public boolean checkMultiblock()
{
	int meta = this.getBlockMetadata();
	int xc, zc, yc;

	for(int x=0;x<=1;x++)
		for(int z=0;z<=1;z++)
			for(int y=0;y<=1;y++)
			{
				yc = yCoord + y;
				xc = xCoord;
				zc = zCoord;
				if(meta==3)
				{
					xc = xCoord + x;
					zc = zCoord - z;
				}
				else if(meta==2)
				{
					xc = xCoord - x;
					zc = zCoord + z;
				}
				else if(meta==5)
				{
					xc = xCoord - x;
					zc = zCoord - z;
				}
				else if(meta==4)
				{
					xc = xCoord + x;
					zc = zCoord + z;
				}

				if(worldObj.getBlockId(xc, yc, zc)!=geoactivity.advancedcoalrefiner.blockID)
					return false;
			}
	return true;
}

public void makeMultiBlock()
{
	int meta = this.getBlockMetadata();
	int xc, zc, yc;

	for(int x=0;x<=1;x++)
		for(int z=0;z<=1;z++)
			for(int y=0;y<=1;y++)
			{
				yc = yCoord + y;
				xc = xCoord;
				zc = zCoord;
				if(meta==3)
				{
					xc = xCoord + x;
					zc = zCoord - z;
				}
				else if(meta==2)
				{
					xc = xCoord - x;
					zc = zCoord + z;
				}
				else if(meta==5)
				{
					xc = xCoord - x;
					zc = zCoord - z;
				}
				else if(meta==4)
				{
					xc = xCoord + x;
					zc = zCoord + z;
				}
				ACRTileE tile_entity = (ACRTileE)worldObj.getBlockTileEntity(xc, yc, zc);
				if(tile_entity!=null)
				{
					System.out.println("works2");
					tile_entity.isValid=true;
					tile_entity.setCore(this);
				}
				System.out.println(getCore());
			}
	isValid=true;
	System.out.println(xCoord + " " + yCoord + " " + zCoord);
}

public void destroyMultiBlock()
{
	int meta = this.getBlockMetadata();
	int xc, zc, yc;

	for(int x=0;x<=1;x++)
		for(int z=0;z<=1;z++)
			for(int y=0;y<=1;y++)
			{
				yc = yCoord + y;
				xc = xCoord;
				zc = zCoord;
				if(meta==3)
				{
					xc = xCoord + x;
					zc = zCoord - z;
				}
				else if(meta==2)
				{
					xc = xCoord - x;
					zc = zCoord + z;
				}
				else if(meta==5)
				{
					xc = xCoord - x;
					zc = zCoord - z;
				}
				else if(meta==4)
				{
					xc = xCoord + x;
					zc = zCoord + z;
				}
				ACRTileE tile_entity = (ACRTileE)worldObj.getBlockTileEntity(xc, yc, zc);
				if(tile_entity!=null)
				{
					tile_entity.isValid=false;
					tile_entity.setCore(null);
				}
				System.out.println(getCore());
			}
	isValid=false;
}

public ACRTileE getCore()
{
	if(coretile == null && coreX!=0 && coreY!=0 && coreZ!=0)
		coretile = (ACRTileE)worldObj.getBlockTileEntity(coreX, coreY, coreZ);

	return coretile;
}

public void setCore(ACRTileE core)
{		
	coretile = core;
	if(coretile!=null)
	{
		coreX = core.xCoord;
		coreY = core.yCoord;
		coreZ = core.zCoord;
	}
	else
	{
		coreX = 0;
		coreY = 0;
		coreZ = 0;
	}
}

@Override
public void readFromNBT(NBTTagCompound tagCompound)
{
	super.readFromNBT(tagCompound);

	coreX = tagCompound.getInteger("CoreX");
	coreY = tagCompound.getInteger("CoreY");
	coreZ = tagCompound.getInteger("CoreZ");
}

@Override
public void writeToNBT(NBTTagCompound tagCompound)
{
	super.writeToNBT(tagCompound);

	tagCompound.setInteger("CoreX", coreX);
	tagCompound.setInteger("CoreY", coreY);
	tagCompound.setInteger("CoreZ", coreZ);
}

@Override
public int getSizeInventory()
{
	// TODO Auto-generated method stub
	return 0;
}

@Override
public ItemStack getStackInSlot(int i)
{
	// TODO Auto-generated method stub
	return null;
}

@Override
public ItemStack decrStackSize(int i, int j)
{
	// TODO Auto-generated method stub
	return null;
}

@Override
public ItemStack getStackInSlotOnClosing(int i)
{
	// TODO Auto-generated method stub
	return null;
}

@Override
public void setInventorySlotContents(int i, ItemStack itemstack)
{
	// TODO Auto-generated method stub

}

@Override
public String getInvName()
{
	// TODO Auto-generated method stub
	return null;
}

@Override
public boolean isInvNameLocalized()
{
	// TODO Auto-generated method stub
	return false;
}

@Override
public int getInventoryStackLimit()
{
	// TODO Auto-generated method stub
	return 0;
}

@Override
public boolean isUseableByPlayer(EntityPlayer entityplayer)
{
	// TODO Auto-generated method stub
	return false;
}

@Override
public void openChest()
{
	// TODO Auto-generated method stub

}

@Override
public void closeChest()
{
	// TODO Auto-generated method stub

}

@Override
public boolean isItemValidForSlot(int i, ItemStack itemstack)
{
	// TODO Auto-generated method stub
	return false;
}

@Override
public int[] getAccessibleSlotsFromSide(int var1)
{
	// TODO Auto-generated method stub
	return null;
}

@Override
public boolean canInsertItem(int i, ItemStack itemstack, int j)
{
	// TODO Auto-generated method stub
	return false;
}

@Override
public boolean canExtractItem(int i, ItemStack itemstack, int j)
{
	// TODO Auto-generated method stub
	return false;
}
}

 

The container (only used for testing purposes ATM)

package general.blocks.Machines.ACR;

import general.blocks.Machines.CR.CRSlot;
import general.blocks.Machines.CR.CRTileE;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.player.InventoryPlayer;
import net.minecraft.inventory.Container;
import net.minecraft.inventory.Slot;

public class ACRContainer extends Container
{
public ACRContainer(ACRTileE par2TileEntityFurnace, InventoryPlayer par1InventoryPlayer)
{
	//furnace = par2TileEntityFurnace;
	/*
	this.addSlotToContainer(new Slot(par2TileEntityFurnace, 0, 66, 35));
	this.addSlotToContainer(new Slot(par2TileEntityFurnace, 1, 30, 35));
	this.addSlotToContainer(new CRSlot(par1InventoryPlayer.player, par2TileEntityFurnace, 2, 126, 35));
	*/
	int var3;

	for (var3 = 0; var3 < 3; ++var3)
		for (int var4 = 0; var4 < 9; ++var4)
			this.addSlotToContainer(new Slot(par1InventoryPlayer, var4 + var3 * 9 + 9, 8 + var4 * 18, 84 + var3 * 18));

	for (var3 = 0; var3 < 9; ++var3)
		this.addSlotToContainer(new Slot(par1InventoryPlayer, var3, 8 + var3 * 18, 142));
}


@Override
public boolean canInteractWith(EntityPlayer entityplayer)
{
	// TODO Auto-generated method stub
	return false;
}

}

 

The GUI (again only used for testing)

package general.blocks.Machines.ACR;

import general.blocks.Machines.CR.CRContainer;
import general.blocks.Machines.CR.CRTileE;
import net.minecraft.client.gui.inventory.GuiContainer;
import net.minecraft.entity.player.InventoryPlayer;
import net.minecraft.util.ResourceLocation;

import org.lwjgl.opengl.GL11;

public class ACRGUI extends GuiContainer
{
private static final ResourceLocation field_110410_t = new ResourceLocation("GeoActivity:textures/gui/CR.png");
private ACRTileE furnaceInventory;

public ACRGUI(InventoryPlayer par1InventoryPlayer, ACRTileE par2TileEntityFurnace)
{
	super(new ACRContainer(par2TileEntityFurnace, par1InventoryPlayer));
	furnaceInventory = par2TileEntityFurnace;
}

@Override
protected void drawGuiContainerForegroundLayer(int par1, int par2)
{
	fontRenderer.drawString("Coal Refiner", 60, 8, 4210752);
	fontRenderer.drawString("Inventory", 8, ySize - 96 + 2, 4210752);
}

@Override
protected void drawGuiContainerBackgroundLayer(float par1, int par2, int par3)
{
	GL11.glColor4f(1.0F, 1.0F, 1.0F, 1.0F);

	mc.func_110434_K().func_110577_a(field_110410_t);
	int var5 = (width - xSize) / 2;
	int var6 = (height - ySize) / 2;
	this.drawTexturedModalRect(var5, var6, 0, 0, xSize, ySize);
	int var7;

	/*
	if (furnaceInventory.isBurning())
	{
		var7 = furnaceInventory.getBurnTimeRemainingScaled(12);
		this.drawTexturedModalRect(var5 + 49, var6 + 36 + 12 - var7, 176, 12 - var7, 14, var7 + 2);
	}

	var7 = furnaceInventory.getCookProgressScaled(24);
	this.drawTexturedModalRect(var5 + 89, var6 + 34, 176, 14, var7 + 1, 16);
	*/
}
}

 

Gui Handler

package core;

import general.blocks.CM.CMI.CMIContainer;
import general.blocks.CM.CMI.CMIGUI;
import general.blocks.CM.CMI.CMITileE;
import general.blocks.CM.CMII.CMIIContainer;
import general.blocks.CM.CMII.CMIIGUI;
import general.blocks.CM.CMII.CMIITileE;
import general.blocks.Machines.ACR.ACRContainer;
import general.blocks.Machines.ACR.ACRGUI;
import general.blocks.Machines.ACR.ACRTileE;
import general.blocks.Machines.CR.CRContainer;
import general.blocks.Machines.CR.CRGUI;
import general.blocks.Machines.CR.CRTileE;
import general.items.tools.Adv.AdvContainer;
import general.items.tools.Adv.AdvGUI;
import general.items.tools.Adv.AdvInventory;
import general.items.tools.RM.RMContainer;
import general.items.tools.RM.RMGUI;
import general.items.tools.RM.RMInventory;
import lib.GuiIDs;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.world.World;
import cpw.mods.fml.common.network.IGuiHandler;

public class guiHandler implements IGuiHandler
{
@Override
public Object getServerGuiElement(int id, EntityPlayer player, World world, int x, int y, int z)
{
	if (!world.blockExists(x, y, z))
		return null;

	TileEntity tile_entity = world.getBlockTileEntity(x, y, z);

	switch (id)
	{
		case GuiIDs.ACR:
			if (!(tile_entity instanceof ACRTileE))
				return null;
			return new ACRContainer((ACRTileE) tile_entity, player.inventory);
		default:
			return null;
	}
}

@Override
public Object getClientGuiElement(int id, EntityPlayer player, World world, int x, int y, int z)
{
	if (!world.blockExists(x, y, z))
		return null;

	TileEntity tile_entity = world.getBlockTileEntity(x, y, z);

	switch (id)
	{
		case GuiIDs.ACR:
			if (!(tile_entity instanceof ACRTileE))
				return null;
			return new ACRGUI(player.inventory, (ACRTileE) tile_entity);
		default:
			return null;
	}
}
}

 

I have also registered the TileEntity and the block correctly.

 

I think the problem is in the onBlockActivated activated method, but I am not quite sure...

Link to comment
Share on other sites

In tile entity:

@Override
public boolean isUseableByPlayer(EntityPlayer entityplayer)
{
	// TODO Auto-generated method stub
	return false;
}

In container:

@Override
public boolean canInteractWith(EntityPlayer entityplayer)
{
	// TODO Auto-generated method stub
	return false;
}

 

I don't think you want those to be always false.

Link to comment
Share on other sites

In tile entity:

@Override
public boolean isUseableByPlayer(EntityPlayer entityplayer)
{
	// TODO Auto-generated method stub
	return false;
}

In container:

@Override
public boolean canInteractWith(EntityPlayer entityplayer)
{
	// TODO Auto-generated method stub
	return false;
}

 

I don't think you want those to be always false.

 

Thank you very much, I knew I made some stupid mistake, I often do.

Link to comment
Share on other sites

Hello guys,

I recently started creating a MultiBlock 2x2x2 structure that is made up of one type of block.I have managed to do (I think) almost all of it, but the problem I have is that the GUI won't open and that the Master TileEntity coordinates have ALWAYS the X axes value higher with one then the coordinate that the last block in the structure is placed.

 

I have made my structure have a MasterBlock in the low left corner.That is also the block you need to click on before the structure forms.What I did is that I used metadata to check with direction the block has in the world so that it will always be in the low left corner.

 

So the structure functions as follows:

You put down the first block in the bottom left facing you, then you place the other blocks need.After that, your right click the first block placed and the structure should form and open the GUI.

 

I have tested it and it seems like the structure forms, but the GUI is not opening, only when some glitch happens after I remove a block.

 

Also I have made so that if you remove a block, it make the MasterBlock in all the other TileEntities null.

 

Here is my code, I have looked for 5 hours at it now, and I still can not find what is wrong with it:

 

Advanced Coal Refiner(the block)

package general.blocks.Machines;

import lib.GuiIDs;
import general.geoactivity;
import general.blocks.Machines.ACR.ACRTileE;
import net.minecraft.block.BlockContainer;
import net.minecraft.block.material.Material;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.tileentity.TileEntityFurnace;
import net.minecraft.util.MathHelper;
import net.minecraft.world.World;

public class AdvancedCoalRefiner extends BlockContainer
{
public AdvancedCoalRefiner(int id, Material material)
{
	super(id, material);
}

/**
     * Called when the block is placed in the world.
     */
    public void onBlockPlacedBy(World par1World, int par2, int par3, int par4, EntityLivingBase par5EntityLivingBase, ItemStack par6ItemStack)
    {
        int l = MathHelper.floor_double((double)(par5EntityLivingBase.rotationYaw * 4.0F / 360.0F) + 0.5D) & 3;

        if (l == 0)
        {
            par1World.setBlockMetadataWithNotify(par2, par3, par4, 2, 2);
        }

        if (l == 1)
        {
            par1World.setBlockMetadataWithNotify(par2, par3, par4, 5, 2);
        }

        if (l == 2)
        {
            par1World.setBlockMetadataWithNotify(par2, par3, par4, 3, 2);
        }

        if (l == 3)
        {
            par1World.setBlockMetadataWithNotify(par2, par3, par4, 4, 2);
        }

        if (par6ItemStack.hasDisplayName())
        {
            ((TileEntityFurnace)par1World.getBlockTileEntity(par2, par3, par4)).setGuiDisplayName(par6ItemStack.getDisplayName());
        }
        System.out.println(par1World.getBlockMetadata(par2, par3, par4));
    }

@Override
    public boolean onBlockActivated(World par1World, int par2, int par3, int par4, EntityPlayer par5EntityPlayer, int par6, float par7, float par8, float par9)
    {
	if (par1World.isRemote)
		return true;
	else
	{
		ACRTileE tile_entity = (ACRTileE) par1World.getBlockTileEntity(par2, par3, par4);
		if (tile_entity == null || par5EntityPlayer.isSneaking())
			return false;
		if(!tile_entity.isValid)
		{
			System.out.println("works1");
			if(tile_entity.checkMultiblock())
			{
				tile_entity.makeMultiBlock();
			}
		}
		if(tile_entity.isValid)
		{
			System.out.println("works3");
			ACRTileE core = (ACRTileE)tile_entity.getCore();
			if(core!=null)
			{
				System.out.println(core.xCoord + " " + core.yCoord + " " + core.zCoord);
				par5EntityPlayer.openGui(geoactivity.instance, GuiIDs.ACR, par1World, core.xCoord, core.yCoord, core.zCoord);
			}
		}
		return true;
	}
    }

@Override
    public void breakBlock(World par1World, int par2, int par3, int par4, int par5, int par6)
    {
	ACRTileE tile_entity = (ACRTileE) par1World.getBlockTileEntity(par2, par3, par4);
	ACRTileE core = tile_entity.getCore();
	if(core!=null)
	{
		System.out.println("destroy1");
		core.destroyMultiBlock();
	}

        super.breakBlock(par1World, par2, par3, par4, par5, par6);
        par1World.removeBlockTileEntity(par2, par3, par4);
    }

@Override
public TileEntity createNewTileEntity(World world)
{
	return new ACRTileE();
}
}

 

ACRTileE (the tile entity)

package general.blocks.Machines.ACR;

import general.geoactivity;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.inventory.ISidedInventory;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.tileentity.TileEntity;

public class ACRTileE extends TileEntity implements ISidedInventory
{	
ACRTileE coretile=null;
private int coreX, coreY, coreZ;
public boolean isValid=false;

public boolean checkMultiblock()
{
	int meta = this.getBlockMetadata();
	int xc, zc, yc;

	for(int x=0;x<=1;x++)
		for(int z=0;z<=1;z++)
			for(int y=0;y<=1;y++)
			{
				yc = yCoord + y;
				xc = xCoord;
				zc = zCoord;
				if(meta==3)
				{
					xc = xCoord + x;
					zc = zCoord - z;
				}
				else if(meta==2)
				{
					xc = xCoord - x;
					zc = zCoord + z;
				}
				else if(meta==5)
				{
					xc = xCoord - x;
					zc = zCoord - z;
				}
				else if(meta==4)
				{
					xc = xCoord + x;
					zc = zCoord + z;
				}

				if(worldObj.getBlockId(xc, yc, zc)!=geoactivity.advancedcoalrefiner.blockID)
					return false;
			}
	return true;
}

public void makeMultiBlock()
{
	int meta = this.getBlockMetadata();
	int xc, zc, yc;

	for(int x=0;x<=1;x++)
		for(int z=0;z<=1;z++)
			for(int y=0;y<=1;y++)
			{
				yc = yCoord + y;
				xc = xCoord;
				zc = zCoord;
				if(meta==3)
				{
					xc = xCoord + x;
					zc = zCoord - z;
				}
				else if(meta==2)
				{
					xc = xCoord - x;
					zc = zCoord + z;
				}
				else if(meta==5)
				{
					xc = xCoord - x;
					zc = zCoord - z;
				}
				else if(meta==4)
				{
					xc = xCoord + x;
					zc = zCoord + z;
				}
				ACRTileE tile_entity = (ACRTileE)worldObj.getBlockTileEntity(xc, yc, zc);
				if(tile_entity!=null)
				{
					System.out.println("works2");
					tile_entity.isValid=true;
					tile_entity.setCore(this);
				}
				System.out.println(getCore());
			}
	isValid=true;
	System.out.println(xCoord + " " + yCoord + " " + zCoord);
}

public void destroyMultiBlock()
{
	int meta = this.getBlockMetadata();
	int xc, zc, yc;

	for(int x=0;x<=1;x++)
		for(int z=0;z<=1;z++)
			for(int y=0;y<=1;y++)
			{
				yc = yCoord + y;
				xc = xCoord;
				zc = zCoord;
				if(meta==3)
				{
					xc = xCoord + x;
					zc = zCoord - z;
				}
				else if(meta==2)
				{
					xc = xCoord - x;
					zc = zCoord + z;
				}
				else if(meta==5)
				{
					xc = xCoord - x;
					zc = zCoord - z;
				}
				else if(meta==4)
				{
					xc = xCoord + x;
					zc = zCoord + z;
				}
				ACRTileE tile_entity = (ACRTileE)worldObj.getBlockTileEntity(xc, yc, zc);
				if(tile_entity!=null)
				{
					tile_entity.isValid=false;
					tile_entity.setCore(null);
				}
				System.out.println(getCore());
			}
	isValid=false;
}

public ACRTileE getCore()
{
	if(coretile == null && coreX!=0 && coreY!=0 && coreZ!=0)
		coretile = (ACRTileE)worldObj.getBlockTileEntity(coreX, coreY, coreZ);

	return coretile;
}

public void setCore(ACRTileE core)
{		
	coretile = core;
	if(coretile!=null)
	{
		coreX = core.xCoord;
		coreY = core.yCoord;
		coreZ = core.zCoord;
	}
	else
	{
		coreX = 0;
		coreY = 0;
		coreZ = 0;
	}
}

@Override
public void readFromNBT(NBTTagCompound tagCompound)
{
	super.readFromNBT(tagCompound);

	coreX = tagCompound.getInteger("CoreX");
	coreY = tagCompound.getInteger("CoreY");
	coreZ = tagCompound.getInteger("CoreZ");
}

@Override
public void writeToNBT(NBTTagCompound tagCompound)
{
	super.writeToNBT(tagCompound);

	tagCompound.setInteger("CoreX", coreX);
	tagCompound.setInteger("CoreY", coreY);
	tagCompound.setInteger("CoreZ", coreZ);
}

@Override
public int getSizeInventory()
{
	// TODO Auto-generated method stub
	return 0;
}

@Override
public ItemStack getStackInSlot(int i)
{
	// TODO Auto-generated method stub
	return null;
}

@Override
public ItemStack decrStackSize(int i, int j)
{
	// TODO Auto-generated method stub
	return null;
}

@Override
public ItemStack getStackInSlotOnClosing(int i)
{
	// TODO Auto-generated method stub
	return null;
}

@Override
public void setInventorySlotContents(int i, ItemStack itemstack)
{
	// TODO Auto-generated method stub

}

@Override
public String getInvName()
{
	// TODO Auto-generated method stub
	return null;
}

@Override
public boolean isInvNameLocalized()
{
	// TODO Auto-generated method stub
	return false;
}

@Override
public int getInventoryStackLimit()
{
	// TODO Auto-generated method stub
	return 0;
}

@Override
public boolean isUseableByPlayer(EntityPlayer entityplayer)
{
	// TODO Auto-generated method stub
	return false;
}

@Override
public void openChest()
{
	// TODO Auto-generated method stub

}

@Override
public void closeChest()
{
	// TODO Auto-generated method stub

}

@Override
public boolean isItemValidForSlot(int i, ItemStack itemstack)
{
	// TODO Auto-generated method stub
	return false;
}

@Override
public int[] getAccessibleSlotsFromSide(int var1)
{
	// TODO Auto-generated method stub
	return null;
}

@Override
public boolean canInsertItem(int i, ItemStack itemstack, int j)
{
	// TODO Auto-generated method stub
	return false;
}

@Override
public boolean canExtractItem(int i, ItemStack itemstack, int j)
{
	// TODO Auto-generated method stub
	return false;
}
}

 

The container (only used for testing purposes ATM)

package general.blocks.Machines.ACR;

import general.blocks.Machines.CR.CRSlot;
import general.blocks.Machines.CR.CRTileE;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.player.InventoryPlayer;
import net.minecraft.inventory.Container;
import net.minecraft.inventory.Slot;

public class ACRContainer extends Container
{
public ACRContainer(ACRTileE par2TileEntityFurnace, InventoryPlayer par1InventoryPlayer)
{
	//furnace = par2TileEntityFurnace;
	/*
	this.addSlotToContainer(new Slot(par2TileEntityFurnace, 0, 66, 35));
	this.addSlotToContainer(new Slot(par2TileEntityFurnace, 1, 30, 35));
	this.addSlotToContainer(new CRSlot(par1InventoryPlayer.player, par2TileEntityFurnace, 2, 126, 35));
	*/
	int var3;

	for (var3 = 0; var3 < 3; ++var3)
		for (int var4 = 0; var4 < 9; ++var4)
			this.addSlotToContainer(new Slot(par1InventoryPlayer, var4 + var3 * 9 + 9, 8 + var4 * 18, 84 + var3 * 18));

	for (var3 = 0; var3 < 9; ++var3)
		this.addSlotToContainer(new Slot(par1InventoryPlayer, var3, 8 + var3 * 18, 142));
}


@Override
public boolean canInteractWith(EntityPlayer entityplayer)
{
	// TODO Auto-generated method stub
	return false;
}

}

 

The GUI (again only used for testing)

package general.blocks.Machines.ACR;

import general.blocks.Machines.CR.CRContainer;
import general.blocks.Machines.CR.CRTileE;
import net.minecraft.client.gui.inventory.GuiContainer;
import net.minecraft.entity.player.InventoryPlayer;
import net.minecraft.util.ResourceLocation;

import org.lwjgl.opengl.GL11;

public class ACRGUI extends GuiContainer
{
private static final ResourceLocation field_110410_t = new ResourceLocation("GeoActivity:textures/gui/CR.png");
private ACRTileE furnaceInventory;

public ACRGUI(InventoryPlayer par1InventoryPlayer, ACRTileE par2TileEntityFurnace)
{
	super(new ACRContainer(par2TileEntityFurnace, par1InventoryPlayer));
	furnaceInventory = par2TileEntityFurnace;
}

@Override
protected void drawGuiContainerForegroundLayer(int par1, int par2)
{
	fontRenderer.drawString("Coal Refiner", 60, 8, 4210752);
	fontRenderer.drawString("Inventory", 8, ySize - 96 + 2, 4210752);
}

@Override
protected void drawGuiContainerBackgroundLayer(float par1, int par2, int par3)
{
	GL11.glColor4f(1.0F, 1.0F, 1.0F, 1.0F);

	mc.func_110434_K().func_110577_a(field_110410_t);
	int var5 = (width - xSize) / 2;
	int var6 = (height - ySize) / 2;
	this.drawTexturedModalRect(var5, var6, 0, 0, xSize, ySize);
	int var7;

	/*
	if (furnaceInventory.isBurning())
	{
		var7 = furnaceInventory.getBurnTimeRemainingScaled(12);
		this.drawTexturedModalRect(var5 + 49, var6 + 36 + 12 - var7, 176, 12 - var7, 14, var7 + 2);
	}

	var7 = furnaceInventory.getCookProgressScaled(24);
	this.drawTexturedModalRect(var5 + 89, var6 + 34, 176, 14, var7 + 1, 16);
	*/
}
}

 

Gui Handler

package core;

import general.blocks.CM.CMI.CMIContainer;
import general.blocks.CM.CMI.CMIGUI;
import general.blocks.CM.CMI.CMITileE;
import general.blocks.CM.CMII.CMIIContainer;
import general.blocks.CM.CMII.CMIIGUI;
import general.blocks.CM.CMII.CMIITileE;
import general.blocks.Machines.ACR.ACRContainer;
import general.blocks.Machines.ACR.ACRGUI;
import general.blocks.Machines.ACR.ACRTileE;
import general.blocks.Machines.CR.CRContainer;
import general.blocks.Machines.CR.CRGUI;
import general.blocks.Machines.CR.CRTileE;
import general.items.tools.Adv.AdvContainer;
import general.items.tools.Adv.AdvGUI;
import general.items.tools.Adv.AdvInventory;
import general.items.tools.RM.RMContainer;
import general.items.tools.RM.RMGUI;
import general.items.tools.RM.RMInventory;
import lib.GuiIDs;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.world.World;
import cpw.mods.fml.common.network.IGuiHandler;

public class guiHandler implements IGuiHandler
{
@Override
public Object getServerGuiElement(int id, EntityPlayer player, World world, int x, int y, int z)
{
	if (!world.blockExists(x, y, z))
		return null;

	TileEntity tile_entity = world.getBlockTileEntity(x, y, z);

	switch (id)
	{
		case GuiIDs.ACR:
			if (!(tile_entity instanceof ACRTileE))
				return null;
			return new ACRContainer((ACRTileE) tile_entity, player.inventory);
		default:
			return null;
	}
}

@Override
public Object getClientGuiElement(int id, EntityPlayer player, World world, int x, int y, int z)
{
	if (!world.blockExists(x, y, z))
		return null;

	TileEntity tile_entity = world.getBlockTileEntity(x, y, z);

	switch (id)
	{
		case GuiIDs.ACR:
			if (!(tile_entity instanceof ACRTileE))
				return null;
			return new ACRGUI(player.inventory, (ACRTileE) tile_entity);
		default:
			return null;
	}
}
}

 

I have also registered the TileEntity and the block correctly.

 

I think the problem is in the onBlockActivated activated method, but I am not quite sure...

 

Nothing to do with the question, but use github or pastebin for your code - its cleaner and then we can look anywere in ur code to try and fix it.

Lets make forge modding the best it can be!

Link to comment
Share on other sites

@biggles, my work network block pastebin and github

@op, please continue to use the forums and maybe ALSO add a link to your github :)

 

Well at the moment I have not set up GitHub, but when I will come from vacation I will set up one.

 

Also, the multiblock works perfectly!I've managed to fix it myself and I know have some more understanding of multiblocks.

 

If anyone else wants to do a multi block, this tutorial helped me very much:

 

http://minalien.com/tutorial-multi-block-structures-in-minecraft/

Link to comment
Share on other sites

And now is the challenge to figure out how to be able to place the blocks in any way you want, and without the need to rightclick the base multiblock block to form the multiblock  ;D. Good luck :)

Author of PneumaticCraft, MineChess, Minesweeper Mod and Sokoban Mod. Visit www.minemaarten.com to take a look at them.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • https://mclo.gs/4UC49Ao
    • Way back in the Forge 1.17 days, work started for adding JPMS (Java Platform Module Support) to ModLauncher and ForgeModLoader. This has been used internally by Forge and some libraries for a while now, but mods (those with mods.toml specifically) have not been able to take advantage of it. As of Forge 1.21.1 and 1.21.3, this is now possible!   What is JPMS and what does it mean for modders? JPMS is the Java Platform Module System, introduced in Java 9. It allows you to define modules, which are collections of packages and resources that can be exported or hidden from other modules. This allows for much more fine-tuned control over visibility, cleaner syntax for service declarations and support for sealed types across packages. For example, you might have a mod with a module called `com.example.mod` that exports `com.example.mod.api` and `com.example.mod.impl` to other mods, but hides `com.example.mod.internal` from them. This would allow you to have a clean API for other mods to use, while keeping your internal implementation details hidden from IDE hints, helping prevent accidental usage of internals that might break without prior notice. This is particularly useful if you'd like to use public records with module-private constructors or partially module-private record components, as you can create a sealed interface that only your record implements, having the interface be exported and the record hidden. It's also nice for declaring and using services, as you'll get compile-time errors from the Java compiler for typos and the like, rather than deferring to runtime errors. In more advanced cases, you can also have public methods that are only accessible to specific other modules -- handy if you want internal interactions between multiple of your own mods.   How do I bypass it? We understand there may be drama in implementing a system that prevents mods from accessing each other's internals when necessary (like when a mod is abandoned or you need to fix a compat issue) -- after all, we are already modding a game that doesn't have explicit support for Java mods yet. We have already thought of this and are offering APIs from day one to selectively bypass module restrictions. Let me be clear: Forge mods are not required to use JPMS. If you don't want to use it, you don't have to. The default behaviour is to have fully open, fully exported automatic modules. In Java, you can use the `Add-Opens` and `Add-Exports` manifest attributes to selectively bypass module restrictions of other mods at launch time, and we've added explicit support for these when loading your Forge mods. At compile-time, you can use existing solutions such as the extra-java-module-info Gradle plugin to deal with non-modular dependencies and add extra opens and exports to other modules. Here's an example on how to make the internal package `com.example.examplemod.internal` open to your mod in your build.gradle: tasks.named('jar', Jar) { manifest { attributes([ 'Add-Opens' : 'com.example.examplemod/com.example.examplemod.internal' 'Specification-Title' : mod_id, 'Specification-Vendor' : mod_authors // (...) ]) } } With the above in your mod's jar manifest, you can now reflectively access the classes inside that internal package. Multiple entries are separated with a space, as per Java's official spec. You can also use Add-Exports to directly call without reflection, however you'd need to use the Gradle plugin mentioned earlier to be able to compile. The syntax for Add-Exports is the same as Add-Opens, and instructions for the compile-time step with the Gradle plugin are detailed later in this post. Remember to prefer the opens and exports keywords inside module-info.java for sources you control. The Add-Opens/Add-Exports attributes are only intended for forcing open other mods.   What else is new with module support? Previously, the runtime module name was always forced to the first mod ID in your `mods.toml` file and all packages were forced fully open and exported. Module names are now distinguished from mod IDs, meaning the module name in your module-info.java can be different from the mod ID in your `mods.toml`. This allows you to have a more descriptive module name that doesn't have to be the same as your mod ID, however we strongly recommend including your mod ID as part of your module name to aid troubleshooting. The `Automatic-Module-Name` manifest attribute is now also honoured, allowing you to specify a module name for your mod without needing to create a `module-info.java` file. This is particularly useful for mods that don't care about JPMS features but want to have a more descriptive module name and easier integration with other mods that do use JPMS.   How do I use it? The first step is to create a `module-info.java` file in your mod's source directory. This file should be in the same package as your main mod class, and should look something like this: open module com.example.examplemod { requires net.minecraftforge.eventbus; requires net.minecraftforge.fmlcore; requires net.minecraftforge.forge; requires net.minecraftforge.javafmlmod; requires net.minecraftforge.mergetool.api; requires org.slf4j; requires logging; } For now, we're leaving the whole module open to reflection, which is a good starting point. When we know we want to close something off, we can remove the open modifier from the module and open or export individual packages instead. Remember that you need to be open to Forge (module name net.minecraftforge.forge), otherwise it can't call your mod's constructor. Next is fixing modules in Gradle. While Forge and Java support modules properly, Gradle does not put automatic modules on the module path by default, meaning that the logging module (from com.mojang:logging) is not found. To fix this, add the Gradle plugin and add a compile-time module definition for that Mojang library: plugins { // (...) id 'org.gradlex.extra-java-module-info' version "1.9" } // (...) extraJavaModuleInfo { failOnMissingModuleInfo = false automaticModule("com.mojang:logging", "logging") } The automatic module override specified in your build.gradle should match the runtime one to avoid errors. You can do the same for any library or mod dependency that is missing either a module-info or explicit Automatic-Module-Name, however be aware that you may need to update your mod once said library adds one. That's all you need to get started with module support in your mods. You can learn more about modules and how to use them at dev.java.
    • Faire la mise à jour grâce à ce lien m'a aider personnellement, merci à @Paint_Ninja. https://www.amd.com/en/support 
    • When I came across the 'Exit Code: I got a 1 error in my Minecraft mods, so I decided to figure out what was wrong. First, I took a look at the logs. In the mods folder (usually where you'd find logs or crash reports), I found the latest.log file or the corresponding crash report. I read it through carefully, looking for any lines with errors or warnings. Then I checked the Minecraft Forge support site, where you can often find info on what causes errors and how to fix them. I then disabled half of my mods and tried running the game. If the error disappeared, it meant that the problem was with the disabled mod. I repeated this several times to find the problem mod.
    • I have no idea - switch to a pre-configured modpack and use it as working base    
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.