Jump to content

Event for Riding Entities Underwater


GhostWolf2398

Recommended Posts

Hello, I am GhostWolf, one of the coding developers for the Pixelmon mod (essentially Pokemon in Minecraft).

 

We were wondering if it would be possible to add an event into entityLivingBase that would allow us to specify custom behavior for when a player rides an entity underwater. We currently have several mounts that are capable of surfing and diving, and with the code in entityLivingBase lines 281-309 (and 305-309 in particular), as soon as a player goes fully underwater they unmount (whether it is just the natural up and down swimming on the mount or actually diving). Ideally we would be able to just override this or change the event response to this so that the player can remain on the mount.

 

Any help and suggestions you can give on this would be greatly appreciated. We would also be more than happy to take care of the needed coding if you had the way this should be done figured out.

 

 

 

        if (this.isEntityAlive() && this.isInsideOfMaterial(Material.water))

        {

            if (!this.canBreatheUnderwater() && !this.isPotionActive(Potion.waterBreathing.id) && !flag)

            {

                this.setAir(this.decreaseAirSupply(this.getAir()));

 

                if (this.getAir() == -20)

                {

                    this.setAir(0);

 

                    for (int i = 0; i < 8; ++i)

                    {

                        float f = this.rand.nextFloat() - this.rand.nextFloat();

                        float f1 = this.rand.nextFloat() - this.rand.nextFloat();

                        float f2 = this.rand.nextFloat() - this.rand.nextFloat();

                        this.worldObj.spawnParticle("bubble", this.posX + (double)f, this.posY + (double)f1, this.posZ + (double)f2, this.motionX, this.motionY, this.motionZ);

                    }

 

                    this.attackEntityFrom(DamageSource.drown, 2.0F);

                }

            }

 

            this.extinguish();

 

            if (!this.worldObj.isRemote && this.isRiding() && this.ridingEntity instanceof EntityLivingBase)

            {

                this.mountEntity((Entity)null);

            }

        }

 

Link to comment
Share on other sites

Could easily add a boolean Entity.shouldDismountWhenUnderwater(), Should be a Simple PR for someone to make. {I iz busy till the end of next week}

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Consider supporting the team on Patreon

Link to comment
Share on other sites

I went ahead and wrote in the needed code. I can't get the patches to update or commit correctly to github, so here is the code for someone who can do that, all written out for you (red text is added, the rest is just to help you locate where to put it).

 

/** Number of ticks since last jump */

    private int jumpTicks;

    private float field_110151_bq;

   

    /** Determines if entity stays on mount when submerged in water. */

    public boolean stayMountedUnderWater = false;

 

    public EntityLivingBase(World par1World)

    {

 

and

 

                    this.attackEntityFrom(DamageSource.drown, 2.0F);

                }

            }

 

            this.extinguish();

 

            if (!this.worldObj.isRemote && this.isRiding() && this.ridingEntity instanceof EntityLivingBase)

            {

            if (!stayMountedUnderWater){

            this.mountEntity((Entity)null);

            }

            }

        }

 

Link to comment
Share on other sites

This is the location in the code that causes the issue with underwater riding. Based on your comment, I looked at putting something inside the mountEntity() function, but that is only called when you change from mounting to unmounting, and that boolean variable if used there could cause other behavioral issues (such as never letting you get off the mount, etc)

 

The line I placed the check at is the only point at which you would want to circumvent the normal unmounting code for this kind of problem, as it is the only point where the unmounting is caused by the rider being located in water. By locating that boolean check there, you only get the bypass behavior under that one condition, and riding should behave entirely normally for all other situations.

 

If you meant a function in the code of the entity being mounted, it likely wouldn't solve the issue we are having, as it is this particular point in the code where it forces the unmounting, and any other function in the mounted entity that would say force re-mounting would be run too frequently while under water to be an elegant solution to the issue.

 

Hopefully that makes sense, feel free to correct me if I am wrong.

Link to comment
Share on other sites

            if (!this.worldObj.isRemote && this.isRiding() && this.ridingEntity instanceof EntityLivingBase)
            {
                  this.mountEntity((Entity)null);
            }

To:

            if (!this.worldObj.isRemote && this.isRiding() && ridingEntity != null && ridingEntity.shouldDismountInWater(this))
            {
                this.mountEntity((Entity)null);
            }

 

and in entity you have:

public boolean shouldDismountInWater(Entity rider)
{
    return this instanceof EntityLivingBase;
}

...

How is that confusing? Give the mounted the choice of kicking the mountee off if it so chooses, Which mimics what this is doing.

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Consider supporting the team on Patreon

Link to comment
Share on other sites

That makes a lot of sense.

 

I was thinking you were suggesting only making the dismounting code inside the mount's code, and not doing the check at that line in the entityLivingBase code, since that wouldn't change things.

 

With the way you have it, it would give the ridden entity the control over kicking, which makes it more generally customizable, and it will make the check at the right place in code, so that is the best solution to the issue. Thanks for your help and insight.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I have a problem, I am trying to put two different effects to two different armors but when I run it only the emerald armor effect works. This is the code public class ModArmorItem extends ArmorItem{ private static final Map<ArmorMaterial, MobEffectInstance> MATERIAL_TO_EFFECT_MAP = (new ImmutableMap.Builder<ArmorMaterial, MobEffectInstance>()) .put(ModArmorMaterials.EMERALD, new MobEffectInstance(MobEffects.HERO_OF_THE_VILLAGE,200, 1,false,false, true)) .put(ModArmorMaterials.OBSIDIAN, new MobEffectInstance(MobEffects.FIRE_RESISTANCE,200, 1,false,false, true)).build(); public ModArmorItem(ArmorMaterial pMaterial, Type pType, Properties pProperties) { super(pMaterial, pType, pProperties); } @Override public void onArmorTick(ItemStack stack, Level world, Player player){ if (!world.isClientSide()) { if (hasFullSuitOfArmorOn(player)) { evaluateArmorEffects(player); } } } private void evaluateArmorEffects(Player player) { for (Map.Entry<ArmorMaterial,MobEffectInstance> entry : MATERIAL_TO_EFFECT_MAP.entrySet()){ ArmorMaterial mapArmorMaterial = entry.getKey(); MobEffectInstance mapStatusEffect = entry.getValue(); if (hasCorrectArmorOn(mapArmorMaterial, player)) { addStatusEffectForMaterial(player, mapArmorMaterial, mapStatusEffect); } } } private void addStatusEffectForMaterial(Player player, ArmorMaterial mapArmorMaterial, MobEffectInstance mapStatusEffect) { boolean hasPlayerEffect = player.hasEffect(mapStatusEffect.getEffect()); if (hasCorrectArmorOn(mapArmorMaterial, player) && !hasPlayerEffect) { player.addEffect(new MobEffectInstance(mapStatusEffect)); } } private boolean hasCorrectArmorOn(ArmorMaterial material, Player player) { for (ItemStack armorStack : player.getInventory().armor){ if (!(armorStack.getItem() instanceof ArmorItem)) { return false; } } ArmorItem helmet = ((ArmorItem)player.getInventory().getArmor(3).getItem()); ArmorItem breastplace = ((ArmorItem)player.getInventory().getArmor(2).getItem()); ArmorItem leggins = ((ArmorItem)player.getInventory().getArmor(1).getItem()); ArmorItem boots = ((ArmorItem)player.getInventory().getArmor(0).getItem()); return helmet.getMaterial() == material && breastplace.getMaterial() == material && leggins.getMaterial() == material && boots.getMaterial() == material; } private boolean hasFullSuitOfArmorOn(Player player){ ItemStack helmet = player.getInventory().getArmor(3); ItemStack breastplace = player.getInventory().getArmor(2); ItemStack leggins = player.getInventory().getArmor(1); ItemStack boots = player.getInventory().getArmor(0); return !helmet.isEmpty() && !breastplace.isEmpty() && !leggins.isEmpty() && !boots.isEmpty(); } } Also when I place two effects on the same armor, the game crashes. Here is the crash file. The code is the same, only this part is different   private static final Map<ArmorMaterial, MobEffectInstance> MATERIAL_TO_EFFECT_MAP = (new ImmutableMap.Builder<ArmorMaterial, MobEffectInstance>()) .put(ModArmorMaterials.EMERALD, new MobEffectInstance(MobEffects.HERO_OF_THE_VILLAGE,200, 1,false,false, true)) .put(ModArmorMaterials.EMERALD, new MobEffectInstance(MobEffects.FIRE_RESISTANCE,200, 1,false,false, true)).build(); I hope you guys can help me. Thanks.
    • I removed all related embeddium and oculus mods, i just tested it by disconnecting and the error happened again. heres the report https://pastebin.com/1kcR5wAt   EDIT: i tried removing xaeros and also smoothboot thinking there may be an issue there, nothing, heres that report too. https://pastebin.com/zQS7i9rM
    • Hi, I need suggestions. I am a beginner in Minecraft Modding. I would like to apply custom effects to some armors, something like: more chance to drop seeds, change zombie awareness, drop more pieces of wood when chopping logs, and things like that. How would you recommend me to do it, is there any library that has something similar and which ones would you recommend me?.
    • "downloading minecraft server failed, invalid Checksum. try again, or manually place server.jar to skip download"    
    • You have to create an Entity class called PlayerPart and use multiple of them to make the different parts of the player. See EnderDragonPart.java source code. The green hitboxes of the dragon are all EnderDragonParts
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.