Jump to content

[Solved specifically]Detecting click position?


Naiten

Recommended Posts

Well, myitemclass.onLeftClickEntity() allows me to perform different stuff with the entity i clicked. But how do i know the position at wich player clicked? I.e. i want to know if player has clicked front/rear side of my entity. Any ways to do that?

If i helped you, don't forget pressing "Thank You" button. Thanks for your time.

Link to comment
Share on other sites

  • 2 weeks later...
front/rear side of my entity.

suspicious look

 

float angleDifference = entity1.rotationYaw-entity2.rotationYaw;

if they are facing itll be roughly 180, if its on the side itll be roughly 90 or 270 (depending on sides)

if its from the back itll be roughly 0

 

 

... now you're just mean. be honest, tell me if you dont want my help

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

You code is obviously not going to work. If you think it will, take a look at the picture:

 

mE0soQs.jpg

 

E — wagon with front and rear couplers; P1, P2 — players; rY — entity rotationYaw; players have equal rotationYaw, that in this case is zero.

If i use your code it will work next way:

angleDifference_1 = rY - 0;

angleDifference_2 = rY - 0;

angleDifference_1 = angleDifference_2 =>

it will return that both players have clicked same couplers, what is false.

 

Next time think a little, before advising something that is not working and saying i'm „just mean“ and „dont want your help“.

If i helped you, don't forget pressing "Thank You" button. Thanks for your time.

Link to comment
Share on other sites

You code is obviously not going to work. If you think it will, take a look at the picture:

 

mE0soQs.jpg

 

E — wagon with front and rear couplers; P1, P2 — players; rY — entity rotationYaw; players have equal rotationYaw, that in this case is zero.

If i use your code it will work next way:

angleDifference_1 = rY - 0;

angleDifference_2 = rY - 0;

angleDifference_1 = angleDifference_2 =>

it will return that both players have clicked same couplers, that is false.

 

Next time think a little, before advising something that is not working and saying i'm „just mean“ and „dont want our help“.

 

I don't want another rage fight to happen (had one on FB last night, no ones business xD).

 

By looking at your drawing, it seems to be that you are right. BUT!!!!! You did not specify wether you wanted a front or back of the same thing, thus not fully explaining your question. For what WAS asked, you where given the answer. For what you didn't ask, you obviously weren't given an answer.

 

Therefore the lessons we can ALL take away from this is: Ask the ENTIRE question you want answered, don't jump to conclusions, and for me, don't jump into random business (except for that fact that hydroflame is technically my boss in a way is my coworker...).

I am Mew. The Legendary Psychic. I behave oddly and am always playing practical jokes.

 

I have also found that I really love making extremely long and extremely but sometimes not so descriptive variables. Sort of like what I just did there xD

Link to comment
Share on other sites

You did not specify wether you wanted a front or back of the same thing
Haven't i wrote i want to know if player has clicked front/rear side of my entity ? Are my eyes and memory tricking me?

thus not fully explaining your question. For what WAS asked, you where given the answer. For what you didn't ask, you obviously weren't given an answer.

 

Therefore the lessons we can ALL take away from this is: Ask the ENTIRE question you want answered, don't jump to conclusions, and for me, don't jump into random business (except for that fact that hydroflame is technically my boss in a way is my coworker...).

The lesson you should take from this — read more attentively, and don't be a smart-ass.

If i helped you, don't forget pressing "Thank You" button. Thanks for your time.

Link to comment
Share on other sites

hydroflame, huh, what happened now? Have i unfairly offended you or what?

 

I am sorry I did not explain well enough. You never said that you had a mirrored model. Therefore, it still gives you the side you clicked on. And double checking your drawing, it is well and truly wrong...

I am Mew. The Legendary Psychic. I behave oddly and am always playing practical jokes.

 

I have also found that I really love making extremely long and extremely but sometimes not so descriptive variables. Sort of like what I just did there xD

Link to comment
Share on other sites

wth. why does your post have a thank you from me?o_o

 

anyway, you can use hydroflame's suggestion. you just have to tweak it a little. since you say you're good in math, you should be able to understand this:

 

take the player's position to be a point of origin then check what quadrant the entity's position is in relative to that point. if it's in quadrant 1, the difference in angle (hydroflame's suggestion) should be x degrees. if it's in quadrant 2, it should be something different, and so on

Link to comment
Share on other sites

I would use getLookVec() from EntityLivingBase.

This is a code I made for Battlegear's dagger backstab ability:

protected boolean performBackStab(Item item, EntityLivingBase entityHit, EntityLivingBase entityHitting) {
        //Get victim and murderer vector views at hit time
        double[] victimView = new double[]{entityHit.getLookVec().xCoord,entityHit.getLookVec().zCoord};
        double[] murdererView = new double[]{entityHitting.getLookVec().xCoord,entityHitting.getLookVec().zCoord};
        //back-stab conditions: vectors are closely enough aligned, (fuzzy parameter might need testing)
        //but not in opposite directions (face to face or sideways)
        if(Math.abs(victimView[0]*murdererView[1]-victimView[1]*murdererView[0])<backstabFuzzy &&
                Math.signum(victimView[0])==Math.signum(murdererView[0]) &&
                Math.signum(victimView[1])==Math.signum(murdererView[1])){
            return ((IBackStabbable)item).onBackStab(entityHit, entityHitting);//Perform back stab effect
        }
        return false;
    }

I use a fuzzy parameter (close to 0) to allow player some chance of doing it.

Hope that helped.

Link to comment
Share on other sites

I am sorry I did not explain well enough. You never said that you had a mirrored model. Therefore, it still gives you the side you clicked on. And double checking your drawing, it is well and truly wrong...
I don't understand wtf you are talking about, especially 'mirrored model' and following part. And why you are quoting my question about such anger, presented to hydroplane.

 

pelep, GotoLink, thanks for suggestions, but i suddenly got an idea, that will definitely work and which i like more, because i have half of it already done before. I'm currently developing it and i'll share the result if anybody wants...

If i helped you, don't forget pressing "Thank You" button. Thanks for your time.

Link to comment
Share on other sites

So, i'm almost done with it. Currently the code works fine only on flat plane, because it's one o'clock am, i'm tired and don't remember how to write line equations in three dimensions. Also, it will work fine only in my or similar case, because i don't really need side-detection, rather than point-detection ('cause i represent wagon couplers as points where they are located).

 

My draft:

width=800 height=1067wAEv612.jpg?1 [/img]

 

So, since couplers are points that are placed on wagon axis and rotate together with it, i can define their global positions by wagon position, it's rotation and preset distances between couplers and wagon centre. See the top of the draft.

 

//This is what i've made before
//somewhere in my wagon class
rotationCos = Math.cos(Math.toRadians(this.rotationYaw + 90)); //note that i add 90 degrees, because 
rotationSin = Math.sin(Math.toRadians(this.rotationYaw + 90)); //rotationYaw equals zero when parallel to Z-axis
frontCouplerX = posX + rotationCos * frontCouplerShift);
frontCouplerZ = posZ + rotationSin * frontCouplerShift);
rearCouplerX = posX + rotationCos * rearCouplerShift);
rearCouplerZ = posZ + rotationSin * rearCouplerShift);

 

Then i define distance between the front/rear point and the line of player's sight direction (which is length of a perpendicular passing from point to line). Lesser value indicates needed coupler. See the top middle of the draft.

To define that distance i've written a function, because i've not found anything about it in MC sources. Maybe i was searching bad, idk. I'm bad at explaining, but however: both given line and it's perpendicular could be described by angular coefficient equations, which look like y = kx + b, where k is angular coefficient (or a tangent of the angle between line and X-axis) and b is y-intercept of the line.

After equations are made, they are combined and then solved, so we know coordinates of the interception point H. Finally, i use Pythagorean to define the distance between given and intersection points. See the bottom of the draft.

 

public float dist_point2line(float mx, float mz, float qx, float qz, float angle){
//[b]mx-mz[/b] - coordinates of the separate point (coupler), [b]qx-qz[/b] - coordinates of any point that belongs to the line
//in my case it's player position. [b]angle[/b] = angle between the line and X-axis.
float k  = (float) Math.tan(Math.toRadians(angle));
float k1 = (float) Math.tan(Math.toRadians(angle + 90F));
float b  = (float) (qz - k * qx);
float b1  = (float) (mz - k1 * mx);
float hx = (b - b1)/(k1 - k);
float hz = k * hx + b;
return (float) Math.sqrt((hx - mx) * (hx - mx) + (hz - mz) * (hz - mz));
//this was not optimized, because written to show the algorithm.
}

 

And the last piece of code:

 

float dist_front = dist_point2line(cart.frontCouplerX, cart.frontCouplerZ, 
(float) player.posX, (float) player.posZ, player.rotationYaw + 90);
float dist_rear = dist_point2line(cart.rearCouplerX, cart.rearCouplerZ, 
(float) player.posX, (float) player.posZ, player.rotationYaw + 90);
if(dist_front < dist_rear) player.addChatMessage("Clicked on front coupler");
else player.addChatMessage("Clicked on rear coupler");

 

 

Final note: this code was written especially for my case, if you want something more or less specific, i don't promise good results...

If i helped you, don't forget pressing "Thank You" button. Thanks for your time.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • https://mclo.gs/4UC49Ao
    • Way back in the Forge 1.17 days, work started for adding JPMS (Java Platform Module Support) to ModLauncher and ForgeModLoader. This has been used internally by Forge and some libraries for a while now, but mods (those with mods.toml specifically) have not been able to take advantage of it. As of Forge 1.21.1 and 1.21.3, this is now possible!   What is JPMS and what does it mean for modders? JPMS is the Java Platform Module System, introduced in Java 9. It allows you to define modules, which are collections of packages and resources that can be exported or hidden from other modules. This allows for much more fine-tuned control over visibility, cleaner syntax for service declarations and support for sealed types across packages. For example, you might have a mod with a module called `com.example.mod` that exports `com.example.mod.api` and `com.example.mod.impl` to other mods, but hides `com.example.mod.internal` from them. This would allow you to have a clean API for other mods to use, while keeping your internal implementation details hidden from IDE hints, helping prevent accidental usage of internals that might break without prior notice. This is particularly useful if you'd like to use public records with module-private constructors or partially module-private record components, as you can create a sealed interface that only your record implements, having the interface be exported and the record hidden. It's also nice for declaring and using services, as you'll get compile-time errors from the Java compiler for typos and the like, rather than deferring to runtime errors. In more advanced cases, you can also have public methods that are only accessible to specific other modules -- handy if you want internal interactions between multiple of your own mods.   How do I bypass it? We understand there may be drama in implementing a system that prevents mods from accessing each other's internals when necessary (like when a mod is abandoned or you need to fix a compat issue) -- after all, we are already modding a game that doesn't have explicit support for Java mods yet. We have already thought of this and are offering APIs from day one to selectively bypass module restrictions. Let me be clear: Forge mods are not required to use JPMS. If you don't want to use it, you don't have to. The default behaviour is to have fully open, fully exported automatic modules. In Java, you can use the `Add-Opens` and `Add-Exports` manifest attributes to selectively bypass module restrictions of other mods at launch time, and we've added explicit support for these when loading your Forge mods. At compile-time, you can use existing solutions such as the extra-java-module-info Gradle plugin to deal with non-modular dependencies and add extra opens and exports to other modules. Here's an example on how to make the internal package `com.example.examplemod.internal` open to your mod in your build.gradle: tasks.named('jar', Jar) { manifest { attributes([ 'Add-Opens' : 'com.example.examplemod/com.example.examplemod.internal' 'Specification-Title' : mod_id, 'Specification-Vendor' : mod_authors // (...) ]) } } With the above in your mod's jar manifest, you can now reflectively access the classes inside that internal package. Multiple entries are separated with a space, as per Java's official spec. You can also use Add-Exports to directly call without reflection, however you'd need to use the Gradle plugin mentioned earlier to be able to compile. The syntax for Add-Exports is the same as Add-Opens, and instructions for the compile-time step with the Gradle plugin are detailed later in this post. Remember to prefer the opens and exports keywords inside module-info.java for sources you control. The Add-Opens/Add-Exports attributes are only intended for forcing open other mods.   What else is new with module support? Previously, the runtime module name was always forced to the first mod ID in your `mods.toml` file and all packages were forced fully open and exported. Module names are now distinguished from mod IDs, meaning the module name in your module-info.java can be different from the mod ID in your `mods.toml`. This allows you to have a more descriptive module name that doesn't have to be the same as your mod ID, however we strongly recommend including your mod ID as part of your module name to aid troubleshooting. The `Automatic-Module-Name` manifest attribute is now also honoured, allowing you to specify a module name for your mod without needing to create a `module-info.java` file. This is particularly useful for mods that don't care about JPMS features but want to have a more descriptive module name and easier integration with other mods that do use JPMS.   How do I use it? The first step is to create a `module-info.java` file in your mod's source directory. This file should be in the same package as your main mod class, and should look something like this: open module com.example.examplemod { requires net.minecraftforge.eventbus; requires net.minecraftforge.fmlcore; requires net.minecraftforge.forge; requires net.minecraftforge.javafmlmod; requires net.minecraftforge.mergetool.api; requires org.slf4j; requires logging; } For now, we're leaving the whole module open to reflection, which is a good starting point. When we know we want to close something off, we can remove the open modifier from the module and open or export individual packages instead. Remember that you need to be open to Forge (module name net.minecraftforge.forge), otherwise it can't call your mod's constructor. Next is fixing modules in Gradle. While Forge and Java support modules properly, Gradle does not put automatic modules on the module path by default, meaning that the logging module (from com.mojang:logging) is not found. To fix this, add the Gradle plugin and add a compile-time module definition for that Mojang library: plugins { // (...) id 'org.gradlex.extra-java-module-info' version "1.9" } // (...) extraJavaModuleInfo { failOnMissingModuleInfo = false automaticModule("com.mojang:logging", "logging") } The automatic module override specified in your build.gradle should match the runtime one to avoid errors. You can do the same for any library or mod dependency that is missing either a module-info or explicit Automatic-Module-Name, however be aware that you may need to update your mod once said library adds one. That's all you need to get started with module support in your mods. You can learn more about modules and how to use them at dev.java.
    • Faire la mise à jour grâce à ce lien m'a aider personnellement, merci à @Paint_Ninja. https://www.amd.com/en/support 
    • When I came across the 'Exit Code: I got a 1 error in my Minecraft mods, so I decided to figure out what was wrong. First, I took a look at the logs. In the mods folder (usually where you'd find logs or crash reports), I found the latest.log file or the corresponding crash report. I read it through carefully, looking for any lines with errors or warnings. Then I checked the Minecraft Forge support site, where you can often find info on what causes errors and how to fix them. I then disabled half of my mods and tried running the game. If the error disappeared, it meant that the problem was with the disabled mod. I repeated this several times to find the problem mod.
    • I have no idea - switch to a pre-configured modpack and use it as working base    
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.