Jump to content

[1.16.4] getColor and IdyeablearmorItem not working


Collecter128

Recommended Posts

I'm working on a mod, the Megaman Armor Mod, and I can't seem to add customcolors to modded items. It works if I make the item froma vanilla type that is already colored, but when making my own custom item it just stays gray. "IdyeablearmorItem" doesn't seem to do anything when implemented and "getColor" doesn't help either. Do I need to register them or something to have these properties? I wanted something with multiple layers like a spawn egg, but I will take only one dye color if that's all I can do. My code is free to do whatever with on github if anyone wants to take a look at it: GitHub - Collecter128/MegamanArmorMod: This is a mod adding megaman things to Minecraft

Link to comment
Share on other sites

hmmmm... I have a lot more to learn about programming. Got it. Update the mod... um... I think I understand maybe? So I use this new ColorHandlerEvent.Item class to to register the Custom Item Colors? I'm gonna try some things out. Thanks for the direction in which to look, but I may be back if I need help with how this works.

Link to comment
Share on other sites

Sorry, I'm back. Updating to 1.16.5 may take a while but I started it. I tried to get this working in 1.16.4 to see if I could understand what to do but I don't know how to use your information. I assume I need a new class that extends ItemColors and that I have to somehow use  ColorHandlerEvent.Item. Am I warm or cold on how this works? 

Link to comment
Share on other sites

18 minutes ago, Collecter128 said:

I assume I need a new class that extends ItemColors

it's a interface so you need to implements it, but basically yes

20 minutes ago, Collecter128 said:

I have to somehow use  ColorHandlerEvent.Item

it's an Event you need to subscribe to it, then you be able to call ColorHandlerEvent.Item#getItemColors and then ItemColors#register to register your IItemColor implementation
you can take a look at ItemColors.createDefault to look at the vanilla implementations

Link to comment
Share on other sites

... I'm sorry but I don't get it. I really want to learn but I don't think I know what I'm doing.

MegamanArmorMod/java/com/collecter128/megamanarmormod/core at code · Collecter128/MegamanArmorMod (github.com)

CustomItemColors and CustomItemColors2 are my attempts at making this thing work but  I have been getting errors trying to implement things. 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • A friend found this code, but I don't know where. It seems to be very outdated, maybe from 1.12? and so uses TextureManager$loadTexture and TextureManager$deleteTexture which both don't seem to exist anymore. It also uses Minecraft.getMinecraft().mcDataDir.getCanonicalPath() which I replaced with the resource location of my texture .getPath()? Not sure if thats entirely correct. String textureName = "entitytest.png"; File textureFile = null; try { textureFile = new File(Minecraft.getMinecraft().mcDataDir.getCanonicalPath(), textureName); } catch (Exception ex) { } if (textureFile != null && textureFile.exists()) { ResourceLocation MODEL_TEXTURE = Resources.OTHER_TESTMODEL_CUSTOM; TextureManager texturemanager = Minecraft.getMinecraft().getTextureManager(); texturemanager.deleteTexture(MODEL_TEXTURE); Object object = new ThreadDownloadImageData(textureFile, null, MODEL_TEXTURE, new ImageBufferDownload()); texturemanager.loadTexture(MODEL_TEXTURE, (ITextureObject)object); return true; } else { return false; }   Then I've been trying to go through the source code of the reload resource packs from minecraft, to see if I can "cache" some data and simply reload some textures and swap them out, but I can't seem to figure out where exactly its "loading" the texture files and such. Minecraft$reloadResourcePacks(bool) seems to be mainly controlling the loading screen, and using this.resourcePackRepository.reload(); which is PackRepository$reload(), but that function seems to be using this absolute confusion of a line List<String> list = this.selected.stream().map(Pack::getId).collect(ImmutableList.toImmutableList()); and then this.discoverAvailable() and this.rebuildSelected. The rebuild selected seemed promising, but it seems to just be going through each pack and doing this to them? pack.getDefaultPosition().insert(list, pack, Functions.identity(), false); e.g. putting them into a list of packs and returning that into this.selected? Where do the textures actually get baked/loaded/whatever? Any info on how Minecraft reloads resource packs or how the texture manager works would be appreciated!
    • This might be a long shot , but do you remember how you fixed that?
    • Yeah, I'll start with the ones I added last night.  Wasn't crashing until today and wasn't crashing at all yesterday (+past few days since removing Cupboard), so deductive reasoning says it's likeliest to be one of the new ones.  A few horse armor mods and a corn-based add-on to Farmer's Delight, the latter which I hope to keep - I could do without the horse armor mods if necessary.  Let me try a few things and we'll see. 
    • Add crash-reports with sites like https://mclo.gs/ Add this mod: https://www.curseforge.com/minecraft/mc-mods/packet-fixer/files/5416165
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.