Jump to content

Unbreakable Armor


ezeglace

Recommended Posts

So i have been making armor and one thing i noticed was that when you enter 0 for the durability in the enumarmormaterial, while unbreakable it does not protect you at all.

This is the code that i have written.

public static EnumArmorMaterial armorPure = EnumHelper.addArmorMaterial("Pure", 0, new int[]{10, 16, 14, 10}, 0);

As you can see the durability is set to zero but it does not protect when worn.

is there anyway to have the armor truly unbreakable while protect you as it should?

 

Link to comment
Share on other sites

What happens if you override isDamageable() in your new armor class with something like this?

 

    public boolean isDamageable()    { return false; }

 

I'm guessing that's checked before damage is applied to an item (though I could be way off, I'm still new at this).

 

Nope, that don't work. I'll just go sit quietly now.

Link to comment
Share on other sites

I tried that and unfortunately it does not work

 

I'm poring over the code now (you've piqued my curiosity). The trick is to find out where damage is applied and override that method...  I can say that it doesn't seem to be getDamage, or getItemDamage. Overriding both of those to return 0 doesn't seem to help.

 

Update: It looks like damaging items is handled in the ItemStack class. I was apparently on the right track, but ItemStack.damageItem doesn't pay attention to isDamageable(), just isItemStackDamageable()

 

Maybe an extension from ItemStack overriding isItemStackDamageable or damageItem(), that checks for a flag that your immortal armor has set before applying damage.

Link to comment
Share on other sites

It looks like damaging items is handled in the ItemStack class. I was apparently on the right track, but ItemStack.damageItem doesn't pay attention to isDamageable(), just isItemStackDamageable()

 

Maybe an extension from ItemStack overriding isItemStackDamageable or damageItem(), that checks for a flag that your immortal armor has set before applying damage...

 

Naw, that'll need overrides all the way up to the player to change the armor inventory type...

 

I'm not well-versed in forge events, but I think Mazetar has the right idea. If there's an event you can trap when an item is damaged, you can have it self-heal...

Link to comment
Share on other sites

public ItemArmor(int par1, EnumArmorMaterial par2EnumArmorMaterial, int par3, int par4)

    {

        super(par1);

        this.material = par2EnumArmorMaterial;

        this.armorType = par4;

        this.renderIndex = par3;

        this.damageReduceAmount = par2EnumArmorMaterial.getDamageReductionAmount(par4);

        this.setMaxDamage(par2EnumArmorMaterial.getDurability(par4));

        this.maxStackSize = 1;

        this.setCreativeTab(CreativeTabs.tabCombat);

        BlockDispenser.dispenseBehaviorRegistry.putObject(this, field_96605_cw);

    }

 

 

just saying you could return 0 to that ....

 

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

        this.damageReduceAmount = par2EnumArmorMaterial.getDamageReductionAmount(par4);

 

just saying you could return 0 to that ....

 

That's the amount of damage the armor takes? I read it as that's the amount of damage it absorbs... damn obfuscation...

Link to comment
Share on other sites

yes, brain not working too well so late

 

but

 

your custom enum armor material should override

 

public int getDurability(int par1)

    {

        return ItemArmor.getMaxDamageArray()[par1] * this.maxDamageFactor;

    }

and that could return Integer.MAX_VALUE

 

the armor wouldnt be unbreakable... but it would sure take a super long time to break

 

other then that i kinda agree with Mazetar, or make a TickHandler that restore this armor type to max durability

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

Found in Item

 

     /**
     * Called each tick as long the item is on a player inventory. Uses by maps to check if is on a player hand and
     * update it's contents.
     */
    public void onUpdate(ItemStack par1ItemStack, World par2World, Entity par3Entity, int par4, boolean par5) {}

 

Might, perhaps, be overkill...

Link to comment
Share on other sites

Dude int's max value is insanely large, I doubt you can break it at all lols!

 

Edit: re-reading the last posts from you I find it clear that you have all you need to reach A solution to your problem :)

If you guys dont get it.. then well ya.. try harder...

Link to comment
Share on other sites

No idea at the top of my head, but tileEntity of the anvil should reveal this ;)

 

Not true. It is in the EnumToolMaterial xD

 

Which could pose a problem :/

I am Mew. The Legendary Psychic. I behave oddly and am always playing practical jokes.

 

I have also found that I really love making extremely long and extremely but sometimes not so descriptive variables. Sort of like what I just did there xD

Link to comment
Share on other sites

Hehe as I said no idea, but I would assume the anvils inner workings would reveal whatever it was ;)

 

Well that might not be a problem, since you could make your own materials? :)

 

If you guys dont get it.. then well ya.. try harder...

Link to comment
Share on other sites

Guest
This topic is now closed to further replies.


  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • https://mclo.gs/4UC49Ao
    • Way back in the Forge 1.17 days, work started for adding JPMS (Java Platform Module Support) to ModLauncher and ForgeModLoader. This has been used internally by Forge and some libraries for a while now, but mods (those with mods.toml specifically) have not been able to take advantage of it. As of Forge 1.21.1 and 1.21.3, this is now possible!   What is JPMS and what does it mean for modders? JPMS is the Java Platform Module System, introduced in Java 9. It allows you to define modules, which are collections of packages and resources that can be exported or hidden from other modules. This allows for much more fine-tuned control over visibility, cleaner syntax for service declarations and support for sealed types across packages. For example, you might have a mod with a module called `com.example.mod` that exports `com.example.mod.api` and `com.example.mod.impl` to other mods, but hides `com.example.mod.internal` from them. This would allow you to have a clean API for other mods to use, while keeping your internal implementation details hidden from IDE hints, helping prevent accidental usage of internals that might break without prior notice. This is particularly useful if you'd like to use public records with module-private constructors or partially module-private record components, as you can create a sealed interface that only your record implements, having the interface be exported and the record hidden. It's also nice for declaring and using services, as you'll get compile-time errors from the Java compiler for typos and the like, rather than deferring to runtime errors. In more advanced cases, you can also have public methods that are only accessible to specific other modules -- handy if you want internal interactions between multiple of your own mods.   How do I bypass it? We understand there may be drama in implementing a system that prevents mods from accessing each other's internals when necessary (like when a mod is abandoned or you need to fix a compat issue) -- after all, we are already modding a game that doesn't have explicit support for Java mods yet. We have already thought of this and are offering APIs from day one to selectively bypass module restrictions. Let me be clear: Forge mods are not required to use JPMS. If you don't want to use it, you don't have to. The default behaviour is to have fully open, fully exported automatic modules. In Java, you can use the `Add-Opens` and `Add-Exports` manifest attributes to selectively bypass module restrictions of other mods at launch time, and we've added explicit support for these when loading your Forge mods. At compile-time, you can use existing solutions such as the extra-java-module-info Gradle plugin to deal with non-modular dependencies and add extra opens and exports to other modules. Here's an example on how to make the internal package `com.example.examplemod.internal` open to your mod in your build.gradle: tasks.named('jar', Jar) { manifest { attributes([ 'Add-Opens' : 'com.example.examplemod/com.example.examplemod.internal' 'Specification-Title' : mod_id, 'Specification-Vendor' : mod_authors // (...) ]) } } With the above in your mod's jar manifest, you can now reflectively access the classes inside that internal package. Multiple entries are separated with a space, as per Java's official spec. You can also use Add-Exports to directly call without reflection, however you'd need to use the Gradle plugin mentioned earlier to be able to compile. The syntax for Add-Exports is the same as Add-Opens, and instructions for the compile-time step with the Gradle plugin are detailed later in this post. Remember to prefer the opens and exports keywords inside module-info.java for sources you control. The Add-Opens/Add-Exports attributes are only intended for forcing open other mods.   What else is new with module support? Previously, the runtime module name was always forced to the first mod ID in your `mods.toml` file and all packages were forced fully open and exported. Module names are now distinguished from mod IDs, meaning the module name in your module-info.java can be different from the mod ID in your `mods.toml`. This allows you to have a more descriptive module name that doesn't have to be the same as your mod ID, however we strongly recommend including your mod ID as part of your module name to aid troubleshooting. The `Automatic-Module-Name` manifest attribute is now also honoured, allowing you to specify a module name for your mod without needing to create a `module-info.java` file. This is particularly useful for mods that don't care about JPMS features but want to have a more descriptive module name and easier integration with other mods that do use JPMS.   How do I use it? The first step is to create a `module-info.java` file in your mod's source directory. This file should be in the same package as your main mod class, and should look something like this: open module com.example.examplemod { requires net.minecraftforge.eventbus; requires net.minecraftforge.fmlcore; requires net.minecraftforge.forge; requires net.minecraftforge.javafmlmod; requires net.minecraftforge.mergetool.api; requires org.slf4j; requires logging; } For now, we're leaving the whole module open to reflection, which is a good starting point. When we know we want to close something off, we can remove the open modifier from the module and open or export individual packages instead. Remember that you need to be open to Forge (module name net.minecraftforge.forge), otherwise it can't call your mod's constructor. Next is fixing modules in Gradle. While Forge and Java support modules properly, Gradle does not put automatic modules on the module path by default, meaning that the logging module (from com.mojang:logging) is not found. To fix this, add the Gradle plugin and add a compile-time module definition for that Mojang library: plugins { // (...) id 'org.gradlex.extra-java-module-info' version "1.9" } // (...) extraJavaModuleInfo { failOnMissingModuleInfo = false automaticModule("com.mojang:logging", "logging") } The automatic module override specified in your build.gradle should match the runtime one to avoid errors. You can do the same for any library or mod dependency that is missing either a module-info or explicit Automatic-Module-Name, however be aware that you may need to update your mod once said library adds one. That's all you need to get started with module support in your mods. You can learn more about modules and how to use them at dev.java.
    • Faire la mise à jour grâce à ce lien m'a aider personnellement, merci à @Paint_Ninja. https://www.amd.com/en/support 
    • When I came across the 'Exit Code: I got a 1 error in my Minecraft mods, so I decided to figure out what was wrong. First, I took a look at the logs. In the mods folder (usually where you'd find logs or crash reports), I found the latest.log file or the corresponding crash report. I read it through carefully, looking for any lines with errors or warnings. Then I checked the Minecraft Forge support site, where you can often find info on what causes errors and how to fix them. I then disabled half of my mods and tried running the game. If the error disappeared, it meant that the problem was with the disabled mod. I repeated this several times to find the problem mod.
    • I have no idea - switch to a pre-configured modpack and use it as working base    
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.