Jump to content

Custom Enchantment adding effect when attacking an Entity


OwnAgePau

Recommended Posts

Hi there,

 

I have been looking into the adding of enchantments and i have gotten my own enchantment "Frost Enchantment" to show up as an enchantment book, to work in an anvil and i have gotten it to be able to get the enchantment from an enchantment table.

 

Now i was looking for the place where minecraft handles the effects of the enchantments. I looked at swords, EntityPlayer, Enchantments and more. But i haven't found much of something that looks like an enchantment effect. All i found was the stuff in EntityPlayer that refers to the EnchantmentHelper. I tired looking at tutorials, although i did find some. Most of them were Modloader tutorials and they were changing base files (which i am not going to do).

 

Where would i add the enchantment effect? would i do that in sword onEntityHit() or whatever that method is called? (i don't have the source in front of my right now)

 

Any help is appreciated, thanks.

Link to comment
Share on other sites

You don't call an event, unless you want someone else to catch it.

You register to the event, to receive the calls.

Oh well, i am sorry that my Englisch isn't my first language and that i happened to have sayd something that wasn't completely what i meant. I meant it more in a way like where would i place the code that would make the effect occur, like i want my enchantment to do an effect whenever it hits an entity, but i couldn't figure out where i would do that.

 

I have seen that page indeed, but i still haven't quite gotten straightened out where i would place the effect of my sword. As far as i understand on this thread the guy describes to make a certain class which will use the LivingAttackEvent. So when would this method that is being used in this class be triggered?(called entityAttacked in the example). I understand that i would have to make such a class to hook my "effects" to an event, but i don't yet understand the mechanics behind it. Maybe i am just overthinking this right now (it is quite late for me right now).

Link to comment
Share on other sites

You can search for

MinecraftForge.EventBus.post(new LivingAttackEvent(args))

or similar.

this is where the event is triggered.

 

If you use PreInit, Init methods and such in your main mod class, you already know how to make a method that can receive an event. The only difference is the event argument, and the @ForgeSubscribe annotation instead of @EventHandler.

Just place this method in a class (you can put in your main class at first) then register with

MinecraftForge.EventBus.register(class);

(you register the entire class, so you can put multiple events in one)

 

You should already have methods ready to read and write an ItemStack NBTTag to get/set your enchantment by the way.

Link to comment
Share on other sites

You should already have methods ready to read and write an ItemStack NBTTag to get/set your enchantment by the way.

Uhm i am not sure if it has anything to do with it, but uhm in EnchantmentHelper there are methods that read and write NBTTag. And my enchantment can already be obtained with crafting books and using an enchantment table. I also discovered that whenever i attack a mob the "magic damage effect" is being shown.

 

Also i haven't done much with forge events and such (still) and i do understand what an event is and all, i just don't yet understand all about the forge related registrations around it. So just to see if i understood you correctly: I will make this method in a custom ForgeHookEvent class (or whatver i will call it) that will take care of the way i handle the effect that will occur whenever i hit a mob. So whenever

MinecraftForge.EventBus.post(new LivingAttackEvent(args))

something that code (or similar code) is being run it will execute the entityAttacked(args) method in my ForgeHookEvent.class. Am i right?

 

And yes i do use Init and PreInit :)

Link to comment
Share on other sites

Well with the magic effet i mean the particles that come off a mob whenever you hit them with an enchantment. But as far as i'm concerned it doesn't give any extra damage. I also wanted to have my frost enchantment do give the entity a slow debuff. (i will post my enchantment code in here as an edit after i have started up my pc)

 

Edit:

package Mod_Ores.Enchantments;

import Mod_Ores.EnumCreatureHelper;
import Mod_Ores.EnumSoulCreatureAttribute;
import net.minecraft.enchantment.Enchantment;
import net.minecraft.enchantment.EnumEnchantmentType;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.EnumCreatureAttribute;

public class EnchantmentFrost extends Enchantment
{
/**EnchantmentFrost constructor
 * 
 * @param par1id the effectId
 * @param par2weight the weight (rarity something)
 * @param par3enumenchantmenttype the enchantment type
 */
public EnchantmentFrost(int par1id, int par2weight, EnumEnchantmentType par3enumenchantmenttype)
{
	super(par1id, par2weight, par3enumenchantmenttype);
	this.setName("Frost");
}

public String getName()
{
	return name;
}

    /**
     * Calculates de (magic) damage done by the enchantment on a living entity based on level and entity passed.
     */
    public float calcModifierLiving(int par1, EntityLivingBase par2EntityLivingBase)
    {
        return EnumCreatureHelper.getSoulCreatureAttribute() == EnumSoulCreatureAttribute.FROST ? (float)par1 * 2.5F : (float)par1 * 0.0F;
    }
    // I have made a custom Enum in order to give my mobs a certain attribute and if that attribute is a FROST more damage will be done, that was 1 of the 2 ideas. But i am not sure whether its working completely yet as i haven't tested it yet.
    
    /**
     * Returns the minimal value of enchantability needed on the enchantment level passed.
     */
@Override
    public int getMinEnchantability(int par1)
    {
        return 10 + 20 * (par1 - 1);
    }

    /**
     * Returns the maximum value of enchantability nedded on the enchantment level passed.
     */
@Override
    public int getMaxEnchantability(int par1)
    {
        return super.getMinEnchantability(par1) + 50;
    }

    /**
     * Returns the maximum level that the enchantment can have.
     */
@Override
    public int getMaxLevel()
    {
        return 4;
    }
}

Link to comment
Share on other sites

Okay i have done some testing and registered the custom ForgeHookEvent.class. Whenever i now attack an entity it doesn't do anything, i wonder do i have to super.***method do anything in order to continue the usual stuff and just start coding an if() construction in order to find out whether or not the player is attacking with an enchanted sword with Frost on it. Also before i added the event class i tested out my little bit of code to see if the calcModifier stuff was working and it is. So on certain mobs my weapon now does more damage whenver it has my enchantment so i guess i got 1 part working.

 

So what was that you were saying about NBTTag, i have not worked with it as in, created my own function that uses it. Although i have seen some of those methods and have a general idea of how they work.

Link to comment
Share on other sites

public float calcModifierLiving(int par1, EntityLivingBase par2EntityLivingBase)
    {
        return EnumCreatureHelper.getSoulCreatureAttribute() == EnumSoulCreatureAttribute.FROST ? (float)par1 * 2.5F : (float)par1 * 0.0F;
    }

How does getter work without any argument ?

Do you setSoulCreatureAttribute() somewhere ?

Whenever i now attack an entity it doesn't do anything

Be sure not to cancel the event.You don't need a super.x().

start coding an if() construction in order to find out whether or not the player is attacking with an enchanted sword with Frost on it.

This is it. The enchantment you will check by reading the NBTTag from the ItemStack of player.getHeldItem().

Link to comment
Share on other sites

public float calcModifierLiving(int par1, EntityLivingBase par2EntityLivingBase)
    {
        return EnumCreatureHelper.getSoulCreatureAttribute() == EnumSoulCreatureAttribute.FROST ? (float)par1 * 2.5F : (float)par1 * 0.0F;
    }

How does getter work without any argument ?

Do you setSoulCreatureAttribute() somewhere ?

Whenever i now attack an entity it doesn't do anything

Be sure not to cancel the event.You don't need a super.x().

start coding an if() construction in order to find out whether or not the player is attacking with an enchanted sword with Frost on it.

This is it. The enchantment you will check by reading the NBTTag from the ItemStack of player.getHeldItem().

Jeah i changed my custom getCreatureAttribute it now works the way i wanted it to. All that now matters is what to do in the attackEntityEvent, you say that i have to read from NBTTag. Are there some examples that i could start looking at to get an idea of how to do this properly? As i know that enchantment stuff is already stored in NBTTags so i wouldn't have to do that.

 

And btw how can it be that its being canceld then? all i've got in that event is the if(event.isCancable) statement. Would i get rid of that?

Link to comment
Share on other sites

Don't do setCanceled(true) :)

 

ItemStack item =  player.getHeldItem();
if(item!=null && item.getItem() instanceof 'CustomSwordClass' && item.hasTagCompound())
{
NBTTagList enchTag = item.getEnchantmentTagList();//use this if you stored your enchantment at "ench" tag in the item
//then do things
}

Link to comment
Share on other sites

Oh is that what the event.source is, because i have got it set as

DamageSource attackSource = event.source;

And i thought it was the ammount of damage done to the entity, it seems i was mistaken. Well thanks again :)

Link to comment
Share on other sites

specific answer: no idea

general answer: you could always look at how vanilla code does it :)

 

highlight "enchantmentTagList", right-click and click "show call hierarchy". this will show you everywhere in code where this method is called, you can just follor til you find what vanilla code does with it :)

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

Guest
This topic is now closed to further replies.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • LINK DAFTAR : KLIK DISINI LINK DAFTAR : KLIK DISINI   Slot SHOPEEPAY adalah situs slot deposit SHOPEEPAY Ribu paling gacor di indonesia pada tahun 2023. Situs slot SHOPEEPAY kini menyediakan layanan deposit pakai aplikasi shopee yang amat gacor sampai detik ini. MAXWINBET77 Situs slot SHOPEEPAY saat ini menggunakan layanan deposit dari e-wallet shopee adalah alat pembayaran dempet digital lewat SHOPEEPAY. Slot SHOPEEPAY saat ini menjadi situs slot ternama dengan banyak nya keunggulan di dalam situs slot SHOPEEPAY ini. Slot deposit SHOPEEPAY hadir untuk menyedia kan sarana deposit paling termurah di indonesia. Deposit slot SHOPEEPAY hanya dengan modal 5000 Ribu saja kamu sudah bisa mainkan semua jenis game yang ada di dalam situs slot SHOPEEPAY Ribu seperti gates of olympus, mahjong ways 2, Legacy of Kong Maxways dan Koi Gate yang saat ini banyak sekali di cari orang karna tingkatan kemenangan nya paling besar dan mudah jackpot. TRIK DAN TRIK BERMAIN PALING JITU / SLOT DEPOSIT SHOPEEPAY Pilih Game Slot Gacor Yang Sesuai Dengan Preferensi Dan Anggaran Anda Ada banyak tipe game slot gacor yang bisa Anda pilih, mulai dari yang bertema klasik, petualangan, mitologi, sampai film. Pilihlah game slot gacor yang menarik bagi anda dan cocok dengan volatilitas dan RTP yang anda inginkan. Volatilitas yakni tingkat risiko dan varians dalam permainan, sedangkan RTP yakni prosentase pengembalian kepada pemain. Pilihlah game slot gacor dengan volatilitas dan RTP yang pantas dengan anggaran dan tujuan anda. Manajemen Bankroll Yang Baik Bankroll ialah jumlah uang yang Anda siapkan untuk bermain slot gacor. Penting bagi anda untuk mengelola bankroll anda dengan bagus supaya tidak kehabisan uang atau terjebak dalam kecanduan judi. Tentukan jumlah maksimal yang mau anda pertaruhkan per sesi, per hari, atau per minggu, dan jangan melebihi batas tersebut. Juga, tentukan jumlah kemenangan yang mau anda capai atau jumlah kerugian yang bisa anda terima, dan stop bermain dikala mencapai salah satu dari keduanya. Manfaatkan Bonus Dan Promosi Situs slot gacor Neobank menawarkan bonus dan promosi menarik kepada para pemainnya, seperti bonus new member, bonus deposit, bonus cashback, bonus referral, bonus turnover, jackpot progresif, turnamen, freebet, dan lainnya. Manfaatkan bonus dan promosi ini untuk meningkatkan modal dan peluang kemenangan anda. Tetapi, pastikan juga untuk membaca syarat dan ketentuan yang berlaku agar tidak terjebak dalam prasyarat taruhan atau batasan penarikan yang tidak menguntungkan. Pelajari Paytable Dan Fitur Game Sebelum bermain slot gacor Neobank, pastikan Anda mempelajari paytable dan fitur game. Paytable yaitu tabel yang menonjolkan skor masing masing simbol dan kombinasi kemenangan dalam game. Fitur game yaitu fitur tambahan yang bisa meningkatkan kesempatan kemenangan Anda, seperti wild, scatter, cuma cuma spins, bonus games, multiplier, dsb. Dengan mempelajari paytable dan fitur game, Anda bisa mengenal simbol mana yang semestinya Anda targetkan ketika bermain.
    • Link Daftar : KLIK DISINI  Link Login : KLIK DISINI  Link RTP   : KLIK DISINI  Link Gacor Slot Dana   : KLIK DISINI slot deposit dana 5000 ribu via dana adalah permainan slot dana gacor dengan menyediakan slot server thailand deposit dana. dan slot deposit dana adalah slot terbesar di thailand. anda cukup daftar disini dan mainkan disini slot deposit 5000 ribu via dana sudah dipastikan dengan deposit dana akan membuat akun anda menjadi akun special. situs deposit dana adalah situs yang terpercaya dan terakurat. Slot dana merupakan situs slot deposit dana yang sangat trending dan sangat dikenal luas di masyarakat. dengan adanya MAXWINBET77 anda bisa mendapatkan keuntungan besar setiap hari tanpa adanya potongan  yang pastinya menguntungkan bagi anda. situs slot dana  maxwinbet77 adalah situs slot dana terbaik 2024 dan dijamin mudah maxwin. PERMAINAN YANG ADA DI SLOT DANA MAXWINBET77: - TOGEL 4D - SLOT ONLINE - LIVE CASINO - SPORTSBOOK - ARCADE TEMBAK IKAN - SABUNG AYAM Saat Ini Slot Dana Maxwinbet77 Menyediakan Bonus Berupa : - Bonus New Member - Bonus Deposit Harian - Bonus Cashback - Bonus 2D TERBALIK - Bonus Prize 2 & Prize 3 - Bonus Refferal DAFATR DISINI
    • LINK DAFTAR : KLIK DISINI LINK DAFTAR : KLIK DISINI   Slot seabank meruapakan salah satu situs slot paling gacor deposit seabank 100% mudah maxwin, hari ini situs slot seabank meghadirkan permainan slot dengan kemudahan bergabung hanya dengan menggunakan aplikasi Seabank langsung bisa join dengan bandar slot Seabank terbaik dan terpercaya no.1 di indonesia. Slot Seabank resmi di daftar situs slot deposit pakai Seabank 5000 Gampang Maxwin dimana aplikasi Seabank tersebut telah sanggat membantu para bosku untuk bermain slot online deposit via Seabank saat ini slot Seabank ini membantu dalam mempermudah transaksi disaat bosku ingin deposit melakukan pembayaran. kini orang orang ingin bermian judi online khusus nya games slot tidak perlu khawatir lagi apabila tidak memilikui saldo di ATM, sebab dengan adanya aplikasi Seabank sudah memberikan dampak signifikan buat perjudian di indonesia. Selain slot pakai Seabank, terdapat beberapa aplikasi e-wallet yang dapat di gunakan untuk bertansaksi antara lain, slot deposit 5000 Seabank, slot dana, slot ovo, slot pulsa tanpa potongan, dan slot shopeepay mudah menang bisa bosku pakai untuk setoran Seabank resmi terbaru. intinya slot online deposit Seabank memberikan jamianan kemudahan saat main games slot gacor uang asli terbaik di indonesia bos.
    • LINK DAFTAR : KLIK DISINI LINK DAFTAR : KLIK DISINI   Slot deposit bank bsi merupakan salah satu situs slot gacor deposit bank bsi 24 jam mudah maxwin tanpa batas. hari ini slot deposit bank bsi menawarkan bonus terbesar untuk player yang sudah bergabung di situs slot bank bsi ini, dengan ada nya slot bank bsi sanget mempermudah player untuk melakukan transaksi deposit dengan bank bsi. Sebagai Situs Slot Deposit Bank Bsi meyediakan banyak permainan seperti slot online, live casino, sabung ayam, tembak ikan, sportbook semua game tersebuat sangat aman dan terpercaya. Beramin slot bank bsi sangat mudah hanya dengan niminal deposit 5000 ribu saja anda sudah bisa bermain di semua game yang sudah di sediakan oleh situs slot bank bsi. Slot bank bsi adalah saranan untuk Pemain yang mencari pengalaman bermain slot gacor sekarang dapat menemukan metode pembayaran beragam di berbagai situs slot gacor yang tersebar luas di seluruh negeri. Munculnya situs Slot Bank BSI, kini para pemain dapat menikmati kemudahan dan kenyamanan dalam melakukan transaksi pembayaran. Bahkan memungkinkan pemain untuk fokus sepenuhnya pada permainan yang mereka nikmati sepanjang waktu. Ini adalah langkah penting dalam memperluas aksesibilitas judi slot online di Indonesia dan memberikan pengalaman bermain yang lebih baik kepada para pecinta slot gacor.    
    • Sometimes love could be the worst experience. you get to love and trust your partner only to feel regret over it. i have been married for 7 years now and i found some sudden change in my partner attitude, i tried talking about it but he complains i'm nagging a lot . i tried to ignore his attitude but it became unbearable so i was advised to hire a hacker to help me gain access to his phone so i had know if he is cheating or not so i was introduced to [ Remote spy hacker @ g m ail . c o m ] and this expert helped me gain access to his phone without his notice. i got to see his messages, photos, call recordings and many more . Now i can see his cheating and that's the reason for the attitude all along.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.