[1.18.1] Torch not dropping on break and not quite rendering properly

[Mattah12]

So I have two custom torches, both registered as below:

public static final RegistryObject<Block> LIGHTSTONE_TORCH = BLOCKS.register("lightstone_torch", () -> new TorchBlock(BlockBehaviour.Properties.of(Material.DECORATION)
            .noCollission().noOcclusion().instabreak().lightLevel((p_50886_) -> {return 10;})
            .sound(SoundType.GLASS), ParticleTypes.FLAME));
public static final RegistryObject<Block> WALL_LIGHTSTONE_TORCH = BLOCKS.register ("wall_lightstone_torch", () -> new WallTorchBlock((BlockBehaviour.Properties.of(Material.DECORATION)
            .noCollission().instabreak().lightLevel((p_152607_) -> {return 10;})
            .sound(SoundType.GLASS).dropsLike(Registration.LIGHTSTONE_TORCH.get())), ParticleTypes.FLAME)); public static final RegistryObject<StandingAndWallBlockItem> LIGHTSTONE_TORCH_ITEM = ITEMS.register("lightstone_torch", () ->
            new StandingAndWallBlockItem(Registration.LIGHTSTONE_TORCH.get(), Registration.WALL_LIGHTSTONE_TORCH.get(),
                    new Item.Properties().tab(ModSetup.ITEM_GROUP)));

I was originally erroneously using createSimpleTable, under the assumption that torches in part act like blocks. Obviously that did not work so I am trying the below method:

protected LootTable.Builder createItemTable(String name, Item item) {
        LootPool.Builder builder = LootPool.lootPool()
                .name(name)
                .setRolls(ConstantValue.exactly(1))
                .add(LootItem.lootTableItem(item));
        return LootTable.lootTable().withPool(builder);
    }

This doesn't work either so I'm now a bit stumped. Full repo is here https://github.com/Mattah12/Kanohi_Craft2022/tree/master/src/main/java/com/Mattah12/kanohicraft

 

My other issue is that the torches are rendering as in the linked pic, and not solid like a vanilla torch. https://imgur.com/a/Fo7TfzW

[warjort]

For the loot pool stuff, you create your builders here, but don't do anything with the return value?

https://github.com/Mattah12/Kanohi_Craft2022/blob/62dac5df0ba4f7e5e381ef78e01050721ed2dcd8/src/main/java/com/Mattah12/kanohicraft/datagen/KanLootTables.java#L26

[warjort]

For the torch rendering, not really my area of expertise.

But you are using RenderType.translucent() while vanilla uses RenderType.cutout()

https://github.com/Mattah12/Kanohi_Craft2022/blob/62dac5df0ba4f7e5e381ef78e01050721ed2dcd8/src/main/java/com/Mattah12/kanohicraft/setup/ClientSetup.java#L21

Edited July 11, 2022 by warjort

[Mattah12]

  On 7/11/2022 at 12:11 PM, warjort said:

For the loot pool stuff, you create your builders here, but don't do anything with the return value?

https://github.com/Mattah12/Kanohi_Craft2022/blob/62dac5df0ba4f7e5e381ef78e01050721ed2dcd8/src/main/java/com/Mattah12/kanohicraft/datagen/KanLootTables.java#L26

Expand  

Not sure why you're not seeing my most up-to-dat repo, but I'm now using:

createItemTable("lightstone_torch", Registration.LIGHTSTONE_TORCH_ITEM.get());
createItemTable("lightstone_refined_torch", Registration.LIGHTSTONE_REFINED_TORCH_ITEM.get());
createItemTable("wall_lightstone_torch", Registration.LIGHTSTONE_TORCH_ITEM.get());
createItemTable("wall_lightstone_refined_torch", Registration.LIGHTSTONE_REFINED_TORCH_ITEM.get());



//AND


protected LootTable.Builder createItemTable(String name, Item item) {
        LootPool.Builder builder = LootPool.lootPool()
                .name(name)
                .setRolls(ConstantValue.exactly(1))
                .add(LootItem.lootTableItem(item));
        return LootTable.lootTable().withPool(builder);
    }

 

[warjort]

I still don't see a lootTables.put() in the above code?

[Mattah12]

  On 7/11/2022 at 12:49 PM, warjort said:

I still don't see a lootTables.put() in the above code?

Expand  

You fixed both my issues, thanks. Working code in spoilers below should anyone else want to know.

  Reveal hidden contents

lootTables.put(Registration.LIGHTSTONE_TORCH.get(), createItemTable("lightstone_torch", Registration.LIGHTSTONE_TORCH_ITEM.get()));
lootTables.put(Registration.LIGHTSTONE_REFINED_TORCH.get(), createItemTable("lightstone_refined_torch", Registration.LIGHTSTONE_REFINED_TORCH_ITEM.get()));
lootTables.put(Registration.WALL_LIGHTSTONE_TORCH.get(), createItemTable("wall_lightstone_torch", Registration.LIGHTSTONE_TORCH_ITEM.get()));
lootTables.put(Registration.WALL_LIGHTSTONE_REFINED_TORCH.get(),createItemTable("wall_lightstone_refined_torch",Registration.LIGHTSTONE_REFINED_TORCH_ITEM.get()));