Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

Bow Drawback Speed?

GravityWolf

By GravityWolf
in Modder Support

 Share

Recommended Posts

GravityWolf Stone Miner

GravityWolf

Posted
Posted

I am curious as to how I could change bow drawback speed. I've seen a few posts on this, but none has got resolved. I've looked through bow code, arrow code, (couldn't find EnumAction), and I saw nothing on speed. If anyone knows how to do this, it would be great if you could let me know. Thanks! :D

GravityWolf Stone Miner

GravityWolf

Posted
  • Author
Posted

The total drawback duration is determined by Item#getMaxItemUseDuration().

The actual Icons for the bow are hardcoded into EntityPlayer but you can use the Forge method Item#getIcon(ItemStack, int, EntityPlayer, ItemStack, int) to get that behavior.

 

Sorry, but where would I put

this.getMaxItemUseDuration()

Sorry for my noobishness xP

Fruitsalid Stone Miner

Fruitsalid

Posted
Posted

To change the speed at which the arrow will charge you have to change the 20.0f:

    public void onPlayerStoppedUsing(ItemStack par1ItemStack, World par2World, EntityPlayer par3EntityPlayer, int par4)
    {
        int j = this.getMaxItemUseDuration(par1ItemStack) - par4;

        ArrowLooseEvent event = new ArrowLooseEvent(par3EntityPlayer, par1ItemStack, j);
        MinecraftForge.EVENT_BUS.post(event);
        if (event.isCanceled())
        {
            return;
        }
        j = event.charge;

        boolean flag = par3EntityPlayer.capabilities.isCreativeMode || EnchantmentHelper.getEnchantmentLevel(Enchantment.infinity.effectId, par1ItemStack) > 0;

        if (flag || par3EntityPlayer.inventory.hasItem(Item.arrow.itemID))
        {
            float f = (float)j / 20;
            f = (f * f + f * 2.0F) / 3.0F;

            if ((double)f < 0.1D)
            {
                return;
            }

            if (f > 1.0F)
            {
                f = 1.0F;
            }

            EntityArrow entityarrow = new EntityArrow(par2World, par3EntityPlayer, f * 2.0F);

            if (f == 1.0F)
            {
                entityarrow.setIsCritical(true);
            }

            int k = EnchantmentHelper.getEnchantmentLevel(Enchantment.power.effectId, par1ItemStack);

            if (k > 0)
            {
                entityarrow.setDamage(entityarrow.getDamage() + (double)k * 0.5D + 0.5D);
            }

            int l = EnchantmentHelper.getEnchantmentLevel(Enchantment.punch.effectId, par1ItemStack);

            if (l > 0)
            {
                entityarrow.setKnockbackStrength(l);
            }

            if (EnchantmentHelper.getEnchantmentLevel(Enchantment.flame.effectId, par1ItemStack) > 0)
            {
                entityarrow.setFire(100);
            }

            par1ItemStack.damageItem(1, par3EntityPlayer);
            par2World.playSoundAtEntity(par3EntityPlayer, "random.bow", 1.0F, 1.0F / (itemRand.nextFloat() * 0.4F + 1.2F) + f * 0.5F);

            if (flag)
            {
                entityarrow.canBePickedUp = 2;
            }
            else
            {
                par3EntityPlayer.inventory.consumeInventoryItem(Item.arrow.itemID);
            }

            if (!par2World.isRemote)
            {
                par2World.spawnEntityInWorld(entityarrow);
            }
        }
    }

To make the animation match up with the speed of the charging arrow you have to change the 16, 8, and 0. The animation cycle timing goes from the bottom number to the top one. If you don't have this method replace it with public Icon getItemIconForUseDuration(int par1) method.

public Icon getIcon(ItemStack stack, int renderPass, EntityPlayer player, ItemStack usingItem, int useRemaining)
{
	if(player.getItemInUse() == null) return this.itemIcon;
	int Pulling = stack.getMaxItemUseDuration() - useRemaining;
	if (Pulling >= 16)
	{
		return iconArray[2];
	}
	else if (Pulling > 
	{
		return iconArray[1];
	}
	else if (Pulling > 0)
	{
		return iconArray[0];
	}              
	return itemIcon;
}

Mew Dragon Slayer

Mew

Posted
Posted

To change the speed at which the arrow will charge you have to change the 20.0f:

    public void onPlayerStoppedUsing(ItemStack par1ItemStack, World par2World, EntityPlayer par3EntityPlayer, int par4)
    {
        int j = this.getMaxItemUseDuration(par1ItemStack) - par4;

        ArrowLooseEvent event = new ArrowLooseEvent(par3EntityPlayer, par1ItemStack, j);
        MinecraftForge.EVENT_BUS.post(event);
        if (event.isCanceled())
        {
            return;
        }
        j = event.charge;

        boolean flag = par3EntityPlayer.capabilities.isCreativeMode || EnchantmentHelper.getEnchantmentLevel(Enchantment.infinity.effectId, par1ItemStack) > 0;

        if (flag || par3EntityPlayer.inventory.hasItem(Item.arrow.itemID))
        {
            float f = (float)j / 20;
            f = (f * f + f * 2.0F) / 3.0F;

            if ((double)f < 0.1D)
            {
                return;
            }

            if (f > 1.0F)
            {
                f = 1.0F;
            }

            EntityArrow entityarrow = new EntityArrow(par2World, par3EntityPlayer, f * 2.0F);

            if (f == 1.0F)
            {
                entityarrow.setIsCritical(true);
            }

            int k = EnchantmentHelper.getEnchantmentLevel(Enchantment.power.effectId, par1ItemStack);

            if (k > 0)
            {
                entityarrow.setDamage(entityarrow.getDamage() + (double)k * 0.5D + 0.5D);
            }

            int l = EnchantmentHelper.getEnchantmentLevel(Enchantment.punch.effectId, par1ItemStack);

            if (l > 0)
            {
                entityarrow.setKnockbackStrength(l);
            }

            if (EnchantmentHelper.getEnchantmentLevel(Enchantment.flame.effectId, par1ItemStack) > 0)
            {
                entityarrow.setFire(100);
            }

            par1ItemStack.damageItem(1, par3EntityPlayer);
            par2World.playSoundAtEntity(par3EntityPlayer, "random.bow", 1.0F, 1.0F / (itemRand.nextFloat() * 0.4F + 1.2F) + f * 0.5F);

            if (flag)
            {
                entityarrow.canBePickedUp = 2;
            }
            else
            {
                par3EntityPlayer.inventory.consumeInventoryItem(Item.arrow.itemID);
            }

            if (!par2World.isRemote)
            {
                par2World.spawnEntityInWorld(entityarrow);
            }
        }
    }

To make the animation match up with the speed of the charging arrow you have to change the 16, 8, and 0. The animation cycle timing goes from the bottom number to the top one. If you don't have this method replace it with public Icon getItemIconForUseDuration(int par1) method.

public Icon getIcon(ItemStack stack, int renderPass, EntityPlayer player, ItemStack usingItem, int useRemaining)
{
	if(player.getItemInUse() == null) return this.itemIcon;
	int Pulling = stack.getMaxItemUseDuration() - useRemaining;
	if (Pulling >= 16)
	{
		return iconArray[2];
	}
	else if (Pulling > 
	{
		return iconArray[1];
	}
	else if (Pulling > 0)
	{
		return iconArray[0];
	}              
	return itemIcon;
}

 

You beat me to the punch line :/

I am Mew. The Legendary Psychic. I behave oddly and am always playing practical jokes.

 

I have also found that I really love making extremely long and extremely but sometimes not so descriptive variables. Sort of like what I just did there xD

Mew Dragon Slayer

Mew

Posted
Posted

This is like the first problem I've ever figured out by myself, lol. :)

 

Haha, thats awesome. Don't you just love that feeling of being able to share something you found on your own?

 

I know I love that feeling. There is nothing more satisfying than solving a problem.

I am Mew. The Legendary Psychic. I behave oddly and am always playing practical jokes.

 

I have also found that I really love making extremely long and extremely but sometimes not so descriptive variables. Sort of like what I just did there xD

GravityWolf Stone Miner

GravityWolf

Posted
  • Author
Posted

To change the speed at which the arrow will charge you have to change the 20.0f:

    public void onPlayerStoppedUsing(ItemStack par1ItemStack, World par2World, EntityPlayer par3EntityPlayer, int par4)
    {
        int j = this.getMaxItemUseDuration(par1ItemStack) - par4;

        ArrowLooseEvent event = new ArrowLooseEvent(par3EntityPlayer, par1ItemStack, j);
        MinecraftForge.EVENT_BUS.post(event);
        if (event.isCanceled())
        {
            return;
        }
        j = event.charge;

        boolean flag = par3EntityPlayer.capabilities.isCreativeMode || EnchantmentHelper.getEnchantmentLevel(Enchantment.infinity.effectId, par1ItemStack) > 0;

        if (flag || par3EntityPlayer.inventory.hasItem(Item.arrow.itemID))
        {
            float f = (float)j / 20;
            f = (f * f + f * 2.0F) / 3.0F;

            if ((double)f < 0.1D)
            {
                return;
            }

            if (f > 1.0F)
            {
                f = 1.0F;
            }

            EntityArrow entityarrow = new EntityArrow(par2World, par3EntityPlayer, f * 2.0F);

            if (f == 1.0F)
            {
                entityarrow.setIsCritical(true);
            }

            int k = EnchantmentHelper.getEnchantmentLevel(Enchantment.power.effectId, par1ItemStack);

            if (k > 0)
            {
                entityarrow.setDamage(entityarrow.getDamage() + (double)k * 0.5D + 0.5D);
            }

            int l = EnchantmentHelper.getEnchantmentLevel(Enchantment.punch.effectId, par1ItemStack);

            if (l > 0)
            {
                entityarrow.setKnockbackStrength(l);
            }

            if (EnchantmentHelper.getEnchantmentLevel(Enchantment.flame.effectId, par1ItemStack) > 0)
            {
                entityarrow.setFire(100);
            }

            par1ItemStack.damageItem(1, par3EntityPlayer);
            par2World.playSoundAtEntity(par3EntityPlayer, "random.bow", 1.0F, 1.0F / (itemRand.nextFloat() * 0.4F + 1.2F) + f * 0.5F);

            if (flag)
            {
                entityarrow.canBePickedUp = 2;
            }
            else
            {
                par3EntityPlayer.inventory.consumeInventoryItem(Item.arrow.itemID);
            }

            if (!par2World.isRemote)
            {
                par2World.spawnEntityInWorld(entityarrow);
            }
        }
    }

To make the animation match up with the speed of the charging arrow you have to change the 16, 8, and 0. The animation cycle timing goes from the bottom number to the top one. If you don't have this method replace it with public Icon getItemIconForUseDuration(int par1) method.

public Icon getIcon(ItemStack stack, int renderPass, EntityPlayer player, ItemStack usingItem, int useRemaining)
{
	if(player.getItemInUse() == null) return this.itemIcon;
	int Pulling = stack.getMaxItemUseDuration() - useRemaining;
	if (Pulling >= 16)
	{
		return iconArray[2];
	}
	else if (Pulling > 
	{
		return iconArray[1];
	}
	else if (Pulling > 0)
	{
		return iconArray[0];
	}              
	return itemIcon;
}

 

Aah, thank you! But...um...iconArray?? Does that require me to have an icon, or is that an array you made?

hydroflame World Shaper

hydroflame

Posted
Posted
public Icon getIcon(ItemStack stack, int renderPass, EntityPlayer player, ItemStack usingItem, int useRemaining)

{

if(player.getItemInUse() == null) return this.itemIcon;

int Pulling = stack.getMaxItemUseDuration() - useRemaining;

if (Pulling >= 16)

{

return iconArray[2];

 

Icon[] myIcons = new Icon[5];
myIcons[0] = iconRegister.registerIcon(ModMain.modid+":"+"myItem");
myIcons[1] = iconRegister.registerIcon(ModMain.modid+":"+"myItem2");
myIcons[2] = iconRegister.registerIcon(ModMain.modid+":"+"myItem3");
etc

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

GravityWolf Stone Miner

GravityWolf

Posted
  • Author
Posted

public Icon getIcon(ItemStack stack, int renderPass, EntityPlayer player, ItemStack usingItem, int useRemaining)

{

if(player.getItemInUse() == null) return this.itemIcon;

int Pulling = stack.getMaxItemUseDuration() - useRemaining;

if (Pulling >= 16)

{

return iconArray[2];

 

Icon[] myIcons = new Icon[5];
myIcons[0] = iconRegister.registerIcon(ModMain.modid+":"+"myItem");
myIcons[1] = iconRegister.registerIcon(ModMain.modid+":"+"myItem2");
myIcons[2] = iconRegister.registerIcon(ModMain.modid+":"+"myItem3");
etc

 

Yay, thank you! But I am getting an error. Here is my code:

 

Icon[] iconArray = new Icon[5];

iconArray[0] = iconRegister.registerIcon("nrbi" + ":" + "diamonderBow_0");
iconArray[1] = iconRegister.registerIcon("nrbi" + ":" + "diamonderBow_1");
iconArray[2] = iconRegister.registerIcon("nrbi" + ":" + "diamonderBow_2");

 

I am getting it under the semicolons. If anyone could help, that would be great! Thanks!

Fruitsalid Stone Miner

Fruitsalid

Posted
Posted

You can all this from the ItemBow class.

    public static final String[] bowPullIconNameArray = new String[] {"pulling_0", "pulling_1", "pulling_2"};
    @SideOnly(Side.CLIENT)
    private Icon[] iconArray;

and this

@SideOnly(Side.CLIENT)
public void registerIcons(IconRegister par1IconRegister)
{
	this.itemIcon = par1IconRegister.registerIcon("YourMainClass.modid" + ":" + getUnlocalizedName().substring(5));
	this.iconArray = new Icon[bowPullIconNameArray.length];

	for (int i = 0; i < this.iconArray.length; ++i)
	{
		this.iconArray[i] = par1IconRegister.registerIcon(YourMainClass.modid + ":" + bowPullIconNameArray[i]);
	}
}

Change the YourMainClass to what ever yours is. Also the pulling_0 etc. to whatever your images are called are.

GravityWolf Stone Miner

GravityWolf

Posted
  • Author
Posted

You can all this from the ItemBow class.

    public static final String[] bowPullIconNameArray = new String[] {"pulling_0", "pulling_1", "pulling_2"};
    @SideOnly(Side.CLIENT)
    private Icon[] iconArray;

and this

@SideOnly(Side.CLIENT)
public void registerIcons(IconRegister par1IconRegister)
{
	this.itemIcon = par1IconRegister.registerIcon("YourMainClass.modid" + ":" + getUnlocalizedName().substring(5));
	this.iconArray = new Icon[bowPullIconNameArray.length];

	for (int i = 0; i < this.iconArray.length; ++i)
	{
		this.iconArray[i] = par1IconRegister.registerIcon(YourMainClass.modid + ":" + bowPullIconNameArray[i]);
	}
}

Change the YourMainClass to what ever yours is. Also the pulling_0 etc. to whatever your images are called are.

 

I got it to work, but thanks.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • OhOhIWontLetUGo
      Forge 1.21 – How can I add a custom HUD Overlay (Item Icon + Text)

      By OhOhIWontLetUGo · Posted

      Hi everyone, I'm currently developing a Forge 1.21 mod for Minecraft and I want to display a custom HUD overlay for a minigame. My goal: When the game starts, all players should see an item/block icon (from the base game, not a custom texture) plus its name/text in the HUD – similar to how the bossbar overlay works. The HUD should appear centered above the hotbar (or at a similar prominent spot), and update dynamically (icon and name change as the target item changes). What I've tried: I looked at many online tutorials and several GitHub repos (e.g. SeasonHUD, MiniHUD), but most of them use NeoForge or Forge versions <1.20 that provide the IGuiOverlay API (e.g. implements IGuiOverlay, RegisterGuiOverlaysEvent). In Forge 1.21, it seems that neither IGuiOverlay nor RegisterGuiOverlaysEvent exist anymore – at least, I can't import them and they are missing from the docs and code completion. I tried using RenderLevelStageEvent as a workaround but it is probably not intended for custom HUDs. I am not using NeoForge, and switching the project to NeoForge is currently not an option for me. I tried to look at the original minecraft source code to see how elements like hearts, hotbar etc are drawn on the screen but I am too new to Minecraft modding to understand. What I'm looking for: What is the correct way to add a custom HUD element (icon + text) in Forge 1.21, given that the previous overlay API is missing? Is there a new recommended event, callback, or method in Forge 1.21 for custom HUD overlays, or is everyone just using a workaround? Is there a minimal open-source example repo for Forge 1.21 that demonstrates a working HUD overlay without relying on NeoForge or deprecated Forge APIs? My ideal solution: Centered HUD element with an in-game item/block icon (from the base game's assets, e.g. a diamond or any ItemStack / Item) and its name as text, with a transparent background rectangle. It should be visible to the players when the mini game is running. Easy to update the item (e.g. static variable or other method), so it can change dynamically during the game. Any help, code snippets, or up-to-date references would be really appreciated! If this is simply not possible right now in Forge 1.21, it would also help to know that for sure. Thank you very much in advance!
    • Brown
      [1.20.1] Severe server freeze when exiting Nether portal or entering End (no mods, Forge 1.20.1, Arch Linux)

      By Brown · Posted

      Chunk loading maybe stalls the JVM during dimension travel?
    • Ugdhar
      [Help] How to update a mod from 1.19.2 to 1.20.1

      By Ugdhar · Posted

      The simple answer is there is not an easy way. You would need to know how to program in Java, as well as at least some familiarity with how Forge works so you could port the differences. You would also need the sourcecode for the original mod, and permission from the author to modify it, if they did not use some sort of open source license. So it's not impossible, but it would take some effort, but doing so would open up a whole new world of possibilities for you!
    • Ugdhar
      Crash the server

      By Ugdhar · Posted

      Does it still crash if you remove holdmyitems? Looks like that mod doesn't work on a server as far as I can tell from the error.  
    • ME4eniy
      Crash the server

      By ME4eniy · Posted

      Crashes the server when trying to start. Error code -1. Log  

  • Topics

  • Who's Online (See full list)

    • There are no registered users currently online
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept