Jump to content
View in the app

A better way to browse. Learn more.

Forge Forums

A full-screen app on your home screen with push notifications, badges and more.

To install this app on iOS and iPadOS
  1. Tap the Share icon in Safari
  2. Scroll the menu and tap Add to Home Screen.
  3. Tap Add in the top-right corner.
To install this app on Android
  1. Tap the 3-dot menu (⋮) in the top-right corner of the browser.
  2. Tap Add to Home screen or Install app.
  3. Confirm by tapping Install.

Featured Replies

Posted

I have created custom shield by extending existing ShieldItem:

public final class VikingShieldItem extends ShieldItem {

	public VikingShieldItem() {
		super(createProperties());
	}
	
	private static Properties createProperties()
	{
		Properties properties = new Properties();
		properties.tab(CreativeModeTab.TAB_COMBAT);
		properties.durability(672);
		
		return properties;
	}

	@Override
	public boolean isValidRepairItem(ItemStack repairedItemStack, ItemStack repairItemStack) {
		return repairItemStack.is(OreItems.TITANIUM_INGOT.get());
	}
	
}

I have also created two Blockbench model, one regular, and the other one when shield is blocking, and saved them as viking_shield.json and viking_shield_blocking.json.

In viking_shield.json I have this addition:

	"overrides": [
        {
            "predicate": {
                "blocking": 1
            },
            "model": "experimentalmod:item/viking_shield_blocking"
        }
    ]

However, when I start the game, shield is properly loaded, it blocks, everything works ok, but use animation is not working - it hides and restores to same default look, although it should be tilted.

Is there anything else that must be configured for alternate model to be loaded?

Thanks!

You need to register the blocking ItemProperty for your custom ShieldItem in FMLClientSetupEvent in enqueueWork,
you can take a look at the ItemProperties class to use the vanilla blocking ItemProperty as an example.

Do you have a json model for your Shield or do you want to use the vanilla Model or a custom Model (Java)?

  • Author

@Luis_ST Both models were created in Blockbench and then exported as JSON files.

So I guess you are referring to this:

      register(Items.SHIELD, new ResourceLocation("blocking"), (p_174590_, p_174591_, p_174592_, p_174593_) -> {
         return p_174592_ != null && p_174592_.isUsingItem() && p_174592_.getUseItem() == p_174590_ ? 1.0F : 0.0F;
      });

So even though I do inherit from ShieldItem, I have to create my own custom blocking property, which would probably end up being "experimentalmod:blocking" instead of regular "blocking" ?

I will try to add this now, but regardless of that, is this like a "hack" or proper way to do it for every item property?

Thanks :)

7 minutes ago, Adil Yilan said:

So even though I do inherit from ShieldItem, I have to create my own custom blocking property, which would probably end up being "experimentalmod:blocking" instead of regular "blocking" ?

Correct, it's also useful to include your mod is into the property

8 minutes ago, Adil Yilan said:

I will try to add this now, but regardless of that, is this like a "hack" or proper way to do it for every item property?

1 hour ago, Luis_ST said:

You need to register the blocking ItemProperty for your custom ShieldItem in FMLClientSetupEvent in enqueueWork,
you can take a look at the ItemProperties class to use the vanilla blocking ItemProperty as an example.

 

  • Author

Worked like a charm:

@Mod.EventBusSubscriber(modid = ExperimentalMod.MODID, bus = Mod.EventBusSubscriber.Bus.MOD, value = Dist.CLIENT)
public final class ClientSetupEventHandler {

	private static ResourceLocation BLOCKING_PROPERTY_RESLOC = 
			new ResourceLocation(ExperimentalMod.MODID, "blocking");
	
	@SubscribeEvent
    public static void onClientSetup(final FMLClientSetupEvent event) {

		event.enqueueWork(() -> {
			
	    	ItemProperties.register(WeaponItems.VIKING_SHIELD.get(), BLOCKING_PROPERTY_RESLOC, ($itemStack, $level, $entity, $seed) -> {
	    		return $entity != null && $entity.isUsingItem() && $entity.getUseItem() == $itemStack ? 1.0F : 0.0F;
	    	});
		});
		
    }
}

With this correction in model file:

	"overrides": [
        {
            "predicate": {
                "experimentalmod:blocking": 1
            },
            "model": "experimentalmod:item/viking_shield_blocking"
        }
    ]

 

Thanks @Luis_ST !

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

Important Information

By using this site, you agree to our Terms of Use.

Configure browser push notifications

Chrome (Android)
  1. Tap the lock icon next to the address bar.
  2. Tap Permissions → Notifications.
  3. Adjust your preference.
Chrome (Desktop)
  1. Click the padlock icon in the address bar.
  2. Select Site settings.
  3. Find Notifications and adjust your preference.