Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

[1.19] FriendlyByteBuff is null in constructor when using IForgeMenu.create for registration of custom menu type

Adil Yilan

By Adil Yilan
in Modder Support

 Share

Recommended Posts

Adil Yilan Stone Miner

Adil Yilan

Posted
Posted

Hi,

I have implemented custom chest, but I am getting a very strange error when the menu should appear.

This is how menu is registered: 

public final class ContainerMenuTypes {

	private ContainerMenuTypes() {}
	
	public static final DeferredRegister<MenuType<?>> REGISTRY =
			DeferredRegister.create(ForgeRegistries.MENU_TYPES, ExperimentalMod.MODID);
	
	public static final RegistryObject<MenuType<VikingChestMenu>> VIKING_CHEST =
			REGISTRY.register("viking_chest", () -> IForgeMenuType.create(VikingChestMenu::new));

}

 

And this is how constructor looks like: 

	// This constructor is required by forge to register menu type.
	public VikingChestMenu(int containerId, Inventory inventory, FriendlyByteBuf buff) {
		this(containerId, inventory, inventory.player.level.getBlockEntity(buff.readBlockPos()));
	}

 

So when I click on the chest, this error occurs:

  

[15:31:15] [Render thread/ERROR] [minecraft/BlockableEventLoop]: Error executing task on Client
java.lang.NullPointerException: Cannot invoke "net.minecraft.network.FriendlyByteBuf.readBlockPos()" because "buff" is null
	at ba.appimpact.minecraft.experimental.common.menu.container.VikingChestMenu.<init>(VikingChestMenu.java:83) ~[%23186!/:?] {re:classloading}
	at net.minecraftforge.network.IContainerFactory.create(IContainerFactory.java:20) ~[forge-1.19-41.0.110_mapped_parchment_1.18.2-2022.07.17-1.19.jar%23180%23187!/:?] {re:classloading}
	at net.minecraft.world.inventory.MenuType.create(MenuType.java:44) ~[forge-1.19-41.0.110_mapped_parchment_1.18.2-2022.07.17-1.19.jar%23181!/:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.client.gui.screens.MenuScreens$ScreenConstructor.fromPacket(MenuScreens.java:115) ~[forge-1.19-41.0.110_mapped_parchment_1.18.2-2022.07.17-1.19.jar%23181!/:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
	at net.minecraft.client.gui.screens.MenuScreens.lambda$create$0(MenuScreens.java:43) ~[forge-1.19-41.0.110_mapped_parchment_1.18.2-2022.07.17-1.19.jar%23181!/:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
	at java.util.Optional.ifPresent(Optional.java:178) ~[?:?] {}
	at net.minecraft.client.gui.screens.MenuScreens.create(MenuScreens.java:43) ~[forge-1.19-41.0.110_mapped_parchment_1.18.2-2022.07.17-1.19.jar%23181!/:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
	at net.minecraft.client.multiplayer.ClientPacketListener.handleOpenScreen(ClientPacketListener.java:979) ~[forge-1.19-41.0.110_mapped_parchment_1.18.2-2022.07.17-1.19.jar%23181!/:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
	at net.minecraft.network.protocol.game.ClientboundOpenScreenPacket.handle(ClientboundOpenScreenPacket.java:37) ~[forge-1.19-41.0.110_mapped_parchment_1.18.2-2022.07.17-1.19.jar%23181!/:?] {re:classloading}
	at net.minecraft.network.protocol.game.ClientboundOpenScreenPacket.handle(ClientboundOpenScreenPacket.java:11) ~[forge-1.19-41.0.110_mapped_parchment_1.18.2-2022.07.17-1.19.jar%23181!/:?] {re:classloading}
	at net.minecraft.network.protocol.PacketUtils.lambda$ensureRunningOnSameThread$0(PacketUtils.java:22) ~[forge-1.19-41.0.110_mapped_parchment_1.18.2-2022.07.17-1.19.jar%23181!/:?] {re:classloading}
	at net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:157) ~[forge-1.19-41.0.110_mapped_parchment_1.18.2-2022.07.17-1.19.jar%23181!/:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:23) ~[forge-1.19-41.0.110_mapped_parchment_1.18.2-2022.07.17-1.19.jar%23181!/:?] {re:classloading}
	at net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:131) ~[forge-1.19-41.0.110_mapped_parchment_1.18.2-2022.07.17-1.19.jar%23181!/:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.util.thread.BlockableEventLoop.runAllTasks(BlockableEventLoop.java:116) ~[forge-1.19-41.0.110_mapped_parchment_1.18.2-2022.07.17-1.19.jar%23181!/:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.client.Minecraft.runTick(Minecraft.java:1041) ~[forge-1.19-41.0.110_mapped_parchment_1.18.2-2022.07.17-1.19.jar%23181!/:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
	at net.minecraft.client.Minecraft.run(Minecraft.java:669) ~[forge-1.19-41.0.110_mapped_parchment_1.18.2-2022.07.17-1.19.jar%23181!/:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
	at net.minecraft.client.main.Main.main(Main.java:206) ~[forge-1.19-41.0.110_mapped_parchment_1.18.2-2022.07.17-1.19.jar%23181!/:?] {re:classloading,pl:runtimedistcleaner:A}
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?] {}
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?] {}
	at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?] {}
	at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?] {}
	at net.minecraftforge.fml.loading.targets.ForgeClientUserdevLaunchHandler.lambda$launchService$0(ForgeClientUserdevLaunchHandler.java:25) ~[fmlloader-1.19-41.0.110.jar%2394!/:?] {}
	at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:30) [modlauncher-10.0.8.jar%23106!/:?] {}
	at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:53) [modlauncher-10.0.8.jar%23106!/:?] {}
	at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:71) [modlauncher-10.0.8.jar%23106!/:?] {}
	at cpw.mods.modlauncher.Launcher.run(Launcher.java:106) [modlauncher-10.0.8.jar%23106!/:?] {}
	at cpw.mods.modlauncher.Launcher.main(Launcher.java:77) [modlauncher-10.0.8.jar%23106!/:?] {}
	at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26) [modlauncher-10.0.8.jar%23106!/:?] {}
	at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23) [modlauncher-10.0.8.jar%23106!/:?] {}
	at cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:141) [bootstraplauncher-1.1.2.jar:?] {}

 

For some reason, FriendlyByteBuf buff is null in constructor and I need it to access block entity so that rest of the code can execute.

Any ideas what could be wrong here?

 

Adil Yilan Stone Miner

Adil Yilan

Posted
  • Author
Posted

This is the use method on VikingChestBlock class: 

	@Override
	public InteractionResult use(BlockState blockState, Level level, BlockPos blockPos, Player player, InteractionHand hand, BlockHitResult blockHitResult) {
		
		// IF: Code is executing on logical client.
		if(level.isClientSide) {
			// Do nothing.
			return InteractionResult.SUCCESS;
		}
		
		// Get block entity at the position where block was used.
		BlockEntity blockEntity = level.getBlockEntity(blockPos);
		
        if (blockEntity instanceof VikingChestBlockEntity) {

        	// Open menu.
			player.openMenu((VikingChestBlockEntity)blockEntity);
			
         }
		
		return InteractionResult.CONSUME;
	}

 

I also used this, but didn't work either:

  

@Override
	public InteractionResult use(BlockState blockState, Level level, BlockPos blockPos, Player player, InteractionHand hand, BlockHitResult blockHitResult) {
		
		// IF: Code is executing on logical client.
		if(level.isClientSide) {
			// Do nothing.
			return InteractionResult.SUCCESS;
		}
		
		// Get menu provider reference.
		MenuProvider menuprovider = this.getMenuProvider(blockState, level, blockPos);

		// IF: Menu provider is defined.
		if (menuprovider != null) {
			
			// Open menu.
			player.openMenu(menuprovider);
			
		}

		return InteractionResult.CONSUME;
	}

 

 

Adil Yilan Stone Miner

Adil Yilan

Posted
  • Author
Posted

Thanks @diesieben07 and @Luis_ST, you've helped me a lot as usual. :)

 

It works great now with this code:

  

@Override
      public InteractionResult use(BlockState blockState, Level level, BlockPos blockPos, Player player, InteractionHand hand, BlockHitResult blockHitResult) {
		
		// IF: Code is executing on logical client.
		if(level.isClientSide) {
			// Do nothing.
			return InteractionResult.SUCCESS;
		}
		
		// Get block entity at the block location.
		BlockEntity blockEntity = level.getBlockEntity(blockPos);
		
		// IF: block entity is matching.
		if (blockEntity instanceof VikingChestBlockEntity) {
			
			// Cast player to ServerPlayer.
			ServerPlayer serverPlayer = (ServerPlayer) player;
			
			// Cast block entity to VikingChestBlockEntity.
			VikingChestBlockEntity vikingChestBlockEntity = (VikingChestBlockEntity)blockEntity;

			// Open menu.
            NetworkHooks.openScreen(serverPlayer, vikingChestBlockEntity, blockPos);
		}

		return InteractionResult.CONSUME;
	}

 

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • le0ne
      Crash after world loads to 100%

      By le0ne · Posted

      I've been using this modpack for a few days now with no issues, it was working properly just an hour or two ago and now all of a sudden when I try to load it I get this error: 'The game crashed: exception in server tick loop Error: com.google.gson.JsonSyntaxException: java.lang.IllegalStateException: Expected BEGIN_OBJECT but was STRING at line 1 column 1 path $' debug log: https://pastebin.com/1htBuhsP crash report: https://pastebin.com/QggHKYDg
    • BudgieG671
      Exception in server tick loop 1.20.1 Create modpack

      By BudgieG671 · Posted

      Everything worked fine until I decided to install supplementaries squared, amendments and a couple other mods like artifacts, and compats for it. I'm having a hard time fixing this, and I get this crash whenever I try to enter a world. Not even a new world is feasible. Any help would be highly appreciated!! https://pastebin.com/7KXYZ6fM
    • Lala1
      I cant join my friends server can anyone help?

      By Lala1 · Posted

      Internal Exception: com.google.gson.JsonParseException: Error loading registry data: Unknown element: ResourceKey[minecraft:worldgen/configured_feature / minecraft:crimson_forest_vegetation]   This error is there when i try to join my friends server. We had some mods and it was okay but after 3 days i cant join.
    • Dark...
      PROBLEM WITH SHUTDOWNS ON MODPACK

      By Dark... · Posted

      It just says the mod i had but i dont have now.. and i didnt even use these mods and it still was crashing with the mods  
    • cryptidblade__
      Unknown Forge Error

      By cryptidblade__ · Posted

      Hello,   I've been back and forth in emails with some CurseForge support staff on the issue but there's been no progress. In the CurseForge app, I have custom profiles and some public modpacks that will not load no matter what. I've goen through every link sent to me, I've reinstalled Minecraft, reinstalled the launcher, repaired the installations individually, uninstalled and reinstalled the public modpacks, downloaded the latest Java--all of it. But each time, I'm always met with either "java runtime exception", "exit code 1" on the rare occasions Minecraft does launch, or "java is out of date" (which literally cannot be possible since I reinstalled the latest version a few different times.) Making a new profile works, but I want to be able to play the ones I had before.  I had gotten one of the old public Minecraft modpacks to work, the prehistoric one about dinosaurs being featured right now, but then it only worked once. I've tried to retrace my steps and it just would not work. I have genuinely no clue what's going on.

  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept