Jump to content

Recommended Posts

Posted

Hello,

I want to give item to player. Here's My Code:

public void giveItem(ItemStack stack, EntityPlayer player)
{
      player.inventory.addItemStackToInventory(stack);
}

When I use this method it gives item to player but if player is in survival gamemode and when player clicks that item it disappears. how to fix this?

Posted

I read Packet Handling. this is what I found about sending packets:

PacketDispatcher.sendPacketToPlayer(packet, (Player)player);

and:

package tutorial.generic;

import net.minecraft.network.INetworkManager;
import net.minecraft.network.packet.Packet250CustomPayload;
import cpw.mods.fml.common.network.IPacketHandler;
import cpw.mods.fml.common.network.Player;

public class PacketHandler implements IPacketHandler {

        @Override
        public void onPacketData(INetworkManager manager,
                        Packet250CustomPayload packet, Player playerEntity) {
                // TODO Auto-generated method stub
        }

}

But what I have to write to send ItemStack to player?

Posted

I made Test packet from tutorial to send message but it don't works. here's my code:

import com.google.common.io.ByteArrayDataInput;
import com.google.common.io.ByteArrayDataOutput;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.network.INetworkManager;
import net.minecraft.network.packet.Packet250CustomPayload;
import cpw.mods.fml.common.network.IPacketHandler;
import cpw.mods.fml.common.network.Player;
import cpw.mods.fml.relauncher.Side;

public class PacketHandler extends Packet 
{
    private String text;
    
    public PacketHandler(String text) {
            this.text = text;
    }

    public PacketHandler() { } 
@Override
public void write(ByteArrayDataOutput out) {
	// TODO Auto-generated method stub

}

@Override
public void read(ByteArrayDataInput in) throws ProtocolException {
	// TODO Auto-generated method stub

}

@Override
public void execute(EntityPlayer player, Side side) throws ProtocolException 
{
	if (side.isClient()) 
	{
            player.addChatMessage(text);
        }
	else 
	{
		throw new ProtocolException("Cannot send this packet to the server!");
        }
}

}

mport net.minecraft.entity.player.EntityPlayer;
import net.minecraft.network.packet.Packet250CustomPayload;

import com.google.common.collect.BiMap;
import com.google.common.collect.ImmutableBiMap;

import com.google.common.io.ByteArrayDataInput;
import com.google.common.io.ByteArrayDataOutput;
import com.google.common.io.ByteStreams;

import cpw.mods.fml.common.network.PacketDispatcher;
import cpw.mods.fml.common.network.Player;
import cpw.mods.fml.relauncher.Side;

public abstract class Packet {

        public static final String CHANNEL = "demomod";
        private static final BiMap<Integer, Class<? extends Packet>> idMap;
                
        static {
                ImmutableBiMap.Builder<Integer, Class<? extends Packet>> builder = ImmutableBiMap.builder();
                
                builder.put(Integer.valueOf(0), PacketHandler.class);
                // more packets like this:
                // builder.put(Integer.valueOf(1), AnotherPacket.class);
                // builder.put(Integer.valueOf(2), YetAnotherPacket.class);
                
                idMap = builder.build();
        }

        public static Packet constructPacket(int packetId) throws ProtocolException, ReflectiveOperationException {
                Class<? extends Packet> clazz = idMap.get(Integer.valueOf(packetId));
                if (clazz == null) {
                        throw new ProtocolException("Unknown Packet Id!");
                } else {
                        return clazz.newInstance();
                }
        }

        public static class ProtocolException extends Exception {

                public ProtocolException() {
                }

                public ProtocolException(String message, Throwable cause) {
                        super(message, cause);
                }

                public ProtocolException(String message) {
                        super(message);
                }

                public ProtocolException(Throwable cause) {
                        super(cause);
                }
        }

        public final int getPacketId() {
                if (idMap.inverse().containsKey(getClass())) {
                        return idMap.inverse().get(getClass()).intValue();
                } else {
                        throw new RuntimeException("Packet " + getClass().getSimpleName() + " is missing a mapping!");
                }
        }
        
        public final Packet250CustomPayload makePacket() 
        {
                ByteArrayDataOutput out = ByteStreams.newDataOutput();
                out.writeByte(getPacketId());
                write(out);
                return PacketDispatcher.getPacket(CHANNEL, out.toByteArray());
        }

        public abstract void write(ByteArrayDataOutput out);
        
        public abstract void read(ByteArrayDataInput in) throws ProtocolException;
        
        public abstract void execute(EntityPlayer player, Side side) throws ProtocolException;
}

and on Gui Button Action I added this:

PacketDispatcher.sendPacketToServer(new PacketHandler("Hello World!").makePacket());

But it don't sends message to player. why? Am I doing something wrong?

(On Main Mod Class I'm using this:

@NetworkMod(clientSideRequired = true, serverSideRequired = false)

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Make a test with another Launcher like the Curseforge Launcher, MultiMC or AT Launcher
    • can anyone help me i am opening forge and add modpacks and then it says unable to update native luancher and i redownlaod java and the luancher it self?
    • The problem occurs also in 1.20.1 Forge, but with an "Error executing task on client" instead. I have "Sinytra Connector" installed. On 1.21.5 Fabric, there is no problem. When this happens, the chat message before the death screen appears gets sent, with an extra dash added.
    • Well, as usual, it was user error. Naming mismatch in sounds.json.  Please delete this post if you find it necessary. 
    • Hello Forge community.  I'm running into an issue with a mod I'm working on.  To preface, I can call /playsound modId:name music @a and I can hear the sound I registered being played in game. Great!  However, I cannot get it to trigger via my mod code.    Registration: public static final RegistryObject<SoundEvent> A_WORLD_OF_MADNESS = SOUND_EVENTS.register("a_world_of_madness", () -> new SoundEvent(new ResourceLocation("tetheredsouls", "a_world_of_madness")));   Playback: Minecraft mc = Minecraft.getInstance(); if (!(mc.player instanceof LocalPlayer) || mc.level == null) return; LocalPlayer player = (LocalPlayer) mc.player; BlockPos pos = player.blockPosition(); SoundEvent track = ModSounds.A_WORLD_OF_MADNESS.get(); System.out.println(track); System.out.println(pos); System.out.println(player); // play exactly like the tutorial: client-only, at the player's position try { mc.level.playLocalSound( player.getX(), player.getY(), player.getZ(), track, SoundSource.MUSIC, // Or MASTER if needed 1f, 1f, false ); System.out.println("[DEBUG] playSound success: " + track.getLocation()); } catch (Exception e) { System.err.println("[ERROR] Failed to play sound: " + track.getLocation()); e.printStackTrace(); } Sounds.json:   { "theme_of_laura": { "category": "music", "sounds": [ { "name": "tetheredsouls:a_world_of_madness", "stream": true } ] } } Things I have tried: - multiple .ogg files. Short .ogg files (5 seconds, <100KB).  - default minecraft sounds imported from import net.minecraft.sounds.SoundEvents; These work given my code. No idea why these are different.  - playSound() method, as well as several others in past iterations that did not work   I would be forever grateful if somebody could point me in the right direction. I've looked at several mod github repositories and found extremely similar code to what I'm doing. I've also found several threads in this forum that did not solve my issue. I just cannot figure out what I'm doing differently, and why I'm able to queue sounds manually with playsound but the code won't play it (despite confirming the code is being run with the debug statements.)
  • Topics

  • Who's Online (See full list)

    • There are no registered users currently online
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.