[1.19.2] Teleporting player to custom dimension freezes the game on "Loading terrain..." but the /tp command still works

[SparkyTD]

I messing around with a "Dream" dimension where players get teleported when they go to bed. To detect sleeping time, I am subscribing to the SleepingTimeCheckEvent, and after the player's sleep tick reaches 100, I call entity.changeDimension() passing in my custom dimension as a parameter. After I go to bed and wait a couple seconds, the game switches over to the usual loading screen that says "Loading terrain...", but then it hangs there with no error messages or exceptions on the console (it just says "Saving and pausing game..."). As I understand, this sleep time event is server-sided, so this probably isn't a networking issue, and the teleportation itself should be handled automatically by Minecraft.

I know that the dimension itself works, because I can teleport there with the following command, and it loads in with no issues:

/execute in lunareclipse:sleep_dim run tp Dev ~ 120 ~

The weirdest thig is that the first time I tested this, the bed teleported me to my dimension successfully without freezing, or any other issues. I haven't changed anything in the teleportation code since, so I don't understand what's going on.

I've uploaded all the relevant files on pastebin:

• data/lunareclipse/dimension/sleep_dim.json -> https://pastebin.com/TNiYpbhJ
• data/lunareclipse/dimension_type/sleep_dim.json -> https://pastebin.com/6y0th33Z
• DimensionsInit.java -> https://pastebin.com/hwnpLxSi
• onPlayerSleepInBed -> https://pastebin.com/uhhU1ZaQ
• The last few lines of debug output right before the player is supposed to teleport -> https://pastebin.com/cezPq7mz (there's nothing else after that, the game still shows "Loading terrain..." as I'm writing this)

I figured there is no point uploading a full debug.log, because as I mentioned, there are no error messages whatsoever, and the dimension itself works with vanilla teleport commands.

[warjort]

I don't think you should be using arbitrary code in an event that is obviously a policy decision callback. i.e. It's not meant to have side-effects

Look at the code that follows that event in ServerPlayer.startSleepingInBed() and see what code you will break by moving the player to a different dimension.

e.g. updating the sleeping players in the wrong dimension

 

A safer place to do that teleport code is in your own PlayerTickEvent handler.

handleNetherPortal() which also calls Entity.changeDimension() is called from Entity.baseTick()

[SparkyTD]

7 minutes ago, warjort said:

I don't think you should be using arbitrary code in an event that is obviously a policy decision callback. i.e. It's not meant to have side-effects

Look at the code that follows that event in ServerPlayer.startSleepingInBed() and see what code you will break by moving the player to a different dimension.

e.g. updating the sleeping players in the wrong dimension

 

A safer place to do that teleport code is in your own PlayerTickEvent handler.

handleNetherPortal() which also calls Entity.changeDimension() is called from Entity.baseTick()

I moved the teleportation logic over to the PlayerTickEvent, but it still freezes while loading the dimension. https://pastebin.com/7YRWiWpu

[warjort]

I don't know then, it's not my area of expertise.

Most likely it has something to do with changeDimension() being for vanilla dimensions that have "portals" or for dimensions that are already loaded?

Look at TeleportCommand.performTeleport() which uses different code.

[SparkyTD]

6 minutes ago, warjort said:

I don't know then, it's not my area of expertise.

Most likely it has something to do with changeDimension() being for vanilla dimensions that have "portals" or for dimensions that are already loaded?

Look at TeleportCommand.performTeleport() which uses different code.

Using ((ServerPlayer)event.player).teleportTo() works, thanks for the hint!