[1.16.5] AbstractChestedHorseEntity (Donkey/Mule) don't work with itemInteractionForEntity

[DillaSyx]

Hey I'm new to this forum and could not find the search function to look if this issues was already solved, sorry for that.

 

So I'm currently working on an item, which act similar like an apple.

The player should be able to eat it and the player should be able to feed it to all horses (incl. zombie, skeleton, mule, donkey).

The first part works fine. Now I wanted to add the feeding function by overriding itemInteractionForEntity(), but if I right click on an donkey/mule it does not target them.

So AbstractHorseEntity works fine, but without mule and donkey, as I can not target them. The function is not triggered in general when right clicking donkey/mule.

    @Override
    public ActionResultType itemInteractionForEntity(ItemStack itemStack, PlayerEntity player, LivingEntity target, Hand hand) {

      	System.out.println(target);
      
        if (!target.world.isRemote) {
            if (target instanceof AbstractHorseEntity) {

                itemStack.shrink(1);
            }
        }
        return super.itemInteractionForEntity(itemStack, player, target, hand);
    }

Is it possible to target mule/donkey, too?

 

And is it possible to disable mounting, if saddled when right click with the food item?

[DillaSyx]

Okay I could find a workaround with EntityMountEvent and EntityInteract.

I can now feed every AbstractHorseEntity with the item and was able to cancel the mounting event.

Following Code kinda works fine for me, if someone has the same problem.
Still one bug:

- not tamed Zombie/Skeleton horses eat 2 items per click

    private static void feedingHorse(AbstractHorseEntity target, PlayerEntity player){

        ItemStack rightHand = player.getHeldEquipment().iterator().next();

        if (target.getHealth() < target.getMaxHealth()) {
            target.heal(3.0F);
        }

        if (target.isTame() && target.getTemper() < target.getMaxTemper()) {
            target.increaseTemper(3);
        }

        if (target.isChild()) {
            target.addGrowth(60);
        }

        if (!player.abilities.isCreativeMode) {
            rightHand.shrink(1);
        }
        player.playSound(ModSoundEvents.EATING_HORSE_FOOD.get(), SoundCategory.NEUTRAL, 1, 1);
    }

    @SubscribeEvent
    public static void onEntityMount(EntityMountEvent event) {

        Iterable<ItemStack> equip = event.getEntityMounting().getHeldEquipment();
        ItemStack rightHand = equip.iterator().next();
        Entity entityMounting = event.getEntityMounting();
        Entity target = event.getEntityBeingMounted();

        if (!target.isRidingOrBeingRiddenBy(entityMounting)) {
            if (entityMounting instanceof PlayerEntity) {
                if (target instanceof AbstractHorseEntity) {
                    if (rightHand.getItem() == ModItems.HORSE_FOOD.get()) {

                        feedingHorse((AbstractHorseEntity) target, (PlayerEntity) entityMounting);
                        event.setCanceled(true);
                    }
                }
            }
        }
    }

    /**
     * ADDED FOR NON TAMED HORSES
     */
    @SubscribeEvent
    public static void onPlayerInteractEntity(PlayerInteractEvent.EntityInteract event) {

        PlayerEntity player = event.getPlayer();
        ItemStack rightHand = player.getHeldEquipment().iterator().next();
        Entity target = event.getTarget();

        if(target instanceof AbstractHorseEntity){
            if(!((AbstractHorseEntity) target).isTame()){
                if(rightHand.getItem() == ModItems.HORSE_FOOD.get()){

                    feedingHorse((AbstractHorseEntity) target, player);
                }
            }
        }
    }

 

Edited October 21, 2022 by DillaSyx