I'm trying to remove Items from creative tabs. But the method setCreativeTab() is no longer present in the Item class.

Is there a new method/new way of doing that?

I have tried this (which gives me an error on startup (UnsupportedOperationException: null)

@SubscribeEvent
    public static void removeItemsFromCreativeTabs(FMLCommonSetupEvent event){
        for (Item item:ForgeRegistries.ITEMS) {
            if (item.getName(new ItemStack(item)).getString().equals("Wooden Pickaxe")){
                item.getCreativeTabs().clear();
            }
        }
    }

 

The method you are using returns an unmodifiable list in its default implementation so you can't clear it.

If you want to modify the actual data, you will need to use an access transformer to make the Item.category field public

https://forge.gemwire.uk/wiki/Access_Transformers

But there is no guarantee the Item actually uses that field.

An item can override getCreativeTags() to do something else (vanilla items don't do this).

 

You should probably also be aware that Mojang are changing how this works in 1.19.3

https://www.minecraft.net/en-us/article/minecraft-snapshot-22w42a

On 10/25/2022 at 6:56 AM, warjort said:

An item can override getCreativeTags() to do something else (vanilla items don't do this).

`getCreativeTags()` or `getCreativeTabs()`?

 

Quote

If you want to modify the actual data, you will need to use an access transformer to make the Item.category field public

https://forge.gemwire.uk/wiki/Access_Transformers

Isn't reflection a viable option? It doesn't seem complicated.

Edited January 28, 20232 yr by badkraft
added question

On 10/25/2022 at 6:12 AM, Julian Texo said:

I'm trying to remove Items from creative tabs. But the method setCreativeTab() is no longer present in the Item class.

Is there a new method/new way of doing that?

I have tried this (which gives me an error on startup (UnsupportedOperationException: null)

@SubscribeEvent
    public static void removeItemsFromCreativeTabs(FMLCommonSetupEvent event){
        for (Item item:ForgeRegistries.ITEMS) {
            if (item.getName(new ItemStack(item)).getString().equals("Wooden Pickaxe")){
                item.getCreativeTabs().clear();
            }
        }
    }

 

Rather than iterating all of the items you want to remove, you can set up place holders in your mod code:

	//	get a handle on items we want to remove from tabs
	@ObjectHolder("minecraft:wooden_sword")
	public static Item WOODEN_SWORD = null;

... now, in your event, instead of iterating the collection, you can test whether the item is assigned:

LOGGER.debug("Item :: WOODEN SWORD [" + (WOODEN_SWORD != null) + "]");

My log produces the following line:

Quote

28Jan2023 12:23:32.287] [Worker-Main-17/DEBUG] [com.badkraft.foundations.Foundations/]: Item :: WOODEN SWORD [true]

 

I used reflection to set the `Item.category` to `null` which removes the item from a `CreativeModeTab`. Here's the class:

import com.mojang.logging.LogUtils;
import net.minecraft.world.item.CreativeModeTab;
import net.minecraft.world.item.Item;
import org.slf4j.Logger;

import java.lang.reflect.Field;

public class ItemReflector {
    private static final Logger LOGGER = LogUtils.getLogger();
    private static final String CATEGORY = "category";
    private static final Class<Item> CLASS = Item.class;

    private final Field category;

    public ItemReflector() {
        LOGGER.debug("Reflecting (" + CLASS + ")");

        Field catField = null;

        try {
            catField = getField(CATEGORY);
        } catch (NoSuchFieldException e) {
            LOGGER.error(e.getMessage(), e);
        }

        category = catField;
    }

    public void setItemCategory(Item item, CreativeModeTab tab) {
        try{
            category.set(item, tab);
        } catch (IllegalAccessException e) {
            LOGGER.error(e.getMessage(), e);
        }
    }

    private Field getField(String fieldName) throws NoSuchFieldException {
        Field field = CLASS.getDeclaredField(fieldName);
        field.setAccessible(true);

        return field;
    }
}

... then, to implement:

// snipped irrelevant code

import com.mojang.logging.LogUtils;
import net.minecraft.world.item.*;
import net.minecraftforge.registries.DeferredRegister;
import net.minecraftforge.registries.ForgeRegistries;
import net.minecraftforge.registries.ObjectHolder;
import net.minecraftforge.registries.RegistryObject;
import org.slf4j.Logger;

public class ItemInit {
	private static final Logger LOGGER = LogUtils.getLogger();

	private final ItemReflector reflector;

	//	get a handle on items we want to remove from tabs
	@ObjectHolder("minecraft:wooden_axe")
	public static Item WOODEN_AXE = null;

	public ItemInit() {
		reflector = new ItemReflector();
	}

	public void removeItems() {
		String itemName;
		String categoryName;

		reflector.setItemCategory(WOODEN_AXE, null);
		LOGGER.debug("Removed Item [" + (WOODEN_AXE.getItemCategory() == null) + "]");
	}
}

 

Now, what this does *NOT* do is remove the item from searching. You can still find the item by searching for "wooden". As soon as I figure that out, I'll update the answer.