[1.18.2] NBT errors on world close

[MultiCoder]

import net.minecraft.sounds.SoundEvent;
import net.minecraft.sounds.SoundEvents;
import net.minecraft.world.entity.Entity;
import net.minecraft.world.entity.EntityType;
import net.minecraft.world.entity.LivingEntity;
import net.minecraft.world.entity.animal.Cow;
import net.minecraft.world.entity.projectile.AbstractArrow;
import net.minecraft.world.item.ItemStack;
import net.minecraft.world.level.Level;
import net.minecraft.world.phys.EntityHitResult;
import org.multicoder.mcpaintball.init.entityinit;
import org.multicoder.mcpaintball.init.soundinit;

public class BluePaintballArrowEntity extends AbstractArrow
{

    public BluePaintballArrowEntity(EntityType<? extends Entity> p_36858_, Level p_36859_) {super((EntityType<? extends AbstractArrow>) p_36858_, p_36859_);}

    public BluePaintballArrowEntity(Level p_36861_, double p_36862_, double p_36863_, double p_36864_) {super((EntityType<? extends AbstractArrow>) entityinit.BLUE_PAINTBALL.get(), p_36862_, p_36863_, p_36864_,p_36861_);}

    public BluePaintballArrowEntity(Level p_36866_, LivingEntity p_36867_) {super((EntityType<? extends AbstractArrow>) entityinit.BLUE_PAINTBALL.get(), p_36867_,p_36866_);}

    @Override
    protected SoundEvent getDefaultHitGroundSoundEvent() {return null;}

    @Override
    protected ItemStack getPickupItem() {return ItemStack.EMPTY;}

    @Override
    protected void onHitEntity(EntityHitResult p_36757_)
    {
        if (p_36757_.getEntity() instanceof Cow) {getOwner().playSound(soundinit.DING.get(),1.0f,1.0f);}
    }

}

This is the entity file.

The debug and log GIST

I'm unsure why this error occurs, can anyone explain what is causing the issue.

 

I have narrowed down the error to the additional save data method, it seems to be a resource location but what is it looking for

Edited October 30, 2022 by MultiCoder
Appended

[warjort]

Quote

Caused by: java.lang.NullPointerException: Cannot invoke "net.minecraft.resources.ResourceLocation.toString()" because the return value of "net.minecraft.core.Registry.getKey(Object)" is null

at net.minecraft.world.entity.projectile.AbstractArrow.addAdditionalSaveData(AbstractArrow.java:438) ~[forge-1.18.2-40.1.0_mapped_official_1.18.2-recomp.jar%2376!/:?]

Look in the code for AbstractArrow.addAdditionalSaveData()

There's only 1 place where it does Registry.getKey() and that's for the soundEvent.

So it basically says your SoundEvent isn't registered.

The reason for this is probably because you override getDefaultHitGroundSoundEvent() to return null. That method is used in instance initialisation.

[MultiCoder]

Thank you for that. It has fixed the problem.