Jump to content
View in the app

A better way to browse. Learn more.

Forge Forums

A full-screen app on your home screen with push notifications, badges and more.

To install this app on iOS and iPadOS
  1. Tap the Share icon in Safari
  2. Scroll the menu and tap Add to Home Screen.
  3. Tap Add in the top-right corner.
To install this app on Android
  1. Tap the 3-dot menu (⋮) in the top-right corner of the browser.
  2. Tap Add to Home screen or Install app.
  3. Confirm by tapping Install.

Featured Replies

Posted

I was looking into this topic, and trying to update it to 1.19.2, and came up with this so far.

As it happens, it seems like the block is rendered at camera origin, despite my intention to render it in a specific block position. Am I even using the right event? Am I rendering the block correctly? 

Translating the poseStack to all 0 does not seem to be helping either.

Edited by zskamljic

If you look at LevelRender.renderHitOutline() it uses (pseudo code)

blockPos - camera.getPosition()

So, the PoseStack must be at the camera position when that event is called.

 

You can't translate to anywhere. PoseStack.translate() is a relative operation so passing all 0 does nothing. 🙂 

 

Try something like:

                var target = event.getTarget();
                var cpos = event.getCamera().getPosition(); // camera
                var bpos = target.getBlockPos().relative(target.getDirection()); // block

                var poseStack = event.getPoseStack();
                poseStack.pushPose();
                poseStack.translate(bpos.getX() - cpos.x, bpos.getY() - cpos.y, bpos.getZ() - cpos.z);
                // your code here
                poseStack.popPose();

 

Edited by warjort

Boilerplate:

If you don't post your logs/debug.log we can't help you. For curseforge you need to enable the forge debug.log in its minecraft settings. You should also post your crash report if you have one.

If there is no error in the log file and you don't have a crash report then post the launcher_log.txt from the minecraft folder. Again for curseforge this will be in your curseforge/minecraft/Install

Large files should be posted to a file sharing site like https://gist.github.com  You should also read the support forum sticky post.

  • Author

That works perfectly! Thanks! Is there a similar way to also change the alpha of the block? The following does not appear to work:

	RenderSystem.setShaderColor(1f, 1f, 1f, 0.1f);
	

Edited by zskamljic

If you look at the code for the method you are using, it uses the BlockAndTintGetter (the player.level) you pass to do its calculations of light levels.

If you want to alter things, you will probably need to create a wrapper/delegate implementation of that interface that changes the values returned by the real ClientLevel?

Boilerplate:

If you don't post your logs/debug.log we can't help you. For curseforge you need to enable the forge debug.log in its minecraft settings. You should also post your crash report if you have one.

If there is no error in the log file and you don't have a crash report then post the launcher_log.txt from the minecraft folder. Again for curseforge this will be in your curseforge/minecraft/Install

Large files should be posted to a file sharing site like https://gist.github.com  You should also read the support forum sticky post.

  • Author

I have tried creating a "proxy" BlockAndTintGetter, based on my debugging only getShade, getLightEngine and getBlockState are called, changing values returned by getShade seems to darken the block (closer to 0f) or use default color (closer to 1f), getBlockTint (which I expected to return ARGB int does not seem to get called at all.

I have also tried changing buffer color, but it appears to be ignored there.

You know as much as about this as I do.  It's not really my area of expertise.

I do know there is some caching code in there. So maybe you are hitting that? See for example AmbientOcclusionFace.calculate() and BlockModelRenderer.Cache

I've tried a couple of times to understand how minecraft's lighting code works, but it is spaghetti. 🙂 

 

Maybe you can use your debugger to disable the cache to see if that is your problem? 

Boilerplate:

If you don't post your logs/debug.log we can't help you. For curseforge you need to enable the forge debug.log in its minecraft settings. You should also post your crash report if you have one.

If there is no error in the log file and you don't have a crash report then post the launcher_log.txt from the minecraft folder. Again for curseforge this will be in your curseforge/minecraft/Install

Large files should be posted to a file sharing site like https://gist.github.com  You should also read the support forum sticky post.

  • Author

I have tried creating a "proxy" BlockAndTintGetter, based on my debugging only getShade, getLightEngine and getBlockState are called, changing values returned by getShade seems to darken the block (closer to 0f) or use default color (closer to 1f), getBlockTint (which I expected to return ARGB int does not seem to get called at all.

I have also tried changing buffer color, but it appears to be ignored there.

By digging through the code, I have discovered that in VertexConsumer interface, one of the overloads of putBulkData is used, with alpha set to 1. The answer was to proxy the VertextConsumer and override the default method putBulkData, using custom alpha value.

I have updated the original gist with the "solution", but it still feels like there should be a cleaner way to achieve this. 

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

Important Information

By using this site, you agree to our Terms of Use.

Configure browser push notifications

Chrome (Android)
  1. Tap the lock icon next to the address bar.
  2. Tap Permissions → Notifications.
  3. Adjust your preference.
Chrome (Desktop)
  1. Click the padlock icon in the address bar.
  2. Select Site settings.
  3. Find Notifications and adjust your preference.