Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

[1.19] Refresh Villager Trades

HutchCS

By HutchCS
in Modder Support

 Share

Recommended Posts

HutchCS Tree Puncher

HutchCS

Posted
Posted

Hello all, I am trying to make a villager refresh mod, it is supposed to be able to refresh the most recent trade if it has not been traded with at that level. I am able to refresh the trades at level 1 by simply setting them as null and they auto regenerate, but for the later levels, that does not suffice, I was able to separate the MerchantOffers at the new trade (meaning if level three, it has the 4 trades from level 1 and 2 as one MerchantOffers, but the level 3 trades are a separate MerchantOffers). I have not been able to successfully regenerate new trades to replace for that final level. Any ideas?

warjort Reality Controller

warjort

Posted
Posted

If you look at AbstractVillager.getOffers() it will only regenerate the trades if the offers field is null.

It does this by calling updateTrades().

But if you look in that method it calls addOffersFromItemListing() with a maximum of 2.

So, it will only ever create 2 trades.

 

You could use an access transformer to make the Villager.updateTrades() method public.

https://forge.gemwire.uk/wiki/Access_Transformers

Then call it multiple times to fill all the levels for the villager?

 

  • Like 1

Boilerplate:

If you don't post your logs/debug.log we can't help you. For curseforge you need to enable the forge debug.log in its minecraft settings. You should also post your crash report if you have one.

If there is no error in the log file and you don't have a crash report then post the launcher_log.txt from the minecraft folder. Again for curseforge this will be in your curseforge/minecraft/Install

Large files should be posted to a file sharing site like https://gist.github.com  You should also read the support forum sticky post.

HutchCS Tree Puncher

HutchCS

Posted
  • Author
Posted
On 11/11/2022 at 3:17 PM, warjort said:

If you look at AbstractVillager.getOffers() it will only regenerate the trades if the offers field is null.

It does this by calling updateTrades().

But if you look in that method it calls addOffersFromItemListing() with a maximum of 2.

So, it will only ever create 2 trades.

 

You could use an access transformer to make the Villager.updateTrades() method public.

https://forge.gemwire.uk/wiki/Access_Transformers

Then call it multiple times to fill all the levels for the villager?

 

I didnt end up using the access transformer as I wasn't able to find the proper srg name for the updateTrades method even though i copied the same one used https://github.com/Favouriteless/SeasonalVillagers/blob/main/src/main/resources/META-INF/accesstransformer.cfg in this mod, but whatever. I was however able to get new trades through copying the old villager data into a new villagerdata variable, this will give me new trades (tested using println, I can see the result and costA and costB are different), but it wont update in the Villager GUI

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • Attack Helicopter
      Essential mod incopatible

      By Attack Helicopter · Posted

      I tried do download the essential mod to my mod pack but i didnt work. I paly on 1.21 and it should work. I use neoforge for my modding. The weird things is my friend somehow added the mod to his modpack and many others that I somehow can´t. Is there anything i can do? 
    • Venatus94
      Minecraft Server crash

      By Venatus94 · Posted

      Thanks, I've now installed a slightly newer version and the server is at least starting up now.
    • Mrmeeseeks
      New Issue no title

      By Mrmeeseeks · Posted

      i have the same issue. Found 1 Create mod class dependency(ies) in createdeco-1.3.3-1.19.2.jar, which are missing from the current create-1.19.2-0.5.1.i.jar Found 11 Create mod class dependency(ies) in createaddition-fabric+1.19.2-20230723a.jar, which are missing from the current create-1.19.2-0.5.1.i.jar Detailed walkthrough of mods which rely on missing Create mod classes: Mod: createaddition-fabric+1.19.2-20230723a.jar Missing classes of create: com/simibubi/create/compat/jei/category/sequencedAssembly/JeiSequencedAssemblySubCategory com/simibubi/create/compat/recipeViewerCommon/SequencedAssemblySubCategoryType com/simibubi/create/compat/rei/CreateREI com/simibubi/create/compat/rei/EmptyBackground com/simibubi/create/compat/rei/ItemIcon com/simibubi/create/compat/rei/category/CreateRecipeCategory com/simibubi/create/compat/rei/category/WidgetUtil com/simibubi/create/compat/rei/category/animations/AnimatedBlazeBurner com/simibubi/create/compat/rei/category/animations/AnimatedKinetics com/simibubi/create/compat/rei/category/sequencedAssembly/ReiSequencedAssemblySubCategory com/simibubi/create/compat/rei/display/CreateDisplay Mod: createdeco-1.3.3-1.19.2.jar Missing classes of create: com/simibubi/create/content/kinetics/fan/SplashingRecipe
    • TileEntity
      Minecraft Server crash

      By TileEntity · Posted

      The crash points to moonlight lib - try other builds or make a test without this mod and the mods requiring it
    • TileEntity
      Game Crashes When I Start It

      By TileEntity · Posted

      Do you have shaders enabled? There is an issue with the mod simpleclouds - remove this mod or disable shaders, if enabled  

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept