Trying to figure out Ore Generation. Can someone help?

[WilliamBen12]

so i want to make my ore spawn on stone anywhere. but i do not understand the oreplacement code.

 

[warjort]

https://forums.minecraftforge.net/topic/115928-1182-error-trying-to-register-a-custom-feature-based-on-kelpfeature-solved/

[WilliamBen12]

not what i wanted

First that was in 1.18 not 1.19.

second i'm looking to learn the correct variables for this

public static final RegistryObject<PlacedFeature> SIMPLE_ANCIENT_DEBRIS_PLACED = PLACED_FEATURES.register("simple_ancient_debris_placed",
            () -> new PlacedFeature(ModConfiguredFeatures.SIMPLE_ANCIENT_DEBRIS.getHolder().get(),
                    m_195343_(10, // VeinsPerChunk
                            HeightRangePlacement.m_191692_(VerticalAnchor.absolute(-100), VerticalAnchor.absolute(100)))));

 

[WilliamBen12]

 

 

i'm looking to learn the correct variables for this

public static final RegistryObject<PlacedFeature> SIMPLE_ANCIENT_DEBRIS_PLACED = PLACED_FEATURES.register("simple_ancient_debris_placed",
            () -> new PlacedFeature(ModConfiguredFeatures.SIMPLE_ANCIENT_DEBRIS.getHolder().get(),
                    m_195343_(10, // VeinsPerChunk
                            HeightRangePlacement.m_191692_(VerticalAnchor.absolute(-100), VerticalAnchor.absolute(100)))));

 

[WilliamBen12]

can someone explain VerticalAnchors to me

[WilliamBen12]

so can someone please find the error

my simple anceint debris is not generating

my github

[warjort]

your link is a 404 - not found

[WilliamBen12]

sorry here

https://github.com/liambcode/forge-1.19.2-43.1.30-mdk

 

[warjort]

This is the same as your previous thread which was a lot of back and forth to try to get the information out of you to fix a very simple error.

It also included you trying to spam me with private messages beyond what is on that thread.

https://forums.minecraftforge.net/topic/117995-my-custom-blocks-are-not-dropping-anything-when-mined-help/#comment-519611

 

Show me where in that repo you are using vertical anchors. Or even any worldgen.

I only see tags, recipes and loot tables in your data folder and nothing in your java code.

 

Frankly, you are just too much of a time sink to make trying to help you worthwhile.

You either need to up your game or stop wasting people's time.

I am inclined to think this isn't real and you are just trolling.

[WilliamBen12]

the stuff is there now 

for some reason the world derectory didn't cross over to the github repo

i'm not trolling. I asure you.

Edited November 15, 2022 by WilliamBen12

[warjort]

This method and the similar one in the placed features class is not being called. So nothing is registered.

https://github.com/liambcode/forge-1.19.2-43.1.30-mdk/blob/9d47d3fc63591e8f286d94cf5e1473af644f02e1/src/main/java/com/liam/debrismod/world/feature/ModConfiguredFeatures.java#L35

You are only registering blocks and items.

https://github.com/liambcode/forge-1.19.2-43.1.30-mdk/blob/9d47d3fc63591e8f286d94cf5e1473af644f02e1/src/main/java/com/liam/debrismod/DebrisMod.java#L35

[warjort]

And for your next inevitable question, from the earlier link:

https://forums.minecraftforge.net/topic/115928-1182-error-trying-to-register-a-custom-feature-based-on-kelpfeature-solved/?do=findComment&comment=512557

Quote

But more importantly you need a Biome that uses it.

To modify vanilla biomes see: https://forge.gemwire.uk/wiki/Biome_Modifiers or before 1.19 you use the BiomeLoadingEvent

 

[WilliamBen12]

I hate GitHub!!!

those classes are registered but github didn't update that.

second the link didn't help and still doesn't

[warjort]

Quote

second the link didn't help and still doesn't

Not my fault. The information is there.

e.g. show me where in the code you are adding your placed feature to a biome.

 

If you make another post that just says "it does not work" I will just ignore you.

Edited November 15, 2022 by warjort

[WilliamBen12]

please don't

i forgot to also add the forge-1.19.2-43.1.30-mdk/src/main/resources/data/debrismod/forge/biome_modifier to the repo

its there now

https://github.com/liambcode/forge-1.19.2-43.1.30-mdk/tree/master/src/main/resources/data/debrismod/forge/biome_modifier

Edited November 15, 2022 by WilliamBen12

[warjort]

You are hard work.

 

1) Why are you using the wrong (very old) version of the parchment mappings.

https://github.com/liambcode/forge-1.19.2-43.1.30-mdk/blob/4a0dc18dd75269dc419f3c639625ba790ab32c6f/build.gradle#L30

https://parchmentmc.org/docs/getting-started

 

2) To try to figure out which methods you were using I had to download the mod and load into an ide.

Except the code in that repo doesn't compile.  So, after many attempts, I am still not looking at the code you are using.

Normally I would throw it back to you, since I am obviously not looking at the real code.

 But...

 

3) You can't spell minecraft.

https://github.com/liambcode/forge-1.19.2-43.1.30-mdk/blob/4a0dc18dd75269dc419f3c639625ba790ab32c6f/src/main/resources/data/debrismod/forge/biome_modifier/add_simple_ancient_debris.json#L3

 

4) The only placed feature you have configured to go in a biome is using a configuration where it starts at a minimum of y=70 and a maximum of y=0

Can you tell me a number that is bigger than 70 and also less than 0? 🙂 

https://github.com/liambcode/forge-1.19.2-43.1.30-mdk/blob/4a0dc18dd75269dc419f3c639625ba790ab32c6f/src/main/java/com/liam/debrismod/world/feature/ModPlacedFeatures.java#L20

[WilliamBen12]

yes i am hard work but in the end it will be worth it, for me at least.

second it works. thank you.

third it is real code and if i knew how, when it is done i would give you the jar file.